Re: [PATCH v1 2/3] tty: serial: lpuart: Use defines that correspond to correct register

[Philippe Schenker]

On Wed, 2019-10-16 at 22:22 +0200, Stefan Agner wrote:
> On 2019-10-16 17:18, Philippe Schenker wrote:
> > Use UARTMODIR defines instead of UARTMODEM as it is a 32-bit
> > function
> 
> This reads a bit strange at first. Also it is helpful for later to
> state
> that this does not make a difference in practise, so how about:
> 
> Use define from the 32-bit register description UARTMODIR_* instead of
> UARTMODEM_*. The value is the same, so there is no functional change.
> 
> Otherwise looks good to me:
> 
> Reviewed-by: Stefan Agner 

Thanks for your review and comment. And also thanks to Andy Duan for his
reviews!

You're right, I could have included that so it is clear that nothing is
changed. I will send a v2 today with your suggested commit message

Philippe

> 
> --
> Stefan
> 
> > Signed-off-by: Philippe Schenker 
> > ---
> > 
> >  drivers/tty/serial/fsl_lpuart.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/tty/serial/fsl_lpuart.c
> > b/drivers/tty/serial/fsl_lpuart.c
> > index f3271857621c..346b4a070ce9 100644
> > --- a/drivers/tty/serial/fsl_lpuart.c
> > +++ b/drivers/tty/serial/fsl_lpuart.c
> > @@ -1879,10 +1879,10 @@ lpuart32_set_termios(struct uart_port *port,
> > struct ktermios *termios,
> > }
> >  
> > if (termios->c_cflag & CRTSCTS) {
> > -   modem |= UARTMODEM_RXRTSE | UARTMODEM_TXCTSE;
> > +   modem |= (UARTMODIR_RXRTSE | UARTMODIR_TXCTSE);
> > } else {
> > termios->c_cflag &= ~CRTSCTS;
> > -   modem &= ~(UARTMODEM_RXRTSE | UARTMODEM_TXCTSE);
> > +   modem &= ~(UARTMODIR_RXRTSE | UARTMODIR_TXCTSE);
> > }
> >  
> > if (termios->c_cflag & CSTOPB)

RE: [EXT] [PATCH v1 2/3] tty: serial: lpuart: Use defines that correspond to correct register

[Andy Duan]

From: Philippe Schenker  Sent: Wednesday, 
October 16, 2019 11:19 PM
> Use UARTMODIR defines instead of UARTMODEM as it is a 32-bit function
> 
> Signed-off-by: Philippe Schenker 

Reviewed-by: Fugang Duan 

> ---
> 
>  drivers/tty/serial/fsl_lpuart.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/tty/serial/fsl_lpuart.c 
> b/drivers/tty/serial/fsl_lpuart.c index
> f3271857621c..346b4a070ce9 100644
> --- a/drivers/tty/serial/fsl_lpuart.c
> +++ b/drivers/tty/serial/fsl_lpuart.c
> @@ -1879,10 +1879,10 @@ lpuart32_set_termios(struct uart_port *port,
> struct ktermios *termios,
> }
> 
> if (termios->c_cflag & CRTSCTS) {
> -   modem |= UARTMODEM_RXRTSE |
> UARTMODEM_TXCTSE;
> +   modem |= (UARTMODIR_RXRTSE |
> UARTMODIR_TXCTSE);
> } else {
> termios->c_cflag &= ~CRTSCTS;
> -   modem &= ~(UARTMODEM_RXRTSE |
> UARTMODEM_TXCTSE);
> +   modem &= ~(UARTMODIR_RXRTSE |
> UARTMODIR_TXCTSE);
> }
> 
> if (termios->c_cflag & CSTOPB)
> --
> 2.23.0

Re: [PATCH v1 2/3] tty: serial: lpuart: Use defines that correspond to correct register

[Stefan Agner]

On 2019-10-16 17:18, Philippe Schenker wrote:
> Use UARTMODIR defines instead of UARTMODEM as it is a 32-bit function

This reads a bit strange at first. Also it is helpful for later to state
that this does not make a difference in practise, so how about:

Use define from the 32-bit register description UARTMODIR_* instead of
UARTMODEM_*. The value is the same, so there is no functional change.

Otherwise looks good to me:

Reviewed-by: Stefan Agner 

--
Stefan

> 
> Signed-off-by: Philippe Schenker 
> ---
> 
>  drivers/tty/serial/fsl_lpuart.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c
> index f3271857621c..346b4a070ce9 100644
> --- a/drivers/tty/serial/fsl_lpuart.c
> +++ b/drivers/tty/serial/fsl_lpuart.c
> @@ -1879,10 +1879,10 @@ lpuart32_set_termios(struct uart_port *port,
> struct ktermios *termios,
>   }
>  
>   if (termios->c_cflag & CRTSCTS) {
> - modem |= UARTMODEM_RXRTSE | UARTMODEM_TXCTSE;
> + modem |= (UARTMODIR_RXRTSE | UARTMODIR_TXCTSE);
>   } else {
>   termios->c_cflag &= ~CRTSCTS;
> - modem &= ~(UARTMODEM_RXRTSE | UARTMODEM_TXCTSE);
> + modem &= ~(UARTMODIR_RXRTSE | UARTMODIR_TXCTSE);
>   }
>  
>   if (termios->c_cflag & CSTOPB)

[PATCH v1 2/3] tty: serial: lpuart: Use defines that correspond to correct register

[Philippe Schenker]

Use UARTMODIR defines instead of UARTMODEM as it is a 32-bit function

Signed-off-by: Philippe Schenker 
---

 drivers/tty/serial/fsl_lpuart.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c
index f3271857621c..346b4a070ce9 100644
--- a/drivers/tty/serial/fsl_lpuart.c
+++ b/drivers/tty/serial/fsl_lpuart.c
@@ -1879,10 +1879,10 @@ lpuart32_set_termios(struct uart_port *port, struct 
ktermios *termios,
}
 
if (termios->c_cflag & CRTSCTS) {
-   modem |= UARTMODEM_RXRTSE | UARTMODEM_TXCTSE;
+   modem |= (UARTMODIR_RXRTSE | UARTMODIR_TXCTSE);
} else {
termios->c_cflag &= ~CRTSCTS;
-   modem &= ~(UARTMODEM_RXRTSE | UARTMODEM_TXCTSE);
+   modem &= ~(UARTMODIR_RXRTSE | UARTMODIR_TXCTSE);
}
 
if (termios->c_cflag & CSTOPB)
-- 
2.23.0