Re: [PATCH v1 4/4] arm64: dts: mediatek: add mt2712 cpufreq related device nodes
On 12/17/2017 07:05 PM, Rafael J. Wysocki wrote: > On Tuesday, December 12, 2017 10:34:42 AM CET Matthias Brugger wrote: >> Hi, >> >> On 12/12/2017 08:26 AM, Viresh Kumar wrote: >>> On 12-12-17, 02:17, Rafael J. Wysocki wrote: On Monday, December 11, 2017 8:57:19 AM CET Viresh Kumar wrote: > On 08-12-17, 14:07, Andrew-sh Cheng wrote: >> Add opp v2 information, >> and also add clocks, regulators and opp information into cpu nodes >> >> Signed-off-by: Andrew-sh Cheng >> --- >> arch/arm64/boot/dts/mediatek/mt2712-evb.dts | 27 ++ >> arch/arm64/boot/dts/mediatek/mt2712e.dtsi | 57 >> + >> 2 files changed, 84 insertions(+) > > Acked-by: Viresh Kumar Of course, DT bindings require ACKs from DT maintainers to be applied. >>> >>> I didn't knew that we need Acks from DT maintainers for dts files as well? >>> Yeah, >>> its very much required while defining new bindings for sure. >>> >> >> I will take the dts parts through the Mediatek SoC tree, so you don't have to >> worry about them. >> >> Please let me know when you take patch 1 and 2. > > Applied now, thanks! > > Do you need the branch containing them to be exposed? > No, that's not necessary. I pushed the two patches to v4.15-next/dts64 now.
Re: [PATCH v1 4/4] arm64: dts: mediatek: add mt2712 cpufreq related device nodes
On Tuesday, December 12, 2017 10:34:42 AM CET Matthias Brugger wrote: > Hi, > > On 12/12/2017 08:26 AM, Viresh Kumar wrote: > > On 12-12-17, 02:17, Rafael J. Wysocki wrote: > >> On Monday, December 11, 2017 8:57:19 AM CET Viresh Kumar wrote: > >>> On 08-12-17, 14:07, Andrew-sh Cheng wrote: > Add opp v2 information, > and also add clocks, regulators and opp information into cpu nodes > > Signed-off-by: Andrew-sh Cheng > --- > arch/arm64/boot/dts/mediatek/mt2712-evb.dts | 27 ++ > arch/arm64/boot/dts/mediatek/mt2712e.dtsi | 57 > + > 2 files changed, 84 insertions(+) > >>> > >>> Acked-by: Viresh Kumar > >> > >> Of course, DT bindings require ACKs from DT maintainers to be applied. > > > > I didn't knew that we need Acks from DT maintainers for dts files as well? > > Yeah, > > its very much required while defining new bindings for sure. > > > > I will take the dts parts through the Mediatek SoC tree, so you don't have to > worry about them. > > Please let me know when you take patch 1 and 2. Applied now, thanks! Do you need the branch containing them to be exposed? Thanks, Rafael
Re: [PATCH v1 4/4] arm64: dts: mediatek: add mt2712 cpufreq related device nodes
Hi, On 12/12/2017 08:26 AM, Viresh Kumar wrote: > On 12-12-17, 02:17, Rafael J. Wysocki wrote: >> On Monday, December 11, 2017 8:57:19 AM CET Viresh Kumar wrote: >>> On 08-12-17, 14:07, Andrew-sh Cheng wrote: Add opp v2 information, and also add clocks, regulators and opp information into cpu nodes Signed-off-by: Andrew-sh Cheng --- arch/arm64/boot/dts/mediatek/mt2712-evb.dts | 27 ++ arch/arm64/boot/dts/mediatek/mt2712e.dtsi | 57 + 2 files changed, 84 insertions(+) >>> >>> Acked-by: Viresh Kumar >> >> Of course, DT bindings require ACKs from DT maintainers to be applied. > > I didn't knew that we need Acks from DT maintainers for dts files as well? > Yeah, > its very much required while defining new bindings for sure. > I will take the dts parts through the Mediatek SoC tree, so you don't have to worry about them. Please let me know when you take patch 1 and 2. Regards, Matthias
Re: [PATCH v1 4/4] arm64: dts: mediatek: add mt2712 cpufreq related device nodes
On 12-12-17, 02:17, Rafael J. Wysocki wrote: > On Monday, December 11, 2017 8:57:19 AM CET Viresh Kumar wrote: > > On 08-12-17, 14:07, Andrew-sh Cheng wrote: > > > Add opp v2 information, > > > and also add clocks, regulators and opp information into cpu nodes > > > > > > Signed-off-by: Andrew-sh Cheng > > > --- > > > arch/arm64/boot/dts/mediatek/mt2712-evb.dts | 27 ++ > > > arch/arm64/boot/dts/mediatek/mt2712e.dtsi | 57 > > > + > > > 2 files changed, 84 insertions(+) > > > > Acked-by: Viresh Kumar > > Of course, DT bindings require ACKs from DT maintainers to be applied. I didn't knew that we need Acks from DT maintainers for dts files as well? Yeah, its very much required while defining new bindings for sure. -- viresh
Re: [PATCH v1 4/4] arm64: dts: mediatek: add mt2712 cpufreq related device nodes
On Monday, December 11, 2017 8:57:19 AM CET Viresh Kumar wrote: > On 08-12-17, 14:07, Andrew-sh Cheng wrote: > > Add opp v2 information, > > and also add clocks, regulators and opp information into cpu nodes > > > > Signed-off-by: Andrew-sh Cheng > > --- > > arch/arm64/boot/dts/mediatek/mt2712-evb.dts | 27 ++ > > arch/arm64/boot/dts/mediatek/mt2712e.dtsi | 57 > > + > > 2 files changed, 84 insertions(+) > > Acked-by: Viresh Kumar Of course, DT bindings require ACKs from DT maintainers to be applied.
Re: [PATCH v1 4/4] arm64: dts: mediatek: add mt2712 cpufreq related device nodes
On 08-12-17, 14:07, Andrew-sh Cheng wrote: > Add opp v2 information, > and also add clocks, regulators and opp information into cpu nodes > > Signed-off-by: Andrew-sh Cheng > --- > arch/arm64/boot/dts/mediatek/mt2712-evb.dts | 27 ++ > arch/arm64/boot/dts/mediatek/mt2712e.dtsi | 57 > + > 2 files changed, 84 insertions(+) Acked-by: Viresh Kumar -- viresh
[PATCH v1 4/4] arm64: dts: mediatek: add mt2712 cpufreq related device nodes
Add opp v2 information,
and also add clocks, regulators and opp information into cpu nodes
Signed-off-by: Andrew-sh Cheng
---
arch/arm64/boot/dts/mediatek/mt2712-evb.dts | 27 ++
arch/arm64/boot/dts/mediatek/mt2712e.dtsi | 57 +
2 files changed, 84 insertions(+)
diff --git a/arch/arm64/boot/dts/mediatek/mt2712-evb.dts
b/arch/arm64/boot/dts/mediatek/mt2712-evb.dts
index 14163b9..d47f3c7 100644
--- a/arch/arm64/boot/dts/mediatek/mt2712-evb.dts
+++ b/arch/arm64/boot/dts/mediatek/mt2712-evb.dts
@@ -26,6 +26,33 @@
linux,initrd-start = <0x4500>;
linux,initrd-end = <0x4a00>;
};
+
+ cpus_fixed_vproc0: fixedregulator@0 {
+ compatible = "regulator-fixed";
+ regulator-name = "vproc_buck0";
+ regulator-min-microvolt = <100>;
+ regulator-max-microvolt = <100>;
+ };
+
+ cpus_fixed_vproc1: fixedregulator@1 {
+ compatible = "regulator-fixed";
+ regulator-name = "vproc_buck1";
+ regulator-min-microvolt = <100>;
+ regulator-max-microvolt = <100>;
+ };
+
+};
+
+&cpu0 {
+ proc-supply = <&cpus_fixed_vproc0>;
+};
+
+&cpu1 {
+ proc-supply = <&cpus_fixed_vproc0>;
+};
+
+&cpu2 {
+ proc-supply = <&cpus_fixed_vproc1>;
};
&uart0 {
diff --git a/arch/arm64/boot/dts/mediatek/mt2712e.dtsi
b/arch/arm64/boot/dts/mediatek/mt2712e.dtsi
index 61dd763..fdf66f4 100644
--- a/arch/arm64/boot/dts/mediatek/mt2712e.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt2712e.dtsi
@@ -16,6 +16,48 @@
#address-cells = <2>;
#size-cells = <2>;
+ cluster0_opp: opp_table0 {
+ compatible = "operating-points-v2";
+ opp-shared;
+ opp00 {
+ opp-hz = /bits/ 64 <59800>;
+ opp-microvolt = <100>;
+ };
+ opp01 {
+ opp-hz = /bits/ 64 <70200>;
+ opp-microvolt = <100>;
+ };
+ opp02 {
+ opp-hz = /bits/ 64 <79300>;
+ opp-microvolt = <100>;
+ };
+ };
+
+ cluster1_opp: opp_table1 {
+ compatible = "operating-points-v2";
+ opp-shared;
+ opp00 {
+ opp-hz = /bits/ 64 <59800>;
+ opp-microvolt = <100>;
+ };
+ opp01 {
+ opp-hz = /bits/ 64 <70200>;
+ opp-microvolt = <100>;
+ };
+ opp02 {
+ opp-hz = /bits/ 64 <79300>;
+ opp-microvolt = <100>;
+ };
+ opp03 {
+ opp-hz = /bits/ 64 <89700>;
+ opp-microvolt = <100>;
+ };
+ opp04 {
+ opp-hz = /bits/ 64 <100100>;
+ opp-microvolt = <100>;
+ };
+ };
+
cpus {
#address-cells = <1>;
#size-cells = <0>;
@@ -41,6 +83,11 @@
device_type = "cpu";
compatible = "arm,cortex-a35";
reg = <0x000>;
+ clocks = <&mcucfg CLK_MCU_MP0_SEL>,
+ <&topckgen CLK_TOP_F_MP0_PLL1>;
+ clock-names = "cpu", "intermediate";
+ proc-supply = <&cpus_fixed_vproc0>;
+ operating-points-v2 = <&cluster0_opp>;
cpu-idle-states = <&CPU_SLEEP_0 &CLUSTER_SLEEP_0>;
};
@@ -49,6 +96,11 @@
compatible = "arm,cortex-a35";
reg = <0x001>;
enable-method = "psci";
+ clocks = <&mcucfg CLK_MCU_MP0_SEL>,
+ <&topckgen CLK_TOP_F_MP0_PLL1>;
+ clock-names = "cpu", "intermediate";
+ proc-supply = <&cpus_fixed_vproc0>;
+ operating-points-v2 = <&cluster0_opp>;
cpu-idle-states = <&CPU_SLEEP_0 &CLUSTER_SLEEP_0>;
};
@@ -57,6 +109,11 @@
compatible = "arm,cortex-a72";
reg = <0x200>;
enable-method = "psci";
+ clocks = <&mcucfg CLK_MCU_MP2_SEL>,
+ <&topckgen CLK_TOP_F_BIG_PLL1>;
+ clock-names = "cpu", "intermediate";
+ proc-supply = <&cpus_fixed_vproc1>;
+ operating-points-v2 = <&cluster1_opp>;
cpu-idle-states = <&CPU_SLEEP_0 &CLUSTER_SLEEP_0>;
};
--
2.6.4
