Re: [PATCH v1 4/5] mm/memory_hotplug: onlining pages can only fail due to notifiers

[Pasha Tatashin]

LGTM

Reviewed-by: Pavel Tatashin 

On 8/16/18 6:06 AM, David Hildenbrand wrote:
> Onlining pages can only fail if a notifier reported a problem (e.g. -ENOMEM).
> online_pages_range() can never fail.
> 
> Signed-off-by: David Hildenbrand 
> ---
>  mm/memory_hotplug.c | 9 ++---
>  1 file changed, 2 insertions(+), 7 deletions(-)
> 
> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
> index 3dc6d2a309c2..bbbd16f9d877 100644
> --- a/mm/memory_hotplug.c
> +++ b/mm/memory_hotplug.c
> @@ -933,13 +933,8 @@ int __ref online_pages(unsigned long pfn, unsigned long 
> nr_pages, int online_typ
>   setup_zone_pageset(zone);
>   }
>  
> - ret = walk_system_ram_range(pfn, nr_pages, _pages,
> - online_pages_range);
> - if (ret) {
> - if (need_zonelists_rebuild)
> - zone_pcp_reset(zone);
> - goto failed_addition;
> - }
> + walk_system_ram_range(pfn, nr_pages, _pages,
> +   online_pages_range);
>  
>   zone->present_pages += onlined_pages;
>  
> 

Re: [PATCH v1 4/5] mm/memory_hotplug: onlining pages can only fail due to notifiers

[Pasha Tatashin]

LGTM

Reviewed-by: Pavel Tatashin 

On 8/16/18 6:06 AM, David Hildenbrand wrote:
> Onlining pages can only fail if a notifier reported a problem (e.g. -ENOMEM).
> online_pages_range() can never fail.
> 
> Signed-off-by: David Hildenbrand 
> ---
>  mm/memory_hotplug.c | 9 ++---
>  1 file changed, 2 insertions(+), 7 deletions(-)
> 
> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
> index 3dc6d2a309c2..bbbd16f9d877 100644
> --- a/mm/memory_hotplug.c
> +++ b/mm/memory_hotplug.c
> @@ -933,13 +933,8 @@ int __ref online_pages(unsigned long pfn, unsigned long 
> nr_pages, int online_typ
>   setup_zone_pageset(zone);
>   }
>  
> - ret = walk_system_ram_range(pfn, nr_pages, _pages,
> - online_pages_range);
> - if (ret) {
> - if (need_zonelists_rebuild)
> - zone_pcp_reset(zone);
> - goto failed_addition;
> - }
> + walk_system_ram_range(pfn, nr_pages, _pages,
> +   online_pages_range);
>  
>   zone->present_pages += onlined_pages;
>  
> 

[PATCH v1 4/5] mm/memory_hotplug: onlining pages can only fail due to notifiers

[David Hildenbrand]

Onlining pages can only fail if a notifier reported a problem (e.g. -ENOMEM).
online_pages_range() can never fail.

Signed-off-by: David Hildenbrand 
---
 mm/memory_hotplug.c | 9 ++---
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
index 3dc6d2a309c2..bbbd16f9d877 100644
--- a/mm/memory_hotplug.c
+++ b/mm/memory_hotplug.c
@@ -933,13 +933,8 @@ int __ref online_pages(unsigned long pfn, unsigned long 
nr_pages, int online_typ
setup_zone_pageset(zone);
}
 
-   ret = walk_system_ram_range(pfn, nr_pages, _pages,
-   online_pages_range);
-   if (ret) {
-   if (need_zonelists_rebuild)
-   zone_pcp_reset(zone);
-   goto failed_addition;
-   }
+   walk_system_ram_range(pfn, nr_pages, _pages,
+ online_pages_range);
 
zone->present_pages += onlined_pages;
 
-- 
2.17.1

[PATCH v1 4/5] mm/memory_hotplug: onlining pages can only fail due to notifiers

[David Hildenbrand]

Onlining pages can only fail if a notifier reported a problem (e.g. -ENOMEM).
online_pages_range() can never fail.

Signed-off-by: David Hildenbrand 
---
 mm/memory_hotplug.c | 9 ++---
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
index 3dc6d2a309c2..bbbd16f9d877 100644
--- a/mm/memory_hotplug.c
+++ b/mm/memory_hotplug.c
@@ -933,13 +933,8 @@ int __ref online_pages(unsigned long pfn, unsigned long 
nr_pages, int online_typ
setup_zone_pageset(zone);
}
 
-   ret = walk_system_ram_range(pfn, nr_pages, _pages,
-   online_pages_range);
-   if (ret) {
-   if (need_zonelists_rebuild)
-   zone_pcp_reset(zone);
-   goto failed_addition;
-   }
+   walk_system_ram_range(pfn, nr_pages, _pages,
+ online_pages_range);
 
zone->present_pages += onlined_pages;
 
-- 
2.17.1