Re: [PATCH v12 3/4] dt-bindings: power: Add the bindings for the bq2515x family of chargers.

2020-05-29 Thread Rob Herring
On Thu, May 28, 2020 at 05:53:49PM -0500, Ricardo Rivera-Matos wrote:
> The BQ2515X family of devices are highly integrated battery management
> ICs that integrate the most common functions for wearable devices
> namely a charger, an output voltage rail, ADC for battery and system
> monitoring, and a push-button controller.
> 
> Datasheets:
> http://www.ti.com/lit/ds/symlink/bq25150.pdf
> http://www.ti.com/lit/ds/symlink/bq25155.pdf
> 
> Signed-off-by: Ricardo Rivera-Matos 
> ---
>  .../bindings/power/supply/bq2515x.yaml| 91 +++
>  1 file changed, 91 insertions(+)
>  create mode 100644 
> Documentation/devicetree/bindings/power/supply/bq2515x.yaml
> 
> diff --git a/Documentation/devicetree/bindings/power/supply/bq2515x.yaml 
> b/Documentation/devicetree/bindings/power/supply/bq2515x.yaml
> new file mode 100644
> index ..19cb336d581e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/power/supply/bq2515x.yaml
> @@ -0,0 +1,91 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +# Copyright (C) 2020 Texas Instruments Incorporated
> +%YAML 1.2
> +---
> +$id: "http://devicetree.org/schemas/power/supply/bq2515x.yaml#;
> +$schema: "http://devicetree.org/meta-schemas/core.yaml#;
> +
> +title: TI bq2515x 500-mA Linear charger family
> +
> +maintainers:
> +  - Dan Murphy 
> +  - Ricardo Rivera-Matos 
> +
> +description: |
> +  The BQ2515x family is a highly integrated battery charge management IC that
> +  integrates the most common functions for wearable devices, namely a 
> charger,
> +  an output voltage rail, ADC for battery and system monitoring, and
> +  push-button controller.
> +
> +  Specifications about the charger can be found at:
> +http://www.ti.com/lit/ds/symlink/bq25150.pdf
> +http://www.ti.com/lit/ds/symlink/bq25155.pdf
> +
> +properties:
> +  compatible:
> +enum:
> +  - ti,bq25150
> +  - ti,bq25155
> +
> +  reg:
> +maxItems: 1
> +description: I2C address of the charger.
> +
> +  ac-detect-gpios:
> +description: |
> +   GPIO used for connecting the bq2515x device PG (AC Detect)
> +   pin.
> +maxItems: 1
> +
> +  reset-gpios:
> +description: GPIO used for hardware reset.
> +maxItems: 1
> +
> +  powerdown-gpios:
> +description: GPIO used for low power mode of IC.
> +maxItems: 1
> +
> +  charge-enable-gpios:
> +description: GPIO used to turn on and off charging.
> +maxItems: 1
> +
> +  input-current-limit-microamp:
> +$ref: /schemas/types.yaml#/definitions/uint32
> +description: Maximum input current in micro Amps.
> +minimum: 5
> +maximum: 50
> +
> +  monitored-battery:
> +$ref: battery.yaml#

This doesn't work. It's saying monitored-battery is a node containing 
all the properties in battery.yaml.

> +
> +required:
> +  - compatible
> +  - reg

How is the battery optional?

> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +bat: battery {
> +  compatible = "simple-battery";
> +  constant-charge-current-max-microamp = <5>;
> +  precharge-current-microamp = <2500>;
> +  constant-charge-voltage-max-microvolt = <400>;
> +};
> +#include 
> +i2c0 {
> +  #address-cells = <1>;
> +  #size-cells = <0>;
> +
> +  bq25150: charger@6b {
> +compatible = "ti,bq25150";
> +reg = <0x6b>;
> +monitored-battery = <>;
> +input-current-limit-microamp = <10>;
> +
> +ac-detect-gpios = < 28 GPIO_ACTIVE_HIGH>;
> +reset-gpios = < 14 GPIO_ACTIVE_HIGH>;
> +powerdown-gpios = < 15 GPIO_ACTIVE_HIGH>;
> +charge-enable-gpios = < 13 GPIO_ACTIVE_LOW>;
> +  };
> +};
> -- 
> 2.26.2
> 


[PATCH v12 3/4] dt-bindings: power: Add the bindings for the bq2515x family of chargers.

2020-05-28 Thread Ricardo Rivera-Matos
The BQ2515X family of devices are highly integrated battery management
ICs that integrate the most common functions for wearable devices
namely a charger, an output voltage rail, ADC for battery and system
monitoring, and a push-button controller.

Datasheets:
http://www.ti.com/lit/ds/symlink/bq25150.pdf
http://www.ti.com/lit/ds/symlink/bq25155.pdf

Signed-off-by: Ricardo Rivera-Matos 
---
 .../bindings/power/supply/bq2515x.yaml| 91 +++
 1 file changed, 91 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/power/supply/bq2515x.yaml

diff --git a/Documentation/devicetree/bindings/power/supply/bq2515x.yaml 
b/Documentation/devicetree/bindings/power/supply/bq2515x.yaml
new file mode 100644
index ..19cb336d581e
--- /dev/null
+++ b/Documentation/devicetree/bindings/power/supply/bq2515x.yaml
@@ -0,0 +1,91 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+# Copyright (C) 2020 Texas Instruments Incorporated
+%YAML 1.2
+---
+$id: "http://devicetree.org/schemas/power/supply/bq2515x.yaml#;
+$schema: "http://devicetree.org/meta-schemas/core.yaml#;
+
+title: TI bq2515x 500-mA Linear charger family
+
+maintainers:
+  - Dan Murphy 
+  - Ricardo Rivera-Matos 
+
+description: |
+  The BQ2515x family is a highly integrated battery charge management IC that
+  integrates the most common functions for wearable devices, namely a charger,
+  an output voltage rail, ADC for battery and system monitoring, and
+  push-button controller.
+
+  Specifications about the charger can be found at:
+http://www.ti.com/lit/ds/symlink/bq25150.pdf
+http://www.ti.com/lit/ds/symlink/bq25155.pdf
+
+properties:
+  compatible:
+enum:
+  - ti,bq25150
+  - ti,bq25155
+
+  reg:
+maxItems: 1
+description: I2C address of the charger.
+
+  ac-detect-gpios:
+description: |
+   GPIO used for connecting the bq2515x device PG (AC Detect)
+   pin.
+maxItems: 1
+
+  reset-gpios:
+description: GPIO used for hardware reset.
+maxItems: 1
+
+  powerdown-gpios:
+description: GPIO used for low power mode of IC.
+maxItems: 1
+
+  charge-enable-gpios:
+description: GPIO used to turn on and off charging.
+maxItems: 1
+
+  input-current-limit-microamp:
+$ref: /schemas/types.yaml#/definitions/uint32
+description: Maximum input current in micro Amps.
+minimum: 5
+maximum: 50
+
+  monitored-battery:
+$ref: battery.yaml#
+
+required:
+  - compatible
+  - reg
+
+additionalProperties: false
+
+examples:
+  - |
+bat: battery {
+  compatible = "simple-battery";
+  constant-charge-current-max-microamp = <5>;
+  precharge-current-microamp = <2500>;
+  constant-charge-voltage-max-microvolt = <400>;
+};
+#include 
+i2c0 {
+  #address-cells = <1>;
+  #size-cells = <0>;
+
+  bq25150: charger@6b {
+compatible = "ti,bq25150";
+reg = <0x6b>;
+monitored-battery = <>;
+input-current-limit-microamp = <10>;
+
+ac-detect-gpios = < 28 GPIO_ACTIVE_HIGH>;
+reset-gpios = < 14 GPIO_ACTIVE_HIGH>;
+powerdown-gpios = < 15 GPIO_ACTIVE_HIGH>;
+charge-enable-gpios = < 13 GPIO_ACTIVE_LOW>;
+  };
+};
-- 
2.26.2