Re: [PATCH v13 0/6] Introduce the STACKLEAK feature and a test for it
On June 24, 2018 9:18 AM, Ingo Molnar wrote: > - Alexander Popov alex.po...@linux.com wrote: > > > On 22.06.2018 06:16, Ingo Molnar wrote: > > > > > - Kees Cook keesc...@chromium.org wrote: > > > > > > > On Thu, Jun 21, 2018 at 7:07 PM, Kees Cook keesc...@chromium.org wrote: > > > > > > > > > It needs rebasing to -rc1 (which I've done already, but I'm still > > > > > > > > > > doing build tests on it). > > > > > > > > It's passed basic allmodconfig builds: > > > > > > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/kees/linux.git > > > > > > > > branch: for-next/stackleak > > > > > > Ok, that's 6 patches - please send the latest for review as emails to > > > lkml the > > > > > > usual. Thanks! > > > > I'll resend the rebased v13 shortly. > > Well, I assume there were v12->v13 changes, correct? > > If yes, and if it's on a different base krnel, then why did you call it a > > 'resend'? That will only get fewer people to review it ... Please don't do > that > > for future iterations. > > Thanks, > > Ingo v13 was sent for the first time a month ago and you were on the list of recipients: http://www.openwall.com/lists/kernel-hardening/2018/05/26/6 Jordan
Re: [PATCH v13 0/6] Introduce the STACKLEAK feature and a test for it
On June 24, 2018 9:18 AM, Ingo Molnar wrote: > - Alexander Popov alex.po...@linux.com wrote: > > > On 22.06.2018 06:16, Ingo Molnar wrote: > > > > > - Kees Cook keesc...@chromium.org wrote: > > > > > > > On Thu, Jun 21, 2018 at 7:07 PM, Kees Cook keesc...@chromium.org wrote: > > > > > > > > > It needs rebasing to -rc1 (which I've done already, but I'm still > > > > > > > > > > doing build tests on it). > > > > > > > > It's passed basic allmodconfig builds: > > > > > > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/kees/linux.git > > > > > > > > branch: for-next/stackleak > > > > > > Ok, that's 6 patches - please send the latest for review as emails to > > > lkml the > > > > > > usual. Thanks! > > > > I'll resend the rebased v13 shortly. > > Well, I assume there were v12->v13 changes, correct? > > If yes, and if it's on a different base krnel, then why did you call it a > > 'resend'? That will only get fewer people to review it ... Please don't do > that > > for future iterations. > > Thanks, > > Ingo v13 was sent for the first time a month ago and you were on the list of recipients: http://www.openwall.com/lists/kernel-hardening/2018/05/26/6 Jordan
