Re: [PATCH v13 43/51] ext4: Don't allow unmapped identifiers in richacls

[Andreas Dilger]

> On Nov 3, 2015, at 8:17 AM, Andreas Gruenbacher  wrote:
> 
> Don't allow acls which contain unmapped identifiers: they are meaningful
> for remote file systems only.

Looks fine.

Reviewed-by: Andreas Dilger 

> Signed-off-by: Andreas Gruenbacher 
> ---
> fs/ext4/richacl.c | 4 
> 1 file changed, 4 insertions(+)
> 
> diff --git a/fs/ext4/richacl.c b/fs/ext4/richacl.c
> index 906d048..2115385 100644
> --- a/fs/ext4/richacl.c
> +++ b/fs/ext4/richacl.c
> @@ -74,6 +74,10 @@ __ext4_set_richacl(handle_t *handle, struct inode *inode, 
> struct richacl *acl)
>   int retval, size;
>   void *value;
> 
> + /* Don't allow acls with unmapped identifiers. */
> + if (richacl_has_unmapped_identifiers(acl))
> + return -EINVAL;
> +
>   if (richacl_equiv_mode(acl, ) == 0) {
>   inode->i_ctime = ext4_current_time(inode);
>   inode->i_mode = mode;
> --
> 2.5.0
> 


Cheers, Andreas







signature.asc
Description: Message signed with OpenPGP using GPGMail

[PATCH v13 43/51] ext4: Don't allow unmapped identifiers in richacls

[Andreas Gruenbacher]

Don't allow acls which contain unmapped identifiers: they are meaningful
for remote file systems only.

Signed-off-by: Andreas Gruenbacher 
---
 fs/ext4/richacl.c | 4 
 1 file changed, 4 insertions(+)

diff --git a/fs/ext4/richacl.c b/fs/ext4/richacl.c
index 906d048..2115385 100644
--- a/fs/ext4/richacl.c
+++ b/fs/ext4/richacl.c
@@ -74,6 +74,10 @@ __ext4_set_richacl(handle_t *handle, struct inode *inode, 
struct richacl *acl)
int retval, size;
void *value;
 
+   /* Don't allow acls with unmapped identifiers. */
+   if (richacl_has_unmapped_identifiers(acl))
+   return -EINVAL;
+
if (richacl_equiv_mode(acl, ) == 0) {
inode->i_ctime = ext4_current_time(inode);
inode->i_mode = mode;
-- 
2.5.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH v13 43/51] ext4: Don't allow unmapped identifiers in richacls

[Andreas Gruenbacher]

Don't allow acls which contain unmapped identifiers: they are meaningful
for remote file systems only.

Signed-off-by: Andreas Gruenbacher 
---
 fs/ext4/richacl.c | 4 
 1 file changed, 4 insertions(+)

diff --git a/fs/ext4/richacl.c b/fs/ext4/richacl.c
index 906d048..2115385 100644
--- a/fs/ext4/richacl.c
+++ b/fs/ext4/richacl.c
@@ -74,6 +74,10 @@ __ext4_set_richacl(handle_t *handle, struct inode *inode, 
struct richacl *acl)
int retval, size;
void *value;
 
+   /* Don't allow acls with unmapped identifiers. */
+   if (richacl_has_unmapped_identifiers(acl))
+   return -EINVAL;
+
if (richacl_equiv_mode(acl, ) == 0) {
inode->i_ctime = ext4_current_time(inode);
inode->i_mode = mode;
-- 
2.5.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH v13 43/51] ext4: Don't allow unmapped identifiers in richacls

[Andreas Dilger]

> On Nov 3, 2015, at 8:17 AM, Andreas Gruenbacher  wrote:
> 
> Don't allow acls which contain unmapped identifiers: they are meaningful
> for remote file systems only.

Looks fine.

Reviewed-by: Andreas Dilger 

> Signed-off-by: Andreas Gruenbacher 
> ---
> fs/ext4/richacl.c | 4 
> 1 file changed, 4 insertions(+)
> 
> diff --git a/fs/ext4/richacl.c b/fs/ext4/richacl.c
> index 906d048..2115385 100644
> --- a/fs/ext4/richacl.c
> +++ b/fs/ext4/richacl.c
> @@ -74,6 +74,10 @@ __ext4_set_richacl(handle_t *handle, struct inode *inode, 
> struct richacl *acl)
>   int retval, size;
>   void *value;
> 
> + /* Don't allow acls with unmapped identifiers. */
> + if (richacl_has_unmapped_identifiers(acl))
> + return -EINVAL;
> +
>   if (richacl_equiv_mode(acl, ) == 0) {
>   inode->i_ctime = ext4_current_time(inode);
>   inode->i_mode = mode;
> --
> 2.5.0
> 


Cheers, Andreas







signature.asc
Description: Message signed with OpenPGP using GPGMail