Re: [PATCH v16 0/9] arm64: ARMv8.5-A: MTE: Add async mode support
On Mon, 15 Mar 2021 13:20:10 +, Vincenzo Frascino wrote: > This patchset implements the asynchronous mode support for ARMv8.5-A > Memory Tagging Extension (MTE), which is a debugging feature that allows > to detect with the help of the architecture the C and C++ programmatic > memory errors like buffer overflow, use-after-free, use-after-return, etc. > > MTE is built on top of the AArch64 v8.0 virtual address tagging TBI > (Top Byte Ignore) feature and allows a task to set a 4 bit tag on any > subset of its address space that is multiple of a 16 bytes granule. MTE > is based on a lock-key mechanism where the lock is the tag associated to > the physical memory and the key is the tag associated to the virtual > address. > When MTE is enabled and tags are set for ranges of address space of a task, > the PE will compare the tag related to the physical memory with the tag > related to the virtual address (tag check operation). Access to the memory > is granted only if the two tags match. In case of mismatch the PE will raise > an exception. > > [...] Applied to arm64 (for-next/mte-async-kernel-mode) but with a note that I'll drop them if Andrew prefers to take the patches via the mm tree. Thanks! [1/9] arm64: mte: Add asynchronous mode support https://git.kernel.org/arm64/c/f3b7deef8dca [2/9] kasan: Add KASAN mode kernel parameter https://git.kernel.org/arm64/c/2603f8a78dfb [3/9] arm64: mte: Drop arch_enable_tagging() https://git.kernel.org/arm64/c/c137c6145b11 [4/9] kasan: Add report for async mode https://git.kernel.org/arm64/c/8f7b5054755e [5/9] arm64: mte: Enable TCO in functions that can read beyond buffer limits https://git.kernel.org/arm64/c/e60beb95c08b [6/9] arm64: mte: Conditionally compile mte_enable_kernel_*() https://git.kernel.org/arm64/c/d8969752cc4e [7/9] arm64: mte: Enable async tag check fault https://git.kernel.org/arm64/c/65812c6921cc [8/9] arm64: mte: Report async tag faults before suspend https://git.kernel.org/arm64/c/eab0e6e17d87 [9/9] kasan, arm64: tests supports for HW_TAGS async mode https://git.kernel.org/arm64/c/e80a76aa1a91 -- Catalin
Re: [PATCH v16 0/9] arm64: ARMv8.5-A: MTE: Add async mode support
On Thu, Mar 18, 2021 at 06:56:07PM +, Catalin Marinas wrote:
> On Mon, Mar 15, 2021 at 01:20:10PM +, Vincenzo Frascino wrote:
> > This patchset implements the asynchronous mode support for ARMv8.5-A
> > Memory Tagging Extension (MTE), which is a debugging feature that allows
> > to detect with the help of the architecture the C and C++ programmatic
> > memory errors like buffer overflow, use-after-free, use-after-return, etc.
> >
> > MTE is built on top of the AArch64 v8.0 virtual address tagging TBI
> > (Top Byte Ignore) feature and allows a task to set a 4 bit tag on any
> > subset of its address space that is multiple of a 16 bytes granule. MTE
> > is based on a lock-key mechanism where the lock is the tag associated to
> > the physical memory and the key is the tag associated to the virtual
> > address.
> > When MTE is enabled and tags are set for ranges of address space of a task,
> > the PE will compare the tag related to the physical memory with the tag
> > related to the virtual address (tag check operation). Access to the memory
> > is granted only if the two tags match. In case of mismatch the PE will raise
> > an exception.
> >
> > The exception can be handled synchronously or asynchronously. When the
> > asynchronous mode is enabled:
> > - Upon fault the PE updates the TFSR_EL1 register.
> > - The kernel detects the change during one of the following:
> > - Context switching
> > - Return to user/EL0
> > - Kernel entry from EL1
> > - Kernel exit to EL1
> > - If the register has been updated by the PE the kernel clears it and
> > reports the error.
> >
> > The series is based on linux-next/akpm.
>
> Andrew, could you please pick these patches up via the mm tree? They
> depend on kasan patches already queued.
Andrew, are you ok for me to queue these patches via the arm64 tree for
5.13 or you'd rather take them in the mm tree? There is a conflict with
the mm tree in lib/test_kasan.c, I think commit ce816b430b5a ("kasan:
detect false-positives in tests").
Thanks.
--
Catalin
Re: [PATCH v16 0/9] arm64: ARMv8.5-A: MTE: Add async mode support
On Thu, Mar 18, 2021 at 7:56 PM Catalin Marinas wrote: > > On Mon, Mar 15, 2021 at 01:20:10PM +, Vincenzo Frascino wrote: > > This patchset implements the asynchronous mode support for ARMv8.5-A > > Memory Tagging Extension (MTE), which is a debugging feature that allows > > to detect with the help of the architecture the C and C++ programmatic > > memory errors like buffer overflow, use-after-free, use-after-return, etc. > > > > MTE is built on top of the AArch64 v8.0 virtual address tagging TBI > > (Top Byte Ignore) feature and allows a task to set a 4 bit tag on any > > subset of its address space that is multiple of a 16 bytes granule. MTE > > is based on a lock-key mechanism where the lock is the tag associated to > > the physical memory and the key is the tag associated to the virtual > > address. > > When MTE is enabled and tags are set for ranges of address space of a task, > > the PE will compare the tag related to the physical memory with the tag > > related to the virtual address (tag check operation). Access to the memory > > is granted only if the two tags match. In case of mismatch the PE will raise > > an exception. > > > > The exception can be handled synchronously or asynchronously. When the > > asynchronous mode is enabled: > > - Upon fault the PE updates the TFSR_EL1 register. > > - The kernel detects the change during one of the following: > > - Context switching > > - Return to user/EL0 > > - Kernel entry from EL1 > > - Kernel exit to EL1 > > - If the register has been updated by the PE the kernel clears it and > > reports the error. > > > > The series is based on linux-next/akpm. > > Andrew, could you please pick these patches up via the mm tree? They > depend on kasan patches already queued. Hi Andrew, Looks like these patches have reached a stable state. Could you please pick them up into mm targeting 5.13? Thanks!
Re: [PATCH v16 0/9] arm64: ARMv8.5-A: MTE: Add async mode support
On Thu, Mar 18, 2021 at 7:56 PM Catalin Marinas wrote: > > On Mon, Mar 15, 2021 at 01:20:10PM +, Vincenzo Frascino wrote: > > This patchset implements the asynchronous mode support for ARMv8.5-A > > Memory Tagging Extension (MTE), which is a debugging feature that allows > > to detect with the help of the architecture the C and C++ programmatic > > memory errors like buffer overflow, use-after-free, use-after-return, etc. > > > > MTE is built on top of the AArch64 v8.0 virtual address tagging TBI > > (Top Byte Ignore) feature and allows a task to set a 4 bit tag on any > > subset of its address space that is multiple of a 16 bytes granule. MTE > > is based on a lock-key mechanism where the lock is the tag associated to > > the physical memory and the key is the tag associated to the virtual > > address. > > When MTE is enabled and tags are set for ranges of address space of a task, > > the PE will compare the tag related to the physical memory with the tag > > related to the virtual address (tag check operation). Access to the memory > > is granted only if the two tags match. In case of mismatch the PE will raise > > an exception. > > > > The exception can be handled synchronously or asynchronously. When the > > asynchronous mode is enabled: > > - Upon fault the PE updates the TFSR_EL1 register. > > - The kernel detects the change during one of the following: > > - Context switching > > - Return to user/EL0 > > - Kernel entry from EL1 > > - Kernel exit to EL1 > > - If the register has been updated by the PE the kernel clears it and > > reports the error. > > > > The series is based on linux-next/akpm. > > Andrew, could you please pick these patches up via the mm tree? They > depend on kasan patches already queued. > > Andrey, all the kasan patches have your acked-by with the google.com > address and you've been cc'ed on that. You may want to update the > .mailmap file in the kernel. Good point. I was wondering if there's something like that for email changes. Will send a patch. Thank you, Catalin.
Re: [PATCH v16 0/9] arm64: ARMv8.5-A: MTE: Add async mode support
On Mon, Mar 15, 2021 at 01:20:10PM +, Vincenzo Frascino wrote: > This patchset implements the asynchronous mode support for ARMv8.5-A > Memory Tagging Extension (MTE), which is a debugging feature that allows > to detect with the help of the architecture the C and C++ programmatic > memory errors like buffer overflow, use-after-free, use-after-return, etc. > > MTE is built on top of the AArch64 v8.0 virtual address tagging TBI > (Top Byte Ignore) feature and allows a task to set a 4 bit tag on any > subset of its address space that is multiple of a 16 bytes granule. MTE > is based on a lock-key mechanism where the lock is the tag associated to > the physical memory and the key is the tag associated to the virtual > address. > When MTE is enabled and tags are set for ranges of address space of a task, > the PE will compare the tag related to the physical memory with the tag > related to the virtual address (tag check operation). Access to the memory > is granted only if the two tags match. In case of mismatch the PE will raise > an exception. > > The exception can be handled synchronously or asynchronously. When the > asynchronous mode is enabled: > - Upon fault the PE updates the TFSR_EL1 register. > - The kernel detects the change during one of the following: > - Context switching > - Return to user/EL0 > - Kernel entry from EL1 > - Kernel exit to EL1 > - If the register has been updated by the PE the kernel clears it and > reports the error. > > The series is based on linux-next/akpm. Andrew, could you please pick these patches up via the mm tree? They depend on kasan patches already queued. Andrey, all the kasan patches have your acked-by with the google.com address and you've been cc'ed on that. You may want to update the .mailmap file in the kernel. Thanks. -- Catalin
[PATCH v16 0/9] arm64: ARMv8.5-A: MTE: Add async mode support
This patchset implements the asynchronous mode support for ARMv8.5-A Memory Tagging Extension (MTE), which is a debugging feature that allows to detect with the help of the architecture the C and C++ programmatic memory errors like buffer overflow, use-after-free, use-after-return, etc. MTE is built on top of the AArch64 v8.0 virtual address tagging TBI (Top Byte Ignore) feature and allows a task to set a 4 bit tag on any subset of its address space that is multiple of a 16 bytes granule. MTE is based on a lock-key mechanism where the lock is the tag associated to the physical memory and the key is the tag associated to the virtual address. When MTE is enabled and tags are set for ranges of address space of a task, the PE will compare the tag related to the physical memory with the tag related to the virtual address (tag check operation). Access to the memory is granted only if the two tags match. In case of mismatch the PE will raise an exception. The exception can be handled synchronously or asynchronously. When the asynchronous mode is enabled: - Upon fault the PE updates the TFSR_EL1 register. - The kernel detects the change during one of the following: - Context switching - Return to user/EL0 - Kernel entry from EL1 - Kernel exit to EL1 - If the register has been updated by the PE the kernel clears it and reports the error. The series is based on linux-next/akpm. To simplify the testing a tree with the new patches on top has been made available at [1]. [1] https://git.gitlab.arm.com/linux-arm/linux-vf.git mte/v13.async.akpm Changes: v16: - Rebase on the latest linux-next/akpm. - Address review comments. v15: - Rebase on the latest linux-next/akpm. - Address review comments. - Enable KUNIT tests for async mode. - Drop kselftest that verified that TCO is enabled in load_unaligned_zeropad(). v14: - Rebase on the latest linux-next/akpm. - Address review comments. - Drop a patch that prevented to running the KUNIT tests in async mode. - Add kselftest to verify that TCO is enabled in load_unaligned_zeropad(). v13: - Rebase on the latest linux-next/akpm. - Address review comments. v12: - Fixed a bug affecting kernel functions allowed to read beyond buffer boundaries. - Added support for save/restore of TFSR_EL1 register during suspend/resume operations. - Rebased on latest linux-next/akpm. v11: - Added patch that disables KUNIT tests in async mode v10: - Rebase on the latest linux-next/akpm - Address review comments. v9: - Rebase on the latest linux-next/akpm - Address review comments. v8: - Address review comments. v7: - Fix a warning reported by kernel test robot. This time for real. v6: - Drop patches that forbid KASAN KUNIT tests when async mode is enabled. - Fix a warning reported by kernel test robot. - Address review comments. v5: - Rebase the series on linux-next/akpm. - Forbid execution for KASAN KUNIT tests when async mode is enabled. - Dropped patch to inline mte_assign_mem_tag_range(). - Address review comments. v4: - Added support for kasan.mode (sync/async) kernel command line parameter. - Addressed review comments. v3: - Exposed kasan_hw_tags_mode to convert the internal KASAN represenetation. - Added dsb() for kernel exit paths in arm64. - Addressed review comments. v2: - Fixed a compilation issue reported by krobot. - General cleanup. Cc: Andrew Morton Cc: Catalin Marinas Cc: Will Deacon Cc: Dmitry Vyukov Cc: Andrey Ryabinin Cc: Alexander Potapenko Cc: Marco Elver Cc: Evgenii Stepanov Cc: Branislav Rankov Cc: Andrey Konovalov Cc: Lorenzo Pieralisi Signed-off-by: Vincenzo Frascino Andrey Konovalov (1): kasan, arm64: tests supports for HW_TAGS async mode Vincenzo Frascino (8): arm64: mte: Add asynchronous mode support kasan: Add KASAN mode kernel parameter arm64: mte: Drop arch_enable_tagging() kasan: Add report for async mode arm64: mte: Enable TCO in functions that can read beyond buffer limits arm64: mte: Conditionally compile mte_enable_kernel_*() arm64: mte: Enable async tag check fault arm64: mte: Report async tag faults before suspend Documentation/dev-tools/kasan.rst | 9 +++ arch/arm64/include/asm/memory.h | 4 +- arch/arm64/include/asm/mte-kasan.h | 9 ++- arch/arm64/include/asm/mte.h| 48 + arch/arm64/include/asm/uaccess.h| 22 ++ arch/arm64/include/asm/word-at-a-time.h | 4 ++ arch/arm64/kernel/entry-common.c| 6 ++ arch/arm64/kernel/mte.c | 94 - arch/arm64/kernel/suspend.c | 3 + include/linux/kasan.h | 6 ++ lib/test_kasan.c| 19 +++-- mm/kasan/hw_tags.c | 66 +++-- mm/kasan/kasan.h| 40 +-- mm/kasan/report.c | 22 +- 14 files changed, 329
