Re: [PATCH v2] ARM: dts: Fix LEDs on exynos5422-odroidxu3

2015-09-16 Thread Kukjin Kim 
On 09/16/15 08:54, Krzysztof Kozlowski wrote:
> On 16.09.2015 08:35, Kukjin Kim wrote:
>> On 09/13/15 18:32, Krzysztof Kozlowski wrote:
>>> The LEDs on Odroid XU3 family boards could not properly probe because PWM
>>> outputs were reduced only to PWM for fan. Fix it for Odroid XU3 and
>>> XU3-Lite boards by switching to usage of all 4 outputs (although the PWM
>>> for MIPI probably is redundant because board does not have MIPI
>>> connector available).
>>>
>>> This fixes warnings on dmesg:
>>> [4.838712] samsung-pwm 12dd.pwm: tried to request PWM channel 1 
>>> without output
>>> [4.838725] leds_pwm pwmleds: unable to request PWM for green:mmc0: -22
>>> [4.838767] leds_pwm: probe of pwmleds failed with error -22
>>>
>>> Signed-off-by: Krzysztof Kozlowski 
>>>
>>> ---
>>>
>>> Changes since v1:
>>> 1. Do not rebase on patchset adding support for Odroid XU4 board. Rebase
>>>just on current next.
>>> ---
>>
>> Applied, thanks.
>>
> 
> Thanks. This is actually a candidate for current v4.3 cycle. It fixes
> issue with LEDs for Odroid XU3 caused by Anand's b685d540cc26:
> The offending commit b685d540cc26 was merged in v4.3.
> I forgot to add "fixes" tag.
>   Fixes: b685d540cc26 ("ARM: dts: Add pwm-fan node for 
> exynos5422-odroidxu3")
> 
> Can you send it to arm-soc during this cycle?
> 
Why not? Will do it ;-)

> For current v4.3 Bartlomiej's patch is also an important candidate:
> "ARM: dts: add suspend opp to exynos4412"
> 
Thanks for gentle reminder.

- Kukjin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH v2] ARM: dts: Fix LEDs on exynos5422-odroidxu3

2015-09-16 Thread Kukjin Kim 
On 09/16/15 08:54, Krzysztof Kozlowski wrote:
> On 16.09.2015 08:35, Kukjin Kim wrote:
>> On 09/13/15 18:32, Krzysztof Kozlowski wrote:
>>> The LEDs on Odroid XU3 family boards could not properly probe because PWM
>>> outputs were reduced only to PWM for fan. Fix it for Odroid XU3 and
>>> XU3-Lite boards by switching to usage of all 4 outputs (although the PWM
>>> for MIPI probably is redundant because board does not have MIPI
>>> connector available).
>>>
>>> This fixes warnings on dmesg:
>>> [4.838712] samsung-pwm 12dd.pwm: tried to request PWM channel 1 
>>> without output
>>> [4.838725] leds_pwm pwmleds: unable to request PWM for green:mmc0: -22
>>> [4.838767] leds_pwm: probe of pwmleds failed with error -22
>>>
>>> Signed-off-by: Krzysztof Kozlowski 
>>>
>>> ---
>>>
>>> Changes since v1:
>>> 1. Do not rebase on patchset adding support for Odroid XU4 board. Rebase
>>>just on current next.
>>> ---
>>
>> Applied, thanks.
>>
> 
> Thanks. This is actually a candidate for current v4.3 cycle. It fixes
> issue with LEDs for Odroid XU3 caused by Anand's b685d540cc26:
> The offending commit b685d540cc26 was merged in v4.3.
> I forgot to add "fixes" tag.
>   Fixes: b685d540cc26 ("ARM: dts: Add pwm-fan node for 
> exynos5422-odroidxu3")
> 
> Can you send it to arm-soc during this cycle?
> 
Why not? Will do it ;-)

> For current v4.3 Bartlomiej's patch is also an important candidate:
> "ARM: dts: add suspend opp to exynos4412"
> 
Thanks for gentle reminder.

- Kukjin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH v2] ARM: dts: Fix LEDs on exynos5422-odroidxu3

2015-09-15 Thread Krzysztof Kozlowski 
On 16.09.2015 08:35, Kukjin Kim wrote:
> On 09/13/15 18:32, Krzysztof Kozlowski wrote:
>> The LEDs on Odroid XU3 family boards could not properly probe because PWM
>> outputs were reduced only to PWM for fan. Fix it for Odroid XU3 and
>> XU3-Lite boards by switching to usage of all 4 outputs (although the PWM
>> for MIPI probably is redundant because board does not have MIPI
>> connector available).
>>
>> This fixes warnings on dmesg:
>> [4.838712] samsung-pwm 12dd.pwm: tried to request PWM channel 1 
>> without output
>> [4.838725] leds_pwm pwmleds: unable to request PWM for green:mmc0: -22
>> [4.838767] leds_pwm: probe of pwmleds failed with error -22
>>
>> Signed-off-by: Krzysztof Kozlowski 
>>
>> ---
>>
>> Changes since v1:
>> 1. Do not rebase on patchset adding support for Odroid XU4 board. Rebase
>>just on current next.
>> ---
> 
> Applied, thanks.
> 

Thanks. This is actually a candidate for current v4.3 cycle. It fixes
issue with LEDs for Odroid XU3 caused by Anand's b685d540cc26:
The offending commit b685d540cc26 was merged in v4.3.
I forgot to add "fixes" tag.
Fixes: b685d540cc26 ("ARM: dts: Add pwm-fan node for 
exynos5422-odroidxu3")

Can you send it to arm-soc during this cycle?

For current v4.3 Bartlomiej's patch is also an important candidate:
"ARM: dts: add suspend opp to exynos4412"

Best regards,
Krzysztof
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH v2] ARM: dts: Fix LEDs on exynos5422-odroidxu3

2015-09-15 Thread Kukjin Kim 
On 09/13/15 18:32, Krzysztof Kozlowski wrote:
> The LEDs on Odroid XU3 family boards could not properly probe because PWM
> outputs were reduced only to PWM for fan. Fix it for Odroid XU3 and
> XU3-Lite boards by switching to usage of all 4 outputs (although the PWM
> for MIPI probably is redundant because board does not have MIPI
> connector available).
> 
> This fixes warnings on dmesg:
> [4.838712] samsung-pwm 12dd.pwm: tried to request PWM channel 1 
> without output
> [4.838725] leds_pwm pwmleds: unable to request PWM for green:mmc0: -22
> [4.838767] leds_pwm: probe of pwmleds failed with error -22
> 
> Signed-off-by: Krzysztof Kozlowski 
> 
> ---
> 
> Changes since v1:
> 1. Do not rebase on patchset adding support for Odroid XU4 board. Rebase
>just on current next.
> ---

Applied, thanks.

- Kukjin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH v2] ARM: dts: Fix LEDs on exynos5422-odroidxu3

2015-09-15 Thread Kukjin Kim 
On 09/13/15 18:32, Krzysztof Kozlowski wrote:
> The LEDs on Odroid XU3 family boards could not properly probe because PWM
> outputs were reduced only to PWM for fan. Fix it for Odroid XU3 and
> XU3-Lite boards by switching to usage of all 4 outputs (although the PWM
> for MIPI probably is redundant because board does not have MIPI
> connector available).
> 
> This fixes warnings on dmesg:
> [4.838712] samsung-pwm 12dd.pwm: tried to request PWM channel 1 
> without output
> [4.838725] leds_pwm pwmleds: unable to request PWM for green:mmc0: -22
> [4.838767] leds_pwm: probe of pwmleds failed with error -22
> 
> Signed-off-by: Krzysztof Kozlowski 
> 
> ---
> 
> Changes since v1:
> 1. Do not rebase on patchset adding support for Odroid XU4 board. Rebase
>just on current next.
> ---

Applied, thanks.

- Kukjin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH v2] ARM: dts: Fix LEDs on exynos5422-odroidxu3

2015-09-15 Thread Krzysztof Kozlowski 
On 16.09.2015 08:35, Kukjin Kim wrote:
> On 09/13/15 18:32, Krzysztof Kozlowski wrote:
>> The LEDs on Odroid XU3 family boards could not properly probe because PWM
>> outputs were reduced only to PWM for fan. Fix it for Odroid XU3 and
>> XU3-Lite boards by switching to usage of all 4 outputs (although the PWM
>> for MIPI probably is redundant because board does not have MIPI
>> connector available).
>>
>> This fixes warnings on dmesg:
>> [4.838712] samsung-pwm 12dd.pwm: tried to request PWM channel 1 
>> without output
>> [4.838725] leds_pwm pwmleds: unable to request PWM for green:mmc0: -22
>> [4.838767] leds_pwm: probe of pwmleds failed with error -22
>>
>> Signed-off-by: Krzysztof Kozlowski 
>>
>> ---
>>
>> Changes since v1:
>> 1. Do not rebase on patchset adding support for Odroid XU4 board. Rebase
>>just on current next.
>> ---
> 
> Applied, thanks.
> 

Thanks. This is actually a candidate for current v4.3 cycle. It fixes
issue with LEDs for Odroid XU3 caused by Anand's b685d540cc26:
The offending commit b685d540cc26 was merged in v4.3.
I forgot to add "fixes" tag.
Fixes: b685d540cc26 ("ARM: dts: Add pwm-fan node for 
exynos5422-odroidxu3")

Can you send it to arm-soc during this cycle?

For current v4.3 Bartlomiej's patch is also an important candidate:
"ARM: dts: add suspend opp to exynos4412"

Best regards,
Krzysztof
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH v2] ARM: dts: Fix LEDs on exynos5422-odroidxu3

2015-09-13 Thread Krzysztof Kozlowski 
The LEDs on Odroid XU3 family boards could not properly probe because PWM
outputs were reduced only to PWM for fan. Fix it for Odroid XU3 and
XU3-Lite boards by switching to usage of all 4 outputs (although the PWM
for MIPI probably is redundant because board does not have MIPI
connector available).

This fixes warnings on dmesg:
[4.838712] samsung-pwm 12dd.pwm: tried to request PWM channel 1 without 
output
[4.838725] leds_pwm pwmleds: unable to request PWM for green:mmc0: -22
[4.838767] leds_pwm: probe of pwmleds failed with error -22

Signed-off-by: Krzysztof Kozlowski 

---

Changes since v1:
1. Do not rebase on patchset adding support for Odroid XU4 board. Rebase
   just on current next.
---
 arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi 
b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
index dd8bc86d9de4..90d298dce851 100644
--- a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
+++ b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
@@ -473,7 +473,6 @@
 */
pinctrl-0 = <_out _out _out _out>;
pinctrl-names = "default";
-   samsung,pwm-outputs = <0>;
status = "okay";
 };
 
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH v2] ARM: dts: Fix LEDs on exynos5422-odroidxu3

2015-09-13 Thread Krzysztof Kozlowski 
The LEDs on Odroid XU3 family boards could not properly probe because PWM
outputs were reduced only to PWM for fan. Fix it for Odroid XU3 and
XU3-Lite boards by switching to usage of all 4 outputs (although the PWM
for MIPI probably is redundant because board does not have MIPI
connector available).

This fixes warnings on dmesg:
[4.838712] samsung-pwm 12dd.pwm: tried to request PWM channel 1 without 
output
[4.838725] leds_pwm pwmleds: unable to request PWM for green:mmc0: -22
[4.838767] leds_pwm: probe of pwmleds failed with error -22

Signed-off-by: Krzysztof Kozlowski 

---

Changes since v1:
1. Do not rebase on patchset adding support for Odroid XU4 board. Rebase
   just on current next.
---
 arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi 
b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
index dd8bc86d9de4..90d298dce851 100644
--- a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
+++ b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
@@ -473,7 +473,6 @@
 */
pinctrl-0 = <_out _out _out _out>;
pinctrl-names = "default";
-   samsung,pwm-outputs = <0>;
status = "okay";
 };
 
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/