Re: [PATCH v2] ASoC: rockchip-i2s: dt: fix an error in the example

2014-09-15 Thread Mark Brown
On Sun, Sep 14, 2014 at 11:39:59AM +0800, Jianqun wrote:
> Reference to RK3288 TRM, fix an error in the example by swap "tx" and "rx".
> 
> Table 10-1 DMAC_BUS Request Mapping Table
> Req numberSource  Polarity
> 0 I2S tx  High level
> 1 I2S rx  High level
> 
> Tested on RK3288 board.
> 
> Signed-off-by: Jianqun 
> ---
> change since v1:
> - modify patch's changelog as Mark's suggestion

No, the patch has already been applied.  Once a patch has been applied
don't resend it, it can't be re-applied.  In this case the advice about
the changelog was something you should bear in mind for future
changelogs.


signature.asc
Description: Digital signature


Re: [PATCH v2] ASoC: rockchip-i2s: dt: fix an error in the example

2014-09-15 Thread Mark Brown
On Sun, Sep 14, 2014 at 11:39:59AM +0800, Jianqun wrote:
 Reference to RK3288 TRM, fix an error in the example by swap tx and rx.
 
 Table 10-1 DMAC_BUS Request Mapping Table
 Req numberSource  Polarity
 0 I2S tx  High level
 1 I2S rx  High level
 
 Tested on RK3288 board.
 
 Signed-off-by: Jianqun jay...@rock-chips.com
 ---
 change since v1:
 - modify patch's changelog as Mark's suggestion

No, the patch has already been applied.  Once a patch has been applied
don't resend it, it can't be re-applied.  In this case the advice about
the changelog was something you should bear in mind for future
changelogs.


signature.asc
Description: Digital signature


[PATCH v2] ASoC: rockchip-i2s: dt: fix an error in the example

2014-09-13 Thread Jianqun
Reference to RK3288 TRM, fix an error in the example by swap "tx" and "rx".

Table 10-1 DMAC_BUS Request Mapping Table
Req number  Source  Polarity
0   I2S tx  High level
1   I2S rx  High level

Tested on RK3288 board.

Signed-off-by: Jianqun 
---
change since v1:
- modify patch's changelog as Mark's suggestion

 Documentation/devicetree/bindings/sound/rockchip-i2s.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/sound/rockchip-i2s.txt 
b/Documentation/devicetree/bindings/sound/rockchip-i2s.txt
index 6c55fcf..9b82c20 100644
--- a/Documentation/devicetree/bindings/sound/rockchip-i2s.txt
+++ b/Documentation/devicetree/bindings/sound/rockchip-i2s.txt
@@ -31,7 +31,7 @@ i2s@ff89 {
#address-cells = <1>;
#size-cells = <0>;
dmas = < 0>, < 1>;
-   dma-names = "rx", "tx";
+   dma-names = "tx", "rx";
clock-names = "i2s_hclk", "i2s_clk";
clocks = < HCLK_I2S0>, < SCLK_I2S0>;
 };
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH v2] ASoC: rockchip-i2s: dt: fix an error in the example

2014-09-13 Thread Jianqun
Reference to RK3288 TRM, fix an error in the example by swap tx and rx.

Table 10-1 DMAC_BUS Request Mapping Table
Req number  Source  Polarity
0   I2S tx  High level
1   I2S rx  High level

Tested on RK3288 board.

Signed-off-by: Jianqun jay...@rock-chips.com
---
change since v1:
- modify patch's changelog as Mark's suggestion

 Documentation/devicetree/bindings/sound/rockchip-i2s.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/sound/rockchip-i2s.txt 
b/Documentation/devicetree/bindings/sound/rockchip-i2s.txt
index 6c55fcf..9b82c20 100644
--- a/Documentation/devicetree/bindings/sound/rockchip-i2s.txt
+++ b/Documentation/devicetree/bindings/sound/rockchip-i2s.txt
@@ -31,7 +31,7 @@ i2s@ff89 {
#address-cells = 1;
#size-cells = 0;
dmas = pdma1 0, pdma1 1;
-   dma-names = rx, tx;
+   dma-names = tx, rx;
clock-names = i2s_hclk, i2s_clk;
clocks = cru HCLK_I2S0, cru SCLK_I2S0;
 };
-- 
1.9.1

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/