Re: [PATCH v2] apf27dev: add max1027 in the dts

2014-08-31 Thread Alexander Shiyan 

Sun, 31 Aug 2014 00:00:57 +0200 от Philippe Reynes :
> 
> Signed-off-by: Philippe Reynes 
> ---
>  arch/arm/boot/dts/imx27-apf27dev.dts |   17 +
>  1 files changed, 17 insertions(+), 0 deletions(-)
> 
> Changelog:
> v2: (thanks Alexander Shiyan for the feedback)
> - spi mode 0 is the default so no need to explicitly define it
> 
> diff --git a/arch/arm/boot/dts/imx27-apf27dev.dts 
> b/arch/arm/boot/dts/imx27-apf27dev.dts
> index b982309..f2bab73 100644
> --- a/arch/arm/boot/dts/imx27-apf27dev.dts
> +++ b/arch/arm/boot/dts/imx27-apf27dev.dts
> @@ -82,6 +82,16 @@
>   pinctrl-names = "default";
>   pinctrl-0 = <_cspi1 _cspi1_cs>;
>   status = "okay";
> +
> + adc@0 {
> + compatible = "maxim,max1027";
> + reg = <0>;
> + interrupt-parent = <>;
> + interrupts = <15 IRQ_TYPE_EDGE_FALLING>;
> + pinctrl-names = "default";
> + pinctrl-0 = <_max1027>;
> + spi-max-frequency = <1000>;
> + };
>  };
>  
>   {
> @@ -230,6 +240,13 @@
>   pinctrl_sdhc2_cd: sdhc2cdgrp {
>   fsl,pins = ;
>   };
> +
> + pinctrl_max1027: max1027 {
> +  fsl,pins = <
> +  MX27_PAD_UART1_CTS__GPIO5_14 0
> +  MX27_PAD_UART1_RTS__GPIO5_15 0
> + >;
> + };
>   };
>  };

Only one remark.
Function of GPIO5.14 is unclear. Can you add a comment for this?

---

Re: [PATCH v2] apf27dev: add max1027 in the dts

2014-08-31 Thread Alexander Shiyan 

Sun, 31 Aug 2014 00:00:57 +0200 от Philippe Reynes trem...@gmail.com:
 
 Signed-off-by: Philippe Reynes trem...@gmail.com
 ---
  arch/arm/boot/dts/imx27-apf27dev.dts |   17 +
  1 files changed, 17 insertions(+), 0 deletions(-)
 
 Changelog:
 v2: (thanks Alexander Shiyan for the feedback)
 - spi mode 0 is the default so no need to explicitly define it
 
 diff --git a/arch/arm/boot/dts/imx27-apf27dev.dts 
 b/arch/arm/boot/dts/imx27-apf27dev.dts
 index b982309..f2bab73 100644
 --- a/arch/arm/boot/dts/imx27-apf27dev.dts
 +++ b/arch/arm/boot/dts/imx27-apf27dev.dts
 @@ -82,6 +82,16 @@
   pinctrl-names = default;
   pinctrl-0 = pinctrl_cspi1 pinctrl_cspi1_cs;
   status = okay;
 +
 + adc@0 {
 + compatible = maxim,max1027;
 + reg = 0;
 + interrupt-parent = gpio5;
 + interrupts = 15 IRQ_TYPE_EDGE_FALLING;
 + pinctrl-names = default;
 + pinctrl-0 = pinctrl_max1027;
 + spi-max-frequency = 1000;
 + };
  };
  
  cspi2 {
 @@ -230,6 +240,13 @@
   pinctrl_sdhc2_cd: sdhc2cdgrp {
   fsl,pins = MX27_PAD_TOUT__GPIO3_14 0x0;
   };
 +
 + pinctrl_max1027: max1027 {
 +  fsl,pins = 
 +  MX27_PAD_UART1_CTS__GPIO5_14 0
 +  MX27_PAD_UART1_RTS__GPIO5_15 0
 + ;
 + };
   };
  };

Only one remark.
Function of GPIO5.14 is unclear. Can you add a comment for this?

---

[PATCH v2] apf27dev: add max1027 in the dts

2014-08-30 Thread Philippe Reynes 

Signed-off-by: Philippe Reynes 
---
 arch/arm/boot/dts/imx27-apf27dev.dts |   17 +
 1 files changed, 17 insertions(+), 0 deletions(-)

Changelog:
v2: (thanks Alexander Shiyan for the feedback)
- spi mode 0 is the default so no need to explicitly define it

diff --git a/arch/arm/boot/dts/imx27-apf27dev.dts 
b/arch/arm/boot/dts/imx27-apf27dev.dts
index b982309..f2bab73 100644
--- a/arch/arm/boot/dts/imx27-apf27dev.dts
+++ b/arch/arm/boot/dts/imx27-apf27dev.dts
@@ -82,6 +82,16 @@
pinctrl-names = "default";
pinctrl-0 = <_cspi1 _cspi1_cs>;
status = "okay";
+
+   adc@0 {
+   compatible = "maxim,max1027";
+   reg = <0>;
+   interrupt-parent = <>;
+   interrupts = <15 IRQ_TYPE_EDGE_FALLING>;
+   pinctrl-names = "default";
+   pinctrl-0 = <_max1027>;
+   spi-max-frequency = <1000>;
+   };
 };
 
  {
@@ -230,6 +240,13 @@
pinctrl_sdhc2_cd: sdhc2cdgrp {
fsl,pins = ;
};
+
+   pinctrl_max1027: max1027 {
+fsl,pins = <
+MX27_PAD_UART1_CTS__GPIO5_14 0
+MX27_PAD_UART1_RTS__GPIO5_15 0
+   >;
+   };
};
 };
 
-- 
1.7.4.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH v2] apf27dev: add max1027 in the dts

2014-08-30 Thread Philippe Reynes 

Signed-off-by: Philippe Reynes trem...@gmail.com
---
 arch/arm/boot/dts/imx27-apf27dev.dts |   17 +
 1 files changed, 17 insertions(+), 0 deletions(-)

Changelog:
v2: (thanks Alexander Shiyan for the feedback)
- spi mode 0 is the default so no need to explicitly define it

diff --git a/arch/arm/boot/dts/imx27-apf27dev.dts 
b/arch/arm/boot/dts/imx27-apf27dev.dts
index b982309..f2bab73 100644
--- a/arch/arm/boot/dts/imx27-apf27dev.dts
+++ b/arch/arm/boot/dts/imx27-apf27dev.dts
@@ -82,6 +82,16 @@
pinctrl-names = default;
pinctrl-0 = pinctrl_cspi1 pinctrl_cspi1_cs;
status = okay;
+
+   adc@0 {
+   compatible = maxim,max1027;
+   reg = 0;
+   interrupt-parent = gpio5;
+   interrupts = 15 IRQ_TYPE_EDGE_FALLING;
+   pinctrl-names = default;
+   pinctrl-0 = pinctrl_max1027;
+   spi-max-frequency = 1000;
+   };
 };
 
 cspi2 {
@@ -230,6 +240,13 @@
pinctrl_sdhc2_cd: sdhc2cdgrp {
fsl,pins = MX27_PAD_TOUT__GPIO3_14 0x0;
};
+
+   pinctrl_max1027: max1027 {
+fsl,pins = 
+MX27_PAD_UART1_CTS__GPIO5_14 0
+MX27_PAD_UART1_RTS__GPIO5_15 0
+   ;
+   };
};
 };
 
-- 
1.7.4.4

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/