Re: [PATCH v2] dmaengine: make dmatest less noisy
On Mon, Aug 19, 2013 at 10:31 AM, Joe Perches wrote: >> -static unsigned int threads_per_chan = 1; >> +static unsigned int threads_per_chan = 8; >> module_param(threads_per_chan, uint, S_IRUGO); >> MODULE_PARM_DESC(threads_per_chan, >> "Number of threads to start per channel (default: 1)"); > > This is unrelated and makes the MODULE_PARAM_DESC below > it have the incorrect default. Argh sorry, unrelated patches in the tree. As I don't have loadable modules enabled in this system I have to alter the compile defaults and compile the module into the kernel :-/ Thanks for fixing the real issue the right way! Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2] dmaengine: make dmatest less noisy
On Mon, 2013-08-19 at 01:49 -0700, Dan Williams wrote:
> On Mon, Aug 19, 2013 at 1:37 AM, Andy Shevchenko
> wrote:
> > On Mon, 2013-08-19 at 10:25 +0200, Linus Walleij wrote:
> >> Commit 95019c8c5 "dmatest: gather test results in the linked list"
> >> started to warning whenever we add results to a test thread.
> >> A warning for something completely normal? This is just cluttering
> >> my terminal. Move to debug prints.
> >>
> >> Cc: Andy Shevchenko
> >> Signed-off-by: Linus Walleij
> >
> >> --- a/drivers/dma/dmatest.c
> >> +++ b/drivers/dma/dmatest.c
> >
> >> @@ -406,7 +406,7 @@ static int thread_result_add(struct dmatest_info *info,
> >> list_add_tail(>node, >results);
> >> mutex_unlock(>results_lock);
> >>
> >> - pr_warn("%s\n", thread_result_get(r->name, tr));
> >> + pr_debug("%s\n", thread_result_get(r->name, tr));
> >
> > This is the idea behind original DMATEST module logic.
> > As far as I understand we would like to have them as warnings in case
> > when driver is compiled in and tests are run from the beginning.
> >
> > Though, I sent a correction patch that moves "No error" messages to
> > debug level which, I think, makes sense. I don't know why Dan still keep
> > silent on my last message in the discussion [1].
> >
>
> Applying them now, and yes I agree with your patch to take this back
> to the original implementation of not squawking on success.
Thank you!
--
Andy Shevchenko
Intel Finland Oy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2] dmaengine: make dmatest less noisy
On Mon, Aug 19, 2013 at 1:37 AM, Andy Shevchenko
wrote:
> On Mon, 2013-08-19 at 10:25 +0200, Linus Walleij wrote:
>> Commit 95019c8c5 "dmatest: gather test results in the linked list"
>> started to warning whenever we add results to a test thread.
>> A warning for something completely normal? This is just cluttering
>> my terminal. Move to debug prints.
>>
>> Cc: Andy Shevchenko
>> Signed-off-by: Linus Walleij
>
>> --- a/drivers/dma/dmatest.c
>> +++ b/drivers/dma/dmatest.c
>
>> @@ -406,7 +406,7 @@ static int thread_result_add(struct dmatest_info *info,
>> list_add_tail(>node, >results);
>> mutex_unlock(>results_lock);
>>
>> - pr_warn("%s\n", thread_result_get(r->name, tr));
>> + pr_debug("%s\n", thread_result_get(r->name, tr));
>
> This is the idea behind original DMATEST module logic.
> As far as I understand we would like to have them as warnings in case
> when driver is compiled in and tests are run from the beginning.
>
> Though, I sent a correction patch that moves "No error" messages to
> debug level which, I think, makes sense. I don't know why Dan still keep
> silent on my last message in the discussion [1].
>
Applying them now, and yes I agree with your patch to take this back
to the original implementation of not squawking on success.
> [1] http://www.spinics.net/lists/kernel/msg1581822.html
>
>
> --
> Andy Shevchenko
> Intel Finland Oy
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2] dmaengine: make dmatest less noisy
On Mon, 2013-08-19 at 10:25 +0200, Linus Walleij wrote:
> Commit 95019c8c5 "dmatest: gather test results in the linked list"
> started to warning whenever we add results to a test thread.
> A warning for something completely normal? This is just cluttering
> my terminal. Move to debug prints.
>
> Cc: Andy Shevchenko
> Signed-off-by: Linus Walleij
> --- a/drivers/dma/dmatest.c
> +++ b/drivers/dma/dmatest.c
> @@ -406,7 +406,7 @@ static int thread_result_add(struct dmatest_info *info,
> list_add_tail(>node, >results);
> mutex_unlock(>results_lock);
>
> - pr_warn("%s\n", thread_result_get(r->name, tr));
> + pr_debug("%s\n", thread_result_get(r->name, tr));
This is the idea behind original DMATEST module logic.
As far as I understand we would like to have them as warnings in case
when driver is compiled in and tests are run from the beginning.
Though, I sent a correction patch that moves "No error" messages to
debug level which, I think, makes sense. I don't know why Dan still keep
silent on my last message in the discussion [1].
[1] http://www.spinics.net/lists/kernel/msg1581822.html
--
Andy Shevchenko
Intel Finland Oy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2] dmaengine: make dmatest less noisy
On Mon, 2013-08-19 at 10:25 +0200, Linus Walleij wrote:
> Commit 95019c8c5 "dmatest: gather test results in the linked list"
> started to warning whenever we add results to a test thread.
> A warning for something completely normal? This is just cluttering
> my terminal. Move to debug prints.
[]
> diff --git a/drivers/dma/dmatest.c b/drivers/dma/dmatest.c
[]
> @@ -36,7 +36,7 @@ static char test_device[20];
> module_param_string(device, test_device, sizeof(test_device), S_IRUGO);
> MODULE_PARM_DESC(device, "Bus ID of the DMA Engine to test (default: any)");
>
> -static unsigned int threads_per_chan = 1;
> +static unsigned int threads_per_chan = 8;
> module_param(threads_per_chan, uint, S_IRUGO);
> MODULE_PARM_DESC(threads_per_chan,
> "Number of threads to start per channel (default: 1)");
This is unrelated and makes the MODULE_PARAM_DESC below
it have the incorrect default.
> @@ -406,7 +406,7 @@ static int thread_result_add(struct dmatest_info *info,
> list_add_tail(>node, >results);
> mutex_unlock(>results_lock);
>
> - pr_warn("%s\n", thread_result_get(r->name, tr));
> + pr_debug("%s\n", thread_result_get(r->name, tr));
> return 0;
> }
>
This bit is sensible though.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH v2] dmaengine: make dmatest less noisy
Commit 95019c8c5 "dmatest: gather test results in the linked list"
started to warning whenever we add results to a test thread.
A warning for something completely normal? This is just cluttering
my terminal. Move to debug prints.
Cc: Andy Shevchenko
Signed-off-by: Linus Walleij
---
ChangeLog v1->v2:
- Instead of flat out deleting this, move it to debug.
---
drivers/dma/dmatest.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/dma/dmatest.c b/drivers/dma/dmatest.c
index e88ded2..e1dc005 100644
--- a/drivers/dma/dmatest.c
+++ b/drivers/dma/dmatest.c
@@ -36,7 +36,7 @@ static char test_device[20];
module_param_string(device, test_device, sizeof(test_device), S_IRUGO);
MODULE_PARM_DESC(device, "Bus ID of the DMA Engine to test (default: any)");
-static unsigned int threads_per_chan = 1;
+static unsigned int threads_per_chan = 8;
module_param(threads_per_chan, uint, S_IRUGO);
MODULE_PARM_DESC(threads_per_chan,
"Number of threads to start per channel (default: 1)");
@@ -406,7 +406,7 @@ static int thread_result_add(struct dmatest_info *info,
list_add_tail(>node, >results);
mutex_unlock(>results_lock);
- pr_warn("%s\n", thread_result_get(r->name, tr));
+ pr_debug("%s\n", thread_result_get(r->name, tr));
return 0;
}
--
1.8.1.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH v2] dmaengine: make dmatest less noisy
Commit 95019c8c5 dmatest: gather test results in the linked list started to warning whenever we add results to a test thread. A warning for something completely normal? This is just cluttering my terminal. Move to debug prints. Cc: Andy Shevchenko andriy.shevche...@linux.intel.com Signed-off-by: Linus Walleij linus.wall...@linaro.org --- ChangeLog v1-v2: - Instead of flat out deleting this, move it to debug. --- drivers/dma/dmatest.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/dma/dmatest.c b/drivers/dma/dmatest.c index e88ded2..e1dc005 100644 --- a/drivers/dma/dmatest.c +++ b/drivers/dma/dmatest.c @@ -36,7 +36,7 @@ static char test_device[20]; module_param_string(device, test_device, sizeof(test_device), S_IRUGO); MODULE_PARM_DESC(device, Bus ID of the DMA Engine to test (default: any)); -static unsigned int threads_per_chan = 1; +static unsigned int threads_per_chan = 8; module_param(threads_per_chan, uint, S_IRUGO); MODULE_PARM_DESC(threads_per_chan, Number of threads to start per channel (default: 1)); @@ -406,7 +406,7 @@ static int thread_result_add(struct dmatest_info *info, list_add_tail(tr-node, r-results); mutex_unlock(info-results_lock); - pr_warn(%s\n, thread_result_get(r-name, tr)); + pr_debug(%s\n, thread_result_get(r-name, tr)); return 0; } -- 1.8.1.4 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2] dmaengine: make dmatest less noisy
On Mon, 2013-08-19 at 10:25 +0200, Linus Walleij wrote: Commit 95019c8c5 dmatest: gather test results in the linked list started to warning whenever we add results to a test thread. A warning for something completely normal? This is just cluttering my terminal. Move to debug prints. [] diff --git a/drivers/dma/dmatest.c b/drivers/dma/dmatest.c [] @@ -36,7 +36,7 @@ static char test_device[20]; module_param_string(device, test_device, sizeof(test_device), S_IRUGO); MODULE_PARM_DESC(device, Bus ID of the DMA Engine to test (default: any)); -static unsigned int threads_per_chan = 1; +static unsigned int threads_per_chan = 8; module_param(threads_per_chan, uint, S_IRUGO); MODULE_PARM_DESC(threads_per_chan, Number of threads to start per channel (default: 1)); This is unrelated and makes the MODULE_PARAM_DESC below it have the incorrect default. @@ -406,7 +406,7 @@ static int thread_result_add(struct dmatest_info *info, list_add_tail(tr-node, r-results); mutex_unlock(info-results_lock); - pr_warn(%s\n, thread_result_get(r-name, tr)); + pr_debug(%s\n, thread_result_get(r-name, tr)); return 0; } This bit is sensible though. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2] dmaengine: make dmatest less noisy
On Mon, 2013-08-19 at 10:25 +0200, Linus Walleij wrote: Commit 95019c8c5 dmatest: gather test results in the linked list started to warning whenever we add results to a test thread. A warning for something completely normal? This is just cluttering my terminal. Move to debug prints. Cc: Andy Shevchenko andriy.shevche...@linux.intel.com Signed-off-by: Linus Walleij linus.wall...@linaro.org --- a/drivers/dma/dmatest.c +++ b/drivers/dma/dmatest.c @@ -406,7 +406,7 @@ static int thread_result_add(struct dmatest_info *info, list_add_tail(tr-node, r-results); mutex_unlock(info-results_lock); - pr_warn(%s\n, thread_result_get(r-name, tr)); + pr_debug(%s\n, thread_result_get(r-name, tr)); This is the idea behind original DMATEST module logic. As far as I understand we would like to have them as warnings in case when driver is compiled in and tests are run from the beginning. Though, I sent a correction patch that moves No error messages to debug level which, I think, makes sense. I don't know why Dan still keep silent on my last message in the discussion [1]. [1] http://www.spinics.net/lists/kernel/msg1581822.html -- Andy Shevchenko andriy.shevche...@linux.intel.com Intel Finland Oy -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2] dmaengine: make dmatest less noisy
On Mon, Aug 19, 2013 at 1:37 AM, Andy Shevchenko andriy.shevche...@linux.intel.com wrote: On Mon, 2013-08-19 at 10:25 +0200, Linus Walleij wrote: Commit 95019c8c5 dmatest: gather test results in the linked list started to warning whenever we add results to a test thread. A warning for something completely normal? This is just cluttering my terminal. Move to debug prints. Cc: Andy Shevchenko andriy.shevche...@linux.intel.com Signed-off-by: Linus Walleij linus.wall...@linaro.org --- a/drivers/dma/dmatest.c +++ b/drivers/dma/dmatest.c @@ -406,7 +406,7 @@ static int thread_result_add(struct dmatest_info *info, list_add_tail(tr-node, r-results); mutex_unlock(info-results_lock); - pr_warn(%s\n, thread_result_get(r-name, tr)); + pr_debug(%s\n, thread_result_get(r-name, tr)); This is the idea behind original DMATEST module logic. As far as I understand we would like to have them as warnings in case when driver is compiled in and tests are run from the beginning. Though, I sent a correction patch that moves No error messages to debug level which, I think, makes sense. I don't know why Dan still keep silent on my last message in the discussion [1]. Applying them now, and yes I agree with your patch to take this back to the original implementation of not squawking on success. [1] http://www.spinics.net/lists/kernel/msg1581822.html -- Andy Shevchenko andriy.shevche...@linux.intel.com Intel Finland Oy -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2] dmaengine: make dmatest less noisy
On Mon, 2013-08-19 at 01:49 -0700, Dan Williams wrote: On Mon, Aug 19, 2013 at 1:37 AM, Andy Shevchenko andriy.shevche...@linux.intel.com wrote: On Mon, 2013-08-19 at 10:25 +0200, Linus Walleij wrote: Commit 95019c8c5 dmatest: gather test results in the linked list started to warning whenever we add results to a test thread. A warning for something completely normal? This is just cluttering my terminal. Move to debug prints. Cc: Andy Shevchenko andriy.shevche...@linux.intel.com Signed-off-by: Linus Walleij linus.wall...@linaro.org --- a/drivers/dma/dmatest.c +++ b/drivers/dma/dmatest.c @@ -406,7 +406,7 @@ static int thread_result_add(struct dmatest_info *info, list_add_tail(tr-node, r-results); mutex_unlock(info-results_lock); - pr_warn(%s\n, thread_result_get(r-name, tr)); + pr_debug(%s\n, thread_result_get(r-name, tr)); This is the idea behind original DMATEST module logic. As far as I understand we would like to have them as warnings in case when driver is compiled in and tests are run from the beginning. Though, I sent a correction patch that moves No error messages to debug level which, I think, makes sense. I don't know why Dan still keep silent on my last message in the discussion [1]. Applying them now, and yes I agree with your patch to take this back to the original implementation of not squawking on success. Thank you! -- Andy Shevchenko andriy.shevche...@linux.intel.com Intel Finland Oy -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2] dmaengine: make dmatest less noisy
On Mon, Aug 19, 2013 at 10:31 AM, Joe Perches j...@perches.com wrote: -static unsigned int threads_per_chan = 1; +static unsigned int threads_per_chan = 8; module_param(threads_per_chan, uint, S_IRUGO); MODULE_PARM_DESC(threads_per_chan, Number of threads to start per channel (default: 1)); This is unrelated and makes the MODULE_PARAM_DESC below it have the incorrect default. Argh sorry, unrelated patches in the tree. As I don't have loadable modules enabled in this system I have to alter the compile defaults and compile the module into the kernel :-/ Thanks for fixing the real issue the right way! Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
