Re: [PATCH v2] staging: kpc2000: Add dependency on MFD_CORE to kconfig symbol 'KPC2000'
On Fri, May 24, 2019 at 03:02:48AM +, Geordan Neukum wrote: > On Fri, May 24, 2019 at 2:38 AM Geordan Neukum wrote: > > + depends on MFD_CORE > > In order for this to work in menuconfig, this either needs to be a > select or I need to > add a prompt to MFD_CORE. I don't have strong feelings either way, but all > other > Kconfig options which are related to the MFD_CORE appear to do a straight > selection. Let me know what you think and I'll go that route. Yeah, you are right, sorry about that. Let me just go hand edit-this patch and queue it up as this was my fault... thanks, greg k-h
Re: [PATCH v2] staging: kpc2000: Add dependency on MFD_CORE to kconfig symbol 'KPC2000'
On Fri, May 24, 2019 at 2:38 AM Geordan Neukum wrote: > + depends on MFD_CORE In order for this to work in menuconfig, this either needs to be a select or I need to add a prompt to MFD_CORE. I don't have strong feelings either way, but all other Kconfig options which are related to the MFD_CORE appear to do a straight selection. Let me know what you think and I'll go that route. Thanks, Geordan
[PATCH v2] staging: kpc2000: Add dependency on MFD_CORE to kconfig symbol 'KPC2000'
The kpc2000 core makes calls against functions conditionally exported upon selection of the kconfig symbol MFD_CORE. Therefore, the kpc2000 core depends upon the mfd_core, and that dependency must be tracked in Kconfig to avoid potential build issues. Signed-off-by: Geordan Neukum --- v2 changes - base patch on staging-linus - only add MFD_CORE dependency as the UIO dependency has already been handled by YueHaibing drivers/staging/kpc2000/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/kpc2000/Kconfig b/drivers/staging/kpc2000/Kconfig index febe4f8b30e5..ef0f4abe894a 100644 --- a/drivers/staging/kpc2000/Kconfig +++ b/drivers/staging/kpc2000/Kconfig @@ -2,6 +2,7 @@ config KPC2000 bool "Daktronics KPC Device support" + depends on MFD_CORE depends on PCI depends on UIO help -- 2.21.0
