Re: [PATCH v2] xen/arm: enable PV control for ARM
On 21 July 2013 15:54, Stefano Stabellini wrote: > On Fri, 19 Jul 2013, Julien Grall wrote: >> Enable power management from the toolstack for ARM guest. >> >> Signed-off-by: Julien Grall >> >> --- >> Changes in v2: >> - Don't compile xen/cpu_hotplug.o with ARM64 >> --- >> drivers/xen/Makefile |5 ++--- >> 1 file changed, 2 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/xen/Makefile b/drivers/xen/Makefile >> index 2bf461a..b550a94 100644 >> --- a/drivers/xen/Makefile >> +++ b/drivers/xen/Makefile >> @@ -1,9 +1,8 @@ >> -ifneq ($(CONFIG_ARM),y) >> -obj-y+= manage.o >> +ifneq ($(filter y, ($CONFIG_ARM) $(CONFIG_ARM64)),y > > This is wrong: ifneq is checking for the opposite condition of what we want, > and > beside you have the $ in the wrong place for CONFIG_ARM. > > Please test you patches before sending them. My apologies, I tried without any issue on ARM (certainly, because of the $ in wrong place). I will send a new patch. -- Julien Grall -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2] xen/arm: enable PV control for ARM
On Fri, 19 Jul 2013, Julien Grall wrote: > Enable power management from the toolstack for ARM guest. > > Signed-off-by: Julien Grall > > --- > Changes in v2: > - Don't compile xen/cpu_hotplug.o with ARM64 > --- > drivers/xen/Makefile |5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/xen/Makefile b/drivers/xen/Makefile > index 2bf461a..b550a94 100644 > --- a/drivers/xen/Makefile > +++ b/drivers/xen/Makefile > @@ -1,9 +1,8 @@ > -ifneq ($(CONFIG_ARM),y) > -obj-y+= manage.o > +ifneq ($(filter y, ($CONFIG_ARM) $(CONFIG_ARM64)),y This is wrong: ifneq is checking for the opposite condition of what we want, and beside you have the $ in the wrong place for CONFIG_ARM. Please test you patches before sending them. > obj-$(CONFIG_HOTPLUG_CPU)+= cpu_hotplug.o > endif > obj-$(CONFIG_X86)+= fallback.o > -obj-y+= grant-table.o features.o events.o balloon.o time.o > +obj-y+= grant-table.o features.o events.o balloon.o time.o manage.o > obj-y+= xenbus/ > > nostackp := $(call cc-option, -fno-stack-protector) > -- > 1.7.10.4 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2] xen/arm: enable PV control for ARM
On Fri, 19 Jul 2013, Julien Grall wrote: Enable power management from the toolstack for ARM guest. Signed-off-by: Julien Grall julien.gr...@linaro.org --- Changes in v2: - Don't compile xen/cpu_hotplug.o with ARM64 --- drivers/xen/Makefile |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/xen/Makefile b/drivers/xen/Makefile index 2bf461a..b550a94 100644 --- a/drivers/xen/Makefile +++ b/drivers/xen/Makefile @@ -1,9 +1,8 @@ -ifneq ($(CONFIG_ARM),y) -obj-y+= manage.o +ifneq ($(filter y, ($CONFIG_ARM) $(CONFIG_ARM64)),y This is wrong: ifneq is checking for the opposite condition of what we want, and beside you have the $ in the wrong place for CONFIG_ARM. Please test you patches before sending them. obj-$(CONFIG_HOTPLUG_CPU)+= cpu_hotplug.o endif obj-$(CONFIG_X86)+= fallback.o -obj-y+= grant-table.o features.o events.o balloon.o time.o +obj-y+= grant-table.o features.o events.o balloon.o time.o manage.o obj-y+= xenbus/ nostackp := $(call cc-option, -fno-stack-protector) -- 1.7.10.4 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2] xen/arm: enable PV control for ARM
On 21 July 2013 15:54, Stefano Stabellini stefano.stabell...@eu.citrix.com wrote: On Fri, 19 Jul 2013, Julien Grall wrote: Enable power management from the toolstack for ARM guest. Signed-off-by: Julien Grall julien.gr...@linaro.org --- Changes in v2: - Don't compile xen/cpu_hotplug.o with ARM64 --- drivers/xen/Makefile |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/xen/Makefile b/drivers/xen/Makefile index 2bf461a..b550a94 100644 --- a/drivers/xen/Makefile +++ b/drivers/xen/Makefile @@ -1,9 +1,8 @@ -ifneq ($(CONFIG_ARM),y) -obj-y+= manage.o +ifneq ($(filter y, ($CONFIG_ARM) $(CONFIG_ARM64)),y This is wrong: ifneq is checking for the opposite condition of what we want, and beside you have the $ in the wrong place for CONFIG_ARM. Please test you patches before sending them. My apologies, I tried without any issue on ARM (certainly, because of the $ in wrong place). I will send a new patch. -- Julien Grall -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH v2] xen/arm: enable PV control for ARM
Enable power management from the toolstack for ARM guest. Signed-off-by: Julien Grall --- Changes in v2: - Don't compile xen/cpu_hotplug.o with ARM64 --- drivers/xen/Makefile |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/xen/Makefile b/drivers/xen/Makefile index 2bf461a..b550a94 100644 --- a/drivers/xen/Makefile +++ b/drivers/xen/Makefile @@ -1,9 +1,8 @@ -ifneq ($(CONFIG_ARM),y) -obj-y += manage.o +ifneq ($(filter y, ($CONFIG_ARM) $(CONFIG_ARM64)),) obj-$(CONFIG_HOTPLUG_CPU) += cpu_hotplug.o endif obj-$(CONFIG_X86) += fallback.o -obj-y += grant-table.o features.o events.o balloon.o time.o +obj-y += grant-table.o features.o events.o balloon.o time.o manage.o obj-y += xenbus/ nostackp := $(call cc-option, -fno-stack-protector) -- 1.7.10.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH v2] xen/arm: enable PV control for ARM
Enable power management from the toolstack for ARM guest. Signed-off-by: Julien Grall julien.gr...@linaro.org --- Changes in v2: - Don't compile xen/cpu_hotplug.o with ARM64 --- drivers/xen/Makefile |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/xen/Makefile b/drivers/xen/Makefile index 2bf461a..b550a94 100644 --- a/drivers/xen/Makefile +++ b/drivers/xen/Makefile @@ -1,9 +1,8 @@ -ifneq ($(CONFIG_ARM),y) -obj-y += manage.o +ifneq ($(filter y, ($CONFIG_ARM) $(CONFIG_ARM64)),) obj-$(CONFIG_HOTPLUG_CPU) += cpu_hotplug.o endif obj-$(CONFIG_X86) += fallback.o -obj-y += grant-table.o features.o events.o balloon.o time.o +obj-y += grant-table.o features.o events.o balloon.o time.o manage.o obj-y += xenbus/ nostackp := $(call cc-option, -fno-stack-protector) -- 1.7.10.4 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
