Re: [PATCH v2 0/2] drm/rockchip: Optimization vop dpms control
Am Donnerstag, 22. Januar 2015, 18:29:55 schrieb Mark Yao: > drm dpms have many power modes, ON,OFF,SUSPEND,STANDBY, etc. > but vop only have enable/disable mode, maybe case such bug: > --> DRM_DPMS_ON: power on vop > --> DRM_DPMS_SUSPEND: power off vop > --> DRM_DPMS_OFF: already power off at SUSPEND, crash > so use a bool val is more suitable. > > another problem at vop_crtc_dpms: > vop_enable()->drm_vblank_on, drm_vblank_on may call vop > enable vblank. if it happen, vblank enable would failed, > then cause irq status error. because is_enabled value is set > after drm_vblank_on. This series, on a rk3288-firefly board with a sda7123 vga connector Tested-by: Heiko Stuebner Heiko -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 0/2] drm/rockchip: Optimization vop dpms control
Am Donnerstag, 22. Januar 2015, 18:29:55 schrieb Mark Yao: drm dpms have many power modes, ON,OFF,SUSPEND,STANDBY, etc. but vop only have enable/disable mode, maybe case such bug: -- DRM_DPMS_ON: power on vop -- DRM_DPMS_SUSPEND: power off vop -- DRM_DPMS_OFF: already power off at SUSPEND, crash so use a bool val is more suitable. another problem at vop_crtc_dpms: vop_enable()-drm_vblank_on, drm_vblank_on may call vop enable vblank. if it happen, vblank enable would failed, then cause irq status error. because is_enabled value is set after drm_vblank_on. This series, on a rk3288-firefly board with a sda7123 vga connector Tested-by: Heiko Stuebner he...@sntech.de Heiko -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH v2 0/2] drm/rockchip: Optimization vop dpms control
drm dpms have many power modes, ON,OFF,SUSPEND,STANDBY, etc. but vop only have enable/disable mode, maybe case such bug: --> DRM_DPMS_ON: power on vop --> DRM_DPMS_SUSPEND: power off vop --> DRM_DPMS_OFF: already power off at SUSPEND, crash so use a bool val is more suitable. another problem at vop_crtc_dpms: vop_enable()->drm_vblank_on, drm_vblank_on may call vop enable vblank. if it happen, vblank enable would failed, then cause irq status error. because is_enabled value is set after drm_vblank_on. Changes in v2: - fix mistake that set is_enabled wrong. Mark Yao (2): drm/rockchip: vop use is_enabled instead of dpms mode drm/rockchip: vop: set vop enabled after enable iommu drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c |2 +- drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 17 + drivers/gpu/drm/rockchip/rockchip_drm_gem.h |3 +-- 3 files changed, 7 insertions(+), 15 deletions(-) -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH v2 0/2] drm/rockchip: Optimization vop dpms control
drm dpms have many power modes, ON,OFF,SUSPEND,STANDBY, etc. but vop only have enable/disable mode, maybe case such bug: -- DRM_DPMS_ON: power on vop -- DRM_DPMS_SUSPEND: power off vop -- DRM_DPMS_OFF: already power off at SUSPEND, crash so use a bool val is more suitable. another problem at vop_crtc_dpms: vop_enable()-drm_vblank_on, drm_vblank_on may call vop enable vblank. if it happen, vblank enable would failed, then cause irq status error. because is_enabled value is set after drm_vblank_on. Changes in v2: - fix mistake that set is_enabled wrong. Mark Yao (2): drm/rockchip: vop use is_enabled instead of dpms mode drm/rockchip: vop: set vop enabled after enable iommu drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c |2 +- drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 17 + drivers/gpu/drm/rockchip/rockchip_drm_gem.h |3 +-- 3 files changed, 7 insertions(+), 15 deletions(-) -- 1.7.9.5 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/