Re: [PATCH v2 0/2] gpio: regression fixes
On Mon, Mar 1, 2021 at 5:57 PM Andy Shevchenko wrote: > > On Mon, Mar 1, 2021 at 11:13 AM Bartosz Golaszewski > wrote: > > On Mon, Mar 1, 2021 at 10:05 AM Johan Hovold wrote: > > > > > > Here's a fix for a regression in 5.12 due to the new stub-driver hack, > > > and a fix for potential list corruption due to missing locking which has > > > been there since the introduction of the character-device interface in > > > 4.6. > > > > > > Johan > > > > > > Changes in v2 > > > - drop the corresponding drv_set_drvdata() which is no longer needed > > >after patch 1/2 > > > - add Saravanas's reviewed-by tag to patch 2/2 > > > > > > > > > Johan Hovold (2): > > > gpio: fix NULL-deref-on-deregistration regression > > > gpio: fix gpio-device list corruption > > > > > > drivers/gpio/gpiolib.c | 7 +-- > > > 1 file changed, 5 insertions(+), 2 deletions(-) > > > Patches applied, thanks! > > Ooops, you are fast! The regression broke my gpip-sim I'm working on right now so I tested it too. Bartosz
Re: [PATCH v2 0/2] gpio: regression fixes
On Mon, Mar 1, 2021 at 1:12 AM Bartosz Golaszewski wrote: > > On Mon, Mar 1, 2021 at 10:05 AM Johan Hovold wrote: > > > > Here's a fix for a regression in 5.12 due to the new stub-driver hack, > > and a fix for potential list corruption due to missing locking which has > > been there since the introduction of the character-device interface in > > 4.6. > > > > Johan > > > > Changes in v2 > > - drop the corresponding drv_set_drvdata() which is no longer needed > >after patch 1/2 > > - add Saravanas's reviewed-by tag to patch 2/2 > > > > > > Johan Hovold (2): > > gpio: fix NULL-deref-on-deregistration regression > > gpio: fix gpio-device list corruption > > > > drivers/gpio/gpiolib.c | 7 +-- > > 1 file changed, 5 insertions(+), 2 deletions(-) > > > > -- > > 2.26.2 > > > > Patches applied, thanks! Thanks Johan and Bartosz! -Saravana
Re: [PATCH v2 0/2] gpio: regression fixes
On Mon, Mar 1, 2021 at 11:13 AM Bartosz Golaszewski wrote: > On Mon, Mar 1, 2021 at 10:05 AM Johan Hovold wrote: > > > > Here's a fix for a regression in 5.12 due to the new stub-driver hack, > > and a fix for potential list corruption due to missing locking which has > > been there since the introduction of the character-device interface in > > 4.6. > > > > Johan > > > > Changes in v2 > > - drop the corresponding drv_set_drvdata() which is no longer needed > >after patch 1/2 > > - add Saravanas's reviewed-by tag to patch 2/2 > > > > > > Johan Hovold (2): > > gpio: fix NULL-deref-on-deregistration regression > > gpio: fix gpio-device list corruption > > > > drivers/gpio/gpiolib.c | 7 +-- > > 1 file changed, 5 insertions(+), 2 deletions(-) > Patches applied, thanks! Ooops, you are fast! Anyway, I have tested with gpio-aggregator (w/o this series it sparkles with all possible bugs). Tested-by: Andy Shevchenko -- With Best Regards, Andy Shevchenko
Re: [PATCH v2 0/2] gpio: regression fixes
On Mon, Mar 1, 2021 at 10:05 AM Johan Hovold wrote: > > Here's a fix for a regression in 5.12 due to the new stub-driver hack, > and a fix for potential list corruption due to missing locking which has > been there since the introduction of the character-device interface in > 4.6. > > Johan > > Changes in v2 > - drop the corresponding drv_set_drvdata() which is no longer needed >after patch 1/2 > - add Saravanas's reviewed-by tag to patch 2/2 > > > Johan Hovold (2): > gpio: fix NULL-deref-on-deregistration regression > gpio: fix gpio-device list corruption > > drivers/gpio/gpiolib.c | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > -- > 2.26.2 > Patches applied, thanks! Bartosz
[PATCH v2 0/2] gpio: regression fixes
Here's a fix for a regression in 5.12 due to the new stub-driver hack, and a fix for potential list corruption due to missing locking which has been there since the introduction of the character-device interface in 4.6. Johan Changes in v2 - drop the corresponding drv_set_drvdata() which is no longer needed after patch 1/2 - add Saravanas's reviewed-by tag to patch 2/2 Johan Hovold (2): gpio: fix NULL-deref-on-deregistration regression gpio: fix gpio-device list corruption drivers/gpio/gpiolib.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) -- 2.26.2
