Re: [PATCH v2 02/14] drm/bridge: ti-sn65dsi86: Simplify refclk handling

[Andrzej Hajda]

W dniu 30.03.2021 o 04:53, Douglas Anderson pisze:
> The clock framework makes it simple to deal with an optional clock.
> You can call clk_get_optional() and if the clock isn't specified it'll
> just return NULL without complaint. It's valid to pass NULL to
> enable/disable/prepare/unprepare. Let's make use of this to simplify
> things a tiny bit.
>
> Signed-off-by: Douglas Anderson 
> Reviewed-by: Robert Foss 
> Reviewed-by: Bjorn Andersson 
> Reviewed-by: Stephen Boyd 
> Reviewed-by: Laurent Pinchart 
Reviewed-by: Andrzej Hajda 

Regards
Andrzej
> ---
>
> Changes in v2:
> - Removed 2nd paragraph in commit message.
>
>   drivers/gpu/drm/bridge/ti-sn65dsi86.c | 11 +++
>   1 file changed, 3 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c 
> b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
> index 88df4dd0f39d..96fe8f2c0ea9 100644
> --- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c
> +++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
> @@ -1275,14 +1275,9 @@ static int ti_sn_bridge_probe(struct i2c_client 
> *client,
>   return ret;
>   }
>   
> - pdata->refclk = devm_clk_get(pdata->dev, "refclk");
> - if (IS_ERR(pdata->refclk)) {
> - ret = PTR_ERR(pdata->refclk);
> - if (ret == -EPROBE_DEFER)
> - return ret;
> - DRM_DEBUG_KMS("refclk not found\n");
> - pdata->refclk = NULL;
> - }
> + pdata->refclk = devm_clk_get_optional(pdata->dev, "refclk");
> + if (IS_ERR(pdata->refclk))
> + return PTR_ERR(pdata->refclk);
>   
>   ret = ti_sn_bridge_parse_dsi_host(pdata);
>   if (ret)

[PATCH v2 02/14] drm/bridge: ti-sn65dsi86: Simplify refclk handling

[Douglas Anderson]

The clock framework makes it simple to deal with an optional clock.
You can call clk_get_optional() and if the clock isn't specified it'll
just return NULL without complaint. It's valid to pass NULL to
enable/disable/prepare/unprepare. Let's make use of this to simplify
things a tiny bit.

Signed-off-by: Douglas Anderson 
Reviewed-by: Robert Foss 
Reviewed-by: Bjorn Andersson 
Reviewed-by: Stephen Boyd 
Reviewed-by: Laurent Pinchart 
---

Changes in v2:
- Removed 2nd paragraph in commit message.

 drivers/gpu/drm/bridge/ti-sn65dsi86.c | 11 +++
 1 file changed, 3 insertions(+), 8 deletions(-)

diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c 
b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
index 88df4dd0f39d..96fe8f2c0ea9 100644
--- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c
+++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
@@ -1275,14 +1275,9 @@ static int ti_sn_bridge_probe(struct i2c_client *client,
return ret;
}
 
-   pdata->refclk = devm_clk_get(pdata->dev, "refclk");
-   if (IS_ERR(pdata->refclk)) {
-   ret = PTR_ERR(pdata->refclk);
-   if (ret == -EPROBE_DEFER)
-   return ret;
-   DRM_DEBUG_KMS("refclk not found\n");
-   pdata->refclk = NULL;
-   }
+   pdata->refclk = devm_clk_get_optional(pdata->dev, "refclk");
+   if (IS_ERR(pdata->refclk))
+   return PTR_ERR(pdata->refclk);
 
ret = ti_sn_bridge_parse_dsi_host(pdata);
if (ret)
-- 
2.31.0.291.g576ba9dcdaf-goog