Re: [PATCH v2 05/11] serial: sh-sci: Do not open-code sci_getreg()

[Peter Hurley]

On 04/29/2016 05:58 AM, Geert Uytterhoeven wrote:
> Replace open-coded variants of sci_getreg() by function calls, and drop
> intermediate variables where appropriate.

Reviewed-by: Peter Hurley 

Re: [PATCH v2 05/11] serial: sh-sci: Do not open-code sci_getreg()

[Peter Hurley]

On 04/29/2016 05:58 AM, Geert Uytterhoeven wrote:
> Replace open-coded variants of sci_getreg() by function calls, and drop
> intermediate variables where appropriate.

Reviewed-by: Peter Hurley 

[PATCH v2 05/11] serial: sh-sci: Do not open-code sci_getreg()

[Geert Uytterhoeven]

Replace open-coded variants of sci_getreg() by function calls, and drop
intermediate variables where appropriate.

Signed-off-by: Geert Uytterhoeven 
---
v2:
  - New.
---
 drivers/tty/serial/sh-sci.c | 7 ++-
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/tty/serial/sh-sci.c b/drivers/tty/serial/sh-sci.c
index bf3780a7f700cad8..ce7bd165929ea078 100644
--- a/drivers/tty/serial/sh-sci.c
+++ b/drivers/tty/serial/sh-sci.c
@@ -703,7 +703,6 @@ static void sci_poll_put_char(struct uart_port *port, 
unsigned char c)
 static void sci_init_pins(struct uart_port *port, unsigned int cflag)
 {
struct sci_port *s = to_sci_port(port);
-   const struct plat_sci_reg *reg = sci_regmap[s->cfg->regtype] + SCSPTR;
 
/*
 * Use port-specific handler if provided.
@@ -717,7 +716,7 @@ static void sci_init_pins(struct uart_port *port, unsigned 
int cflag)
 * For the generic path SCSPTR is necessary. Bail out if that's
 * unavailable, too.
 */
-   if (!reg->size)
+   if (!sci_getreg(port, SCSPTR)->size)
return;
 
if ((s->cfg->capabilities & SCIx_HAVE_RTSCTS) &&
@@ -1866,12 +1865,10 @@ static void sci_enable_ms(struct uart_port *port)
 
 static void sci_break_ctl(struct uart_port *port, int break_state)
 {
-   struct sci_port *s = to_sci_port(port);
-   const struct plat_sci_reg *reg = sci_regmap[s->cfg->regtype] + SCSPTR;
unsigned short scscr, scsptr;
 
/* check wheter the port has SCSPTR */
-   if (!reg->size) {
+   if (!sci_getreg(port, SCSPTR)->size) {
/*
 * Not supported by hardware. Most parts couple break and rx
 * interrupts together, with break detection always enabled.
-- 
1.9.1

[PATCH v2 05/11] serial: sh-sci: Do not open-code sci_getreg()

[Geert Uytterhoeven]

Replace open-coded variants of sci_getreg() by function calls, and drop
intermediate variables where appropriate.

Signed-off-by: Geert Uytterhoeven 
---
v2:
  - New.
---
 drivers/tty/serial/sh-sci.c | 7 ++-
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/tty/serial/sh-sci.c b/drivers/tty/serial/sh-sci.c
index bf3780a7f700cad8..ce7bd165929ea078 100644
--- a/drivers/tty/serial/sh-sci.c
+++ b/drivers/tty/serial/sh-sci.c
@@ -703,7 +703,6 @@ static void sci_poll_put_char(struct uart_port *port, 
unsigned char c)
 static void sci_init_pins(struct uart_port *port, unsigned int cflag)
 {
struct sci_port *s = to_sci_port(port);
-   const struct plat_sci_reg *reg = sci_regmap[s->cfg->regtype] + SCSPTR;
 
/*
 * Use port-specific handler if provided.
@@ -717,7 +716,7 @@ static void sci_init_pins(struct uart_port *port, unsigned 
int cflag)
 * For the generic path SCSPTR is necessary. Bail out if that's
 * unavailable, too.
 */
-   if (!reg->size)
+   if (!sci_getreg(port, SCSPTR)->size)
return;
 
if ((s->cfg->capabilities & SCIx_HAVE_RTSCTS) &&
@@ -1866,12 +1865,10 @@ static void sci_enable_ms(struct uart_port *port)
 
 static void sci_break_ctl(struct uart_port *port, int break_state)
 {
-   struct sci_port *s = to_sci_port(port);
-   const struct plat_sci_reg *reg = sci_regmap[s->cfg->regtype] + SCSPTR;
unsigned short scscr, scsptr;
 
/* check wheter the port has SCSPTR */
-   if (!reg->size) {
+   if (!sci_getreg(port, SCSPTR)->size) {
/*
 * Not supported by hardware. Most parts couple break and rx
 * interrupts together, with break detection always enabled.
-- 
1.9.1