Re: [PATCH v2 1/2] ASoC: es7241: add dt-bindings documentation for the es7241 adc
On Sat, Jun 30, 2018 at 07:22:40PM +0200, Jerome Brunet wrote: > +Optional properties: > +- VDDP-supply: regulator phandle for the VDDA supply > +- VDDA-supply: regulator phandle for the VDDP supply > +- VDDD-supply: regulator phandle for the VDDD supply Same issue as with the other binding: power isn't optional in the hardware so shouldn't be optional in the binding. signature.asc Description: PGP signature
Re: [PATCH v2 1/2] ASoC: es7241: add dt-bindings documentation for the es7241 adc
On Sat, Jun 30, 2018 at 07:22:40PM +0200, Jerome Brunet wrote: > +Optional properties: > +- VDDP-supply: regulator phandle for the VDDA supply > +- VDDA-supply: regulator phandle for the VDDP supply > +- VDDD-supply: regulator phandle for the VDDD supply Same issue as with the other binding: power isn't optional in the hardware so shouldn't be optional in the binding. signature.asc Description: PGP signature
[PATCH v2 1/2] ASoC: es7241: add dt-bindings documentation for the es7241 adc
Signed-off-by: Jerome Brunet --- .../devicetree/bindings/sound/everest,es7241.txt | 23 ++ 1 file changed, 23 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/everest,es7241.txt diff --git a/Documentation/devicetree/bindings/sound/everest,es7241.txt b/Documentation/devicetree/bindings/sound/everest,es7241.txt new file mode 100644 index ..adee52281b3c --- /dev/null +++ b/Documentation/devicetree/bindings/sound/everest,es7241.txt @@ -0,0 +1,23 @@ +ES7134 i2s DA converter + +Required properties: +- compatible : "everest,es7241" + +Optional properties: +- VDDP-supply: regulator phandle for the VDDA supply +- VDDA-supply: regulator phandle for the VDDP supply +- VDDD-supply: regulator phandle for the VDDD supply +- reset-gpios: gpio connected to the reset pin +- m0-gpios : gpio connected to the m0 pin +- m1-gpios : gpio connected to the m1 pin + +Example: + +linein: audio-codec@2 { + #sound-dai-cells = <0>; + compatible = "everest,es7241"; + VDDA-supply = <_3v3>; + VDDP-supply = <_3v3>; + VDDD-supply = <_3v3>; + reset-gpios = < GPIOH_42>; +}; -- 2.14.4
[PATCH v2 1/2] ASoC: es7241: add dt-bindings documentation for the es7241 adc
Signed-off-by: Jerome Brunet --- .../devicetree/bindings/sound/everest,es7241.txt | 23 ++ 1 file changed, 23 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/everest,es7241.txt diff --git a/Documentation/devicetree/bindings/sound/everest,es7241.txt b/Documentation/devicetree/bindings/sound/everest,es7241.txt new file mode 100644 index ..adee52281b3c --- /dev/null +++ b/Documentation/devicetree/bindings/sound/everest,es7241.txt @@ -0,0 +1,23 @@ +ES7134 i2s DA converter + +Required properties: +- compatible : "everest,es7241" + +Optional properties: +- VDDP-supply: regulator phandle for the VDDA supply +- VDDA-supply: regulator phandle for the VDDP supply +- VDDD-supply: regulator phandle for the VDDD supply +- reset-gpios: gpio connected to the reset pin +- m0-gpios : gpio connected to the m0 pin +- m1-gpios : gpio connected to the m1 pin + +Example: + +linein: audio-codec@2 { + #sound-dai-cells = <0>; + compatible = "everest,es7241"; + VDDA-supply = <_3v3>; + VDDP-supply = <_3v3>; + VDDD-supply = <_3v3>; + reset-gpios = < GPIOH_42>; +}; -- 2.14.4