Re: [PATCH v2 1/2] eeprom: at24: make spd world-readable again

[Bartosz Golaszewski]

niedz., 28 lip 2019 o 18:41 Jean Delvare  napisał(a):
>
> The integration of the at24 driver into the nvmem framework broke the
> world-readability of spd EEPROMs. Fix it.
>
> Signed-off-by: Jean Delvare 
> Fixes: 57d155506dd5 ("eeprom: at24: extend driver to plug into the NVMEM 
> framework")
> Cc: Andrew Lunn 
> Cc: Srinivas Kandagatla 
> Cc: Greg Kroah-Hartman 
> Cc: Bartosz Golaszewski 
> Cc: Arnd Bergmann 
> ---
> Note: This is only the 1st half of the fix, the nvmem core driver
> also needs to be fixed.
>
> Changes since V1:
>  * Split into 2 patches, one to the at24 driver and one to the nvmem
>core.
>
>  drivers/misc/eeprom/at24.c |2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-5.1.orig/drivers/misc/eeprom/at24.c   2019-07-28 16:52:06.550918923 
> +0200
> +++ linux-5.1/drivers/misc/eeprom/at24.c2019-07-28 16:53:28.104167083 
> +0200
> @@ -719,7 +719,7 @@ static int at24_probe(struct i2c_client
> nvmem_config.name = dev_name(dev);
> nvmem_config.dev = dev;
> nvmem_config.read_only = !writable;
> -   nvmem_config.root_only = true;
> +   nvmem_config.root_only = !(flags & AT24_FLAG_IRUGO);
> nvmem_config.owner = THIS_MODULE;
> nvmem_config.compat = true;
> nvmem_config.base_dev = dev;
>
>
> --
> Jean Delvare
> SUSE L3 Support

Applied to fixes.

Bart

[PATCH v2 1/2] eeprom: at24: make spd world-readable again

[Jean Delvare]

The integration of the at24 driver into the nvmem framework broke the
world-readability of spd EEPROMs. Fix it.

Signed-off-by: Jean Delvare 
Fixes: 57d155506dd5 ("eeprom: at24: extend driver to plug into the NVMEM 
framework")
Cc: Andrew Lunn 
Cc: Srinivas Kandagatla 
Cc: Greg Kroah-Hartman 
Cc: Bartosz Golaszewski 
Cc: Arnd Bergmann 
---
Note: This is only the 1st half of the fix, the nvmem core driver
also needs to be fixed.

Changes since V1:
 * Split into 2 patches, one to the at24 driver and one to the nvmem
   core.

 drivers/misc/eeprom/at24.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-5.1.orig/drivers/misc/eeprom/at24.c   2019-07-28 16:52:06.550918923 
+0200
+++ linux-5.1/drivers/misc/eeprom/at24.c2019-07-28 16:53:28.104167083 
+0200
@@ -719,7 +719,7 @@ static int at24_probe(struct i2c_client
nvmem_config.name = dev_name(dev);
nvmem_config.dev = dev;
nvmem_config.read_only = !writable;
-   nvmem_config.root_only = true;
+   nvmem_config.root_only = !(flags & AT24_FLAG_IRUGO);
nvmem_config.owner = THIS_MODULE;
nvmem_config.compat = true;
nvmem_config.base_dev = dev;


-- 
Jean Delvare
SUSE L3 Support