Re: [PATCH v2 1/3] i2c: mux: pca954x: simplify code to reach the adapter
On 2018-10-05 13:43, Wolfram Sang wrote: > On Wed, Oct 03, 2018 at 05:50:22PM +0200, Luca Ceresoli wrote: >> From: Luca Ceresoli >> >> struct i2c_client has a direct pointer to the adapter, no need to dig >> it out of the struct device tree. >> >> Signed-off-by: Luca Ceresoli > > I like such cleanups! Me too! All three patches applied to for-next. Thanks! Cheers, Peter
Re: [PATCH v2 1/3] i2c: mux: pca954x: simplify code to reach the adapter
On 2018-10-05 13:43, Wolfram Sang wrote: > On Wed, Oct 03, 2018 at 05:50:22PM +0200, Luca Ceresoli wrote: >> From: Luca Ceresoli >> >> struct i2c_client has a direct pointer to the adapter, no need to dig >> it out of the struct device tree. >> >> Signed-off-by: Luca Ceresoli > > I like such cleanups! Me too! All three patches applied to for-next. Thanks! Cheers, Peter
Re: [PATCH v2 1/3] i2c: mux: pca954x: simplify code to reach the adapter
On Wed, Oct 03, 2018 at 05:50:22PM +0200, Luca Ceresoli wrote: > From: Luca Ceresoli > > struct i2c_client has a direct pointer to the adapter, no need to dig > it out of the struct device tree. > > Signed-off-by: Luca Ceresoli I like such cleanups! Acked-by: Wolfram Sang signature.asc Description: PGP signature
Re: [PATCH v2 1/3] i2c: mux: pca954x: simplify code to reach the adapter
On Wed, Oct 03, 2018 at 05:50:22PM +0200, Luca Ceresoli wrote: > From: Luca Ceresoli > > struct i2c_client has a direct pointer to the adapter, no need to dig > it out of the struct device tree. > > Signed-off-by: Luca Ceresoli I like such cleanups! Acked-by: Wolfram Sang signature.asc Description: PGP signature
[PATCH v2 1/3] i2c: mux: pca954x: simplify code to reach the adapter
From: Luca Ceresoli
struct i2c_client has a direct pointer to the adapter, no need to dig
it out of the struct device tree.
Signed-off-by: Luca Ceresoli
---
drivers/i2c/muxes/i2c-mux-pca954x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/muxes/i2c-mux-pca954x.c
b/drivers/i2c/muxes/i2c-mux-pca954x.c
index 24bd9275fde5..bfabf985e830 100644
--- a/drivers/i2c/muxes/i2c-mux-pca954x.c
+++ b/drivers/i2c/muxes/i2c-mux-pca954x.c
@@ -347,7 +347,7 @@ static void pca954x_cleanup(struct i2c_mux_core *muxc)
static int pca954x_probe(struct i2c_client *client,
const struct i2c_device_id *id)
{
- struct i2c_adapter *adap = to_i2c_adapter(client->dev.parent);
+ struct i2c_adapter *adap = client->adapter;
struct pca954x_platform_data *pdata = dev_get_platdata(>dev);
struct device *dev = >dev;
struct device_node *np = dev->of_node;
--
2.17.1
[PATCH v2 1/3] i2c: mux: pca954x: simplify code to reach the adapter
From: Luca Ceresoli
struct i2c_client has a direct pointer to the adapter, no need to dig
it out of the struct device tree.
Signed-off-by: Luca Ceresoli
---
drivers/i2c/muxes/i2c-mux-pca954x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/muxes/i2c-mux-pca954x.c
b/drivers/i2c/muxes/i2c-mux-pca954x.c
index 24bd9275fde5..bfabf985e830 100644
--- a/drivers/i2c/muxes/i2c-mux-pca954x.c
+++ b/drivers/i2c/muxes/i2c-mux-pca954x.c
@@ -347,7 +347,7 @@ static void pca954x_cleanup(struct i2c_mux_core *muxc)
static int pca954x_probe(struct i2c_client *client,
const struct i2c_device_id *id)
{
- struct i2c_adapter *adap = to_i2c_adapter(client->dev.parent);
+ struct i2c_adapter *adap = client->adapter;
struct pca954x_platform_data *pdata = dev_get_platdata(>dev);
struct device *dev = >dev;
struct device_node *np = dev->of_node;
--
2.17.1
