Re: [PATCH v2 1/3] mm/vmalloc: don't set area->caller twice

2013-09-02 Thread Zhang Yanfei 
On 09/03/2013 11:00 AM, Wanpeng Li wrote:
> Changelog:
>  * rebase against mmotm tree
> 
> The caller address has already been set in set_vmalloc_vm(), there's no need
> to set it again in __vmalloc_area_node.
> 
> Signed-off-by: Wanpeng Li 

Reviewed-by: Zhang Yanfei 

> ---
>  mm/vmalloc.c |1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/mm/vmalloc.c b/mm/vmalloc.c
> index 1074543..d78d117 100644
> --- a/mm/vmalloc.c
> +++ b/mm/vmalloc.c
> @@ -1566,7 +1566,6 @@ static void *__vmalloc_area_node(struct vm_struct 
> *area, gfp_t gfp_mask,
>   pages = kmalloc_node(array_size, nested_gfp, node);
>   }
>   area->pages = pages;
> - area->caller = caller;
>   if (!area->pages) {
>   remove_vm_area(area->addr);
>   kfree(area);
> 


-- 
Thanks.
Zhang Yanfei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH v2 1/3] mm/vmalloc: don't set area->caller twice

2013-09-02 Thread Wanpeng Li 
Changelog:
 * rebase against mmotm tree

The caller address has already been set in set_vmalloc_vm(), there's no need
to set it again in __vmalloc_area_node.

Signed-off-by: Wanpeng Li 
---
 mm/vmalloc.c |1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/mm/vmalloc.c b/mm/vmalloc.c
index 1074543..d78d117 100644
--- a/mm/vmalloc.c
+++ b/mm/vmalloc.c
@@ -1566,7 +1566,6 @@ static void *__vmalloc_area_node(struct vm_struct *area, 
gfp_t gfp_mask,
pages = kmalloc_node(array_size, nested_gfp, node);
}
area->pages = pages;
-   area->caller = caller;
if (!area->pages) {
remove_vm_area(area->addr);
kfree(area);
-- 
1.7.5.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH v2 1/3] mm/vmalloc: don't set area-caller twice

2013-09-02 Thread Wanpeng Li 
Changelog:
 * rebase against mmotm tree

The caller address has already been set in set_vmalloc_vm(), there's no need
to set it again in __vmalloc_area_node.

Signed-off-by: Wanpeng Li liw...@linux.vnet.ibm.com
---
 mm/vmalloc.c |1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/mm/vmalloc.c b/mm/vmalloc.c
index 1074543..d78d117 100644
--- a/mm/vmalloc.c
+++ b/mm/vmalloc.c
@@ -1566,7 +1566,6 @@ static void *__vmalloc_area_node(struct vm_struct *area, 
gfp_t gfp_mask,
pages = kmalloc_node(array_size, nested_gfp, node);
}
area-pages = pages;
-   area-caller = caller;
if (!area-pages) {
remove_vm_area(area-addr);
kfree(area);
-- 
1.7.5.4

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH v2 1/3] mm/vmalloc: don't set area-caller twice

2013-09-02 Thread Zhang Yanfei 
On 09/03/2013 11:00 AM, Wanpeng Li wrote:
 Changelog:
  * rebase against mmotm tree
 
 The caller address has already been set in set_vmalloc_vm(), there's no need
 to set it again in __vmalloc_area_node.
 
 Signed-off-by: Wanpeng Li liw...@linux.vnet.ibm.com

Reviewed-by: Zhang Yanfei zhangyan...@cn.fujitsu.com

 ---
  mm/vmalloc.c |1 -
  1 files changed, 0 insertions(+), 1 deletions(-)
 
 diff --git a/mm/vmalloc.c b/mm/vmalloc.c
 index 1074543..d78d117 100644
 --- a/mm/vmalloc.c
 +++ b/mm/vmalloc.c
 @@ -1566,7 +1566,6 @@ static void *__vmalloc_area_node(struct vm_struct 
 *area, gfp_t gfp_mask,
   pages = kmalloc_node(array_size, nested_gfp, node);
   }
   area-pages = pages;
 - area-caller = caller;
   if (!area-pages) {
   remove_vm_area(area-addr);
   kfree(area);
 


-- 
Thanks.
Zhang Yanfei
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/