Re: [PATCH v2 1/6] dt-bindings: reset: Add PDC Global binding for SDM845 SoCs
On Fri, 24 Aug 2018 18:48:55 +0530, Sibi Sankar wrote: > Add PDC Global(Power Domain Controller) binding for SDM845 SoCs. > > Signed-off-by: Sibi Sankar > --- > .../bindings/reset/qcom,pdc-global.txt| 52 +++ > include/dt-bindings/reset/qcom,sdm845-pdc.h | 20 +++ > 2 files changed, 72 insertions(+) > create mode 100644 > Documentation/devicetree/bindings/reset/qcom,pdc-global.txt > create mode 100644 include/dt-bindings/reset/qcom,sdm845-pdc.h > Reviewed-by: Rob Herring
Re: [PATCH v2 1/6] dt-bindings: reset: Add PDC Global binding for SDM845 SoCs
On Fri, 24 Aug 2018 18:48:55 +0530, Sibi Sankar wrote: > Add PDC Global(Power Domain Controller) binding for SDM845 SoCs. > > Signed-off-by: Sibi Sankar > --- > .../bindings/reset/qcom,pdc-global.txt| 52 +++ > include/dt-bindings/reset/qcom,sdm845-pdc.h | 20 +++ > 2 files changed, 72 insertions(+) > create mode 100644 > Documentation/devicetree/bindings/reset/qcom,pdc-global.txt > create mode 100644 include/dt-bindings/reset/qcom,sdm845-pdc.h > Reviewed-by: Rob Herring
Re: [PATCH v2 1/6] dt-bindings: reset: Add PDC Global binding for SDM845 SoCs
On Tue, Aug 28, 2018 at 11:38:26AM +0530, si...@codeaurora.org wrote: > Hi Matthias, > Thanks for the review > > On 2018-08-28 06:08, Matthias Kaehlcke wrote: > > Hi Sibi, > > > > On Fri, Aug 24, 2018 at 06:48:55PM +0530, Sibi Sankar wrote: > > > Add PDC Global(Power Domain Controller) binding for SDM845 SoCs. > > > > nit: missing blank before the opening parenthesis. > > > > Will fix it > > > > > > > Signed-off-by: Sibi Sankar > > > --- > > > .../bindings/reset/qcom,pdc-global.txt| 52 > > > +++ > > > include/dt-bindings/reset/qcom,sdm845-pdc.h | 20 +++ > > > 2 files changed, 72 insertions(+) > > > create mode 100644 > > > Documentation/devicetree/bindings/reset/qcom,pdc-global.txt > > > create mode 100644 include/dt-bindings/reset/qcom,sdm845-pdc.h > > > > > > diff --git > > > a/Documentation/devicetree/bindings/reset/qcom,pdc-global.txt > > > b/Documentation/devicetree/bindings/reset/qcom,pdc-global.txt > > > new file mode 100644 > > > index ..69f9edca9503 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/reset/qcom,pdc-global.txt > > > @@ -0,0 +1,52 @@ > > > +PDC Global > > > +== > > > + > > > +This binding describes a reset-controller found on PDC-Global(Power > > > Domain > > > +Controller) block for Qualcomm Technologies Inc SDM845 SoCs. > > > > Are there other PDC reset controllers that aren't 'global'? Otherwise > > I'd suggest to use 'pdc-reset' instead of 'pdc-global', which is more > > specific and in line with the name of the driver added by this series. > > Or something like 'pdc-reset-global/main' if there are other > > controllers? > > > > These are the only reset lines found in the pdc-global register space. But > as > explained by Bjorn, wouldn't it be better to leave it as such since > pdc-global > best describes the hardware without being limited by the current > functionality > it is being used for? If I understand Bjorn's reply on https://patchwork.kernel.org/patch/10575335/ correctly it is planned to use the 'pdc-global' compatible string in the future in some sort of MFD driver for the 'PDC Global' IP block, which then instantiates other drivers like the reset controller. In this case I agree that 'pdc-global' seems a reasonable choice.
Re: [PATCH v2 1/6] dt-bindings: reset: Add PDC Global binding for SDM845 SoCs
On Tue, Aug 28, 2018 at 11:38:26AM +0530, si...@codeaurora.org wrote: > Hi Matthias, > Thanks for the review > > On 2018-08-28 06:08, Matthias Kaehlcke wrote: > > Hi Sibi, > > > > On Fri, Aug 24, 2018 at 06:48:55PM +0530, Sibi Sankar wrote: > > > Add PDC Global(Power Domain Controller) binding for SDM845 SoCs. > > > > nit: missing blank before the opening parenthesis. > > > > Will fix it > > > > > > > Signed-off-by: Sibi Sankar > > > --- > > > .../bindings/reset/qcom,pdc-global.txt| 52 > > > +++ > > > include/dt-bindings/reset/qcom,sdm845-pdc.h | 20 +++ > > > 2 files changed, 72 insertions(+) > > > create mode 100644 > > > Documentation/devicetree/bindings/reset/qcom,pdc-global.txt > > > create mode 100644 include/dt-bindings/reset/qcom,sdm845-pdc.h > > > > > > diff --git > > > a/Documentation/devicetree/bindings/reset/qcom,pdc-global.txt > > > b/Documentation/devicetree/bindings/reset/qcom,pdc-global.txt > > > new file mode 100644 > > > index ..69f9edca9503 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/reset/qcom,pdc-global.txt > > > @@ -0,0 +1,52 @@ > > > +PDC Global > > > +== > > > + > > > +This binding describes a reset-controller found on PDC-Global(Power > > > Domain > > > +Controller) block for Qualcomm Technologies Inc SDM845 SoCs. > > > > Are there other PDC reset controllers that aren't 'global'? Otherwise > > I'd suggest to use 'pdc-reset' instead of 'pdc-global', which is more > > specific and in line with the name of the driver added by this series. > > Or something like 'pdc-reset-global/main' if there are other > > controllers? > > > > These are the only reset lines found in the pdc-global register space. But > as > explained by Bjorn, wouldn't it be better to leave it as such since > pdc-global > best describes the hardware without being limited by the current > functionality > it is being used for? If I understand Bjorn's reply on https://patchwork.kernel.org/patch/10575335/ correctly it is planned to use the 'pdc-global' compatible string in the future in some sort of MFD driver for the 'PDC Global' IP block, which then instantiates other drivers like the reset controller. In this case I agree that 'pdc-global' seems a reasonable choice.
Re: [PATCH v2 1/6] dt-bindings: reset: Add PDC Global binding for SDM845 SoCs
Hi Matthias,
Thanks for the review
On 2018-08-28 06:08, Matthias Kaehlcke wrote:
Hi Sibi,
On Fri, Aug 24, 2018 at 06:48:55PM +0530, Sibi Sankar wrote:
Add PDC Global(Power Domain Controller) binding for SDM845 SoCs.
nit: missing blank before the opening parenthesis.
Will fix it
Signed-off-by: Sibi Sankar
---
.../bindings/reset/qcom,pdc-global.txt| 52
+++
include/dt-bindings/reset/qcom,sdm845-pdc.h | 20 +++
2 files changed, 72 insertions(+)
create mode 100644
Documentation/devicetree/bindings/reset/qcom,pdc-global.txt
create mode 100644 include/dt-bindings/reset/qcom,sdm845-pdc.h
diff --git
a/Documentation/devicetree/bindings/reset/qcom,pdc-global.txt
b/Documentation/devicetree/bindings/reset/qcom,pdc-global.txt
new file mode 100644
index ..69f9edca9503
--- /dev/null
+++ b/Documentation/devicetree/bindings/reset/qcom,pdc-global.txt
@@ -0,0 +1,52 @@
+PDC Global
+==
+
+This binding describes a reset-controller found on PDC-Global(Power
Domain
+Controller) block for Qualcomm Technologies Inc SDM845 SoCs.
Are there other PDC reset controllers that aren't 'global'? Otherwise
I'd suggest to use 'pdc-reset' instead of 'pdc-global', which is more
specific and in line with the name of the driver added by this series.
Or something like 'pdc-reset-global/main' if there are other
controllers?
These are the only reset lines found in the pdc-global register space.
But as
explained by Bjorn, wouldn't it be better to leave it as such since
pdc-global
best describes the hardware without being limited by the current
functionality
it is being used for?
+Required properties:
+- compatible:
+ Usage: required
+ Value type:
+ Definition: must be:
+ "qcom,sdm845-pdc-global"
+
+- reg:
+ Usage: required
+ Value type:
+ Definition: must specify the base address and size of the register
+ space.
+
+- #reset-cells:
+ Usage: required
+ Value type:
+ Definition: must be 1; cell entry represents the reset index.
+
+Example:
+
+pdc_reset: reset-controller@b2e {
+ compatible = "qcom,sdm845-pdc-global";
+ reg = <0xb2e 0x2>;
+ #reset-cells = <1>;
+};
+
+PDC reset clients
+==
+
+Device nodes that need access to reset lines should
+specify them as a reset phandle in their corresponding node as
+specified in reset.txt.
+
+For list of all valid reset indicies see
s/indicies/indices/ (or s/indicies/lines/ ?)
Cheers
Matthias
Re: [PATCH v2 1/6] dt-bindings: reset: Add PDC Global binding for SDM845 SoCs
Hi Matthias,
Thanks for the review
On 2018-08-28 06:08, Matthias Kaehlcke wrote:
Hi Sibi,
On Fri, Aug 24, 2018 at 06:48:55PM +0530, Sibi Sankar wrote:
Add PDC Global(Power Domain Controller) binding for SDM845 SoCs.
nit: missing blank before the opening parenthesis.
Will fix it
Signed-off-by: Sibi Sankar
---
.../bindings/reset/qcom,pdc-global.txt| 52
+++
include/dt-bindings/reset/qcom,sdm845-pdc.h | 20 +++
2 files changed, 72 insertions(+)
create mode 100644
Documentation/devicetree/bindings/reset/qcom,pdc-global.txt
create mode 100644 include/dt-bindings/reset/qcom,sdm845-pdc.h
diff --git
a/Documentation/devicetree/bindings/reset/qcom,pdc-global.txt
b/Documentation/devicetree/bindings/reset/qcom,pdc-global.txt
new file mode 100644
index ..69f9edca9503
--- /dev/null
+++ b/Documentation/devicetree/bindings/reset/qcom,pdc-global.txt
@@ -0,0 +1,52 @@
+PDC Global
+==
+
+This binding describes a reset-controller found on PDC-Global(Power
Domain
+Controller) block for Qualcomm Technologies Inc SDM845 SoCs.
Are there other PDC reset controllers that aren't 'global'? Otherwise
I'd suggest to use 'pdc-reset' instead of 'pdc-global', which is more
specific and in line with the name of the driver added by this series.
Or something like 'pdc-reset-global/main' if there are other
controllers?
These are the only reset lines found in the pdc-global register space.
But as
explained by Bjorn, wouldn't it be better to leave it as such since
pdc-global
best describes the hardware without being limited by the current
functionality
it is being used for?
+Required properties:
+- compatible:
+ Usage: required
+ Value type:
+ Definition: must be:
+ "qcom,sdm845-pdc-global"
+
+- reg:
+ Usage: required
+ Value type:
+ Definition: must specify the base address and size of the register
+ space.
+
+- #reset-cells:
+ Usage: required
+ Value type:
+ Definition: must be 1; cell entry represents the reset index.
+
+Example:
+
+pdc_reset: reset-controller@b2e {
+ compatible = "qcom,sdm845-pdc-global";
+ reg = <0xb2e 0x2>;
+ #reset-cells = <1>;
+};
+
+PDC reset clients
+==
+
+Device nodes that need access to reset lines should
+specify them as a reset phandle in their corresponding node as
+specified in reset.txt.
+
+For list of all valid reset indicies see
s/indicies/indices/ (or s/indicies/lines/ ?)
Cheers
Matthias
Re: [PATCH v2 1/6] dt-bindings: reset: Add PDC Global binding for SDM845 SoCs
Hi Sibi,
On Fri, Aug 24, 2018 at 06:48:55PM +0530, Sibi Sankar wrote:
> Add PDC Global(Power Domain Controller) binding for SDM845 SoCs.
nit: missing blank before the opening parenthesis.
>
> Signed-off-by: Sibi Sankar
> ---
> .../bindings/reset/qcom,pdc-global.txt| 52 +++
> include/dt-bindings/reset/qcom,sdm845-pdc.h | 20 +++
> 2 files changed, 72 insertions(+)
> create mode 100644
> Documentation/devicetree/bindings/reset/qcom,pdc-global.txt
> create mode 100644 include/dt-bindings/reset/qcom,sdm845-pdc.h
>
> diff --git a/Documentation/devicetree/bindings/reset/qcom,pdc-global.txt
> b/Documentation/devicetree/bindings/reset/qcom,pdc-global.txt
> new file mode 100644
> index ..69f9edca9503
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/reset/qcom,pdc-global.txt
> @@ -0,0 +1,52 @@
> +PDC Global
> +==
> +
> +This binding describes a reset-controller found on PDC-Global(Power Domain
> +Controller) block for Qualcomm Technologies Inc SDM845 SoCs.
Are there other PDC reset controllers that aren't 'global'? Otherwise
I'd suggest to use 'pdc-reset' instead of 'pdc-global', which is more
specific and in line with the name of the driver added by this series.
Or something like 'pdc-reset-global/main' if there are other
controllers?
> +Required properties:
> +- compatible:
> + Usage: required
> + Value type:
> + Definition: must be:
> + "qcom,sdm845-pdc-global"
> +
> +- reg:
> + Usage: required
> + Value type:
> + Definition: must specify the base address and size of the register
> + space.
> +
> +- #reset-cells:
> + Usage: required
> + Value type:
> + Definition: must be 1; cell entry represents the reset index.
> +
> +Example:
> +
> +pdc_reset: reset-controller@b2e {
> + compatible = "qcom,sdm845-pdc-global";
> + reg = <0xb2e 0x2>;
> + #reset-cells = <1>;
> +};
> +
> +PDC reset clients
> +==
> +
> +Device nodes that need access to reset lines should
> +specify them as a reset phandle in their corresponding node as
> +specified in reset.txt.
> +
> +For list of all valid reset indicies see
s/indicies/indices/ (or s/indicies/lines/ ?)
Cheers
Matthias
Re: [PATCH v2 1/6] dt-bindings: reset: Add PDC Global binding for SDM845 SoCs
Hi Sibi,
On Fri, Aug 24, 2018 at 06:48:55PM +0530, Sibi Sankar wrote:
> Add PDC Global(Power Domain Controller) binding for SDM845 SoCs.
nit: missing blank before the opening parenthesis.
>
> Signed-off-by: Sibi Sankar
> ---
> .../bindings/reset/qcom,pdc-global.txt| 52 +++
> include/dt-bindings/reset/qcom,sdm845-pdc.h | 20 +++
> 2 files changed, 72 insertions(+)
> create mode 100644
> Documentation/devicetree/bindings/reset/qcom,pdc-global.txt
> create mode 100644 include/dt-bindings/reset/qcom,sdm845-pdc.h
>
> diff --git a/Documentation/devicetree/bindings/reset/qcom,pdc-global.txt
> b/Documentation/devicetree/bindings/reset/qcom,pdc-global.txt
> new file mode 100644
> index ..69f9edca9503
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/reset/qcom,pdc-global.txt
> @@ -0,0 +1,52 @@
> +PDC Global
> +==
> +
> +This binding describes a reset-controller found on PDC-Global(Power Domain
> +Controller) block for Qualcomm Technologies Inc SDM845 SoCs.
Are there other PDC reset controllers that aren't 'global'? Otherwise
I'd suggest to use 'pdc-reset' instead of 'pdc-global', which is more
specific and in line with the name of the driver added by this series.
Or something like 'pdc-reset-global/main' if there are other
controllers?
> +Required properties:
> +- compatible:
> + Usage: required
> + Value type:
> + Definition: must be:
> + "qcom,sdm845-pdc-global"
> +
> +- reg:
> + Usage: required
> + Value type:
> + Definition: must specify the base address and size of the register
> + space.
> +
> +- #reset-cells:
> + Usage: required
> + Value type:
> + Definition: must be 1; cell entry represents the reset index.
> +
> +Example:
> +
> +pdc_reset: reset-controller@b2e {
> + compatible = "qcom,sdm845-pdc-global";
> + reg = <0xb2e 0x2>;
> + #reset-cells = <1>;
> +};
> +
> +PDC reset clients
> +==
> +
> +Device nodes that need access to reset lines should
> +specify them as a reset phandle in their corresponding node as
> +specified in reset.txt.
> +
> +For list of all valid reset indicies see
s/indicies/indices/ (or s/indicies/lines/ ?)
Cheers
Matthias
Re: [PATCH v2 1/6] dt-bindings: reset: Add PDC Global binding for SDM845 SoCs
On Fri 24 Aug 06:18 PDT 2018, Sibi Sankar wrote:
> Add PDC Global(Power Domain Controller) binding for SDM845 SoCs.
>
> Signed-off-by: Sibi Sankar
Reviewed-by: Bjorn Andersson
Regards,
Bjorn
> ---
> .../bindings/reset/qcom,pdc-global.txt| 52 +++
> include/dt-bindings/reset/qcom,sdm845-pdc.h | 20 +++
> 2 files changed, 72 insertions(+)
> create mode 100644
> Documentation/devicetree/bindings/reset/qcom,pdc-global.txt
> create mode 100644 include/dt-bindings/reset/qcom,sdm845-pdc.h
>
> diff --git a/Documentation/devicetree/bindings/reset/qcom,pdc-global.txt
> b/Documentation/devicetree/bindings/reset/qcom,pdc-global.txt
> new file mode 100644
> index ..69f9edca9503
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/reset/qcom,pdc-global.txt
> @@ -0,0 +1,52 @@
> +PDC Global
> +==
> +
> +This binding describes a reset-controller found on PDC-Global(Power Domain
> +Controller) block for Qualcomm Technologies Inc SDM845 SoCs.
> +
> +Required properties:
> +- compatible:
> + Usage: required
> + Value type:
> + Definition: must be:
> + "qcom,sdm845-pdc-global"
> +
> +- reg:
> + Usage: required
> + Value type:
> + Definition: must specify the base address and size of the register
> + space.
> +
> +- #reset-cells:
> + Usage: required
> + Value type:
> + Definition: must be 1; cell entry represents the reset index.
> +
> +Example:
> +
> +pdc_reset: reset-controller@b2e {
> + compatible = "qcom,sdm845-pdc-global";
> + reg = <0xb2e 0x2>;
> + #reset-cells = <1>;
> +};
> +
> +PDC reset clients
> +==
> +
> +Device nodes that need access to reset lines should
> +specify them as a reset phandle in their corresponding node as
> +specified in reset.txt.
> +
> +For list of all valid reset indicies see
> +
> +
> +Example:
> +
> +modem-pil@408 {
> + ...
> +
> + resets = <_reset PDC_MODEM_SYNC_RESET>;
> + reset-names = "pdc_reset";
> +
> + ...
> +};
> diff --git a/include/dt-bindings/reset/qcom,sdm845-pdc.h
> b/include/dt-bindings/reset/qcom,sdm845-pdc.h
> new file mode 100644
> index ..53c37f9c319a
> --- /dev/null
> +++ b/include/dt-bindings/reset/qcom,sdm845-pdc.h
> @@ -0,0 +1,20 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/*
> + * Copyright (C) 2018 The Linux Foundation. All rights reserved.
> + */
> +
> +#ifndef _DT_BINDINGS_RESET_PDC_SDM_845_H
> +#define _DT_BINDINGS_RESET_PDC_SDM_845_H
> +
> +#define PDC_APPS_SYNC_RESET 0
> +#define PDC_SP_SYNC_RESET1
> +#define PDC_AUDIO_SYNC_RESET 2
> +#define PDC_SENSORS_SYNC_RESET 3
> +#define PDC_AOP_SYNC_RESET 4
> +#define PDC_DEBUG_SYNC_RESET 5
> +#define PDC_GPU_SYNC_RESET 6
> +#define PDC_DISPLAY_SYNC_RESET 7
> +#define PDC_COMPUTE_SYNC_RESET 8
> +#define PDC_MODEM_SYNC_RESET 9
> +
> +#endif
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
Re: [PATCH v2 1/6] dt-bindings: reset: Add PDC Global binding for SDM845 SoCs
On Fri 24 Aug 06:18 PDT 2018, Sibi Sankar wrote:
> Add PDC Global(Power Domain Controller) binding for SDM845 SoCs.
>
> Signed-off-by: Sibi Sankar
Reviewed-by: Bjorn Andersson
Regards,
Bjorn
> ---
> .../bindings/reset/qcom,pdc-global.txt| 52 +++
> include/dt-bindings/reset/qcom,sdm845-pdc.h | 20 +++
> 2 files changed, 72 insertions(+)
> create mode 100644
> Documentation/devicetree/bindings/reset/qcom,pdc-global.txt
> create mode 100644 include/dt-bindings/reset/qcom,sdm845-pdc.h
>
> diff --git a/Documentation/devicetree/bindings/reset/qcom,pdc-global.txt
> b/Documentation/devicetree/bindings/reset/qcom,pdc-global.txt
> new file mode 100644
> index ..69f9edca9503
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/reset/qcom,pdc-global.txt
> @@ -0,0 +1,52 @@
> +PDC Global
> +==
> +
> +This binding describes a reset-controller found on PDC-Global(Power Domain
> +Controller) block for Qualcomm Technologies Inc SDM845 SoCs.
> +
> +Required properties:
> +- compatible:
> + Usage: required
> + Value type:
> + Definition: must be:
> + "qcom,sdm845-pdc-global"
> +
> +- reg:
> + Usage: required
> + Value type:
> + Definition: must specify the base address and size of the register
> + space.
> +
> +- #reset-cells:
> + Usage: required
> + Value type:
> + Definition: must be 1; cell entry represents the reset index.
> +
> +Example:
> +
> +pdc_reset: reset-controller@b2e {
> + compatible = "qcom,sdm845-pdc-global";
> + reg = <0xb2e 0x2>;
> + #reset-cells = <1>;
> +};
> +
> +PDC reset clients
> +==
> +
> +Device nodes that need access to reset lines should
> +specify them as a reset phandle in their corresponding node as
> +specified in reset.txt.
> +
> +For list of all valid reset indicies see
> +
> +
> +Example:
> +
> +modem-pil@408 {
> + ...
> +
> + resets = <_reset PDC_MODEM_SYNC_RESET>;
> + reset-names = "pdc_reset";
> +
> + ...
> +};
> diff --git a/include/dt-bindings/reset/qcom,sdm845-pdc.h
> b/include/dt-bindings/reset/qcom,sdm845-pdc.h
> new file mode 100644
> index ..53c37f9c319a
> --- /dev/null
> +++ b/include/dt-bindings/reset/qcom,sdm845-pdc.h
> @@ -0,0 +1,20 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/*
> + * Copyright (C) 2018 The Linux Foundation. All rights reserved.
> + */
> +
> +#ifndef _DT_BINDINGS_RESET_PDC_SDM_845_H
> +#define _DT_BINDINGS_RESET_PDC_SDM_845_H
> +
> +#define PDC_APPS_SYNC_RESET 0
> +#define PDC_SP_SYNC_RESET1
> +#define PDC_AUDIO_SYNC_RESET 2
> +#define PDC_SENSORS_SYNC_RESET 3
> +#define PDC_AOP_SYNC_RESET 4
> +#define PDC_DEBUG_SYNC_RESET 5
> +#define PDC_GPU_SYNC_RESET 6
> +#define PDC_DISPLAY_SYNC_RESET 7
> +#define PDC_COMPUTE_SYNC_RESET 8
> +#define PDC_MODEM_SYNC_RESET 9
> +
> +#endif
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
[PATCH v2 1/6] dt-bindings: reset: Add PDC Global binding for SDM845 SoCs
Add PDC Global(Power Domain Controller) binding for SDM845 SoCs.
Signed-off-by: Sibi Sankar
---
.../bindings/reset/qcom,pdc-global.txt| 52 +++
include/dt-bindings/reset/qcom,sdm845-pdc.h | 20 +++
2 files changed, 72 insertions(+)
create mode 100644 Documentation/devicetree/bindings/reset/qcom,pdc-global.txt
create mode 100644 include/dt-bindings/reset/qcom,sdm845-pdc.h
diff --git a/Documentation/devicetree/bindings/reset/qcom,pdc-global.txt
b/Documentation/devicetree/bindings/reset/qcom,pdc-global.txt
new file mode 100644
index ..69f9edca9503
--- /dev/null
+++ b/Documentation/devicetree/bindings/reset/qcom,pdc-global.txt
@@ -0,0 +1,52 @@
+PDC Global
+==
+
+This binding describes a reset-controller found on PDC-Global(Power Domain
+Controller) block for Qualcomm Technologies Inc SDM845 SoCs.
+
+Required properties:
+- compatible:
+ Usage: required
+ Value type:
+ Definition: must be:
+ "qcom,sdm845-pdc-global"
+
+- reg:
+ Usage: required
+ Value type:
+ Definition: must specify the base address and size of the register
+ space.
+
+- #reset-cells:
+ Usage: required
+ Value type:
+ Definition: must be 1; cell entry represents the reset index.
+
+Example:
+
+pdc_reset: reset-controller@b2e {
+ compatible = "qcom,sdm845-pdc-global";
+ reg = <0xb2e 0x2>;
+ #reset-cells = <1>;
+};
+
+PDC reset clients
+==
+
+Device nodes that need access to reset lines should
+specify them as a reset phandle in their corresponding node as
+specified in reset.txt.
+
+For list of all valid reset indicies see
+
+
+Example:
+
+modem-pil@408 {
+ ...
+
+ resets = <_reset PDC_MODEM_SYNC_RESET>;
+ reset-names = "pdc_reset";
+
+ ...
+};
diff --git a/include/dt-bindings/reset/qcom,sdm845-pdc.h
b/include/dt-bindings/reset/qcom,sdm845-pdc.h
new file mode 100644
index ..53c37f9c319a
--- /dev/null
+++ b/include/dt-bindings/reset/qcom,sdm845-pdc.h
@@ -0,0 +1,20 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+/*
+ * Copyright (C) 2018 The Linux Foundation. All rights reserved.
+ */
+
+#ifndef _DT_BINDINGS_RESET_PDC_SDM_845_H
+#define _DT_BINDINGS_RESET_PDC_SDM_845_H
+
+#define PDC_APPS_SYNC_RESET0
+#define PDC_SP_SYNC_RESET 1
+#define PDC_AUDIO_SYNC_RESET 2
+#define PDC_SENSORS_SYNC_RESET 3
+#define PDC_AOP_SYNC_RESET 4
+#define PDC_DEBUG_SYNC_RESET 5
+#define PDC_GPU_SYNC_RESET 6
+#define PDC_DISPLAY_SYNC_RESET 7
+#define PDC_COMPUTE_SYNC_RESET 8
+#define PDC_MODEM_SYNC_RESET 9
+
+#endif
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
[PATCH v2 1/6] dt-bindings: reset: Add PDC Global binding for SDM845 SoCs
Add PDC Global(Power Domain Controller) binding for SDM845 SoCs.
Signed-off-by: Sibi Sankar
---
.../bindings/reset/qcom,pdc-global.txt| 52 +++
include/dt-bindings/reset/qcom,sdm845-pdc.h | 20 +++
2 files changed, 72 insertions(+)
create mode 100644 Documentation/devicetree/bindings/reset/qcom,pdc-global.txt
create mode 100644 include/dt-bindings/reset/qcom,sdm845-pdc.h
diff --git a/Documentation/devicetree/bindings/reset/qcom,pdc-global.txt
b/Documentation/devicetree/bindings/reset/qcom,pdc-global.txt
new file mode 100644
index ..69f9edca9503
--- /dev/null
+++ b/Documentation/devicetree/bindings/reset/qcom,pdc-global.txt
@@ -0,0 +1,52 @@
+PDC Global
+==
+
+This binding describes a reset-controller found on PDC-Global(Power Domain
+Controller) block for Qualcomm Technologies Inc SDM845 SoCs.
+
+Required properties:
+- compatible:
+ Usage: required
+ Value type:
+ Definition: must be:
+ "qcom,sdm845-pdc-global"
+
+- reg:
+ Usage: required
+ Value type:
+ Definition: must specify the base address and size of the register
+ space.
+
+- #reset-cells:
+ Usage: required
+ Value type:
+ Definition: must be 1; cell entry represents the reset index.
+
+Example:
+
+pdc_reset: reset-controller@b2e {
+ compatible = "qcom,sdm845-pdc-global";
+ reg = <0xb2e 0x2>;
+ #reset-cells = <1>;
+};
+
+PDC reset clients
+==
+
+Device nodes that need access to reset lines should
+specify them as a reset phandle in their corresponding node as
+specified in reset.txt.
+
+For list of all valid reset indicies see
+
+
+Example:
+
+modem-pil@408 {
+ ...
+
+ resets = <_reset PDC_MODEM_SYNC_RESET>;
+ reset-names = "pdc_reset";
+
+ ...
+};
diff --git a/include/dt-bindings/reset/qcom,sdm845-pdc.h
b/include/dt-bindings/reset/qcom,sdm845-pdc.h
new file mode 100644
index ..53c37f9c319a
--- /dev/null
+++ b/include/dt-bindings/reset/qcom,sdm845-pdc.h
@@ -0,0 +1,20 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+/*
+ * Copyright (C) 2018 The Linux Foundation. All rights reserved.
+ */
+
+#ifndef _DT_BINDINGS_RESET_PDC_SDM_845_H
+#define _DT_BINDINGS_RESET_PDC_SDM_845_H
+
+#define PDC_APPS_SYNC_RESET0
+#define PDC_SP_SYNC_RESET 1
+#define PDC_AUDIO_SYNC_RESET 2
+#define PDC_SENSORS_SYNC_RESET 3
+#define PDC_AOP_SYNC_RESET 4
+#define PDC_DEBUG_SYNC_RESET 5
+#define PDC_GPU_SYNC_RESET 6
+#define PDC_DISPLAY_SYNC_RESET 7
+#define PDC_COMPUTE_SYNC_RESET 8
+#define PDC_MODEM_SYNC_RESET 9
+
+#endif
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
