Re: [PATCH v2 10/21] cpufreq: intel_pstate: use match_string() helper

2018-07-04 Thread Rafael J. Wysocki 
On Wednesday, June 27, 2018 1:56:30 AM CEST Srinivas Pandruvada wrote:
> On Tue, 2018-06-26 at 17:23 +0200, Rafael J. Wysocki wrote:
> > On Thursday, May 31, 2018 1:11:15 PM CEST Yisheng Xie wrote:
> > > match_string() returns the index of an array for a matching string,
> > > which can be used instead of open coded variant.
> > > 
> > > Reviewed-by: Andy Shevchenko 
> Acked-by: Srinivas Pandruvada 

Patch applied, thanks!

Re: [PATCH v2 10/21] cpufreq: intel_pstate: use match_string() helper

2018-06-26 Thread Srinivas Pandruvada 
On Tue, 2018-06-26 at 17:23 +0200, Rafael J. Wysocki wrote:
> On Thursday, May 31, 2018 1:11:15 PM CEST Yisheng Xie wrote:
> > match_string() returns the index of an array for a matching string,
> > which can be used instead of open coded variant.
> > 
> > Reviewed-by: Andy Shevchenko 
Acked-by: Srinivas Pandruvada 

> > Cc: Srinivas Pandruvada 
> > Cc: Len Brown 
> > Cc: "Rafael J. Wysocki" 
> > Cc: Viresh Kumar 
> > Cc: linux...@vger.kernel.org
> > Signed-off-by: Yisheng Xie 
> > ---
> > v2:
> >  - add Reviewed-by tag.
> > 
> >  drivers/cpufreq/intel_pstate.c | 15 ++-
> >  1 file changed, 6 insertions(+), 9 deletions(-)
> > performance
> > diff --git a/drivers/cpufreq/intel_pstate.c
> > b/drivers/cpufreq/intel_pstate.c
> > index 17e566af..d701e26 100644
> > --- a/drivers/cpufreq/intel_pstate.c
> > +++ b/drivers/cpufreq/intel_pstate.c
> > @@ -645,21 +645,18 @@ static ssize_t
> > store_energy_performance_preference(
> >  {
> > struct cpudata *cpu_data = all_cpu_data[policy->cpu];
> > char str_preference[21];
> > -   int ret, i = 0;
> > +   int ret;
> >  
> > ret = sscanf(buf, "%20s", str_preference);
> > if (ret != 1)
> > return -EINVAL;
> >  
> > -   while (energy_perf_strings[i] != NULL) {
> > -   if (!strcmp(str_preference,
> > energy_perf_strings[i])) {
> > -   intel_pstate_set_energy_pref_index(cpu_dat
> > a, i);
> > -   return count;
> > -   }
> > -   ++i;
> > -   }
> > +   ret = match_string(energy_perf_strings, -1,
> > str_preference);
> > +   if (ret < 0)
> > +   return ret;
> >  
> > -   return -EINVAL;
> > +   intel_pstate_set_energy_pref_index(cpu_data, ret);
> > +   return count;
> >  }
> >  
> >  static ssize_t show_energy_performance_preference(
> > 
> 
> Srinivas, any concerns?
>

Re: [PATCH v2 10/21] cpufreq: intel_pstate: use match_string() helper

2018-06-26 Thread Rafael J. Wysocki 
On Thursday, May 31, 2018 1:11:15 PM CEST Yisheng Xie wrote:
> match_string() returns the index of an array for a matching string,
> which can be used instead of open coded variant.
> 
> Reviewed-by: Andy Shevchenko 
> Cc: Srinivas Pandruvada 
> Cc: Len Brown 
> Cc: "Rafael J. Wysocki" 
> Cc: Viresh Kumar 
> Cc: linux...@vger.kernel.org
> Signed-off-by: Yisheng Xie 
> ---
> v2:
>  - add Reviewed-by tag.
> 
>  drivers/cpufreq/intel_pstate.c | 15 ++-
>  1 file changed, 6 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
> index 17e566af..d701e26 100644
> --- a/drivers/cpufreq/intel_pstate.c
> +++ b/drivers/cpufreq/intel_pstate.c
> @@ -645,21 +645,18 @@ static ssize_t store_energy_performance_preference(
>  {
>   struct cpudata *cpu_data = all_cpu_data[policy->cpu];
>   char str_preference[21];
> - int ret, i = 0;
> + int ret;
>  
>   ret = sscanf(buf, "%20s", str_preference);
>   if (ret != 1)
>   return -EINVAL;
>  
> - while (energy_perf_strings[i] != NULL) {
> - if (!strcmp(str_preference, energy_perf_strings[i])) {
> - intel_pstate_set_energy_pref_index(cpu_data, i);
> - return count;
> - }
> - ++i;
> - }
> + ret = match_string(energy_perf_strings, -1, str_preference);
> + if (ret < 0)
> + return ret;
>  
> - return -EINVAL;
> + intel_pstate_set_energy_pref_index(cpu_data, ret);
> + return count;
>  }
>  
>  static ssize_t show_energy_performance_preference(
> 

Srinivas, any concerns?

[PATCH v2 10/21] cpufreq: intel_pstate: use match_string() helper

2018-05-31 Thread Yisheng Xie 
match_string() returns the index of an array for a matching string,
which can be used instead of open coded variant.

Reviewed-by: Andy Shevchenko 
Cc: Srinivas Pandruvada 
Cc: Len Brown 
Cc: "Rafael J. Wysocki" 
Cc: Viresh Kumar 
Cc: linux...@vger.kernel.org
Signed-off-by: Yisheng Xie 
---
v2:
 - add Reviewed-by tag.

 drivers/cpufreq/intel_pstate.c | 15 ++-
 1 file changed, 6 insertions(+), 9 deletions(-)

diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
index 17e566af..d701e26 100644
--- a/drivers/cpufreq/intel_pstate.c
+++ b/drivers/cpufreq/intel_pstate.c
@@ -645,21 +645,18 @@ static ssize_t store_energy_performance_preference(
 {
struct cpudata *cpu_data = all_cpu_data[policy->cpu];
char str_preference[21];
-   int ret, i = 0;
+   int ret;
 
ret = sscanf(buf, "%20s", str_preference);
if (ret != 1)
return -EINVAL;
 
-   while (energy_perf_strings[i] != NULL) {
-   if (!strcmp(str_preference, energy_perf_strings[i])) {
-   intel_pstate_set_energy_pref_index(cpu_data, i);
-   return count;
-   }
-   ++i;
-   }
+   ret = match_string(energy_perf_strings, -1, str_preference);
+   if (ret < 0)
+   return ret;
 
-   return -EINVAL;
+   intel_pstate_set_energy_pref_index(cpu_data, ret);
+   return count;
 }
 
 static ssize_t show_energy_performance_preference(
-- 
1.7.12.4