Re: [PATCH v2 15/17] arm64: dts: imx8mp: Add audio_blk_ctrl node

[Abel Vesa]

On 20-08-18 19:32:05, Dong Aisheng wrote:
> On Fri, Aug 14, 2020 at 8:12 PM Abel Vesa  wrote:
> >
> > Some of the features of the audio_ctrl will be used by some
> > different drivers in a way those drivers will know best, so adding the
> > syscon compatible we allow those to do just that. Only the resets
> > and the clocks are registered bit the clk-blk-ctrl driver.
> >
> > Signed-off-by: Abel Vesa 
> > ---
> >  arch/arm64/boot/dts/freescale/imx8mp.dtsi | 16 
> >  1 file changed, 16 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi 
> > b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > index daa1769..dede0ae 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > @@ -736,6 +736,22 @@
> > };
> > };
> >
> > +   aips5: bus@30c0 {
> > +   compatible = "fsl,aips-bus", "simple-bus";
> > +   reg = <0x30c0 0x40>;
> > +   #address-cells = <1>;
> > +   #size-cells = <1>;
> > +   ranges;
> > +
> > +   audio_blk_ctrl: clock-controller@30e2 {
> > +   compatible = "fsl,imx8mp-audio-blk-ctrl", 
> > "syscon";
> > +   reg = <0x30e2 0x50C>;
> 
> 0x50c
> 

Will do.

> > +
> 
> remove unnecessary blank line
> 

Will do.

> Otherwise:
> Reviewed-by: Dong Aisheng 
> 
> Regards
> Aisheng
> 
> > +   #clock-cells = <1>;
> > +   #reset-cells = <1>;
> > +   };
> > +   };
> > +
> > gic: interrupt-controller@3880 {
> > compatible = "arm,gic-v3";
> > reg = <0x3880 0x1>,
> > --
> > 2.7.4
> >

Re: [PATCH v2 15/17] arm64: dts: imx8mp: Add audio_blk_ctrl node

[Dong Aisheng]

On Fri, Aug 14, 2020 at 8:12 PM Abel Vesa  wrote:
>
> Some of the features of the audio_ctrl will be used by some
> different drivers in a way those drivers will know best, so adding the
> syscon compatible we allow those to do just that. Only the resets
> and the clocks are registered bit the clk-blk-ctrl driver.
>
> Signed-off-by: Abel Vesa 
> ---
>  arch/arm64/boot/dts/freescale/imx8mp.dtsi | 16 
>  1 file changed, 16 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi 
> b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> index daa1769..dede0ae 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> @@ -736,6 +736,22 @@
> };
> };
>
> +   aips5: bus@30c0 {
> +   compatible = "fsl,aips-bus", "simple-bus";
> +   reg = <0x30c0 0x40>;
> +   #address-cells = <1>;
> +   #size-cells = <1>;
> +   ranges;
> +
> +   audio_blk_ctrl: clock-controller@30e2 {
> +   compatible = "fsl,imx8mp-audio-blk-ctrl", 
> "syscon";
> +   reg = <0x30e2 0x50C>;

0x50c

> +

remove unnecessary blank line

Otherwise:
Reviewed-by: Dong Aisheng 

Regards
Aisheng

> +   #clock-cells = <1>;
> +   #reset-cells = <1>;
> +   };
> +   };
> +
> gic: interrupt-controller@3880 {
> compatible = "arm,gic-v3";
> reg = <0x3880 0x1>,
> --
> 2.7.4
>

[PATCH v2 15/17] arm64: dts: imx8mp: Add audio_blk_ctrl node

[Abel Vesa]

Some of the features of the audio_ctrl will be used by some
different drivers in a way those drivers will know best, so adding the
syscon compatible we allow those to do just that. Only the resets
and the clocks are registered bit the clk-blk-ctrl driver.

Signed-off-by: Abel Vesa 
---
 arch/arm64/boot/dts/freescale/imx8mp.dtsi | 16 
 1 file changed, 16 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi 
b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
index daa1769..dede0ae 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
@@ -736,6 +736,22 @@
};
};
 
+   aips5: bus@30c0 {
+   compatible = "fsl,aips-bus", "simple-bus";
+   reg = <0x30c0 0x40>;
+   #address-cells = <1>;
+   #size-cells = <1>;
+   ranges;
+
+   audio_blk_ctrl: clock-controller@30e2 {
+   compatible = "fsl,imx8mp-audio-blk-ctrl", 
"syscon";
+   reg = <0x30e2 0x50C>;
+
+   #clock-cells = <1>;
+   #reset-cells = <1>;
+   };
+   };
+
gic: interrupt-controller@3880 {
compatible = "arm,gic-v3";
reg = <0x3880 0x1>,
-- 
2.7.4