RE: [PATCH v2 2/2] ALSA: set no sound proc fs for reduced memory footprint
> -Original Message- > From: Takashi Iwai [mailto:ti...@suse.de] > Sent: Wednesday, May 27, 2015 3:46 PM > To: Jie, Yang > Cc: Sudip Mukherjee; broo...@kernel.org; alsa-de...@alsa-project.org; > linux-kernel@vger.kernel.org; Girdwood, Liam R; Zhang, Vivian > Subject: Re: [PATCH v2 2/2] ALSA: set no sound proc fs for reduced memory > footprint > > At Wed, 27 May 2015 07:40:24 +, > Jie, Yang wrote: > > > > > -Original Message- > > > From: Takashi Iwai [mailto:ti...@suse.de] > > > Sent: Wednesday, May 27, 2015 3:23 PM > > > To: Jie, Yang > > > Cc: Sudip Mukherjee; broo...@kernel.org; > > > alsa-de...@alsa-project.org; linux-kernel@vger.kernel.org; Girdwood, > > > Liam R; Zhang, Vivian > > > Subject: Re: [PATCH v2 2/2] ALSA: set no sound proc fs for reduced > > > memory footprint > > > > > > At Wed, 27 May 2015 07:09:24 +, > > > Jie, Yang wrote: > > > > > > > > > -Original Message- > > > > > From: Takashi Iwai [mailto:ti...@suse.de] > > > > > Sent: Wednesday, May 27, 2015 2:19 PM > > > > > To: Jie, Yang > > > > > Cc: Sudip Mukherjee; broo...@kernel.org; > > > > > alsa-de...@alsa-project.org; linux-kernel@vger.kernel.org; > > > > > Girdwood, Liam R; Zhang, Vivian > > > > > Subject: Re: [PATCH v2 2/2] ALSA: set no sound proc fs for > > > > > reduced memory footprint > > > > > > > > > > At Wed, 27 May 2015 05:38:01 +, Jie, Yang wrote: > > > > > > > > > > > > > -Original Message- > > > > > > > From: Sudip Mukherjee [mailto:sudipm.mukher...@gmail.com] > > > > > > > Sent: Wednesday, May 27, 2015 12:50 PM > > > > > > > To: Jie, Yang > > > > > > > Cc: ti...@suse.de; broo...@kernel.org; > > > > > > > alsa-de...@alsa-project.org; > > > > > > > linux- ker...@vger.kernel.org; Girdwood, Liam R; Zhang, > > > > > > > Vivian > > > > > > > Subject: Re: [PATCH v2 2/2] ALSA: set no sound proc fs for > > > > > > > reduced memory footprint > > > > > > > > > > > > > > On Tue, May 26, 2015 at 09:13:57PM +0800, Jie Yang wrote: > > > > > > > > Disable sound proc fs, when CONFIG_SND_NO_PROC_FS is > > > selected, > > > > > > > > which can save about 9KB memory size for reducing memory > > > > > > > > footprint > > > > > purpose. > > > > > > > > --- > > > > > > > missing Signed-off-by. > > > > > > > > > > > > Thanks for pointing out. > > > > > > > > > > > > Signed-off-by: Jie Yang > > > > > > > > > > > > Takashi, do I need to resend them? > > > > > > > > > > Yes, but you seen to have missed my first comment. Here again: > > > > > > > > Sorry about the missing. :) > > > > > > > > > > > > > > > > > > == > > > > > == > > > > > > +menuconfig SND_REDUCED_MEMORY_FOOTPRINT > > > > > > + bool "Reduced Memory Footprint Support" > > > > > > + default n > > > > > > + help > > > > > > + Say 'Y' to enable Reduced Memory Footprint Support, which > may > > > > > > + reduce code size and data footprint as much as possible. > > > > > > > > > > I'd like to move this into sound/core. > > > > > Also, the kconfig name appears a bit too lengthy to me. > > > > > > > > > == > > > > > == > > > > > > > > > > And, after reading this again, I wonder whether we just take the > > > > > existing CONFIG_EXPERT for allowing the selection of more knobs > > > > > like CONFIG_SND_PROC_FS. > > > > > > > > > > SND_PROC_FS > > > > > bool "Sound proc file" if EXPERT > > > > > > > > Sounds good. Then we don't need > 'SND_REDUCED_MEMORY_FOOTPRINT' > > > > any more? Or we can keep it as root menu of the set of items, just > > > > as > > > below? > > > > (I cha
Re: [PATCH v2 2/2] ALSA: set no sound proc fs for reduced memory footprint
At Wed, 27 May 2015 07:40:24 +, Jie, Yang wrote: > > > -Original Message- > > From: Takashi Iwai [mailto:ti...@suse.de] > > Sent: Wednesday, May 27, 2015 3:23 PM > > To: Jie, Yang > > Cc: Sudip Mukherjee; broo...@kernel.org; alsa-de...@alsa-project.org; > > linux-kernel@vger.kernel.org; Girdwood, Liam R; Zhang, Vivian > > Subject: Re: [PATCH v2 2/2] ALSA: set no sound proc fs for reduced memory > > footprint > > > > At Wed, 27 May 2015 07:09:24 +, > > Jie, Yang wrote: > > > > > > > -Original Message- > > > > From: Takashi Iwai [mailto:ti...@suse.de] > > > > Sent: Wednesday, May 27, 2015 2:19 PM > > > > To: Jie, Yang > > > > Cc: Sudip Mukherjee; broo...@kernel.org; > > > > alsa-de...@alsa-project.org; linux-kernel@vger.kernel.org; Girdwood, > > > > Liam R; Zhang, Vivian > > > > Subject: Re: [PATCH v2 2/2] ALSA: set no sound proc fs for reduced > > > > memory footprint > > > > > > > > At Wed, 27 May 2015 05:38:01 +, > > > > Jie, Yang wrote: > > > > > > > > > > > -Original Message- > > > > > > From: Sudip Mukherjee [mailto:sudipm.mukher...@gmail.com] > > > > > > Sent: Wednesday, May 27, 2015 12:50 PM > > > > > > To: Jie, Yang > > > > > > Cc: ti...@suse.de; broo...@kernel.org; > > > > > > alsa-de...@alsa-project.org; > > > > > > linux- ker...@vger.kernel.org; Girdwood, Liam R; Zhang, Vivian > > > > > > Subject: Re: [PATCH v2 2/2] ALSA: set no sound proc fs for > > > > > > reduced memory footprint > > > > > > > > > > > > On Tue, May 26, 2015 at 09:13:57PM +0800, Jie Yang wrote: > > > > > > > Disable sound proc fs, when CONFIG_SND_NO_PROC_FS is > > selected, > > > > > > > which can save about 9KB memory size for reducing memory > > > > > > > footprint > > > > purpose. > > > > > > > --- > > > > > > missing Signed-off-by. > > > > > > > > > > Thanks for pointing out. > > > > > > > > > > Signed-off-by: Jie Yang > > > > > > > > > > Takashi, do I need to resend them? > > > > > > > > Yes, but you seen to have missed my first comment. Here again: > > > > > > Sorry about the missing. :) > > > > > > > > > > > > > == > > > > == > > > > > +menuconfig SND_REDUCED_MEMORY_FOOTPRINT > > > > > + bool "Reduced Memory Footprint Support" > > > > > + default n > > > > > + help > > > > > + Say 'Y' to enable Reduced Memory Footprint Support, which may > > > > > + reduce code size and data footprint as much as possible. > > > > > > > > I'd like to move this into sound/core. > > > > Also, the kconfig name appears a bit too lengthy to me. > > > > > > == > > > > == > > > > > > > > And, after reading this again, I wonder whether we just take the > > > > existing CONFIG_EXPERT for allowing the selection of more knobs like > > > > CONFIG_SND_PROC_FS. > > > > > > > > SND_PROC_FS > > > > bool "Sound proc file" if EXPERT > > > > > > Sounds good. Then we don't need 'SND_REDUCED_MEMORY_FOOTPRINT' > > > any more? Or we can keep it as root menu of the set of items, just as > > below? > > > (I changed it to SND_SMALL_FOOTPRINT, as your comment above) > > > > I originally thought to select items from SND_SMALL_FOOTPRINT, but this > > doesn't seem to work. At least, "de"selecting isn't supported by Kconfig > > (i.e. > > set SND_PROC_FS=n when SND_SMALL_FOOTPRINT=y). > > We may have SND_NO_PROC_FS and select it, but it's too bad. > > > > So, IMO, we can drop SND_SMALL_FOOTPRINT but let users choose each > > knob when EXPERT=y. > > Firstly, I used sound/Kconfig but not sound/core/Kconfig, because some > efforts for reducing footprint are based on sound/asoc/(e.g. dapm, dpcm, > ...). sound/core/Kconfig defines the core sound components and configurations, so it's more appropriate. > Secondly, if we drop SND_SMALL_FOOTPRINT, then we have to add > several(may up to ~10) knobs under the sound menu(Sound Card Support), > which looks messy and not neat. The question is whether we want more selectable knobs. If you got for simplicity, SND_PROC_FS shouldn't be selectable either, but just give SND_SMALL_FOOTPRINT selectable. Takashi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH v2 2/2] ALSA: set no sound proc fs for reduced memory footprint
> -Original Message- > From: Takashi Iwai [mailto:ti...@suse.de] > Sent: Wednesday, May 27, 2015 3:23 PM > To: Jie, Yang > Cc: Sudip Mukherjee; broo...@kernel.org; alsa-de...@alsa-project.org; > linux-kernel@vger.kernel.org; Girdwood, Liam R; Zhang, Vivian > Subject: Re: [PATCH v2 2/2] ALSA: set no sound proc fs for reduced memory > footprint > > At Wed, 27 May 2015 07:09:24 +, > Jie, Yang wrote: > > > > > -Original Message- > > > From: Takashi Iwai [mailto:ti...@suse.de] > > > Sent: Wednesday, May 27, 2015 2:19 PM > > > To: Jie, Yang > > > Cc: Sudip Mukherjee; broo...@kernel.org; > > > alsa-de...@alsa-project.org; linux-kernel@vger.kernel.org; Girdwood, > > > Liam R; Zhang, Vivian > > > Subject: Re: [PATCH v2 2/2] ALSA: set no sound proc fs for reduced > > > memory footprint > > > > > > At Wed, 27 May 2015 05:38:01 +, > > > Jie, Yang wrote: > > > > > > > > > -Original Message- > > > > > From: Sudip Mukherjee [mailto:sudipm.mukher...@gmail.com] > > > > > Sent: Wednesday, May 27, 2015 12:50 PM > > > > > To: Jie, Yang > > > > > Cc: ti...@suse.de; broo...@kernel.org; > > > > > alsa-de...@alsa-project.org; > > > > > linux- ker...@vger.kernel.org; Girdwood, Liam R; Zhang, Vivian > > > > > Subject: Re: [PATCH v2 2/2] ALSA: set no sound proc fs for > > > > > reduced memory footprint > > > > > > > > > > On Tue, May 26, 2015 at 09:13:57PM +0800, Jie Yang wrote: > > > > > > Disable sound proc fs, when CONFIG_SND_NO_PROC_FS is > selected, > > > > > > which can save about 9KB memory size for reducing memory > > > > > > footprint > > > purpose. > > > > > > --- > > > > > missing Signed-off-by. > > > > > > > > Thanks for pointing out. > > > > > > > > Signed-off-by: Jie Yang > > > > > > > > Takashi, do I need to resend them? > > > > > > Yes, but you seen to have missed my first comment. Here again: > > > > Sorry about the missing. :) > > > > > > > > > == > > > == > > > > +menuconfig SND_REDUCED_MEMORY_FOOTPRINT > > > > + bool "Reduced Memory Footprint Support" > > > > + default n > > > > + help > > > > + Say 'Y' to enable Reduced Memory Footprint Support, which may > > > > + reduce code size and data footprint as much as possible. > > > > > > I'd like to move this into sound/core. > > > Also, the kconfig name appears a bit too lengthy to me. > > > > == > > > == > > > > > > And, after reading this again, I wonder whether we just take the > > > existing CONFIG_EXPERT for allowing the selection of more knobs like > > > CONFIG_SND_PROC_FS. > > > > > > SND_PROC_FS > > > bool "Sound proc file" if EXPERT > > > > Sounds good. Then we don't need 'SND_REDUCED_MEMORY_FOOTPRINT' > > any more? Or we can keep it as root menu of the set of items, just as > below? > > (I changed it to SND_SMALL_FOOTPRINT, as your comment above) > > I originally thought to select items from SND_SMALL_FOOTPRINT, but this > doesn't seem to work. At least, "de"selecting isn't supported by Kconfig > (i.e. > set SND_PROC_FS=n when SND_SMALL_FOOTPRINT=y). > We may have SND_NO_PROC_FS and select it, but it's too bad. > > So, IMO, we can drop SND_SMALL_FOOTPRINT but let users choose each > knob when EXPERT=y. Firstly, I used sound/Kconfig but not sound/core/Kconfig, because some efforts for reducing footprint are based on sound/asoc/(e.g. dapm, dpcm, ...). Secondly, if we drop SND_SMALL_FOOTPRINT, then we have to add several(may up to ~10) knobs under the sound menu(Sound Card Support), which looks messy and not neat. ~Keyon > > > Takashi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 2/2] ALSA: set no sound proc fs for reduced memory footprint
At Wed, 27 May 2015 07:09:24 +, Jie, Yang wrote: > > > -Original Message- > > From: Takashi Iwai [mailto:ti...@suse.de] > > Sent: Wednesday, May 27, 2015 2:19 PM > > To: Jie, Yang > > Cc: Sudip Mukherjee; broo...@kernel.org; alsa-de...@alsa-project.org; > > linux-kernel@vger.kernel.org; Girdwood, Liam R; Zhang, Vivian > > Subject: Re: [PATCH v2 2/2] ALSA: set no sound proc fs for reduced memory > > footprint > > > > At Wed, 27 May 2015 05:38:01 +, > > Jie, Yang wrote: > > > > > > > -Original Message- > > > > From: Sudip Mukherjee [mailto:sudipm.mukher...@gmail.com] > > > > Sent: Wednesday, May 27, 2015 12:50 PM > > > > To: Jie, Yang > > > > Cc: ti...@suse.de; broo...@kernel.org; alsa-de...@alsa-project.org; > > > > linux- ker...@vger.kernel.org; Girdwood, Liam R; Zhang, Vivian > > > > Subject: Re: [PATCH v2 2/2] ALSA: set no sound proc fs for reduced > > > > memory footprint > > > > > > > > On Tue, May 26, 2015 at 09:13:57PM +0800, Jie Yang wrote: > > > > > Disable sound proc fs, when CONFIG_SND_NO_PROC_FS is selected, > > > > > which can save about 9KB memory size for reducing memory footprint > > purpose. > > > > > --- > > > > missing Signed-off-by. > > > > > > Thanks for pointing out. > > > > > > Signed-off-by: Jie Yang > > > > > > Takashi, do I need to resend them? > > > > Yes, but you seen to have missed my first comment. Here again: > > Sorry about the missing. :) > > > > > == > > == > > > +menuconfig SND_REDUCED_MEMORY_FOOTPRINT > > > + bool "Reduced Memory Footprint Support" > > > + default n > > > + help > > > + Say 'Y' to enable Reduced Memory Footprint Support, which may > > > + reduce code size and data footprint as much as possible. > > > > I'd like to move this into sound/core. > > Also, the kconfig name appears a bit too lengthy to me. > > == > > == > > > > And, after reading this again, I wonder whether we just take the existing > > CONFIG_EXPERT for allowing the selection of more knobs like > > CONFIG_SND_PROC_FS. > > > > SND_PROC_FS > > bool "Sound proc file" if EXPERT > > Sounds good. Then we don't need 'SND_REDUCED_MEMORY_FOOTPRINT' > any more? Or we can keep it as root menu of the set of items, just as below? > (I changed it to SND_SMALL_FOOTPRINT, as your comment above) I originally thought to select items from SND_SMALL_FOOTPRINT, but this doesn't seem to work. At least, "de"selecting isn't supported by Kconfig (i.e. set SND_PROC_FS=n when SND_SMALL_FOOTPRINT=y). We may have SND_NO_PROC_FS and select it, but it's too bad. So, IMO, we can drop SND_SMALL_FOOTPRINT but let users choose each knob when EXPERT=y. Takashi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH v2 2/2] ALSA: set no sound proc fs for reduced memory footprint
> -Original Message- > From: Takashi Iwai [mailto:ti...@suse.de] > Sent: Wednesday, May 27, 2015 2:19 PM > To: Jie, Yang > Cc: Sudip Mukherjee; broo...@kernel.org; alsa-de...@alsa-project.org; > linux-kernel@vger.kernel.org; Girdwood, Liam R; Zhang, Vivian > Subject: Re: [PATCH v2 2/2] ALSA: set no sound proc fs for reduced memory > footprint > > At Wed, 27 May 2015 05:38:01 +, > Jie, Yang wrote: > > > > > -Original Message- > > > From: Sudip Mukherjee [mailto:sudipm.mukher...@gmail.com] > > > Sent: Wednesday, May 27, 2015 12:50 PM > > > To: Jie, Yang > > > Cc: ti...@suse.de; broo...@kernel.org; alsa-de...@alsa-project.org; > > > linux- ker...@vger.kernel.org; Girdwood, Liam R; Zhang, Vivian > > > Subject: Re: [PATCH v2 2/2] ALSA: set no sound proc fs for reduced > > > memory footprint > > > > > > On Tue, May 26, 2015 at 09:13:57PM +0800, Jie Yang wrote: > > > > Disable sound proc fs, when CONFIG_SND_NO_PROC_FS is selected, > > > > which can save about 9KB memory size for reducing memory footprint > purpose. > > > > --- > > > missing Signed-off-by. > > > > Thanks for pointing out. > > > > Signed-off-by: Jie Yang > > > > Takashi, do I need to resend them? > > Yes, but you seen to have missed my first comment. Here again: Sorry about the missing. :) > > == > == > > +menuconfig SND_REDUCED_MEMORY_FOOTPRINT > > + bool "Reduced Memory Footprint Support" > > + default n > > + help > > + Say 'Y' to enable Reduced Memory Footprint Support, which may > > + reduce code size and data footprint as much as possible. > > I'd like to move this into sound/core. > Also, the kconfig name appears a bit too lengthy to me. > == > == > > And, after reading this again, I wonder whether we just take the existing > CONFIG_EXPERT for allowing the selection of more knobs like > CONFIG_SND_PROC_FS. > > SND_PROC_FS > bool "Sound proc file" if EXPERT Sounds good. Then we don't need 'SND_REDUCED_MEMORY_FOOTPRINT' any more? Or we can keep it as root menu of the set of items, just as below? (I changed it to SND_SMALL_FOOTPRINT, as your comment above) menuconfig SND_SMALL_FOOTPRINT bool "Reduced Memory Footprint Support" if EXPERT default n help Say 'Y' to enable Reduced Memory Footprint Support, which may reduce code size and data footprint as much as possible. config SND_PROC_FS bool "Sound Proc FS Support" if SND_SMALL_FOOTPRINT depends on PROC_FS default y help Say 'N' to disable Sound proc FS, which may reduce code size about 9KB on x86_64 platform. If unsure say Y. ~Keyon > depends on PROC_FS > > > > Takashi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 2/2] ALSA: set no sound proc fs for reduced memory footprint
At Wed, 27 May 2015 05:38:01 +, Jie, Yang wrote: > > > -Original Message- > > From: Sudip Mukherjee [mailto:sudipm.mukher...@gmail.com] > > Sent: Wednesday, May 27, 2015 12:50 PM > > To: Jie, Yang > > Cc: ti...@suse.de; broo...@kernel.org; alsa-de...@alsa-project.org; linux- > > ker...@vger.kernel.org; Girdwood, Liam R; Zhang, Vivian > > Subject: Re: [PATCH v2 2/2] ALSA: set no sound proc fs for reduced memory > > footprint > > > > On Tue, May 26, 2015 at 09:13:57PM +0800, Jie Yang wrote: > > > Disable sound proc fs, when CONFIG_SND_NO_PROC_FS is selected, which > > > can save about 9KB memory size for reducing memory footprint purpose. > > > --- > > missing Signed-off-by. > > Thanks for pointing out. > > Signed-off-by: Jie Yang > > Takashi, do I need to resend them? Yes, but you seen to have missed my first comment. Here again: > +menuconfig SND_REDUCED_MEMORY_FOOTPRINT > + bool "Reduced Memory Footprint Support" > + default n > + help > + Say 'Y' to enable Reduced Memory Footprint Support, which may > + reduce code size and data footprint as much as possible. I'd like to move this into sound/core. Also, the kconfig name appears a bit too lengthy to me. And, after reading this again, I wonder whether we just take the existing CONFIG_EXPERT for allowing the selection of more knobs like CONFIG_SND_PROC_FS. SND_PROC_FS bool "Sound proc file" if EXPERT depends on PROC_FS Takashi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH v2 2/2] ALSA: set no sound proc fs for reduced memory footprint
-Original Message- From: Takashi Iwai [mailto:ti...@suse.de] Sent: Wednesday, May 27, 2015 3:46 PM To: Jie, Yang Cc: Sudip Mukherjee; broo...@kernel.org; alsa-de...@alsa-project.org; linux-kernel@vger.kernel.org; Girdwood, Liam R; Zhang, Vivian Subject: Re: [PATCH v2 2/2] ALSA: set no sound proc fs for reduced memory footprint At Wed, 27 May 2015 07:40:24 +, Jie, Yang wrote: -Original Message- From: Takashi Iwai [mailto:ti...@suse.de] Sent: Wednesday, May 27, 2015 3:23 PM To: Jie, Yang Cc: Sudip Mukherjee; broo...@kernel.org; alsa-de...@alsa-project.org; linux-kernel@vger.kernel.org; Girdwood, Liam R; Zhang, Vivian Subject: Re: [PATCH v2 2/2] ALSA: set no sound proc fs for reduced memory footprint At Wed, 27 May 2015 07:09:24 +, Jie, Yang wrote: -Original Message- From: Takashi Iwai [mailto:ti...@suse.de] Sent: Wednesday, May 27, 2015 2:19 PM To: Jie, Yang Cc: Sudip Mukherjee; broo...@kernel.org; alsa-de...@alsa-project.org; linux-kernel@vger.kernel.org; Girdwood, Liam R; Zhang, Vivian Subject: Re: [PATCH v2 2/2] ALSA: set no sound proc fs for reduced memory footprint At Wed, 27 May 2015 05:38:01 +, Jie, Yang wrote: -Original Message- From: Sudip Mukherjee [mailto:sudipm.mukher...@gmail.com] Sent: Wednesday, May 27, 2015 12:50 PM To: Jie, Yang Cc: ti...@suse.de; broo...@kernel.org; alsa-de...@alsa-project.org; linux- ker...@vger.kernel.org; Girdwood, Liam R; Zhang, Vivian Subject: Re: [PATCH v2 2/2] ALSA: set no sound proc fs for reduced memory footprint On Tue, May 26, 2015 at 09:13:57PM +0800, Jie Yang wrote: Disable sound proc fs, when CONFIG_SND_NO_PROC_FS is selected, which can save about 9KB memory size for reducing memory footprint purpose. --- missing Signed-off-by. Thanks for pointing out. Signed-off-by: Jie Yang yang@intel.com Takashi, do I need to resend them? Yes, but you seen to have missed my first comment. Here again: Sorry about the missing. :) == == +menuconfig SND_REDUCED_MEMORY_FOOTPRINT + bool Reduced Memory Footprint Support + default n + help + Say 'Y' to enable Reduced Memory Footprint Support, which may + reduce code size and data footprint as much as possible. I'd like to move this into sound/core. Also, the kconfig name appears a bit too lengthy to me. == == And, after reading this again, I wonder whether we just take the existing CONFIG_EXPERT for allowing the selection of more knobs like CONFIG_SND_PROC_FS. SND_PROC_FS bool Sound proc file if EXPERT Sounds good. Then we don't need 'SND_REDUCED_MEMORY_FOOTPRINT' any more? Or we can keep it as root menu of the set of items, just as below? (I changed it to SND_SMALL_FOOTPRINT, as your comment above) I originally thought to select items from SND_SMALL_FOOTPRINT, but this doesn't seem to work. At least, deselecting isn't supported by Kconfig (i.e. set SND_PROC_FS=n when SND_SMALL_FOOTPRINT=y). We may have SND_NO_PROC_FS and select it, but it's too bad. So, IMO, we can drop SND_SMALL_FOOTPRINT but let users choose each knob when EXPERT=y. Firstly, I used sound/Kconfig but not sound/core/Kconfig, because some efforts for reducing footprint are based on sound/asoc/(e.g. dapm, dpcm, ...). sound/core/Kconfig defines the core sound components and configurations, so it's more appropriate. OK. Secondly, if we drop SND_SMALL_FOOTPRINT, then we have to add several(may up to ~10) knobs under the sound menu(Sound Card Support), which looks messy and not neat. The question is whether we want more selectable knobs. If you got for simplicity, SND_PROC_FS shouldn't be selectable either, but just give SND_SMALL_FOOTPRINT selectable. OK, then I will drop this SND_SMALL_FOOTPRINT and keep SND_PROC_FS, and resend soon. ~Keyon Takashi -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 2/2] ALSA: set no sound proc fs for reduced memory footprint
At Wed, 27 May 2015 05:38:01 +, Jie, Yang wrote: -Original Message- From: Sudip Mukherjee [mailto:sudipm.mukher...@gmail.com] Sent: Wednesday, May 27, 2015 12:50 PM To: Jie, Yang Cc: ti...@suse.de; broo...@kernel.org; alsa-de...@alsa-project.org; linux- ker...@vger.kernel.org; Girdwood, Liam R; Zhang, Vivian Subject: Re: [PATCH v2 2/2] ALSA: set no sound proc fs for reduced memory footprint On Tue, May 26, 2015 at 09:13:57PM +0800, Jie Yang wrote: Disable sound proc fs, when CONFIG_SND_NO_PROC_FS is selected, which can save about 9KB memory size for reducing memory footprint purpose. --- missing Signed-off-by. Thanks for pointing out. Signed-off-by: Jie Yang yang@intel.com Takashi, do I need to resend them? Yes, but you seen to have missed my first comment. Here again: +menuconfig SND_REDUCED_MEMORY_FOOTPRINT + bool Reduced Memory Footprint Support + default n + help + Say 'Y' to enable Reduced Memory Footprint Support, which may + reduce code size and data footprint as much as possible. I'd like to move this into sound/core. Also, the kconfig name appears a bit too lengthy to me. And, after reading this again, I wonder whether we just take the existing CONFIG_EXPERT for allowing the selection of more knobs like CONFIG_SND_PROC_FS. SND_PROC_FS bool Sound proc file if EXPERT depends on PROC_FS Takashi -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH v2 2/2] ALSA: set no sound proc fs for reduced memory footprint
-Original Message- From: Takashi Iwai [mailto:ti...@suse.de] Sent: Wednesday, May 27, 2015 2:19 PM To: Jie, Yang Cc: Sudip Mukherjee; broo...@kernel.org; alsa-de...@alsa-project.org; linux-kernel@vger.kernel.org; Girdwood, Liam R; Zhang, Vivian Subject: Re: [PATCH v2 2/2] ALSA: set no sound proc fs for reduced memory footprint At Wed, 27 May 2015 05:38:01 +, Jie, Yang wrote: -Original Message- From: Sudip Mukherjee [mailto:sudipm.mukher...@gmail.com] Sent: Wednesday, May 27, 2015 12:50 PM To: Jie, Yang Cc: ti...@suse.de; broo...@kernel.org; alsa-de...@alsa-project.org; linux- ker...@vger.kernel.org; Girdwood, Liam R; Zhang, Vivian Subject: Re: [PATCH v2 2/2] ALSA: set no sound proc fs for reduced memory footprint On Tue, May 26, 2015 at 09:13:57PM +0800, Jie Yang wrote: Disable sound proc fs, when CONFIG_SND_NO_PROC_FS is selected, which can save about 9KB memory size for reducing memory footprint purpose. --- missing Signed-off-by. Thanks for pointing out. Signed-off-by: Jie Yang yang@intel.com Takashi, do I need to resend them? Yes, but you seen to have missed my first comment. Here again: Sorry about the missing. :) == == +menuconfig SND_REDUCED_MEMORY_FOOTPRINT + bool Reduced Memory Footprint Support + default n + help + Say 'Y' to enable Reduced Memory Footprint Support, which may + reduce code size and data footprint as much as possible. I'd like to move this into sound/core. Also, the kconfig name appears a bit too lengthy to me. == == And, after reading this again, I wonder whether we just take the existing CONFIG_EXPERT for allowing the selection of more knobs like CONFIG_SND_PROC_FS. SND_PROC_FS bool Sound proc file if EXPERT Sounds good. Then we don't need 'SND_REDUCED_MEMORY_FOOTPRINT' any more? Or we can keep it as root menu of the set of items, just as below? (I changed it to SND_SMALL_FOOTPRINT, as your comment above) menuconfig SND_SMALL_FOOTPRINT bool Reduced Memory Footprint Support if EXPERT default n help Say 'Y' to enable Reduced Memory Footprint Support, which may reduce code size and data footprint as much as possible. config SND_PROC_FS bool Sound Proc FS Support if SND_SMALL_FOOTPRINT depends on PROC_FS default y help Say 'N' to disable Sound proc FS, which may reduce code size about 9KB on x86_64 platform. If unsure say Y. ~Keyon depends on PROC_FS Takashi -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 2/2] ALSA: set no sound proc fs for reduced memory footprint
At Wed, 27 May 2015 07:09:24 +, Jie, Yang wrote: -Original Message- From: Takashi Iwai [mailto:ti...@suse.de] Sent: Wednesday, May 27, 2015 2:19 PM To: Jie, Yang Cc: Sudip Mukherjee; broo...@kernel.org; alsa-de...@alsa-project.org; linux-kernel@vger.kernel.org; Girdwood, Liam R; Zhang, Vivian Subject: Re: [PATCH v2 2/2] ALSA: set no sound proc fs for reduced memory footprint At Wed, 27 May 2015 05:38:01 +, Jie, Yang wrote: -Original Message- From: Sudip Mukherjee [mailto:sudipm.mukher...@gmail.com] Sent: Wednesday, May 27, 2015 12:50 PM To: Jie, Yang Cc: ti...@suse.de; broo...@kernel.org; alsa-de...@alsa-project.org; linux- ker...@vger.kernel.org; Girdwood, Liam R; Zhang, Vivian Subject: Re: [PATCH v2 2/2] ALSA: set no sound proc fs for reduced memory footprint On Tue, May 26, 2015 at 09:13:57PM +0800, Jie Yang wrote: Disable sound proc fs, when CONFIG_SND_NO_PROC_FS is selected, which can save about 9KB memory size for reducing memory footprint purpose. --- missing Signed-off-by. Thanks for pointing out. Signed-off-by: Jie Yang yang@intel.com Takashi, do I need to resend them? Yes, but you seen to have missed my first comment. Here again: Sorry about the missing. :) == == +menuconfig SND_REDUCED_MEMORY_FOOTPRINT + bool Reduced Memory Footprint Support + default n + help + Say 'Y' to enable Reduced Memory Footprint Support, which may + reduce code size and data footprint as much as possible. I'd like to move this into sound/core. Also, the kconfig name appears a bit too lengthy to me. == == And, after reading this again, I wonder whether we just take the existing CONFIG_EXPERT for allowing the selection of more knobs like CONFIG_SND_PROC_FS. SND_PROC_FS bool Sound proc file if EXPERT Sounds good. Then we don't need 'SND_REDUCED_MEMORY_FOOTPRINT' any more? Or we can keep it as root menu of the set of items, just as below? (I changed it to SND_SMALL_FOOTPRINT, as your comment above) I originally thought to select items from SND_SMALL_FOOTPRINT, but this doesn't seem to work. At least, deselecting isn't supported by Kconfig (i.e. set SND_PROC_FS=n when SND_SMALL_FOOTPRINT=y). We may have SND_NO_PROC_FS and select it, but it's too bad. So, IMO, we can drop SND_SMALL_FOOTPRINT but let users choose each knob when EXPERT=y. Takashi -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH v2 2/2] ALSA: set no sound proc fs for reduced memory footprint
-Original Message- From: Takashi Iwai [mailto:ti...@suse.de] Sent: Wednesday, May 27, 2015 3:23 PM To: Jie, Yang Cc: Sudip Mukherjee; broo...@kernel.org; alsa-de...@alsa-project.org; linux-kernel@vger.kernel.org; Girdwood, Liam R; Zhang, Vivian Subject: Re: [PATCH v2 2/2] ALSA: set no sound proc fs for reduced memory footprint At Wed, 27 May 2015 07:09:24 +, Jie, Yang wrote: -Original Message- From: Takashi Iwai [mailto:ti...@suse.de] Sent: Wednesday, May 27, 2015 2:19 PM To: Jie, Yang Cc: Sudip Mukherjee; broo...@kernel.org; alsa-de...@alsa-project.org; linux-kernel@vger.kernel.org; Girdwood, Liam R; Zhang, Vivian Subject: Re: [PATCH v2 2/2] ALSA: set no sound proc fs for reduced memory footprint At Wed, 27 May 2015 05:38:01 +, Jie, Yang wrote: -Original Message- From: Sudip Mukherjee [mailto:sudipm.mukher...@gmail.com] Sent: Wednesday, May 27, 2015 12:50 PM To: Jie, Yang Cc: ti...@suse.de; broo...@kernel.org; alsa-de...@alsa-project.org; linux- ker...@vger.kernel.org; Girdwood, Liam R; Zhang, Vivian Subject: Re: [PATCH v2 2/2] ALSA: set no sound proc fs for reduced memory footprint On Tue, May 26, 2015 at 09:13:57PM +0800, Jie Yang wrote: Disable sound proc fs, when CONFIG_SND_NO_PROC_FS is selected, which can save about 9KB memory size for reducing memory footprint purpose. --- missing Signed-off-by. Thanks for pointing out. Signed-off-by: Jie Yang yang@intel.com Takashi, do I need to resend them? Yes, but you seen to have missed my first comment. Here again: Sorry about the missing. :) == == +menuconfig SND_REDUCED_MEMORY_FOOTPRINT + bool Reduced Memory Footprint Support + default n + help + Say 'Y' to enable Reduced Memory Footprint Support, which may + reduce code size and data footprint as much as possible. I'd like to move this into sound/core. Also, the kconfig name appears a bit too lengthy to me. == == And, after reading this again, I wonder whether we just take the existing CONFIG_EXPERT for allowing the selection of more knobs like CONFIG_SND_PROC_FS. SND_PROC_FS bool Sound proc file if EXPERT Sounds good. Then we don't need 'SND_REDUCED_MEMORY_FOOTPRINT' any more? Or we can keep it as root menu of the set of items, just as below? (I changed it to SND_SMALL_FOOTPRINT, as your comment above) I originally thought to select items from SND_SMALL_FOOTPRINT, but this doesn't seem to work. At least, deselecting isn't supported by Kconfig (i.e. set SND_PROC_FS=n when SND_SMALL_FOOTPRINT=y). We may have SND_NO_PROC_FS and select it, but it's too bad. So, IMO, we can drop SND_SMALL_FOOTPRINT but let users choose each knob when EXPERT=y. Firstly, I used sound/Kconfig but not sound/core/Kconfig, because some efforts for reducing footprint are based on sound/asoc/(e.g. dapm, dpcm, ...). Secondly, if we drop SND_SMALL_FOOTPRINT, then we have to add several(may up to ~10) knobs under the sound menu(Sound Card Support), which looks messy and not neat. ~Keyon Takashi -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 2/2] ALSA: set no sound proc fs for reduced memory footprint
At Wed, 27 May 2015 07:40:24 +, Jie, Yang wrote: -Original Message- From: Takashi Iwai [mailto:ti...@suse.de] Sent: Wednesday, May 27, 2015 3:23 PM To: Jie, Yang Cc: Sudip Mukherjee; broo...@kernel.org; alsa-de...@alsa-project.org; linux-kernel@vger.kernel.org; Girdwood, Liam R; Zhang, Vivian Subject: Re: [PATCH v2 2/2] ALSA: set no sound proc fs for reduced memory footprint At Wed, 27 May 2015 07:09:24 +, Jie, Yang wrote: -Original Message- From: Takashi Iwai [mailto:ti...@suse.de] Sent: Wednesday, May 27, 2015 2:19 PM To: Jie, Yang Cc: Sudip Mukherjee; broo...@kernel.org; alsa-de...@alsa-project.org; linux-kernel@vger.kernel.org; Girdwood, Liam R; Zhang, Vivian Subject: Re: [PATCH v2 2/2] ALSA: set no sound proc fs for reduced memory footprint At Wed, 27 May 2015 05:38:01 +, Jie, Yang wrote: -Original Message- From: Sudip Mukherjee [mailto:sudipm.mukher...@gmail.com] Sent: Wednesday, May 27, 2015 12:50 PM To: Jie, Yang Cc: ti...@suse.de; broo...@kernel.org; alsa-de...@alsa-project.org; linux- ker...@vger.kernel.org; Girdwood, Liam R; Zhang, Vivian Subject: Re: [PATCH v2 2/2] ALSA: set no sound proc fs for reduced memory footprint On Tue, May 26, 2015 at 09:13:57PM +0800, Jie Yang wrote: Disable sound proc fs, when CONFIG_SND_NO_PROC_FS is selected, which can save about 9KB memory size for reducing memory footprint purpose. --- missing Signed-off-by. Thanks for pointing out. Signed-off-by: Jie Yang yang@intel.com Takashi, do I need to resend them? Yes, but you seen to have missed my first comment. Here again: Sorry about the missing. :) == == +menuconfig SND_REDUCED_MEMORY_FOOTPRINT + bool Reduced Memory Footprint Support + default n + help + Say 'Y' to enable Reduced Memory Footprint Support, which may + reduce code size and data footprint as much as possible. I'd like to move this into sound/core. Also, the kconfig name appears a bit too lengthy to me. == == And, after reading this again, I wonder whether we just take the existing CONFIG_EXPERT for allowing the selection of more knobs like CONFIG_SND_PROC_FS. SND_PROC_FS bool Sound proc file if EXPERT Sounds good. Then we don't need 'SND_REDUCED_MEMORY_FOOTPRINT' any more? Or we can keep it as root menu of the set of items, just as below? (I changed it to SND_SMALL_FOOTPRINT, as your comment above) I originally thought to select items from SND_SMALL_FOOTPRINT, but this doesn't seem to work. At least, deselecting isn't supported by Kconfig (i.e. set SND_PROC_FS=n when SND_SMALL_FOOTPRINT=y). We may have SND_NO_PROC_FS and select it, but it's too bad. So, IMO, we can drop SND_SMALL_FOOTPRINT but let users choose each knob when EXPERT=y. Firstly, I used sound/Kconfig but not sound/core/Kconfig, because some efforts for reducing footprint are based on sound/asoc/(e.g. dapm, dpcm, ...). sound/core/Kconfig defines the core sound components and configurations, so it's more appropriate. Secondly, if we drop SND_SMALL_FOOTPRINT, then we have to add several(may up to ~10) knobs under the sound menu(Sound Card Support), which looks messy and not neat. The question is whether we want more selectable knobs. If you got for simplicity, SND_PROC_FS shouldn't be selectable either, but just give SND_SMALL_FOOTPRINT selectable. Takashi -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH v2 2/2] ALSA: set no sound proc fs for reduced memory footprint
> -Original Message- > From: Sudip Mukherjee [mailto:sudipm.mukher...@gmail.com] > Sent: Wednesday, May 27, 2015 12:50 PM > To: Jie, Yang > Cc: ti...@suse.de; broo...@kernel.org; alsa-de...@alsa-project.org; linux- > ker...@vger.kernel.org; Girdwood, Liam R; Zhang, Vivian > Subject: Re: [PATCH v2 2/2] ALSA: set no sound proc fs for reduced memory > footprint > > On Tue, May 26, 2015 at 09:13:57PM +0800, Jie Yang wrote: > > Disable sound proc fs, when CONFIG_SND_NO_PROC_FS is selected, which > > can save about 9KB memory size for reducing memory footprint purpose. > > --- > missing Signed-off-by. Thanks for pointing out. Signed-off-by: Jie Yang Takashi, do I need to resend them? Thanks, ~Keyon > > regards > sudip -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 2/2] ALSA: set no sound proc fs for reduced memory footprint
On Tue, May 26, 2015 at 09:13:57PM +0800, Jie Yang wrote: > Disable sound proc fs, when CONFIG_SND_NO_PROC_FS is selected, > which can save about 9KB memory size for reducing memory > footprint purpose. > --- missing Signed-off-by. regards sudip -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH v2 2/2] ALSA: set no sound proc fs for reduced memory footprint
Disable sound proc fs, when CONFIG_SND_NO_PROC_FS is selected,
which can save about 9KB memory size for reducing memory
footprint purpose.
---
include/sound/info.h | 8
sound/core/Makefile| 2 +-
sound/core/hwdep.c | 6 +++---
sound/core/init.c | 8
sound/core/oss/mixer_oss.c | 6 +++---
sound/core/pcm.c | 6 +++---
sound/core/seq/oss/seq_oss.c | 6 +++---
sound/core/seq/oss/seq_oss_init.c | 5 ++---
sound/core/seq/oss/seq_oss_midi.c | 4 ++--
sound/core/seq/oss/seq_oss_readq.c | 4 ++--
sound/core/seq/oss/seq_oss_synth.c | 4 ++--
sound/core/seq/seq_clientmgr.c | 4 ++--
sound/core/seq/seq_device.c| 2 +-
sound/core/seq/seq_info.h | 2 +-
sound/core/seq/seq_queue.c | 4 ++--
sound/core/seq/seq_timer.c | 4 ++--
sound/core/sound.c | 4 ++--
sound/core/sound_oss.c | 4 ++--
sound/core/timer.c | 4 ++--
sound/pci/hda/Makefile | 3 ++-
sound/pci/hda/hda_eld.c| 4 ++--
sound/pci/hda/hda_local.h | 4 ++--
sound/pci/hda/patch_hdmi.c | 4 ++--
sound/pci/hda/patch_sigmatel.c | 2 +-
24 files changed, 52 insertions(+), 52 deletions(-)
diff --git a/include/sound/info.h b/include/sound/info.h
index 1626995..67390ee 100644
--- a/include/sound/info.h
+++ b/include/sound/info.h
@@ -92,14 +92,14 @@ struct snd_info_entry {
struct list_head list;
};
-#if defined(CONFIG_SND_OSSEMUL) && defined(CONFIG_PROC_FS)
+#if defined(CONFIG_SND_OSSEMUL) && defined(CONFIG_SND_PROC_FS)
int snd_info_minor_register(void);
#else
#define snd_info_minor_register() 0
#endif
-#ifdef CONFIG_PROC_FS
+#ifdef CONFIG_SND_PROC_FS
extern struct snd_info_entry *snd_seq_root;
#ifdef CONFIG_SND_OSSEMUL
@@ -197,7 +197,7 @@ static inline int snd_info_check_reserved_words(const char
*str) { return 1; }
* OSS info part
*/
-#if defined(CONFIG_SND_OSSEMUL) && defined(CONFIG_PROC_FS)
+#if defined(CONFIG_SND_OSSEMUL) && defined(CONFIG_SND_PROC_FS)
#define SNDRV_OSS_INFO_DEV_AUDIO 0
#define SNDRV_OSS_INFO_DEV_SYNTH 1
@@ -210,6 +210,6 @@ static inline int snd_info_check_reserved_words(const char
*str) { return 1; }
int snd_oss_info_register(int dev, int num, char *string);
#define snd_oss_info_unregister(dev, num) snd_oss_info_register(dev, num, NULL)
-#endif /* CONFIG_SND_OSSEMUL && CONFIG_PROC_FS */
+#endif /* CONFIG_SND_OSSEMUL && CONFIG_SND_PROC_FS */
#endif /* __SOUND_INFO_H */
diff --git a/sound/core/Makefile b/sound/core/Makefile
index 7dd17a3..9e5bb10 100644
--- a/sound/core/Makefile
+++ b/sound/core/Makefile
@@ -4,7 +4,7 @@
#
snd-y := sound.o init.o memory.o control.o misc.o device.o
-ifneq ($(CONFIG_PROC_FS),)
+ifneq ($(CONFIG_SND_PROC_FS),)
snd-y += info.o
snd-$(CONFIG_SND_OSSEMUL) += info_oss.o
endif
diff --git a/sound/core/hwdep.c b/sound/core/hwdep.c
index 51692c8..36d2416 100644
--- a/sound/core/hwdep.c
+++ b/sound/core/hwdep.c
@@ -484,7 +484,7 @@ static int snd_hwdep_dev_disconnect(struct snd_device
*device)
return 0;
}
-#ifdef CONFIG_PROC_FS
+#ifdef CONFIG_SND_PROC_FS
/*
* Info interface
*/
@@ -521,10 +521,10 @@ static void __exit snd_hwdep_proc_done(void)
{
snd_info_free_entry(snd_hwdep_proc_entry);
}
-#else /* !CONFIG_PROC_FS */
+#else /* !CONFIG_SND_PROC_FS */
#define snd_hwdep_proc_init()
#define snd_hwdep_proc_done()
-#endif /* CONFIG_PROC_FS */
+#endif /* CONFIG_SND_PROC_FS */
/*
diff --git a/sound/core/init.c b/sound/core/init.c
index f8abd2d..3e0ceba 100644
--- a/sound/core/init.c
+++ b/sound/core/init.c
@@ -100,7 +100,7 @@ int (*snd_mixer_oss_notify_callback)(struct snd_card *card,
int free_flag);
EXPORT_SYMBOL(snd_mixer_oss_notify_callback);
#endif
-#ifdef CONFIG_PROC_FS
+#ifdef CONFIG_SND_PROC_FS
static void snd_card_id_read(struct snd_info_entry *entry,
struct snd_info_buffer *buffer)
{
@@ -122,7 +122,7 @@ static int init_info_for_card(struct snd_card *card)
return snd_info_card_register(card);
}
-#else /* !CONFIG_PROC_FS */
+#else /* !CONFIG_SND_PROC_FS */
#define init_info_for_card(card)
#endif
@@ -776,7 +776,7 @@ int snd_card_register(struct snd_card *card)
EXPORT_SYMBOL(snd_card_register);
-#ifdef CONFIG_PROC_FS
+#ifdef CONFIG_SND_PROC_FS
static void snd_card_info_read(struct snd_info_entry *entry,
struct snd_info_buffer *buffer)
{
@@ -861,7 +861,7 @@ int __init snd_card_info_init(void)
return 0;
}
-#endif /* CONFIG_PROC_FS */
+#endif /* CONFIG_SND_PROC_FS */
/**
* snd_component_add - add a component string
diff --git a/sound/core/oss/mixer_oss.c b/sound/core/oss/mixer_oss.c
index 056f8e2..a99f720 100644
--- a/sound/core/oss/mixer_oss.c
+++ b/sound/core/oss/mixer_oss.c
@@ -,7 +,7 @@ static int snd_mixer_oss_build_input(struct snd_mixer_oss
*mixer, struct snd_mix
return
RE: [PATCH v2 2/2] ALSA: set no sound proc fs for reduced memory footprint
-Original Message- From: Sudip Mukherjee [mailto:sudipm.mukher...@gmail.com] Sent: Wednesday, May 27, 2015 12:50 PM To: Jie, Yang Cc: ti...@suse.de; broo...@kernel.org; alsa-de...@alsa-project.org; linux- ker...@vger.kernel.org; Girdwood, Liam R; Zhang, Vivian Subject: Re: [PATCH v2 2/2] ALSA: set no sound proc fs for reduced memory footprint On Tue, May 26, 2015 at 09:13:57PM +0800, Jie Yang wrote: Disable sound proc fs, when CONFIG_SND_NO_PROC_FS is selected, which can save about 9KB memory size for reducing memory footprint purpose. --- missing Signed-off-by. Thanks for pointing out. Signed-off-by: Jie Yang yang@intel.com Takashi, do I need to resend them? Thanks, ~Keyon regards sudip -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 2/2] ALSA: set no sound proc fs for reduced memory footprint
On Tue, May 26, 2015 at 09:13:57PM +0800, Jie Yang wrote: Disable sound proc fs, when CONFIG_SND_NO_PROC_FS is selected, which can save about 9KB memory size for reducing memory footprint purpose. --- missing Signed-off-by. regards sudip -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH v2 2/2] ALSA: set no sound proc fs for reduced memory footprint
Disable sound proc fs, when CONFIG_SND_NO_PROC_FS is selected,
which can save about 9KB memory size for reducing memory
footprint purpose.
---
include/sound/info.h | 8
sound/core/Makefile| 2 +-
sound/core/hwdep.c | 6 +++---
sound/core/init.c | 8
sound/core/oss/mixer_oss.c | 6 +++---
sound/core/pcm.c | 6 +++---
sound/core/seq/oss/seq_oss.c | 6 +++---
sound/core/seq/oss/seq_oss_init.c | 5 ++---
sound/core/seq/oss/seq_oss_midi.c | 4 ++--
sound/core/seq/oss/seq_oss_readq.c | 4 ++--
sound/core/seq/oss/seq_oss_synth.c | 4 ++--
sound/core/seq/seq_clientmgr.c | 4 ++--
sound/core/seq/seq_device.c| 2 +-
sound/core/seq/seq_info.h | 2 +-
sound/core/seq/seq_queue.c | 4 ++--
sound/core/seq/seq_timer.c | 4 ++--
sound/core/sound.c | 4 ++--
sound/core/sound_oss.c | 4 ++--
sound/core/timer.c | 4 ++--
sound/pci/hda/Makefile | 3 ++-
sound/pci/hda/hda_eld.c| 4 ++--
sound/pci/hda/hda_local.h | 4 ++--
sound/pci/hda/patch_hdmi.c | 4 ++--
sound/pci/hda/patch_sigmatel.c | 2 +-
24 files changed, 52 insertions(+), 52 deletions(-)
diff --git a/include/sound/info.h b/include/sound/info.h
index 1626995..67390ee 100644
--- a/include/sound/info.h
+++ b/include/sound/info.h
@@ -92,14 +92,14 @@ struct snd_info_entry {
struct list_head list;
};
-#if defined(CONFIG_SND_OSSEMUL) defined(CONFIG_PROC_FS)
+#if defined(CONFIG_SND_OSSEMUL) defined(CONFIG_SND_PROC_FS)
int snd_info_minor_register(void);
#else
#define snd_info_minor_register() 0
#endif
-#ifdef CONFIG_PROC_FS
+#ifdef CONFIG_SND_PROC_FS
extern struct snd_info_entry *snd_seq_root;
#ifdef CONFIG_SND_OSSEMUL
@@ -197,7 +197,7 @@ static inline int snd_info_check_reserved_words(const char
*str) { return 1; }
* OSS info part
*/
-#if defined(CONFIG_SND_OSSEMUL) defined(CONFIG_PROC_FS)
+#if defined(CONFIG_SND_OSSEMUL) defined(CONFIG_SND_PROC_FS)
#define SNDRV_OSS_INFO_DEV_AUDIO 0
#define SNDRV_OSS_INFO_DEV_SYNTH 1
@@ -210,6 +210,6 @@ static inline int snd_info_check_reserved_words(const char
*str) { return 1; }
int snd_oss_info_register(int dev, int num, char *string);
#define snd_oss_info_unregister(dev, num) snd_oss_info_register(dev, num, NULL)
-#endif /* CONFIG_SND_OSSEMUL CONFIG_PROC_FS */
+#endif /* CONFIG_SND_OSSEMUL CONFIG_SND_PROC_FS */
#endif /* __SOUND_INFO_H */
diff --git a/sound/core/Makefile b/sound/core/Makefile
index 7dd17a3..9e5bb10 100644
--- a/sound/core/Makefile
+++ b/sound/core/Makefile
@@ -4,7 +4,7 @@
#
snd-y := sound.o init.o memory.o control.o misc.o device.o
-ifneq ($(CONFIG_PROC_FS),)
+ifneq ($(CONFIG_SND_PROC_FS),)
snd-y += info.o
snd-$(CONFIG_SND_OSSEMUL) += info_oss.o
endif
diff --git a/sound/core/hwdep.c b/sound/core/hwdep.c
index 51692c8..36d2416 100644
--- a/sound/core/hwdep.c
+++ b/sound/core/hwdep.c
@@ -484,7 +484,7 @@ static int snd_hwdep_dev_disconnect(struct snd_device
*device)
return 0;
}
-#ifdef CONFIG_PROC_FS
+#ifdef CONFIG_SND_PROC_FS
/*
* Info interface
*/
@@ -521,10 +521,10 @@ static void __exit snd_hwdep_proc_done(void)
{
snd_info_free_entry(snd_hwdep_proc_entry);
}
-#else /* !CONFIG_PROC_FS */
+#else /* !CONFIG_SND_PROC_FS */
#define snd_hwdep_proc_init()
#define snd_hwdep_proc_done()
-#endif /* CONFIG_PROC_FS */
+#endif /* CONFIG_SND_PROC_FS */
/*
diff --git a/sound/core/init.c b/sound/core/init.c
index f8abd2d..3e0ceba 100644
--- a/sound/core/init.c
+++ b/sound/core/init.c
@@ -100,7 +100,7 @@ int (*snd_mixer_oss_notify_callback)(struct snd_card *card,
int free_flag);
EXPORT_SYMBOL(snd_mixer_oss_notify_callback);
#endif
-#ifdef CONFIG_PROC_FS
+#ifdef CONFIG_SND_PROC_FS
static void snd_card_id_read(struct snd_info_entry *entry,
struct snd_info_buffer *buffer)
{
@@ -122,7 +122,7 @@ static int init_info_for_card(struct snd_card *card)
return snd_info_card_register(card);
}
-#else /* !CONFIG_PROC_FS */
+#else /* !CONFIG_SND_PROC_FS */
#define init_info_for_card(card)
#endif
@@ -776,7 +776,7 @@ int snd_card_register(struct snd_card *card)
EXPORT_SYMBOL(snd_card_register);
-#ifdef CONFIG_PROC_FS
+#ifdef CONFIG_SND_PROC_FS
static void snd_card_info_read(struct snd_info_entry *entry,
struct snd_info_buffer *buffer)
{
@@ -861,7 +861,7 @@ int __init snd_card_info_init(void)
return 0;
}
-#endif /* CONFIG_PROC_FS */
+#endif /* CONFIG_SND_PROC_FS */
/**
* snd_component_add - add a component string
diff --git a/sound/core/oss/mixer_oss.c b/sound/core/oss/mixer_oss.c
index 056f8e2..a99f720 100644
--- a/sound/core/oss/mixer_oss.c
+++ b/sound/core/oss/mixer_oss.c
@@ -,7 +,7 @@ static int snd_mixer_oss_build_input(struct snd_mixer_oss
*mixer, struct snd_mix
return 0;
}
