Re: [PATCH v2 2/2] trace_uprobe: Simplify probes_seq_show()

[Masami Hiramatsu]

On Thu, 15 Mar 2018 13:57:56 +0530
Ravi Bangoria  wrote:

> Simplify probes_seq_show() function. No change in output
> before and after patch.

Yeah, we don't need this trick anymore.

Acked-by: Masami Hiramatsu 

Thank you!

> 
> Signed-off-by: Ravi Bangoria 
> ---
>  kernel/trace/trace_uprobe.c | 21 +++--
>  1 file changed, 3 insertions(+), 18 deletions(-)
> 
> diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c
> index 0298bd15be83..544fa10a471b 100644
> --- a/kernel/trace/trace_uprobe.c
> +++ b/kernel/trace/trace_uprobe.c
> @@ -602,24 +602,9 @@ static int probes_seq_show(struct seq_file *m, void *v)
>   char c = is_ret_probe(tu) ? 'r' : 'p';
>   int i;
>  
> - seq_printf(m, "%c:%s/%s", c, tu->tp.call.class->system,
> - trace_event_name(>tp.call));
> - seq_printf(m, " %s:", tu->filename);
> -
> - /* Don't print "0x  (null)" when offset is 0 */
> - if (tu->offset) {
> - seq_printf(m, "0x%0*lx", (int)(sizeof(void *) * 2), tu->offset);
> - } else {
> - switch (sizeof(void *)) {
> - case 4:
> - seq_printf(m, "0x");
> - break;
> - case 8:
> - default:
> - seq_printf(m, "0x");
> - break;
> - }
> - }
> + seq_printf(m, "%c:%s/%s %s:0x%0*lx", c, tu->tp.call.class->system,
> + trace_event_name(>tp.call), tu->filename,
> + (int)(sizeof(void *) * 2), tu->offset);
>  
>   for (i = 0; i < tu->tp.nr_args; i++)
>   seq_printf(m, " %s=%s", tu->tp.args[i].name, 
> tu->tp.args[i].comm);
> -- 
> 2.13.6
> 


-- 
Masami Hiramatsu 

Re: [PATCH v2 2/2] trace_uprobe: Simplify probes_seq_show()

[Masami Hiramatsu]

On Thu, 15 Mar 2018 13:57:56 +0530
Ravi Bangoria  wrote:

> Simplify probes_seq_show() function. No change in output
> before and after patch.

Yeah, we don't need this trick anymore.

Acked-by: Masami Hiramatsu 

Thank you!

> 
> Signed-off-by: Ravi Bangoria 
> ---
>  kernel/trace/trace_uprobe.c | 21 +++--
>  1 file changed, 3 insertions(+), 18 deletions(-)
> 
> diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c
> index 0298bd15be83..544fa10a471b 100644
> --- a/kernel/trace/trace_uprobe.c
> +++ b/kernel/trace/trace_uprobe.c
> @@ -602,24 +602,9 @@ static int probes_seq_show(struct seq_file *m, void *v)
>   char c = is_ret_probe(tu) ? 'r' : 'p';
>   int i;
>  
> - seq_printf(m, "%c:%s/%s", c, tu->tp.call.class->system,
> - trace_event_name(>tp.call));
> - seq_printf(m, " %s:", tu->filename);
> -
> - /* Don't print "0x  (null)" when offset is 0 */
> - if (tu->offset) {
> - seq_printf(m, "0x%0*lx", (int)(sizeof(void *) * 2), tu->offset);
> - } else {
> - switch (sizeof(void *)) {
> - case 4:
> - seq_printf(m, "0x");
> - break;
> - case 8:
> - default:
> - seq_printf(m, "0x");
> - break;
> - }
> - }
> + seq_printf(m, "%c:%s/%s %s:0x%0*lx", c, tu->tp.call.class->system,
> + trace_event_name(>tp.call), tu->filename,
> + (int)(sizeof(void *) * 2), tu->offset);
>  
>   for (i = 0; i < tu->tp.nr_args; i++)
>   seq_printf(m, " %s=%s", tu->tp.args[i].name, 
> tu->tp.args[i].comm);
> -- 
> 2.13.6
> 


-- 
Masami Hiramatsu 

[PATCH v2 2/2] trace_uprobe: Simplify probes_seq_show()

[Ravi Bangoria]

Simplify probes_seq_show() function. No change in output
before and after patch.

Signed-off-by: Ravi Bangoria 
---
 kernel/trace/trace_uprobe.c | 21 +++--
 1 file changed, 3 insertions(+), 18 deletions(-)

diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c
index 0298bd15be83..544fa10a471b 100644
--- a/kernel/trace/trace_uprobe.c
+++ b/kernel/trace/trace_uprobe.c
@@ -602,24 +602,9 @@ static int probes_seq_show(struct seq_file *m, void *v)
char c = is_ret_probe(tu) ? 'r' : 'p';
int i;
 
-   seq_printf(m, "%c:%s/%s", c, tu->tp.call.class->system,
-   trace_event_name(>tp.call));
-   seq_printf(m, " %s:", tu->filename);
-
-   /* Don't print "0x  (null)" when offset is 0 */
-   if (tu->offset) {
-   seq_printf(m, "0x%0*lx", (int)(sizeof(void *) * 2), tu->offset);
-   } else {
-   switch (sizeof(void *)) {
-   case 4:
-   seq_printf(m, "0x");
-   break;
-   case 8:
-   default:
-   seq_printf(m, "0x");
-   break;
-   }
-   }
+   seq_printf(m, "%c:%s/%s %s:0x%0*lx", c, tu->tp.call.class->system,
+   trace_event_name(>tp.call), tu->filename,
+   (int)(sizeof(void *) * 2), tu->offset);
 
for (i = 0; i < tu->tp.nr_args; i++)
seq_printf(m, " %s=%s", tu->tp.args[i].name, 
tu->tp.args[i].comm);
-- 
2.13.6

[PATCH v2 2/2] trace_uprobe: Simplify probes_seq_show()

[Ravi Bangoria]

Simplify probes_seq_show() function. No change in output
before and after patch.

Signed-off-by: Ravi Bangoria 
---
 kernel/trace/trace_uprobe.c | 21 +++--
 1 file changed, 3 insertions(+), 18 deletions(-)

diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c
index 0298bd15be83..544fa10a471b 100644
--- a/kernel/trace/trace_uprobe.c
+++ b/kernel/trace/trace_uprobe.c
@@ -602,24 +602,9 @@ static int probes_seq_show(struct seq_file *m, void *v)
char c = is_ret_probe(tu) ? 'r' : 'p';
int i;
 
-   seq_printf(m, "%c:%s/%s", c, tu->tp.call.class->system,
-   trace_event_name(>tp.call));
-   seq_printf(m, " %s:", tu->filename);
-
-   /* Don't print "0x  (null)" when offset is 0 */
-   if (tu->offset) {
-   seq_printf(m, "0x%0*lx", (int)(sizeof(void *) * 2), tu->offset);
-   } else {
-   switch (sizeof(void *)) {
-   case 4:
-   seq_printf(m, "0x");
-   break;
-   case 8:
-   default:
-   seq_printf(m, "0x");
-   break;
-   }
-   }
+   seq_printf(m, "%c:%s/%s %s:0x%0*lx", c, tu->tp.call.class->system,
+   trace_event_name(>tp.call), tu->filename,
+   (int)(sizeof(void *) * 2), tu->offset);
 
for (i = 0; i < tu->tp.nr_args; i++)
seq_printf(m, " %s=%s", tu->tp.args[i].name, 
tu->tp.args[i].comm);
-- 
2.13.6