Re: [PATCH v2 2/3] mfd: rt5033: Add RT5033 Flash led sub device

[Ingi Kim]

Hi Lee Jones,

Okay, I'm try to remove needless part and resend it
Thanks for the review

Thank you

On 2015년 10월 13일 16:06, Lee Jones wrote:
> On Mon, 12 Oct 2015, Ingi Kim wrote:
> 
>> This patch adds rt5033-led sub device to support it.
>>
>> Signed-off-by: Ingi Kim 
>> ---
>>  drivers/mfd/rt5033.c | 6 +-
>>  1 file changed, 5 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/mfd/rt5033.c b/drivers/mfd/rt5033.c
>> index d60f916..b7f374b 100644
>> --- a/drivers/mfd/rt5033.c
>> +++ b/drivers/mfd/rt5033.c
>> @@ -40,13 +40,17 @@ static const struct regmap_irq_chip rt5033_irq_chip = {
>>  };
>>  
>>  static const struct mfd_cell rt5033_devs[] = {
>> -{ .name = "rt5033-regulator", },
>>  {
>> +.name = "rt5033-regulator",
>> +}, {
> 
> There's no need for this change.  Please remove it.
> 
>>  .name = "rt5033-charger",
>>  .of_compatible = "richtek,rt5033-charger",
>>  }, {
>>  .name = "rt5033-battery",
>>  .of_compatible = "richtek,rt5033-battery",
>> +}, {
>> +.name = "rt5033-led",
>> +.of_compatible = "richtek,rt5033-led",
> 
> For when you resubmit with the hunk above removed:
> 
> Acked-by: Lee Jones 
> 
>>  },
>>  };
>>  
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH v2 2/3] mfd: rt5033: Add RT5033 Flash led sub device

[Lee Jones]

On Mon, 12 Oct 2015, Ingi Kim wrote:

> This patch adds rt5033-led sub device to support it.
> 
> Signed-off-by: Ingi Kim 
> ---
>  drivers/mfd/rt5033.c | 6 +-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/mfd/rt5033.c b/drivers/mfd/rt5033.c
> index d60f916..b7f374b 100644
> --- a/drivers/mfd/rt5033.c
> +++ b/drivers/mfd/rt5033.c
> @@ -40,13 +40,17 @@ static const struct regmap_irq_chip rt5033_irq_chip = {
>  };
>  
>  static const struct mfd_cell rt5033_devs[] = {
> - { .name = "rt5033-regulator", },
>   {
> + .name = "rt5033-regulator",
> + }, {

There's no need for this change.  Please remove it.

>   .name = "rt5033-charger",
>   .of_compatible = "richtek,rt5033-charger",
>   }, {
>   .name = "rt5033-battery",
>   .of_compatible = "richtek,rt5033-battery",
> + }, {
> + .name = "rt5033-led",
> + .of_compatible = "richtek,rt5033-led",

For when you resubmit with the hunk above removed:

Acked-by: Lee Jones 

>   },
>  };
>  

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH v2 2/3] mfd: rt5033: Add RT5033 Flash led sub device

[Ingi Kim]

Hi Lee Jones,

Okay, I'm try to remove needless part and resend it
Thanks for the review

Thank you

On 2015년 10월 13일 16:06, Lee Jones wrote:
> On Mon, 12 Oct 2015, Ingi Kim wrote:
> 
>> This patch adds rt5033-led sub device to support it.
>>
>> Signed-off-by: Ingi Kim 
>> ---
>>  drivers/mfd/rt5033.c | 6 +-
>>  1 file changed, 5 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/mfd/rt5033.c b/drivers/mfd/rt5033.c
>> index d60f916..b7f374b 100644
>> --- a/drivers/mfd/rt5033.c
>> +++ b/drivers/mfd/rt5033.c
>> @@ -40,13 +40,17 @@ static const struct regmap_irq_chip rt5033_irq_chip = {
>>  };
>>  
>>  static const struct mfd_cell rt5033_devs[] = {
>> -{ .name = "rt5033-regulator", },
>>  {
>> +.name = "rt5033-regulator",
>> +}, {
> 
> There's no need for this change.  Please remove it.
> 
>>  .name = "rt5033-charger",
>>  .of_compatible = "richtek,rt5033-charger",
>>  }, {
>>  .name = "rt5033-battery",
>>  .of_compatible = "richtek,rt5033-battery",
>> +}, {
>> +.name = "rt5033-led",
>> +.of_compatible = "richtek,rt5033-led",
> 
> For when you resubmit with the hunk above removed:
> 
> Acked-by: Lee Jones 
> 
>>  },
>>  };
>>  
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH v2 2/3] mfd: rt5033: Add RT5033 Flash led sub device

[Lee Jones]

On Mon, 12 Oct 2015, Ingi Kim wrote:

> This patch adds rt5033-led sub device to support it.
> 
> Signed-off-by: Ingi Kim 
> ---
>  drivers/mfd/rt5033.c | 6 +-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/mfd/rt5033.c b/drivers/mfd/rt5033.c
> index d60f916..b7f374b 100644
> --- a/drivers/mfd/rt5033.c
> +++ b/drivers/mfd/rt5033.c
> @@ -40,13 +40,17 @@ static const struct regmap_irq_chip rt5033_irq_chip = {
>  };
>  
>  static const struct mfd_cell rt5033_devs[] = {
> - { .name = "rt5033-regulator", },
>   {
> + .name = "rt5033-regulator",
> + }, {

There's no need for this change.  Please remove it.

>   .name = "rt5033-charger",
>   .of_compatible = "richtek,rt5033-charger",
>   }, {
>   .name = "rt5033-battery",
>   .of_compatible = "richtek,rt5033-battery",
> + }, {
> + .name = "rt5033-led",
> + .of_compatible = "richtek,rt5033-led",

For when you resubmit with the hunk above removed:

Acked-by: Lee Jones 

>   },
>  };
>  

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH v2 2/3] mfd: rt5033: Add RT5033 Flash led sub device

[Ingi Kim]

This patch adds rt5033-led sub device to support it.

Signed-off-by: Ingi Kim 
---
 drivers/mfd/rt5033.c | 6 +-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/mfd/rt5033.c b/drivers/mfd/rt5033.c
index d60f916..b7f374b 100644
--- a/drivers/mfd/rt5033.c
+++ b/drivers/mfd/rt5033.c
@@ -40,13 +40,17 @@ static const struct regmap_irq_chip rt5033_irq_chip = {
 };
 
 static const struct mfd_cell rt5033_devs[] = {
-   { .name = "rt5033-regulator", },
{
+   .name = "rt5033-regulator",
+   }, {
.name = "rt5033-charger",
.of_compatible = "richtek,rt5033-charger",
}, {
.name = "rt5033-battery",
.of_compatible = "richtek,rt5033-battery",
+   }, {
+   .name = "rt5033-led",
+   .of_compatible = "richtek,rt5033-led",
},
 };
 
-- 
2.0.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH v2 2/3] mfd: rt5033: Add RT5033 Flash led sub device

[Ingi Kim]

This patch adds rt5033-led sub device to support it.

Signed-off-by: Ingi Kim 
---
 drivers/mfd/rt5033.c | 6 +-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/mfd/rt5033.c b/drivers/mfd/rt5033.c
index d60f916..b7f374b 100644
--- a/drivers/mfd/rt5033.c
+++ b/drivers/mfd/rt5033.c
@@ -40,13 +40,17 @@ static const struct regmap_irq_chip rt5033_irq_chip = {
 };
 
 static const struct mfd_cell rt5033_devs[] = {
-   { .name = "rt5033-regulator", },
{
+   .name = "rt5033-regulator",
+   }, {
.name = "rt5033-charger",
.of_compatible = "richtek,rt5033-charger",
}, {
.name = "rt5033-battery",
.of_compatible = "richtek,rt5033-battery",
+   }, {
+   .name = "rt5033-led",
+   .of_compatible = "richtek,rt5033-led",
},
 };
 
-- 
2.0.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/