Re: [PATCH v2 2/3] net: Add Keystone NetCP ethernet driver
On Thursday 21 August 2014 10:48 PM, Stephen Hemminger wrote: > On Fri, 15 Aug 2014 11:12:41 -0400 > Santosh Shilimkar wrote: > >> NetCP driver has a plug-in module architecture where each of the NetCP >> sub-modules exist as a loadable kernel module which plug in to the netcp >> core. These sub-modules are represented as "netcp-devices" in the dts >> bindings. It is mandatory to have the ethernet switch sub-module for >> the ethernet interface to be operational. Any other sub-module like the >> PA is optional. > > What are you doing to prevent/discourage proprietary binary only > sub-modules? > Not sure if you mistook this infrastructure as a replacement for the kernel module. The sub modules are traditional kernel modules that just registers into the NetCP framework. Kernel module infrastructure already discourages the proprietary binary only sub-modules. Regards, Santosh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 2/3] net: Add Keystone NetCP ethernet driver
On Thursday 21 August 2014 10:48 PM, Stephen Hemminger wrote: On Fri, 15 Aug 2014 11:12:41 -0400 Santosh Shilimkar santosh.shilim...@ti.com wrote: NetCP driver has a plug-in module architecture where each of the NetCP sub-modules exist as a loadable kernel module which plug in to the netcp core. These sub-modules are represented as netcp-devices in the dts bindings. It is mandatory to have the ethernet switch sub-module for the ethernet interface to be operational. Any other sub-module like the PA is optional. What are you doing to prevent/discourage proprietary binary only sub-modules? Not sure if you mistook this infrastructure as a replacement for the kernel module. The sub modules are traditional kernel modules that just registers into the NetCP framework. Kernel module infrastructure already discourages the proprietary binary only sub-modules. Regards, Santosh -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 2/3] net: Add Keystone NetCP ethernet driver
On Fri, 15 Aug 2014 11:12:41 -0400 Santosh Shilimkar wrote: > NetCP driver has a plug-in module architecture where each of the NetCP > sub-modules exist as a loadable kernel module which plug in to the netcp > core. These sub-modules are represented as "netcp-devices" in the dts > bindings. It is mandatory to have the ethernet switch sub-module for > the ethernet interface to be operational. Any other sub-module like the > PA is optional. What are you doing to prevent/discourage proprietary binary only sub-modules? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 2/3] net: Add Keystone NetCP ethernet driver
On Fri, 15 Aug 2014 11:12:41 -0400 Santosh Shilimkar santosh.shilim...@ti.com wrote: NetCP driver has a plug-in module architecture where each of the NetCP sub-modules exist as a loadable kernel module which plug in to the netcp core. These sub-modules are represented as netcp-devices in the dts bindings. It is mandatory to have the ethernet switch sub-module for the ethernet interface to be operational. Any other sub-module like the PA is optional. What are you doing to prevent/discourage proprietary binary only sub-modules? -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 2/3] net: Add Keystone NetCP ethernet driver
On 08/15/14 11:12, Santosh Shilimkar wrote:
I am curious about these two calls below(netcp_process_one_rx_packet
and netcp_tx_submit_skb):
On tx you seem to be broadcasting to all "sub-modules" and on receive
you seem to be invoking from all as well.
I couldnt find the code for any of the sub-modules but i suspect
things like switching/bridging or ipsec etc could be sub-modules.
If yes, have you thought about integrating these features into
Linux proper instead?
cheers,
jamal
+
+static inline int netcp_process_one_rx_packet(struct netcp_intf *netcp)
+{
+
+ /* Call each of the RX hooks */
+ p_info.skb = skb;
+ p_info.rxtstamp_complete = false;
+ list_for_each_entry(rx_hook, >rxhook_list_head, list) {
+ int ret;
+
+ ret = rx_hook->hook_rtn(rx_hook->order, rx_hook->hook_data,
+ _info);
+ if (unlikely(ret)) {
+ dev_err(netcp->ndev_dev, "RX hook %d failed: %d\n",
+ rx_hook->order, ret);
+ netcp->ndev->stats.rx_errors++;
+ dev_kfree_skb(skb);
+ return 0;
+ }
+ }
..
+ return 0;
+}
[..]
+static inline int netcp_tx_submit_skb(struct netcp_intf *netcp,
+ struct sk_buff *skb,
+ struct knav_dma_desc *desc)
+{
+ struct netcp_tx_pipe *tx_pipe = NULL;
+
+ p_info.netcp = netcp;
+ p_info.skb = skb;
+ p_info.tx_pipe = NULL;
+ p_info.psdata_len = 0;
+ p_info.ts_context = NULL;
+ p_info.txtstamp_complete = NULL;
+ p_info.epib = desc->epib;
+ p_info.psdata = desc->psdata;
+ memset(p_info.epib, 0, KNAV_DMA_NUM_EPIB_WORDS * sizeof(u32));
+
+ /* Find out where to inject the packet for transmission */
+ list_for_each_entry(tx_hook, >txhook_list_head, list) {
+ ret = tx_hook->hook_rtn(tx_hook->order, tx_hook->hook_data,
+ _info);
+ if (unlikely(ret != 0)) {
+ dev_err(netcp->ndev_dev, "TX hook %d rejected the packet
with reason(%d)\n",
+ tx_hook->order, ret);
+ ret = (ret < 0) ? ret : NETDEV_TX_OK;
+ goto out;
+ }
+ }
+
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 2/3] net: Add Keystone NetCP ethernet driver
On 08/15/14 11:12, Santosh Shilimkar wrote:
I am curious about these two calls below(netcp_process_one_rx_packet
and netcp_tx_submit_skb):
On tx you seem to be broadcasting to all sub-modules and on receive
you seem to be invoking from all as well.
I couldnt find the code for any of the sub-modules but i suspect
things like switching/bridging or ipsec etc could be sub-modules.
If yes, have you thought about integrating these features into
Linux proper instead?
cheers,
jamal
+
+static inline int netcp_process_one_rx_packet(struct netcp_intf *netcp)
+{
+
+ /* Call each of the RX hooks */
+ p_info.skb = skb;
+ p_info.rxtstamp_complete = false;
+ list_for_each_entry(rx_hook, netcp-rxhook_list_head, list) {
+ int ret;
+
+ ret = rx_hook-hook_rtn(rx_hook-order, rx_hook-hook_data,
+ p_info);
+ if (unlikely(ret)) {
+ dev_err(netcp-ndev_dev, RX hook %d failed: %d\n,
+ rx_hook-order, ret);
+ netcp-ndev-stats.rx_errors++;
+ dev_kfree_skb(skb);
+ return 0;
+ }
+ }
..
+ return 0;
+}
[..]
+static inline int netcp_tx_submit_skb(struct netcp_intf *netcp,
+ struct sk_buff *skb,
+ struct knav_dma_desc *desc)
+{
+ struct netcp_tx_pipe *tx_pipe = NULL;
+
+ p_info.netcp = netcp;
+ p_info.skb = skb;
+ p_info.tx_pipe = NULL;
+ p_info.psdata_len = 0;
+ p_info.ts_context = NULL;
+ p_info.txtstamp_complete = NULL;
+ p_info.epib = desc-epib;
+ p_info.psdata = desc-psdata;
+ memset(p_info.epib, 0, KNAV_DMA_NUM_EPIB_WORDS * sizeof(u32));
+
+ /* Find out where to inject the packet for transmission */
+ list_for_each_entry(tx_hook, netcp-txhook_list_head, list) {
+ ret = tx_hook-hook_rtn(tx_hook-order, tx_hook-hook_data,
+ p_info);
+ if (unlikely(ret != 0)) {
+ dev_err(netcp-ndev_dev, TX hook %d rejected the packet
with reason(%d)\n,
+ tx_hook-order, ret);
+ ret = (ret 0) ? ret : NETDEV_TX_OK;
+ goto out;
+ }
+ }
+
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
