Re: [PATCH v2 3/3] arm64: dts: qcom: pm8998: Add die temperature channel node to the ADC
On Thu, 6 Sep 2018 14:22:06 -0700 Matthias Kaehlcke wrote: > On Thu, Sep 06, 2018 at 02:10:43PM -0700, Doug Anderson wrote: > > Hi, > > > > On Thu, Sep 6, 2018 at 2:04 PM, Matthias Kaehlcke > > wrote: > > > Add a channel node for the die temperature to the ADC. > > > > > > Signed-off-by: Matthias Kaehlcke > > > Reviewed-by: Douglas Anderson > > > Signed-off-by: Matthias Kaehlcke > > > > Double-SoB? > > I must have run 'amend' with '-s' out of habit, which wasn't the right > thing to do in this case :/ > > > ...presumably Andy can remove that when he lands and doesn't need a > > re-post... > > Andy, in case you need me to repost let me know. Slightly worse than that (as was patch 1). You accidentally used -- rather than --- to separate the change log. So I ended up with Signed-off-by: M.. Reviewed-by: .. Signed-off-by: M.. -- Changelog Signed-off-by: J Good think the double signed off was raised as chances are I wouldn't have notice it. Jonathan > > Thanks > > Matthias
Re: [PATCH v2 3/3] arm64: dts: qcom: pm8998: Add die temperature channel node to the ADC
On Thu, Sep 06, 2018 at 02:10:43PM -0700, Doug Anderson wrote: > Hi, > > On Thu, Sep 6, 2018 at 2:04 PM, Matthias Kaehlcke wrote: > > Add a channel node for the die temperature to the ADC. > > > > Signed-off-by: Matthias Kaehlcke > > Reviewed-by: Douglas Anderson > > Signed-off-by: Matthias Kaehlcke > > Double-SoB? I must have run 'amend' with '-s' out of habit, which wasn't the right thing to do in this case :/ > ...presumably Andy can remove that when he lands and doesn't need a re-post... Andy, in case you need me to repost let me know. Thanks Matthias
Re: [PATCH v2 3/3] arm64: dts: qcom: pm8998: Add die temperature channel node to the ADC
Hi, On Thu, Sep 6, 2018 at 2:04 PM, Matthias Kaehlcke wrote: > Add a channel node for the die temperature to the ADC. > > Signed-off-by: Matthias Kaehlcke > Reviewed-by: Douglas Anderson > Signed-off-by: Matthias Kaehlcke Double-SoB? ...presumably Andy can remove that when he lands and doesn't need a re-post... -Doug
[PATCH v2 3/3] arm64: dts: qcom: pm8998: Add die temperature channel node to the ADC
Add a channel node for the die temperature to the ADC.
Signed-off-by: Matthias Kaehlcke
Reviewed-by: Douglas Anderson
Signed-off-by: Matthias Kaehlcke
--
Changes in v2:
- none
---
arch/arm64/boot/dts/qcom/pm8998.dtsi | 5 +
1 file changed, 5 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/pm8998.dtsi
b/arch/arm64/boot/dts/qcom/pm8998.dtsi
index 41593ebbea2c..d18d4f260fbe 100644
--- a/arch/arm64/boot/dts/qcom/pm8998.dtsi
+++ b/arch/arm64/boot/dts/qcom/pm8998.dtsi
@@ -19,6 +19,11 @@
#address-cells = <1>;
#size-cells = <0>;
#io-channel-cells = <1>;
+
+ die-temp {
+ reg = ;
+ label = "die_temp";
+ };
};
pm8998_gpio: gpios@c000 {
--
2.19.0.rc2.392.g5ba43deb5a-goog
