Re: [PATCH v2 3/3] power: supply: axp288_fuel_gauge: Do not register FG on ECS EF20EA

2018-02-19 Thread Hans de Goede 

Hi,

On 16-02-18 15:26, Sebastian Reichel wrote:

Hi,

On Fri, Feb 16, 2018 at 08:26:16AM +, Carlo Caione wrote:

From: Carlo Caione 

The ECS EF20EA laptop ships an AXP288 but it is actually using a
different, separate FG chip for AC and battery monitoring. On this
laptop we need to keep using the regular ACPI driver and disable the
AXP288 FG to avoid reporting two batteries to userspace.

Signed-off-by: Carlo Caione 
---


It looks like this could be applied independently of the ACPI
patches to the power-supply tree?


Yes this can be applied independently.

Regards,

Hans





-- Sebastian


  drivers/power/supply/axp288_fuel_gauge.c | 6 ++
  1 file changed, 6 insertions(+)

diff --git a/drivers/power/supply/axp288_fuel_gauge.c 
b/drivers/power/supply/axp288_fuel_gauge.c
index 4cc6e038dfdd..903891a9bcf0 100644
--- a/drivers/power/supply/axp288_fuel_gauge.c
+++ b/drivers/power/supply/axp288_fuel_gauge.c
@@ -708,6 +708,12 @@ static const struct dmi_system_id 
axp288_fuel_gauge_blacklist[] = {
DMI_MATCH(DMI_BOARD_VERSION, "V1.1"),
},
},
+   {
+   /* ECS EF20EA */
+   .matches = {
+   DMI_MATCH(DMI_PRODUCT_NAME, "EF20EA"),
+   },
+   },
{}
  };
  
--

2.14.1

Re: [PATCH v2 3/3] power: supply: axp288_fuel_gauge: Do not register FG on ECS EF20EA

2018-02-19 Thread Hans de Goede 

Hi,

On 16-02-18 15:26, Sebastian Reichel wrote:

Hi,

On Fri, Feb 16, 2018 at 08:26:16AM +, Carlo Caione wrote:

From: Carlo Caione 

The ECS EF20EA laptop ships an AXP288 but it is actually using a
different, separate FG chip for AC and battery monitoring. On this
laptop we need to keep using the regular ACPI driver and disable the
AXP288 FG to avoid reporting two batteries to userspace.

Signed-off-by: Carlo Caione 
---


It looks like this could be applied independently of the ACPI
patches to the power-supply tree?


Yes this can be applied independently.

Regards,

Hans





-- Sebastian


  drivers/power/supply/axp288_fuel_gauge.c | 6 ++
  1 file changed, 6 insertions(+)

diff --git a/drivers/power/supply/axp288_fuel_gauge.c 
b/drivers/power/supply/axp288_fuel_gauge.c
index 4cc6e038dfdd..903891a9bcf0 100644
--- a/drivers/power/supply/axp288_fuel_gauge.c
+++ b/drivers/power/supply/axp288_fuel_gauge.c
@@ -708,6 +708,12 @@ static const struct dmi_system_id 
axp288_fuel_gauge_blacklist[] = {
DMI_MATCH(DMI_BOARD_VERSION, "V1.1"),
},
},
+   {
+   /* ECS EF20EA */
+   .matches = {
+   DMI_MATCH(DMI_PRODUCT_NAME, "EF20EA"),
+   },
+   },
{}
  };
  
--

2.14.1

Re: [PATCH v2 3/3] power: supply: axp288_fuel_gauge: Do not register FG on ECS EF20EA

2018-02-16 Thread Sebastian Reichel 
Hi,

On Fri, Feb 16, 2018 at 08:26:16AM +, Carlo Caione wrote:
> From: Carlo Caione 
> 
> The ECS EF20EA laptop ships an AXP288 but it is actually using a
> different, separate FG chip for AC and battery monitoring. On this
> laptop we need to keep using the regular ACPI driver and disable the
> AXP288 FG to avoid reporting two batteries to userspace.
> 
> Signed-off-by: Carlo Caione 
> ---

It looks like this could be applied independently of the ACPI
patches to the power-supply tree?

-- Sebastian

>  drivers/power/supply/axp288_fuel_gauge.c | 6 ++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/power/supply/axp288_fuel_gauge.c 
> b/drivers/power/supply/axp288_fuel_gauge.c
> index 4cc6e038dfdd..903891a9bcf0 100644
> --- a/drivers/power/supply/axp288_fuel_gauge.c
> +++ b/drivers/power/supply/axp288_fuel_gauge.c
> @@ -708,6 +708,12 @@ static const struct dmi_system_id 
> axp288_fuel_gauge_blacklist[] = {
>   DMI_MATCH(DMI_BOARD_VERSION, "V1.1"),
>   },
>   },
> + {
> + /* ECS EF20EA */
> + .matches = {
> + DMI_MATCH(DMI_PRODUCT_NAME, "EF20EA"),
> + },
> + },
>   {}
>  };
>  
> -- 
> 2.14.1
> 


signature.asc
Description: PGP signature

Re: [PATCH v2 3/3] power: supply: axp288_fuel_gauge: Do not register FG on ECS EF20EA

2018-02-16 Thread Sebastian Reichel 
Hi,

On Fri, Feb 16, 2018 at 08:26:16AM +, Carlo Caione wrote:
> From: Carlo Caione 
> 
> The ECS EF20EA laptop ships an AXP288 but it is actually using a
> different, separate FG chip for AC and battery monitoring. On this
> laptop we need to keep using the regular ACPI driver and disable the
> AXP288 FG to avoid reporting two batteries to userspace.
> 
> Signed-off-by: Carlo Caione 
> ---

It looks like this could be applied independently of the ACPI
patches to the power-supply tree?

-- Sebastian

>  drivers/power/supply/axp288_fuel_gauge.c | 6 ++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/power/supply/axp288_fuel_gauge.c 
> b/drivers/power/supply/axp288_fuel_gauge.c
> index 4cc6e038dfdd..903891a9bcf0 100644
> --- a/drivers/power/supply/axp288_fuel_gauge.c
> +++ b/drivers/power/supply/axp288_fuel_gauge.c
> @@ -708,6 +708,12 @@ static const struct dmi_system_id 
> axp288_fuel_gauge_blacklist[] = {
>   DMI_MATCH(DMI_BOARD_VERSION, "V1.1"),
>   },
>   },
> + {
> + /* ECS EF20EA */
> + .matches = {
> + DMI_MATCH(DMI_PRODUCT_NAME, "EF20EA"),
> + },
> + },
>   {}
>  };
>  
> -- 
> 2.14.1
> 


signature.asc
Description: PGP signature

[PATCH v2 3/3] power: supply: axp288_fuel_gauge: Do not register FG on ECS EF20EA

2018-02-16 Thread Carlo Caione 
From: Carlo Caione 

The ECS EF20EA laptop ships an AXP288 but it is actually using a
different, separate FG chip for AC and battery monitoring. On this
laptop we need to keep using the regular ACPI driver and disable the
AXP288 FG to avoid reporting two batteries to userspace.

Signed-off-by: Carlo Caione 
---
 drivers/power/supply/axp288_fuel_gauge.c | 6 ++
 1 file changed, 6 insertions(+)

diff --git a/drivers/power/supply/axp288_fuel_gauge.c 
b/drivers/power/supply/axp288_fuel_gauge.c
index 4cc6e038dfdd..903891a9bcf0 100644
--- a/drivers/power/supply/axp288_fuel_gauge.c
+++ b/drivers/power/supply/axp288_fuel_gauge.c
@@ -708,6 +708,12 @@ static const struct dmi_system_id 
axp288_fuel_gauge_blacklist[] = {
DMI_MATCH(DMI_BOARD_VERSION, "V1.1"),
},
},
+   {
+   /* ECS EF20EA */
+   .matches = {
+   DMI_MATCH(DMI_PRODUCT_NAME, "EF20EA"),
+   },
+   },
{}
 };
 
-- 
2.14.1

[PATCH v2 3/3] power: supply: axp288_fuel_gauge: Do not register FG on ECS EF20EA

2018-02-16 Thread Carlo Caione 
From: Carlo Caione 

The ECS EF20EA laptop ships an AXP288 but it is actually using a
different, separate FG chip for AC and battery monitoring. On this
laptop we need to keep using the regular ACPI driver and disable the
AXP288 FG to avoid reporting two batteries to userspace.

Signed-off-by: Carlo Caione 
---
 drivers/power/supply/axp288_fuel_gauge.c | 6 ++
 1 file changed, 6 insertions(+)

diff --git a/drivers/power/supply/axp288_fuel_gauge.c 
b/drivers/power/supply/axp288_fuel_gauge.c
index 4cc6e038dfdd..903891a9bcf0 100644
--- a/drivers/power/supply/axp288_fuel_gauge.c
+++ b/drivers/power/supply/axp288_fuel_gauge.c
@@ -708,6 +708,12 @@ static const struct dmi_system_id 
axp288_fuel_gauge_blacklist[] = {
DMI_MATCH(DMI_BOARD_VERSION, "V1.1"),
},
},
+   {
+   /* ECS EF20EA */
+   .matches = {
+   DMI_MATCH(DMI_PRODUCT_NAME, "EF20EA"),
+   },
+   },
{}
 };
 
-- 
2.14.1