Re: [PATCH v2 3/6] ARM: dts: sun8i: s3: Add dtsi for the Elimo Impetus SoM

2020-11-04 Thread Maxime Ripard 
Hi

On Tue, Nov 03, 2020 at 04:28:27PM +, Matteo Scordino wrote:
> -- 
> Matteo Scordino / Embedded Software Consultant
> Mobile: +44 (0)7463701446
> 
> On Mon, 2020-11-02 at 11:05 +0100, Maxime Ripard wrote:
> > Hi!
> > 
> > On Fri, Oct 30, 2020 at 11:43:22PM +, Matteo Scordino wrote:
> > > The Elimo Engineering Impetus is an Open Source Hardware System-on-Module
> > > based on the SoChip S3 SoC.
> > > 
> > > It is meant for integration into carrier boards or, more generally,
> > > larger designs, and uses an M2 connector to facilitate that.
> > > 
> > > Interfaces on the M.2/NGFF 42mm connector:
> > > WiFi IEEE 802. 11abgn (on-module Realtek)
> > > Bluetooth 4.2/BLE (on-module Realtek)
> > > RGB LCD Interface (on-module connector)
> > > MIPI Camera Interface (on-module connector)
> > > IEEE 802. 3u Ethernet MAC (external connecto)
> > > USB2.0 (Host, Device, OTG) (external connector)
> > > Audio Line In/Out (external connector)
> > > 
> > > Signed-off-by: Matteo Scordino 
> > > ---
> > >  arch/arm/boot/dts/sun8i-s3-elimo-impetus.dtsi | 51 +++
> > >  1 file changed, 51 insertions(+)
> > >  create mode 100644 arch/arm/boot/dts/sun8i-s3-elimo-impetus.dtsi
> > > 
> > > diff --git a/arch/arm/boot/dts/sun8i-s3-elimo-impetus.dtsi 
> > > b/arch/arm/boot/dts/sun8i-s3-elimo-impetus.dtsi
> > > new file mode 100644
> > > index ..f219188fc9ba
> > > --- /dev/null
> > > +++ b/arch/arm/boot/dts/sun8i-s3-elimo-impetus.dtsi
> > > @@ -0,0 +1,51 @@
> > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> > > +/*
> > > + * Copyright (C) 2020 Matteo Scordino 
> > > + */
> > > +
> > > +/dts-v1/;
> > > +#include "sun8i-v3.dtsi"
> > > +#include "sunxi-common-regulators.dtsi"
> > > +
> > > +/ {
> > > + model = "Elimo Impetus SoM";
> > > + compatible = "elimo,impetus", "sochip,s3", "allwinner,sun8i-v3";
> > > +
> > > + aliases {
> > > + serial0 = &uart0;
> > > + serial1 = &uart1;
> > > + };
> > > +
> > > + chosen {
> > > + stdout-path = "serial0:115200n8";
> > > + };
> > > +};
> > > +
> > > +&mmc0 {
> > > + broken-cd;
> > > + bus-width = <4>;
> > > + vmmc-supply = <®_vcc3v3>;
> > > + status = "okay";
> > > +};
> > > +
> > > +&uart0 {
> > > + pinctrl-0 = <&uart0_pb_pins>;
> > > + pinctrl-names = "default";
> > > + status = "okay";
> > > +};
> > > +
> > > +&uart1 {
> > > + pinctrl-0 = <&uart1_pg_pins>;
> > > + pinctrl-names = "default";
> > > + status = "okay";
> > > +};
> > 
> > What is uart1 used for? the BT chip?
> > 
> > Maxime
> 
> No, BT is provided over SDIO by a Cypress 43455.
> When used with the Initium carrier board, UART1 goes to an FTDI bridge that is
> connected to the same USB-C connector that is used for power.
> The idea being, if want an application that uses the UART to communicate with 
> a
> PC, it's convenient to provide power+connectivity on a single port.
> 
> I guess your point is that we would be better off only defining this in the 
> DTS
> of the carrier board?

I wasn't trying to make any point, it was a legitimate question, we
don't want to enable something that is optional or could be used for
something else (like a UART exposed on a generic pin header).

But from what you're telling me, yeah, it should be moved to the
daughter board DTS.

Maxime



signature.asc
Description: PGP signature

Re: [PATCH v2 3/6] ARM: dts: sun8i: s3: Add dtsi for the Elimo Impetus SoM

2020-11-03 Thread Matteo Scordino 
-- 
Matteo Scordino / Embedded Software Consultant
Mobile: +44 (0)7463701446

On Mon, 2020-11-02 at 11:05 +0100, Maxime Ripard wrote:
> Hi!
> 
> On Fri, Oct 30, 2020 at 11:43:22PM +, Matteo Scordino wrote:
> > The Elimo Engineering Impetus is an Open Source Hardware System-on-Module
> > based on the SoChip S3 SoC.
> > 
> > It is meant for integration into carrier boards or, more generally,
> > larger designs, and uses an M2 connector to facilitate that.
> > 
> > Interfaces on the M.2/NGFF 42mm connector:
> > WiFi IEEE 802. 11abgn (on-module Realtek)
> > Bluetooth 4.2/BLE (on-module Realtek)
> > RGB LCD Interface (on-module connector)
> > MIPI Camera Interface (on-module connector)
> > IEEE 802. 3u Ethernet MAC (external connecto)
> > USB2.0 (Host, Device, OTG) (external connector)
> > Audio Line In/Out (external connector)
> > 
> > Signed-off-by: Matteo Scordino 
> > ---
> >  arch/arm/boot/dts/sun8i-s3-elimo-impetus.dtsi | 51 +++
> >  1 file changed, 51 insertions(+)
> >  create mode 100644 arch/arm/boot/dts/sun8i-s3-elimo-impetus.dtsi
> > 
> > diff --git a/arch/arm/boot/dts/sun8i-s3-elimo-impetus.dtsi 
> > b/arch/arm/boot/dts/sun8i-s3-elimo-impetus.dtsi
> > new file mode 100644
> > index ..f219188fc9ba
> > --- /dev/null
> > +++ b/arch/arm/boot/dts/sun8i-s3-elimo-impetus.dtsi
> > @@ -0,0 +1,51 @@
> > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> > +/*
> > + * Copyright (C) 2020 Matteo Scordino 
> > + */
> > +
> > +/dts-v1/;
> > +#include "sun8i-v3.dtsi"
> > +#include "sunxi-common-regulators.dtsi"
> > +
> > +/ {
> > +   model = "Elimo Impetus SoM";
> > +   compatible = "elimo,impetus", "sochip,s3", "allwinner,sun8i-v3";
> > +
> > +   aliases {
> > +   serial0 = &uart0;
> > +   serial1 = &uart1;
> > +   };
> > +
> > +   chosen {
> > +   stdout-path = "serial0:115200n8";
> > +   };
> > +};
> > +
> > +&mmc0 {
> > +   broken-cd;
> > +   bus-width = <4>;
> > +   vmmc-supply = <®_vcc3v3>;
> > +   status = "okay";
> > +};
> > +
> > +&uart0 {
> > +   pinctrl-0 = <&uart0_pb_pins>;
> > +   pinctrl-names = "default";
> > +   status = "okay";
> > +};
> > +
> > +&uart1 {
> > +   pinctrl-0 = <&uart1_pg_pins>;
> > +   pinctrl-names = "default";
> > +   status = "okay";
> > +};
> 
> What is uart1 used for? the BT chip?
> 
> Maxime

No, BT is provided over SDIO by a Cypress 43455.
When used with the Initium carrier board, UART1 goes to an FTDI bridge that is
connected to the same USB-C connector that is used for power.
The idea being, if want an application that uses the UART to communicate with a
PC, it's convenient to provide power+connectivity on a single port.

I guess your point is that we would be better off only defining this in the DTS
of the carrier board?


signature.asc
Description: This is a digitally signed message part

Re: [PATCH v2 3/6] ARM: dts: sun8i: s3: Add dtsi for the Elimo Impetus SoM

2020-11-02 Thread Maxime Ripard 
Hi!

On Fri, Oct 30, 2020 at 11:43:22PM +, Matteo Scordino wrote:
> The Elimo Engineering Impetus is an Open Source Hardware System-on-Module
> based on the SoChip S3 SoC.
> 
> It is meant for integration into carrier boards or, more generally,
> larger designs, and uses an M2 connector to facilitate that.
> 
> Interfaces on the M.2/NGFF 42mm connector:
> WiFi IEEE 802. 11abgn (on-module Realtek)
> Bluetooth 4.2/BLE (on-module Realtek)
> RGB LCD Interface (on-module connector)
> MIPI Camera Interface (on-module connector)
> IEEE 802. 3u Ethernet MAC (external connecto)
> USB2.0 (Host, Device, OTG) (external connector)
> Audio Line In/Out (external connector)
> 
> Signed-off-by: Matteo Scordino 
> ---
>  arch/arm/boot/dts/sun8i-s3-elimo-impetus.dtsi | 51 +++
>  1 file changed, 51 insertions(+)
>  create mode 100644 arch/arm/boot/dts/sun8i-s3-elimo-impetus.dtsi
> 
> diff --git a/arch/arm/boot/dts/sun8i-s3-elimo-impetus.dtsi 
> b/arch/arm/boot/dts/sun8i-s3-elimo-impetus.dtsi
> new file mode 100644
> index ..f219188fc9ba
> --- /dev/null
> +++ b/arch/arm/boot/dts/sun8i-s3-elimo-impetus.dtsi
> @@ -0,0 +1,51 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> + * Copyright (C) 2020 Matteo Scordino 
> + */
> +
> +/dts-v1/;
> +#include "sun8i-v3.dtsi"
> +#include "sunxi-common-regulators.dtsi"
> +
> +/ {
> + model = "Elimo Impetus SoM";
> + compatible = "elimo,impetus", "sochip,s3", "allwinner,sun8i-v3";
> +
> + aliases {
> + serial0 = &uart0;
> + serial1 = &uart1;
> + };
> +
> + chosen {
> + stdout-path = "serial0:115200n8";
> + };
> +};
> +
> +&mmc0 {
> + broken-cd;
> + bus-width = <4>;
> + vmmc-supply = <®_vcc3v3>;
> + status = "okay";
> +};
> +
> +&uart0 {
> + pinctrl-0 = <&uart0_pb_pins>;
> + pinctrl-names = "default";
> + status = "okay";
> +};
> +
> +&uart1 {
> + pinctrl-0 = <&uart1_pg_pins>;
> + pinctrl-names = "default";
> + status = "okay";
> +};

What is uart1 used for? the BT chip?

Maxime


signature.asc
Description: PGP signature

[PATCH v2 3/6] ARM: dts: sun8i: s3: Add dtsi for the Elimo Impetus SoM

2020-10-30 Thread Matteo Scordino 
The Elimo Engineering Impetus is an Open Source Hardware System-on-Module
based on the SoChip S3 SoC.

It is meant for integration into carrier boards or, more generally,
larger designs, and uses an M2 connector to facilitate that.

Interfaces on the M.2/NGFF 42mm connector:
WiFi IEEE 802. 11abgn (on-module Realtek)
Bluetooth 4.2/BLE (on-module Realtek)
RGB LCD Interface (on-module connector)
MIPI Camera Interface (on-module connector)
IEEE 802. 3u Ethernet MAC (external connecto)
USB2.0 (Host, Device, OTG) (external connector)
Audio Line In/Out (external connector)

Signed-off-by: Matteo Scordino 
---
 arch/arm/boot/dts/sun8i-s3-elimo-impetus.dtsi | 51 +++
 1 file changed, 51 insertions(+)
 create mode 100644 arch/arm/boot/dts/sun8i-s3-elimo-impetus.dtsi

diff --git a/arch/arm/boot/dts/sun8i-s3-elimo-impetus.dtsi 
b/arch/arm/boot/dts/sun8i-s3-elimo-impetus.dtsi
new file mode 100644
index ..f219188fc9ba
--- /dev/null
+++ b/arch/arm/boot/dts/sun8i-s3-elimo-impetus.dtsi
@@ -0,0 +1,51 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright (C) 2020 Matteo Scordino 
+ */
+
+/dts-v1/;
+#include "sun8i-v3.dtsi"
+#include "sunxi-common-regulators.dtsi"
+
+/ {
+   model = "Elimo Impetus SoM";
+   compatible = "elimo,impetus", "sochip,s3", "allwinner,sun8i-v3";
+
+   aliases {
+   serial0 = &uart0;
+   serial1 = &uart1;
+   };
+
+   chosen {
+   stdout-path = "serial0:115200n8";
+   };
+};
+
+&mmc0 {
+   broken-cd;
+   bus-width = <4>;
+   vmmc-supply = <®_vcc3v3>;
+   status = "okay";
+};
+
+&uart0 {
+   pinctrl-0 = <&uart0_pb_pins>;
+   pinctrl-names = "default";
+   status = "okay";
+};
+
+&uart1 {
+   pinctrl-0 = <&uart1_pg_pins>;
+   pinctrl-names = "default";
+   status = "okay";
+};
+
+&usb_otg {
+   dr_mode = "otg";
+   status = "okay";
+};
+
+&usbphy {
+   usb0_id_det-gpio = <&pio 5 6 GPIO_ACTIVE_HIGH>;
+   status = "okay";
+};
-- 
2.20.1