Re: [PATCH v2 3/6] selftests: mqueue: allow extra cflags

[Michael Ellerman]

On Mon, 2015-09-07 at 22:04 +0800, Bamvor Jian Zhang wrote:
> change from = to += in order to pass the proper headers and librareis

Please start your changelogs with a Capital letter, they are supposed to be
proper English sentences.

> (popt.h and libpopt.so) in order to build successful in cross
> compiling.

Yeah. More generally it allows the user to pass whatever CFLAGS they wish,
which is a good feature.

Acked-by: Michael Ellerman 

cheers



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH v2 3/6] selftests: mqueue: allow extra cflags

[Bamvor Jian Zhang]

change from = to += in order to pass the proper headers and librareis
(popt.h and libpopt.so) in order to build successful in cross
compiling.

Suggested-by: Michael Ellermani 
Signed-off-by: Bamvor Jian Zhang 
---
 tools/testing/selftests/mqueue/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/mqueue/Makefile 
b/tools/testing/selftests/mqueue/Makefile
index 0e3b41e..ca8327f 100644
--- a/tools/testing/selftests/mqueue/Makefile
+++ b/tools/testing/selftests/mqueue/Makefile
@@ -1,4 +1,4 @@
-CFLAGS = -O2
+CFLAGS += -O2
 
 all:
$(CC) $(CFLAGS) mq_open_tests.c -o mq_open_tests -lrt
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH v2 3/6] selftests: mqueue: allow extra cflags

[Bamvor Jian Zhang]

change from = to += in order to pass the proper headers and librareis
(popt.h and libpopt.so) in order to build successful in cross
compiling.

Suggested-by: Michael Ellermani 
Signed-off-by: Bamvor Jian Zhang 
---
 tools/testing/selftests/mqueue/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/mqueue/Makefile 
b/tools/testing/selftests/mqueue/Makefile
index 0e3b41e..ca8327f 100644
--- a/tools/testing/selftests/mqueue/Makefile
+++ b/tools/testing/selftests/mqueue/Makefile
@@ -1,4 +1,4 @@
-CFLAGS = -O2
+CFLAGS += -O2
 
 all:
$(CC) $(CFLAGS) mq_open_tests.c -o mq_open_tests -lrt
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH v2 3/6] selftests: mqueue: allow extra cflags

[Michael Ellerman]

On Mon, 2015-09-07 at 22:04 +0800, Bamvor Jian Zhang wrote:
> change from = to += in order to pass the proper headers and librareis

Please start your changelogs with a Capital letter, they are supposed to be
proper English sentences.

> (popt.h and libpopt.so) in order to build successful in cross
> compiling.

Yeah. More generally it allows the user to pass whatever CFLAGS they wish,
which is a good feature.

Acked-by: Michael Ellerman 

cheers



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/