Re: [PATCH v2 4/4] mtd: rawnand: AMD: Also use the last page for bad block markers

[Boris Brezillon]

On Tue, 22 Jan 2019 11:23:33 +
Schrempf Frieder  wrote:

> From: Frieder Schrempf 
> 
> According to the datasheet of some Cypress SLC NANDs, the bad
> block markers can be in the first, second or last page of a block.
> So let's check all three locations.
> 
> Signed-off-by: Frieder Schrempf 

Reviewed-by: Boris Brezillon 

> ---
>  drivers/mtd/nand/raw/nand_amd.c | 8 +++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/nand/raw/nand_amd.c b/drivers/mtd/nand/raw/nand_amd.c
> index 6202cbf7ee8d..2ffcddff3e27 100644
> --- a/drivers/mtd/nand/raw/nand_amd.c
> +++ b/drivers/mtd/nand/raw/nand_amd.c
> @@ -40,7 +40,13 @@ static void amd_nand_decode_id(struct nand_chip *chip)
>  static int amd_nand_init(struct nand_chip *chip)
>  {
>   if (nand_is_slc(chip))
> - chip->options |= NAND_BBM_FIRSTPAGE | NAND_BBM_SECONDPAGE;
> + /*
> +  * According to the datasheet of some Cypress SLC NANDs,
> +  * the bad block markers can be in the first, second or last
> +  * page of a block. So let's check all three locations.
> +  */
> + chip->options |= NAND_BBM_FIRSTPAGE | NAND_BBM_SECONDPAGE |
> +  NAND_BBM_LASTPAGE;
>  
>   return 0;
>  }

[PATCH v2 4/4] mtd: rawnand: AMD: Also use the last page for bad block markers

[Schrempf Frieder]

From: Frieder Schrempf 

According to the datasheet of some Cypress SLC NANDs, the bad
block markers can be in the first, second or last page of a block.
So let's check all three locations.

Signed-off-by: Frieder Schrempf 
---
 drivers/mtd/nand/raw/nand_amd.c | 8 +++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/drivers/mtd/nand/raw/nand_amd.c b/drivers/mtd/nand/raw/nand_amd.c
index 6202cbf7ee8d..2ffcddff3e27 100644
--- a/drivers/mtd/nand/raw/nand_amd.c
+++ b/drivers/mtd/nand/raw/nand_amd.c
@@ -40,7 +40,13 @@ static void amd_nand_decode_id(struct nand_chip *chip)
 static int amd_nand_init(struct nand_chip *chip)
 {
if (nand_is_slc(chip))
-   chip->options |= NAND_BBM_FIRSTPAGE | NAND_BBM_SECONDPAGE;
+   /*
+* According to the datasheet of some Cypress SLC NANDs,
+* the bad block markers can be in the first, second or last
+* page of a block. So let's check all three locations.
+*/
+   chip->options |= NAND_BBM_FIRSTPAGE | NAND_BBM_SECONDPAGE |
+NAND_BBM_LASTPAGE;
 
return 0;
 }
-- 
2.17.1