Re: [PATCH v2 4/4] uprobes/powerpc: remove additional trap instruction check
* Ananth N Mavinakayanahalli [2013-03-22 20:49:46]: > From: Ananth N Mavinakayanahalli > > prepare_uprobe() already checks if the underlying unstruction > (on file) is a trap variant. We don't need to check this again. > > Signed-off-by: Ananth N Mavinakayanahalli Acked-by: Srikar Dronamraju > --- > arch/powerpc/kernel/uprobes.c |6 -- > 1 file changed, 6 deletions(-) > > Index: linux-3.9-rc3/arch/powerpc/kernel/uprobes.c > === > --- linux-3.9-rc3.orig/arch/powerpc/kernel/uprobes.c > +++ linux-3.9-rc3/arch/powerpc/kernel/uprobes.c > @@ -53,12 +53,6 @@ int arch_uprobe_analyze_insn(struct arch > if (addr & 0x03) > return -EINVAL; > > - /* > - * We currently don't support a uprobe on an already > - * existing breakpoint instruction underneath > - */ > - if (is_trap(auprobe->ainsn)) > - return -ENOTSUPP; > return 0; > } > -- Thanks and Regards Srikar Dronamraju -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 4/4] uprobes/powerpc: remove additional trap instruction check
* Ananth N Mavinakayanahalli ana...@in.ibm.com [2013-03-22 20:49:46]: From: Ananth N Mavinakayanahalli ana...@in.ibm.com prepare_uprobe() already checks if the underlying unstruction (on file) is a trap variant. We don't need to check this again. Signed-off-by: Ananth N Mavinakayanahalli ana...@in.ibm.com Acked-by: Srikar Dronamraju sri...@linux.vnet.ibm.com --- arch/powerpc/kernel/uprobes.c |6 -- 1 file changed, 6 deletions(-) Index: linux-3.9-rc3/arch/powerpc/kernel/uprobes.c === --- linux-3.9-rc3.orig/arch/powerpc/kernel/uprobes.c +++ linux-3.9-rc3/arch/powerpc/kernel/uprobes.c @@ -53,12 +53,6 @@ int arch_uprobe_analyze_insn(struct arch if (addr 0x03) return -EINVAL; - /* - * We currently don't support a uprobe on an already - * existing breakpoint instruction underneath - */ - if (is_trap(auprobe-ainsn)) - return -ENOTSUPP; return 0; } -- Thanks and Regards Srikar Dronamraju -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH v2 4/4] uprobes/powerpc: remove additional trap instruction check
From: Ananth N Mavinakayanahalli prepare_uprobe() already checks if the underlying unstruction (on file) is a trap variant. We don't need to check this again. Signed-off-by: Ananth N Mavinakayanahalli --- arch/powerpc/kernel/uprobes.c |6 -- 1 file changed, 6 deletions(-) Index: linux-3.9-rc3/arch/powerpc/kernel/uprobes.c === --- linux-3.9-rc3.orig/arch/powerpc/kernel/uprobes.c +++ linux-3.9-rc3/arch/powerpc/kernel/uprobes.c @@ -53,12 +53,6 @@ int arch_uprobe_analyze_insn(struct arch if (addr & 0x03) return -EINVAL; - /* -* We currently don't support a uprobe on an already -* existing breakpoint instruction underneath -*/ - if (is_trap(auprobe->ainsn)) - return -ENOTSUPP; return 0; } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH v2 4/4] uprobes/powerpc: remove additional trap instruction check
From: Ananth N Mavinakayanahalli ana...@in.ibm.com prepare_uprobe() already checks if the underlying unstruction (on file) is a trap variant. We don't need to check this again. Signed-off-by: Ananth N Mavinakayanahalli ana...@in.ibm.com --- arch/powerpc/kernel/uprobes.c |6 -- 1 file changed, 6 deletions(-) Index: linux-3.9-rc3/arch/powerpc/kernel/uprobes.c === --- linux-3.9-rc3.orig/arch/powerpc/kernel/uprobes.c +++ linux-3.9-rc3/arch/powerpc/kernel/uprobes.c @@ -53,12 +53,6 @@ int arch_uprobe_analyze_insn(struct arch if (addr 0x03) return -EINVAL; - /* -* We currently don't support a uprobe on an already -* existing breakpoint instruction underneath -*/ - if (is_trap(auprobe-ainsn)) - return -ENOTSUPP; return 0; } -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
