Re: [PATCH v2 4/5] arm64: dts: rockchip: add thermal nodes for rk3328 SoC

[Heiko Stuebner]

Am Freitag, 4. August 2017, 16:06:15 CEST schrieb Rocky Hao:
> add thermal zone and dynamic CPU power coefficients for rk3328
> 
> Signed-off-by: Rocky Hao 

applied for 4.14 after dropping the unnecessary property-comments.


Thanks
Heiko

Re: [PATCH v2 4/5] arm64: dts: rockchip: add thermal nodes for rk3328 SoC

[Heiko Stuebner]

Am Freitag, 4. August 2017, 16:06:15 CEST schrieb Rocky Hao:
> add thermal zone and dynamic CPU power coefficients for rk3328
> 
> Signed-off-by: Rocky Hao 

applied for 4.14 after dropping the unnecessary property-comments.


Thanks
Heiko

Re: [PATCH v2 4/5] arm64: dts: rockchip: add thermal nodes for rk3328 SoC

[Heiko Stuebner]

Hi Rocky,

Am Freitag, 11. August 2017, 17:46:55 CEST schrieb rocky.hao:
> Hi Caesar,
> Thanks for your comments.

just to add, there is no need to resend, I can drop the comments
here myself when applying :-)


Heiko

> Best Regards,
> Rocky
> 
> 在 2017/8/11 14:44, Caesar Wang 写道:
> > 在 2017年08月04日 16:06, Rocky Hao 写道:
> >> add thermal zone and dynamic CPU power coefficients for rk3328
> >>
> >> Signed-off-by: Rocky Hao 
> >> ---
> >> Change in v2:
> >> - remove gerrit Change-Id
> >>
> >>   arch/arm64/boot/dts/rockchip/rk3328.dtsi | 43 
> >> 
> >>   1 file changed, 43 insertions(+)
> >>
> >> diff --git a/arch/arm64/boot/dts/rockchip/rk3328.dtsi 
> >> b/arch/arm64/boot/dts/rockchip/rk3328.dtsi
> >> index 186fb93fdffd..68829f808320 100644
> >> --- a/arch/arm64/boot/dts/rockchip/rk3328.dtsi
> >> +++ b/arch/arm64/boot/dts/rockchip/rk3328.dtsi
> >> @@ -47,6 +47,7 @@
> >>   #include 
> >>   #include 
> >>   #include 
> >> +#include 
> >>   / {
> >>   compatible = "rockchip,rk3328";
> >> @@ -74,6 +75,8 @@
> >>   compatible = "arm,cortex-a53", "arm,armv8";
> >>   reg = <0x0 0x0>;
> >>   clocks = < ARMCLK>;
> >> +#cooling-cells = <2>; /* min followed by max */
> >> +dynamic-power-coefficient = <120>;
> >>   enable-method = "psci";
> >>   next-level-cache = <>;
> >>   };
> >> @@ -83,6 +86,7 @@
> >>   compatible = "arm,cortex-a53", "arm,armv8";
> >>   reg = <0x0 0x1>;
> >>   clocks = < ARMCLK>;
> >> +dynamic-power-coefficient = <120>;
> >>   enable-method = "psci";
> >>   next-level-cache = <>;
> >>   };
> >> @@ -92,6 +96,7 @@
> >>   compatible = "arm,cortex-a53", "arm,armv8";
> >>   reg = <0x0 0x2>;
> >>   clocks = < ARMCLK>;
> >> +dynamic-power-coefficient = <120>;
> >>   enable-method = "psci";
> >>   next-level-cache = <>;
> >>   };
> >> @@ -101,6 +106,7 @@
> >>   compatible = "arm,cortex-a53", "arm,armv8";
> >>   reg = <0x0 0x3>;
> >>   clocks = < ARMCLK>;
> >> +dynamic-power-coefficient = <120>;
> >>   enable-method = "psci";
> >>   next-level-cache = <>;
> >>   };
> >> @@ -308,6 +314,43 @@
> >>   interrupts = ;
> >>   };
> >> +thermal-zones {
> >> +soc_thermal: soc-thermal {
> >> +polling-delay-passive = <20>; /* milliseconds */
> >> +polling-delay = <1000>; /* milliseconds */
> >> +sustainable-power = <1000>; /* milliwatts */
> >> +
> >> +thermal-sensors = < 0>;
> >> +
> >> +trips {
> >> +threshold: trip-point0 {
> >> +temperature = <7>; /* millicelsius */
> >> +hysteresis = <2000>; /* millicelsius */
> >> +type = "passive";
> >> +};
> >> +target: trip-point1 {
> >> +temperature = <85000>; /* millicelsius */
> >> +hysteresis = <2000>; /* millicelsius */
> >> +type = "passive";
> >> +};
> >> +soc_crit: soc-crit {
> >> +temperature = <95000>; /* millicelsius */
> >> +hysteresis = <2000>; /* millicelsius */
> > 
> > The document had already described, maybe we should remove the 
> > millicelsius/milliseconds/milliwatts here.
> It is ok for me.
> >> +type = "critical";
> >> +};
> >> +};
> >> +
> >> +cooling-maps {
> >> +map0 {
> >> +trip = <>;
> >> +cooling-device = < THERMAL_NO_LIMIT 
> >> THERMAL_NO_LIMIT>;
> >> +contribution = <4096>;
> >> +};
> >> +};
> >> +};
> >> +
> >> +};
> >> +
> >>   tsadc: tsadc@ff25 {
> >>   compatible = "rockchip,rk3328-tsadc";
> >>   reg = <0x0 0xff25 0x0 0x100>;
> > 
> > 
> > 
> > 
> 
> 
> 

Re: [PATCH v2 4/5] arm64: dts: rockchip: add thermal nodes for rk3328 SoC

[Heiko Stuebner]

Hi Rocky,

Am Freitag, 11. August 2017, 17:46:55 CEST schrieb rocky.hao:
> Hi Caesar,
> Thanks for your comments.

just to add, there is no need to resend, I can drop the comments
here myself when applying :-)


Heiko

> Best Regards,
> Rocky
> 
> 在 2017/8/11 14:44, Caesar Wang 写道:
> > 在 2017年08月04日 16:06, Rocky Hao 写道:
> >> add thermal zone and dynamic CPU power coefficients for rk3328
> >>
> >> Signed-off-by: Rocky Hao 
> >> ---
> >> Change in v2:
> >> - remove gerrit Change-Id
> >>
> >>   arch/arm64/boot/dts/rockchip/rk3328.dtsi | 43 
> >> 
> >>   1 file changed, 43 insertions(+)
> >>
> >> diff --git a/arch/arm64/boot/dts/rockchip/rk3328.dtsi 
> >> b/arch/arm64/boot/dts/rockchip/rk3328.dtsi
> >> index 186fb93fdffd..68829f808320 100644
> >> --- a/arch/arm64/boot/dts/rockchip/rk3328.dtsi
> >> +++ b/arch/arm64/boot/dts/rockchip/rk3328.dtsi
> >> @@ -47,6 +47,7 @@
> >>   #include 
> >>   #include 
> >>   #include 
> >> +#include 
> >>   / {
> >>   compatible = "rockchip,rk3328";
> >> @@ -74,6 +75,8 @@
> >>   compatible = "arm,cortex-a53", "arm,armv8";
> >>   reg = <0x0 0x0>;
> >>   clocks = < ARMCLK>;
> >> +#cooling-cells = <2>; /* min followed by max */
> >> +dynamic-power-coefficient = <120>;
> >>   enable-method = "psci";
> >>   next-level-cache = <>;
> >>   };
> >> @@ -83,6 +86,7 @@
> >>   compatible = "arm,cortex-a53", "arm,armv8";
> >>   reg = <0x0 0x1>;
> >>   clocks = < ARMCLK>;
> >> +dynamic-power-coefficient = <120>;
> >>   enable-method = "psci";
> >>   next-level-cache = <>;
> >>   };
> >> @@ -92,6 +96,7 @@
> >>   compatible = "arm,cortex-a53", "arm,armv8";
> >>   reg = <0x0 0x2>;
> >>   clocks = < ARMCLK>;
> >> +dynamic-power-coefficient = <120>;
> >>   enable-method = "psci";
> >>   next-level-cache = <>;
> >>   };
> >> @@ -101,6 +106,7 @@
> >>   compatible = "arm,cortex-a53", "arm,armv8";
> >>   reg = <0x0 0x3>;
> >>   clocks = < ARMCLK>;
> >> +dynamic-power-coefficient = <120>;
> >>   enable-method = "psci";
> >>   next-level-cache = <>;
> >>   };
> >> @@ -308,6 +314,43 @@
> >>   interrupts = ;
> >>   };
> >> +thermal-zones {
> >> +soc_thermal: soc-thermal {
> >> +polling-delay-passive = <20>; /* milliseconds */
> >> +polling-delay = <1000>; /* milliseconds */
> >> +sustainable-power = <1000>; /* milliwatts */
> >> +
> >> +thermal-sensors = < 0>;
> >> +
> >> +trips {
> >> +threshold: trip-point0 {
> >> +temperature = <7>; /* millicelsius */
> >> +hysteresis = <2000>; /* millicelsius */
> >> +type = "passive";
> >> +};
> >> +target: trip-point1 {
> >> +temperature = <85000>; /* millicelsius */
> >> +hysteresis = <2000>; /* millicelsius */
> >> +type = "passive";
> >> +};
> >> +soc_crit: soc-crit {
> >> +temperature = <95000>; /* millicelsius */
> >> +hysteresis = <2000>; /* millicelsius */
> > 
> > The document had already described, maybe we should remove the 
> > millicelsius/milliseconds/milliwatts here.
> It is ok for me.
> >> +type = "critical";
> >> +};
> >> +};
> >> +
> >> +cooling-maps {
> >> +map0 {
> >> +trip = <>;
> >> +cooling-device = < THERMAL_NO_LIMIT 
> >> THERMAL_NO_LIMIT>;
> >> +contribution = <4096>;
> >> +};
> >> +};
> >> +};
> >> +
> >> +};
> >> +
> >>   tsadc: tsadc@ff25 {
> >>   compatible = "rockchip,rk3328-tsadc";
> >>   reg = <0x0 0xff25 0x0 0x100>;
> > 
> > 
> > 
> > 
> 
> 
> 

Re: [PATCH v2 4/5] arm64: dts: rockchip: add thermal nodes for rk3328 SoC

[rocky.hao]

Hi Caesar,
Thanks for your comments.

Best Regards,
Rocky

在 2017/8/11 14:44, Caesar Wang 写道:

在 2017年08月04日 16:06, Rocky Hao 写道:

add thermal zone and dynamic CPU power coefficients for rk3328

Signed-off-by: Rocky Hao 
---
Change in v2:
- remove gerrit Change-Id

  arch/arm64/boot/dts/rockchip/rk3328.dtsi | 43 


  1 file changed, 43 insertions(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3328.dtsi 
b/arch/arm64/boot/dts/rockchip/rk3328.dtsi

index 186fb93fdffd..68829f808320 100644
--- a/arch/arm64/boot/dts/rockchip/rk3328.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3328.dtsi
@@ -47,6 +47,7 @@
  #include 
  #include 
  #include 
+#include 
  / {
  compatible = "rockchip,rk3328";
@@ -74,6 +75,8 @@
  compatible = "arm,cortex-a53", "arm,armv8";
  reg = <0x0 0x0>;
  clocks = < ARMCLK>;
+#cooling-cells = <2>; /* min followed by max */
+dynamic-power-coefficient = <120>;
  enable-method = "psci";
  next-level-cache = <>;
  };
@@ -83,6 +86,7 @@
  compatible = "arm,cortex-a53", "arm,armv8";
  reg = <0x0 0x1>;
  clocks = < ARMCLK>;
+dynamic-power-coefficient = <120>;
  enable-method = "psci";
  next-level-cache = <>;
  };
@@ -92,6 +96,7 @@
  compatible = "arm,cortex-a53", "arm,armv8";
  reg = <0x0 0x2>;
  clocks = < ARMCLK>;
+dynamic-power-coefficient = <120>;
  enable-method = "psci";
  next-level-cache = <>;
  };
@@ -101,6 +106,7 @@
  compatible = "arm,cortex-a53", "arm,armv8";
  reg = <0x0 0x3>;
  clocks = < ARMCLK>;
+dynamic-power-coefficient = <120>;
  enable-method = "psci";
  next-level-cache = <>;
  };
@@ -308,6 +314,43 @@
  interrupts = ;
  };
+thermal-zones {
+soc_thermal: soc-thermal {
+polling-delay-passive = <20>; /* milliseconds */
+polling-delay = <1000>; /* milliseconds */
+sustainable-power = <1000>; /* milliwatts */
+
+thermal-sensors = < 0>;
+
+trips {
+threshold: trip-point0 {
+temperature = <7>; /* millicelsius */
+hysteresis = <2000>; /* millicelsius */
+type = "passive";
+};
+target: trip-point1 {
+temperature = <85000>; /* millicelsius */
+hysteresis = <2000>; /* millicelsius */
+type = "passive";
+};
+soc_crit: soc-crit {
+temperature = <95000>; /* millicelsius */
+hysteresis = <2000>; /* millicelsius */


The document had already described, maybe we should remove the 
millicelsius/milliseconds/milliwatts here.

It is ok for me.

+type = "critical";
+};
+};
+
+cooling-maps {
+map0 {
+trip = <>;
+cooling-device = < THERMAL_NO_LIMIT 
THERMAL_NO_LIMIT>;

+contribution = <4096>;
+};
+};
+};
+
+};
+
  tsadc: tsadc@ff25 {
  compatible = "rockchip,rk3328-tsadc";
  reg = <0x0 0xff25 0x0 0x100>;

Re: [PATCH v2 4/5] arm64: dts: rockchip: add thermal nodes for rk3328 SoC

[rocky.hao]

Hi Caesar,
Thanks for your comments.

Best Regards,
Rocky

在 2017/8/11 14:44, Caesar Wang 写道:

在 2017年08月04日 16:06, Rocky Hao 写道:

add thermal zone and dynamic CPU power coefficients for rk3328

Signed-off-by: Rocky Hao 
---
Change in v2:
- remove gerrit Change-Id

  arch/arm64/boot/dts/rockchip/rk3328.dtsi | 43 


  1 file changed, 43 insertions(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3328.dtsi 
b/arch/arm64/boot/dts/rockchip/rk3328.dtsi

index 186fb93fdffd..68829f808320 100644
--- a/arch/arm64/boot/dts/rockchip/rk3328.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3328.dtsi
@@ -47,6 +47,7 @@
  #include 
  #include 
  #include 
+#include 
  / {
  compatible = "rockchip,rk3328";
@@ -74,6 +75,8 @@
  compatible = "arm,cortex-a53", "arm,armv8";
  reg = <0x0 0x0>;
  clocks = < ARMCLK>;
+#cooling-cells = <2>; /* min followed by max */
+dynamic-power-coefficient = <120>;
  enable-method = "psci";
  next-level-cache = <>;
  };
@@ -83,6 +86,7 @@
  compatible = "arm,cortex-a53", "arm,armv8";
  reg = <0x0 0x1>;
  clocks = < ARMCLK>;
+dynamic-power-coefficient = <120>;
  enable-method = "psci";
  next-level-cache = <>;
  };
@@ -92,6 +96,7 @@
  compatible = "arm,cortex-a53", "arm,armv8";
  reg = <0x0 0x2>;
  clocks = < ARMCLK>;
+dynamic-power-coefficient = <120>;
  enable-method = "psci";
  next-level-cache = <>;
  };
@@ -101,6 +106,7 @@
  compatible = "arm,cortex-a53", "arm,armv8";
  reg = <0x0 0x3>;
  clocks = < ARMCLK>;
+dynamic-power-coefficient = <120>;
  enable-method = "psci";
  next-level-cache = <>;
  };
@@ -308,6 +314,43 @@
  interrupts = ;
  };
+thermal-zones {
+soc_thermal: soc-thermal {
+polling-delay-passive = <20>; /* milliseconds */
+polling-delay = <1000>; /* milliseconds */
+sustainable-power = <1000>; /* milliwatts */
+
+thermal-sensors = < 0>;
+
+trips {
+threshold: trip-point0 {
+temperature = <7>; /* millicelsius */
+hysteresis = <2000>; /* millicelsius */
+type = "passive";
+};
+target: trip-point1 {
+temperature = <85000>; /* millicelsius */
+hysteresis = <2000>; /* millicelsius */
+type = "passive";
+};
+soc_crit: soc-crit {
+temperature = <95000>; /* millicelsius */
+hysteresis = <2000>; /* millicelsius */


The document had already described, maybe we should remove the 
millicelsius/milliseconds/milliwatts here.

It is ok for me.

+type = "critical";
+};
+};
+
+cooling-maps {
+map0 {
+trip = <>;
+cooling-device = < THERMAL_NO_LIMIT 
THERMAL_NO_LIMIT>;

+contribution = <4096>;
+};
+};
+};
+
+};
+
  tsadc: tsadc@ff25 {
  compatible = "rockchip,rk3328-tsadc";
  reg = <0x0 0xff25 0x0 0x100>;

Re: [PATCH v2 4/5] arm64: dts: rockchip: add thermal nodes for rk3328 SoC

[Caesar Wang]

在 2017年08月04日 16:06, Rocky Hao 写道:

add thermal zone and dynamic CPU power coefficients for rk3328

Signed-off-by: Rocky Hao 
---
Change in v2:
- remove gerrit Change-Id

  arch/arm64/boot/dts/rockchip/rk3328.dtsi | 43 
  1 file changed, 43 insertions(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3328.dtsi 
b/arch/arm64/boot/dts/rockchip/rk3328.dtsi
index 186fb93fdffd..68829f808320 100644
--- a/arch/arm64/boot/dts/rockchip/rk3328.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3328.dtsi
@@ -47,6 +47,7 @@
  #include 
  #include 
  #include 
+#include 
  
  / {

compatible = "rockchip,rk3328";
@@ -74,6 +75,8 @@
compatible = "arm,cortex-a53", "arm,armv8";
reg = <0x0 0x0>;
clocks = < ARMCLK>;
+   #cooling-cells = <2>; /* min followed by max */
+   dynamic-power-coefficient = <120>;
enable-method = "psci";
next-level-cache = <>;
};
@@ -83,6 +86,7 @@
compatible = "arm,cortex-a53", "arm,armv8";
reg = <0x0 0x1>;
clocks = < ARMCLK>;
+   dynamic-power-coefficient = <120>;
enable-method = "psci";
next-level-cache = <>;
};
@@ -92,6 +96,7 @@
compatible = "arm,cortex-a53", "arm,armv8";
reg = <0x0 0x2>;
clocks = < ARMCLK>;
+   dynamic-power-coefficient = <120>;
enable-method = "psci";
next-level-cache = <>;
};
@@ -101,6 +106,7 @@
compatible = "arm,cortex-a53", "arm,armv8";
reg = <0x0 0x3>;
clocks = < ARMCLK>;
+   dynamic-power-coefficient = <120>;
enable-method = "psci";
next-level-cache = <>;
};
@@ -308,6 +314,43 @@
interrupts = ;
};
  
+	thermal-zones {

+   soc_thermal: soc-thermal {
+   polling-delay-passive = <20>; /* milliseconds */
+   polling-delay = <1000>; /* milliseconds */
+   sustainable-power = <1000>; /* milliwatts */
+
+   thermal-sensors = < 0>;
+
+   trips {
+   threshold: trip-point0 {
+   temperature = <7>; /* millicelsius 
*/
+   hysteresis = <2000>; /* millicelsius */
+   type = "passive";
+   };
+   target: trip-point1 {
+   temperature = <85000>; /* millicelsius 
*/
+   hysteresis = <2000>; /* millicelsius */
+   type = "passive";
+   };
+   soc_crit: soc-crit {
+   temperature = <95000>; /* millicelsius 
*/
+   hysteresis = <2000>; /* millicelsius */


The document had already described, maybe we should remove the 
millicelsius/milliseconds/milliwatts here.

+   type = "critical";
+   };
+   };
+
+   cooling-maps {
+   map0 {
+   trip = <>;
+   cooling-device = < THERMAL_NO_LIMIT 
THERMAL_NO_LIMIT>;
+   contribution = <4096>;
+   };
+   };
+   };
+
+   };
+
tsadc: tsadc@ff25 {
compatible = "rockchip,rk3328-tsadc";
reg = <0x0 0xff25 0x0 0x100>;

Re: [PATCH v2 4/5] arm64: dts: rockchip: add thermal nodes for rk3328 SoC

[Caesar Wang]

在 2017年08月04日 16:06, Rocky Hao 写道:

add thermal zone and dynamic CPU power coefficients for rk3328

Signed-off-by: Rocky Hao 
---
Change in v2:
- remove gerrit Change-Id

  arch/arm64/boot/dts/rockchip/rk3328.dtsi | 43 
  1 file changed, 43 insertions(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3328.dtsi 
b/arch/arm64/boot/dts/rockchip/rk3328.dtsi
index 186fb93fdffd..68829f808320 100644
--- a/arch/arm64/boot/dts/rockchip/rk3328.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3328.dtsi
@@ -47,6 +47,7 @@
  #include 
  #include 
  #include 
+#include 
  
  / {

compatible = "rockchip,rk3328";
@@ -74,6 +75,8 @@
compatible = "arm,cortex-a53", "arm,armv8";
reg = <0x0 0x0>;
clocks = < ARMCLK>;
+   #cooling-cells = <2>; /* min followed by max */
+   dynamic-power-coefficient = <120>;
enable-method = "psci";
next-level-cache = <>;
};
@@ -83,6 +86,7 @@
compatible = "arm,cortex-a53", "arm,armv8";
reg = <0x0 0x1>;
clocks = < ARMCLK>;
+   dynamic-power-coefficient = <120>;
enable-method = "psci";
next-level-cache = <>;
};
@@ -92,6 +96,7 @@
compatible = "arm,cortex-a53", "arm,armv8";
reg = <0x0 0x2>;
clocks = < ARMCLK>;
+   dynamic-power-coefficient = <120>;
enable-method = "psci";
next-level-cache = <>;
};
@@ -101,6 +106,7 @@
compatible = "arm,cortex-a53", "arm,armv8";
reg = <0x0 0x3>;
clocks = < ARMCLK>;
+   dynamic-power-coefficient = <120>;
enable-method = "psci";
next-level-cache = <>;
};
@@ -308,6 +314,43 @@
interrupts = ;
};
  
+	thermal-zones {

+   soc_thermal: soc-thermal {
+   polling-delay-passive = <20>; /* milliseconds */
+   polling-delay = <1000>; /* milliseconds */
+   sustainable-power = <1000>; /* milliwatts */
+
+   thermal-sensors = < 0>;
+
+   trips {
+   threshold: trip-point0 {
+   temperature = <7>; /* millicelsius 
*/
+   hysteresis = <2000>; /* millicelsius */
+   type = "passive";
+   };
+   target: trip-point1 {
+   temperature = <85000>; /* millicelsius 
*/
+   hysteresis = <2000>; /* millicelsius */
+   type = "passive";
+   };
+   soc_crit: soc-crit {
+   temperature = <95000>; /* millicelsius 
*/
+   hysteresis = <2000>; /* millicelsius */


The document had already described, maybe we should remove the 
millicelsius/milliseconds/milliwatts here.

+   type = "critical";
+   };
+   };
+
+   cooling-maps {
+   map0 {
+   trip = <>;
+   cooling-device = < THERMAL_NO_LIMIT 
THERMAL_NO_LIMIT>;
+   contribution = <4096>;
+   };
+   };
+   };
+
+   };
+
tsadc: tsadc@ff25 {
compatible = "rockchip,rk3328-tsadc";
reg = <0x0 0xff25 0x0 0x100>;

[PATCH v2 4/5] arm64: dts: rockchip: add thermal nodes for rk3328 SoC

[Rocky Hao]

add thermal zone and dynamic CPU power coefficients for rk3328

Signed-off-by: Rocky Hao 
---
Change in v2:
- remove gerrit Change-Id

 arch/arm64/boot/dts/rockchip/rk3328.dtsi | 43 
 1 file changed, 43 insertions(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3328.dtsi 
b/arch/arm64/boot/dts/rockchip/rk3328.dtsi
index 186fb93fdffd..68829f808320 100644
--- a/arch/arm64/boot/dts/rockchip/rk3328.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3328.dtsi
@@ -47,6 +47,7 @@
 #include 
 #include 
 #include 
+#include 
 
 / {
compatible = "rockchip,rk3328";
@@ -74,6 +75,8 @@
compatible = "arm,cortex-a53", "arm,armv8";
reg = <0x0 0x0>;
clocks = < ARMCLK>;
+   #cooling-cells = <2>; /* min followed by max */
+   dynamic-power-coefficient = <120>;
enable-method = "psci";
next-level-cache = <>;
};
@@ -83,6 +86,7 @@
compatible = "arm,cortex-a53", "arm,armv8";
reg = <0x0 0x1>;
clocks = < ARMCLK>;
+   dynamic-power-coefficient = <120>;
enable-method = "psci";
next-level-cache = <>;
};
@@ -92,6 +96,7 @@
compatible = "arm,cortex-a53", "arm,armv8";
reg = <0x0 0x2>;
clocks = < ARMCLK>;
+   dynamic-power-coefficient = <120>;
enable-method = "psci";
next-level-cache = <>;
};
@@ -101,6 +106,7 @@
compatible = "arm,cortex-a53", "arm,armv8";
reg = <0x0 0x3>;
clocks = < ARMCLK>;
+   dynamic-power-coefficient = <120>;
enable-method = "psci";
next-level-cache = <>;
};
@@ -308,6 +314,43 @@
interrupts = ;
};
 
+   thermal-zones {
+   soc_thermal: soc-thermal {
+   polling-delay-passive = <20>; /* milliseconds */
+   polling-delay = <1000>; /* milliseconds */
+   sustainable-power = <1000>; /* milliwatts */
+
+   thermal-sensors = < 0>;
+
+   trips {
+   threshold: trip-point0 {
+   temperature = <7>; /* millicelsius 
*/
+   hysteresis = <2000>; /* millicelsius */
+   type = "passive";
+   };
+   target: trip-point1 {
+   temperature = <85000>; /* millicelsius 
*/
+   hysteresis = <2000>; /* millicelsius */
+   type = "passive";
+   };
+   soc_crit: soc-crit {
+   temperature = <95000>; /* millicelsius 
*/
+   hysteresis = <2000>; /* millicelsius */
+   type = "critical";
+   };
+   };
+
+   cooling-maps {
+   map0 {
+   trip = <>;
+   cooling-device = < 
THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
+   contribution = <4096>;
+   };
+   };
+   };
+
+   };
+
tsadc: tsadc@ff25 {
compatible = "rockchip,rk3328-tsadc";
reg = <0x0 0xff25 0x0 0x100>;
-- 
1.9.1

[PATCH v2 4/5] arm64: dts: rockchip: add thermal nodes for rk3328 SoC

[Rocky Hao]

add thermal zone and dynamic CPU power coefficients for rk3328

Signed-off-by: Rocky Hao 
---
Change in v2:
- remove gerrit Change-Id

 arch/arm64/boot/dts/rockchip/rk3328.dtsi | 43 
 1 file changed, 43 insertions(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3328.dtsi 
b/arch/arm64/boot/dts/rockchip/rk3328.dtsi
index 186fb93fdffd..68829f808320 100644
--- a/arch/arm64/boot/dts/rockchip/rk3328.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3328.dtsi
@@ -47,6 +47,7 @@
 #include 
 #include 
 #include 
+#include 
 
 / {
compatible = "rockchip,rk3328";
@@ -74,6 +75,8 @@
compatible = "arm,cortex-a53", "arm,armv8";
reg = <0x0 0x0>;
clocks = < ARMCLK>;
+   #cooling-cells = <2>; /* min followed by max */
+   dynamic-power-coefficient = <120>;
enable-method = "psci";
next-level-cache = <>;
};
@@ -83,6 +86,7 @@
compatible = "arm,cortex-a53", "arm,armv8";
reg = <0x0 0x1>;
clocks = < ARMCLK>;
+   dynamic-power-coefficient = <120>;
enable-method = "psci";
next-level-cache = <>;
};
@@ -92,6 +96,7 @@
compatible = "arm,cortex-a53", "arm,armv8";
reg = <0x0 0x2>;
clocks = < ARMCLK>;
+   dynamic-power-coefficient = <120>;
enable-method = "psci";
next-level-cache = <>;
};
@@ -101,6 +106,7 @@
compatible = "arm,cortex-a53", "arm,armv8";
reg = <0x0 0x3>;
clocks = < ARMCLK>;
+   dynamic-power-coefficient = <120>;
enable-method = "psci";
next-level-cache = <>;
};
@@ -308,6 +314,43 @@
interrupts = ;
};
 
+   thermal-zones {
+   soc_thermal: soc-thermal {
+   polling-delay-passive = <20>; /* milliseconds */
+   polling-delay = <1000>; /* milliseconds */
+   sustainable-power = <1000>; /* milliwatts */
+
+   thermal-sensors = < 0>;
+
+   trips {
+   threshold: trip-point0 {
+   temperature = <7>; /* millicelsius 
*/
+   hysteresis = <2000>; /* millicelsius */
+   type = "passive";
+   };
+   target: trip-point1 {
+   temperature = <85000>; /* millicelsius 
*/
+   hysteresis = <2000>; /* millicelsius */
+   type = "passive";
+   };
+   soc_crit: soc-crit {
+   temperature = <95000>; /* millicelsius 
*/
+   hysteresis = <2000>; /* millicelsius */
+   type = "critical";
+   };
+   };
+
+   cooling-maps {
+   map0 {
+   trip = <>;
+   cooling-device = < 
THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
+   contribution = <4096>;
+   };
+   };
+   };
+
+   };
+
tsadc: tsadc@ff25 {
compatible = "rockchip,rk3328-tsadc";
reg = <0x0 0xff25 0x0 0x100>;
-- 
1.9.1