Re: [PATCH v2 5/6] DT bindings documentation for Broadcom IPROC USB Device controller.

2017-02-27 Thread Rob Herring 
On Tue, Feb 21, 2017 at 05:13:03PM +0530, Raviteja Garimella wrote:
> The device node is used for UDCs integrated into Broadcom's
> iProc family of SoCs'. The UDC is based on Synopsys Designware
> Cores AHB Subsystem USB Device Controller IP.

For subject:
dt-bindings: usb: Add Broadcom IPROC USB Device controller

> 
> Signed-off-by: Raviteja Garimella 
> ---
>  Documentation/devicetree/bindings/usb/iproc-udc.txt | 21 
> +
>  1 file changed, 21 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/usb/iproc-udc.txt
> 
> diff --git a/Documentation/devicetree/bindings/usb/iproc-udc.txt 
> b/Documentation/devicetree/bindings/usb/iproc-udc.txt
> new file mode 100644
> index 000..c2ce803
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/iproc-udc.txt
> @@ -0,0 +1,21 @@
> +Broadcom IPROC USB Device controller.
> +
> +The device node is used for UDCs integrated into Broadcom's
> +iProc family (Northstar2, Cygnus) of SoCs'. The UDC is based
> +on Synopsys Designware Cores AHB Subsystem Device Controller
> +IP.
> +
> +Required properties:
> + - compatible: Add the compatibility strings for supported platforms.
> +   For Broadcom NS2 platform, add "brcm,ns2-udc".
> +   For Broadcom Cygnus platform, add "brcm,cygnus-udc".
> + - reg: Offset and length of UDC register set
> + - interrupts: description of interrupt line
> + - phys: phandle to phy node.
> +
> +Example:
> + udc_dwc: usb@664e {
> + compatible = "brcm,ns2-udc", "brcm,cygnus-udc";

This doesn't look right?

> + reg = <0x664e 0x2000>;
> + interrupts = ;
> + phys = <_phy>;
> -- 
> 2.1.0
>

Re: [PATCH v2 5/6] DT bindings documentation for Broadcom IPROC USB Device controller.

2017-02-27 Thread Rob Herring 
On Tue, Feb 21, 2017 at 05:13:03PM +0530, Raviteja Garimella wrote:
> The device node is used for UDCs integrated into Broadcom's
> iProc family of SoCs'. The UDC is based on Synopsys Designware
> Cores AHB Subsystem USB Device Controller IP.

For subject:
dt-bindings: usb: Add Broadcom IPROC USB Device controller

> 
> Signed-off-by: Raviteja Garimella 
> ---
>  Documentation/devicetree/bindings/usb/iproc-udc.txt | 21 
> +
>  1 file changed, 21 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/usb/iproc-udc.txt
> 
> diff --git a/Documentation/devicetree/bindings/usb/iproc-udc.txt 
> b/Documentation/devicetree/bindings/usb/iproc-udc.txt
> new file mode 100644
> index 000..c2ce803
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/iproc-udc.txt
> @@ -0,0 +1,21 @@
> +Broadcom IPROC USB Device controller.
> +
> +The device node is used for UDCs integrated into Broadcom's
> +iProc family (Northstar2, Cygnus) of SoCs'. The UDC is based
> +on Synopsys Designware Cores AHB Subsystem Device Controller
> +IP.
> +
> +Required properties:
> + - compatible: Add the compatibility strings for supported platforms.
> +   For Broadcom NS2 platform, add "brcm,ns2-udc".
> +   For Broadcom Cygnus platform, add "brcm,cygnus-udc".
> + - reg: Offset and length of UDC register set
> + - interrupts: description of interrupt line
> + - phys: phandle to phy node.
> +
> +Example:
> + udc_dwc: usb@664e {
> + compatible = "brcm,ns2-udc", "brcm,cygnus-udc";

This doesn't look right?

> + reg = <0x664e 0x2000>;
> + interrupts = ;
> + phys = <_phy>;
> -- 
> 2.1.0
>

Re: [PATCH v2 5/6] DT bindings documentation for Broadcom IPROC USB Device controller.

2017-02-21 Thread Scott Branden 

Hi Raviteja,

updates inline

On 17-02-21 03:43 AM, Raviteja Garimella wrote:

The device node is used for UDCs integrated into Broadcom's
iProc family of SoCs'. The UDC is based on Synopsys Designware
Cores AHB Subsystem USB Device Controller IP.

Signed-off-by: Raviteja Garimella 
---
 Documentation/devicetree/bindings/usb/iproc-udc.txt | 21 +
 1 file changed, 21 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/usb/iproc-udc.txt

diff --git a/Documentation/devicetree/bindings/usb/iproc-udc.txt 
b/Documentation/devicetree/bindings/usb/iproc-udc.txt
new file mode 100644
index 000..c2ce803
--- /dev/null
+++ b/Documentation/devicetree/bindings/usb/iproc-udc.txt
@@ -0,0 +1,21 @@
+Broadcom IPROC USB Device controller.
+
+The device node is used for UDCs integrated into Broadcom's
+iProc family (Northstar2, Cygnus) of SoCs'. The UDC is based
+on Synopsys Designware Cores AHB Subsystem Device Controller
+IP.
+
+Required properties:
+ - compatible: Add the compatibility strings for supported platforms.
+   For Broadcom NS2 platform, add "brcm,ns2-udc".

   For Broadcom NS2 platform, add "brcm,ns2-udc", "brcm,iproc-udc".

+   For Broadcom Cygnus platform, add "brcm,cygnus-udc".

   For Broadcom Cygnus platform, add "brcm,cygnus-udc", "brcm,iproc-udc".

+ - reg: Offset and length of UDC register set
+ - interrupts: description of interrupt line
+ - phys: phandle to phy node.
+
+Example:
+   udc_dwc: usb@664e {
+   compatible = "brcm,ns2-udc", "brcm,cygnus-udc";

compatible = "brcm,ns2-udc", "brcm,iproc-udc";

+   reg = <0x664e 0x2000>;
+   interrupts = ;
+   phys = <_phy>;


Regards,
 Scott

Re: [PATCH v2 5/6] DT bindings documentation for Broadcom IPROC USB Device controller.

2017-02-21 Thread Scott Branden 

Hi Raviteja,

updates inline

On 17-02-21 03:43 AM, Raviteja Garimella wrote:

The device node is used for UDCs integrated into Broadcom's
iProc family of SoCs'. The UDC is based on Synopsys Designware
Cores AHB Subsystem USB Device Controller IP.

Signed-off-by: Raviteja Garimella 
---
 Documentation/devicetree/bindings/usb/iproc-udc.txt | 21 +
 1 file changed, 21 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/usb/iproc-udc.txt

diff --git a/Documentation/devicetree/bindings/usb/iproc-udc.txt 
b/Documentation/devicetree/bindings/usb/iproc-udc.txt
new file mode 100644
index 000..c2ce803
--- /dev/null
+++ b/Documentation/devicetree/bindings/usb/iproc-udc.txt
@@ -0,0 +1,21 @@
+Broadcom IPROC USB Device controller.
+
+The device node is used for UDCs integrated into Broadcom's
+iProc family (Northstar2, Cygnus) of SoCs'. The UDC is based
+on Synopsys Designware Cores AHB Subsystem Device Controller
+IP.
+
+Required properties:
+ - compatible: Add the compatibility strings for supported platforms.
+   For Broadcom NS2 platform, add "brcm,ns2-udc".

   For Broadcom NS2 platform, add "brcm,ns2-udc", "brcm,iproc-udc".

+   For Broadcom Cygnus platform, add "brcm,cygnus-udc".

   For Broadcom Cygnus platform, add "brcm,cygnus-udc", "brcm,iproc-udc".

+ - reg: Offset and length of UDC register set
+ - interrupts: description of interrupt line
+ - phys: phandle to phy node.
+
+Example:
+   udc_dwc: usb@664e {
+   compatible = "brcm,ns2-udc", "brcm,cygnus-udc";

compatible = "brcm,ns2-udc", "brcm,iproc-udc";

+   reg = <0x664e 0x2000>;
+   interrupts = ;
+   phys = <_phy>;


Regards,
 Scott

[PATCH v2 5/6] DT bindings documentation for Broadcom IPROC USB Device controller.

2017-02-21 Thread Raviteja Garimella 
The device node is used for UDCs integrated into Broadcom's
iProc family of SoCs'. The UDC is based on Synopsys Designware
Cores AHB Subsystem USB Device Controller IP.

Signed-off-by: Raviteja Garimella 
---
 Documentation/devicetree/bindings/usb/iproc-udc.txt | 21 +
 1 file changed, 21 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/usb/iproc-udc.txt

diff --git a/Documentation/devicetree/bindings/usb/iproc-udc.txt 
b/Documentation/devicetree/bindings/usb/iproc-udc.txt
new file mode 100644
index 000..c2ce803
--- /dev/null
+++ b/Documentation/devicetree/bindings/usb/iproc-udc.txt
@@ -0,0 +1,21 @@
+Broadcom IPROC USB Device controller.
+
+The device node is used for UDCs integrated into Broadcom's
+iProc family (Northstar2, Cygnus) of SoCs'. The UDC is based
+on Synopsys Designware Cores AHB Subsystem Device Controller
+IP.
+
+Required properties:
+ - compatible: Add the compatibility strings for supported platforms.
+   For Broadcom NS2 platform, add "brcm,ns2-udc".
+   For Broadcom Cygnus platform, add "brcm,cygnus-udc".
+ - reg: Offset and length of UDC register set
+ - interrupts: description of interrupt line
+ - phys: phandle to phy node.
+
+Example:
+   udc_dwc: usb@664e {
+   compatible = "brcm,ns2-udc", "brcm,cygnus-udc";
+   reg = <0x664e 0x2000>;
+   interrupts = ;
+   phys = <_phy>;
-- 
2.1.0

[PATCH v2 5/6] DT bindings documentation for Broadcom IPROC USB Device controller.

2017-02-21 Thread Raviteja Garimella 
The device node is used for UDCs integrated into Broadcom's
iProc family of SoCs'. The UDC is based on Synopsys Designware
Cores AHB Subsystem USB Device Controller IP.

Signed-off-by: Raviteja Garimella 
---
 Documentation/devicetree/bindings/usb/iproc-udc.txt | 21 +
 1 file changed, 21 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/usb/iproc-udc.txt

diff --git a/Documentation/devicetree/bindings/usb/iproc-udc.txt 
b/Documentation/devicetree/bindings/usb/iproc-udc.txt
new file mode 100644
index 000..c2ce803
--- /dev/null
+++ b/Documentation/devicetree/bindings/usb/iproc-udc.txt
@@ -0,0 +1,21 @@
+Broadcom IPROC USB Device controller.
+
+The device node is used for UDCs integrated into Broadcom's
+iProc family (Northstar2, Cygnus) of SoCs'. The UDC is based
+on Synopsys Designware Cores AHB Subsystem Device Controller
+IP.
+
+Required properties:
+ - compatible: Add the compatibility strings for supported platforms.
+   For Broadcom NS2 platform, add "brcm,ns2-udc".
+   For Broadcom Cygnus platform, add "brcm,cygnus-udc".
+ - reg: Offset and length of UDC register set
+ - interrupts: description of interrupt line
+ - phys: phandle to phy node.
+
+Example:
+   udc_dwc: usb@664e {
+   compatible = "brcm,ns2-udc", "brcm,cygnus-udc";
+   reg = <0x664e 0x2000>;
+   interrupts = ;
+   phys = <_phy>;
-- 
2.1.0