Re: [PATCH v2 omap 3/6] arm: Add _rcuidle tracepoints to allow clk_core_disable() use from idle
On Wed, May 18, 2016 at 05:24:51PM +0200, Mason wrote: > On 16/05/2016 20:50, Paul E. McKenney wrote: > > >> stack backtrace: > >> CPU: 0 PID: 0 Comm: swapper/0 Not tainted 4.6.0-rc5-next-20160426+ #1114 > >> Hardware name: Generic OMAP36xx (Flattened Device Tree) > >> [] (unwind_backtrace) from [] (show_stack+0x10/0x14) > >> [] (show_stack) from [] (dump_stack+0xb0/0xe4) > >> [] (dump_stack) from [] (clk_core_disable+0x17c/0x348) > >> [] (clk_core_disable) from [] (clk_disable+0x24/0x30) > >> [] (clk_disable) from [] (_disable_clocks+0x18/0x7c) > >> [] (_disable_clocks) from [] (_idle+0x12c/0x230) > >> [] (_idle) from [] (omap_hwmod_idle+0x24/0x44) > >> [] (omap_hwmod_idle) from [] > >> (omap_device_idle+0x3c/0x90) > >> [] (omap_device_idle) from [] > >> (__rpm_callback+0x2c/0x60) > >> [] (__rpm_callback) from [] (rpm_callback+0x20/0x80) > >> [] (rpm_callback) from [] (rpm_suspend+0x100/0x768) > >> [] (rpm_suspend) from [] > >> (__pm_runtime_suspend+0x64/0x84) > >> [] (__pm_runtime_suspend) from [] > >> (omap2_gpio_prepare_for_idle+0x5 > >> c/0x70) > >> [] (omap2_gpio_prepare_for_idle) from [] > >> (omap_sram_idle+0x140/0x2 > >> 44) > > Wouldn't the stack trace look better without the word wrap? :-) Truth in advertising!!! ;-) Thanx, Paul
Re: [PATCH v2 omap 3/6] arm: Add _rcuidle tracepoints to allow clk_core_disable() use from idle
On Wed, May 18, 2016 at 05:24:51PM +0200, Mason wrote: > On 16/05/2016 20:50, Paul E. McKenney wrote: > > >> stack backtrace: > >> CPU: 0 PID: 0 Comm: swapper/0 Not tainted 4.6.0-rc5-next-20160426+ #1114 > >> Hardware name: Generic OMAP36xx (Flattened Device Tree) > >> [] (unwind_backtrace) from [] (show_stack+0x10/0x14) > >> [] (show_stack) from [] (dump_stack+0xb0/0xe4) > >> [] (dump_stack) from [] (clk_core_disable+0x17c/0x348) > >> [] (clk_core_disable) from [] (clk_disable+0x24/0x30) > >> [] (clk_disable) from [] (_disable_clocks+0x18/0x7c) > >> [] (_disable_clocks) from [] (_idle+0x12c/0x230) > >> [] (_idle) from [] (omap_hwmod_idle+0x24/0x44) > >> [] (omap_hwmod_idle) from [] > >> (omap_device_idle+0x3c/0x90) > >> [] (omap_device_idle) from [] > >> (__rpm_callback+0x2c/0x60) > >> [] (__rpm_callback) from [] (rpm_callback+0x20/0x80) > >> [] (rpm_callback) from [] (rpm_suspend+0x100/0x768) > >> [] (rpm_suspend) from [] > >> (__pm_runtime_suspend+0x64/0x84) > >> [] (__pm_runtime_suspend) from [] > >> (omap2_gpio_prepare_for_idle+0x5 > >> c/0x70) > >> [] (omap2_gpio_prepare_for_idle) from [] > >> (omap_sram_idle+0x140/0x2 > >> 44) > > Wouldn't the stack trace look better without the word wrap? :-) Truth in advertising!!! ;-) Thanx, Paul
Re: [PATCH v2 omap 3/6] arm: Add _rcuidle tracepoints to allow clk_core_disable() use from idle
On 16/05/2016 20:50, Paul E. McKenney wrote: >> stack backtrace: >> CPU: 0 PID: 0 Comm: swapper/0 Not tainted 4.6.0-rc5-next-20160426+ #1114 >> Hardware name: Generic OMAP36xx (Flattened Device Tree) >> [] (unwind_backtrace) from [] (show_stack+0x10/0x14) >> [] (show_stack) from [] (dump_stack+0xb0/0xe4) >> [] (dump_stack) from [] (clk_core_disable+0x17c/0x348) >> [] (clk_core_disable) from [] (clk_disable+0x24/0x30) >> [] (clk_disable) from [] (_disable_clocks+0x18/0x7c) >> [] (_disable_clocks) from [] (_idle+0x12c/0x230) >> [] (_idle) from [] (omap_hwmod_idle+0x24/0x44) >> [] (omap_hwmod_idle) from [] (omap_device_idle+0x3c/0x90) >> [] (omap_device_idle) from [] (__rpm_callback+0x2c/0x60) >> [] (__rpm_callback) from [] (rpm_callback+0x20/0x80) >> [] (rpm_callback) from [] (rpm_suspend+0x100/0x768) >> [] (rpm_suspend) from [] (__pm_runtime_suspend+0x64/0x84) >> [] (__pm_runtime_suspend) from [] >> (omap2_gpio_prepare_for_idle+0x5 >> c/0x70) >> [] (omap2_gpio_prepare_for_idle) from [] >> (omap_sram_idle+0x140/0x2 >> 44) Wouldn't the stack trace look better without the word wrap? :-) Regards.
Re: [PATCH v2 omap 3/6] arm: Add _rcuidle tracepoints to allow clk_core_disable() use from idle
On 16/05/2016 20:50, Paul E. McKenney wrote: >> stack backtrace: >> CPU: 0 PID: 0 Comm: swapper/0 Not tainted 4.6.0-rc5-next-20160426+ #1114 >> Hardware name: Generic OMAP36xx (Flattened Device Tree) >> [] (unwind_backtrace) from [] (show_stack+0x10/0x14) >> [] (show_stack) from [] (dump_stack+0xb0/0xe4) >> [] (dump_stack) from [] (clk_core_disable+0x17c/0x348) >> [] (clk_core_disable) from [] (clk_disable+0x24/0x30) >> [] (clk_disable) from [] (_disable_clocks+0x18/0x7c) >> [] (_disable_clocks) from [] (_idle+0x12c/0x230) >> [] (_idle) from [] (omap_hwmod_idle+0x24/0x44) >> [] (omap_hwmod_idle) from [] (omap_device_idle+0x3c/0x90) >> [] (omap_device_idle) from [] (__rpm_callback+0x2c/0x60) >> [] (__rpm_callback) from [] (rpm_callback+0x20/0x80) >> [] (rpm_callback) from [] (rpm_suspend+0x100/0x768) >> [] (rpm_suspend) from [] (__pm_runtime_suspend+0x64/0x84) >> [] (__pm_runtime_suspend) from [] >> (omap2_gpio_prepare_for_idle+0x5 >> c/0x70) >> [] (omap2_gpio_prepare_for_idle) from [] >> (omap_sram_idle+0x140/0x2 >> 44) Wouldn't the stack trace look better without the word wrap? :-) Regards.
[PATCH v2 omap 3/6] arm: Add _rcuidle tracepoints to allow clk_core_disable() use from idle
This commit adds an _rcuidle suffix to a pair of trace events to
prevent the following splat:
> ===
> [ INFO: suspicious RCU usage. ]
> 4.6.0-rc5-next-20160426+ #1114 Not tainted
> ---
> include/trace/events/clk.h:59 suspicious rcu_dereference_check() usage!
>
> other info that might help us debug this:
>
>
> RCU used illegally from idle CPU!
> rcu_scheduler_active = 1, debug_locks = 0
> RCU used illegally from extended quiescent state!
> 2 locks held by swapper/0/0:
> #0: (>hwmod_key#30){..}, at: [] omap_hwmod_idle+0x18/0x44
> #1: (enable_lock){..}, at: [] clk_enable_lock+0x18/0x124
>
> stack backtrace:
> CPU: 0 PID: 0 Comm: swapper/0 Not tainted 4.6.0-rc5-next-20160426+ #1114
> Hardware name: Generic OMAP36xx (Flattened Device Tree)
> [] (unwind_backtrace) from [] (show_stack+0x10/0x14)
> [] (show_stack) from [] (dump_stack+0xb0/0xe4)
> [] (dump_stack) from [] (clk_core_disable+0x17c/0x348)
> [] (clk_core_disable) from [] (clk_disable+0x24/0x30)
> [] (clk_disable) from [] (_disable_clocks+0x18/0x7c)
> [] (_disable_clocks) from [] (_idle+0x12c/0x230)
> [] (_idle) from [] (omap_hwmod_idle+0x24/0x44)
> [] (omap_hwmod_idle) from [] (omap_device_idle+0x3c/0x90)
> [] (omap_device_idle) from [] (__rpm_callback+0x2c/0x60)
> [] (__rpm_callback) from [] (rpm_callback+0x20/0x80)
> [] (rpm_callback) from [] (rpm_suspend+0x100/0x768)
> [] (rpm_suspend) from [] (__pm_runtime_suspend+0x64/0x84)
> [] (__pm_runtime_suspend) from []
> (omap2_gpio_prepare_for_idle+0x5
> c/0x70)
> [] (omap2_gpio_prepare_for_idle) from []
> (omap_sram_idle+0x140/0x2
> 44)
> [] (omap_sram_idle) from []
> (omap3_enter_idle_bm+0xfc/0x1ec)
> [] (omap3_enter_idle_bm) from []
> (cpuidle_enter_state+0x80/0x3d4)
> [] (cpuidle_enter_state) from []
> (cpu_startup_entry+0x198/0x3a0)
> [] (cpu_startup_entry) from [] (start_kernel+0x354/0x3c8)
> [] (start_kernel) from [<8000807c>] (0x8000807c)
Reported-by: Tony Lindgren
Signed-off-by: Paul E. McKenney
Tested-by: Tony Lindgren
Cc: Russell King
Cc: Steven Rostedt
Cc: Michael Turquette
Cc: Stephen Boyd
Cc:
Cc:
Cc:
---
drivers/clk/clk.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
index fb74dc1f7520..4fa43c02d682 100644
--- a/drivers/clk/clk.c
+++ b/drivers/clk/clk.c
@@ -682,12 +682,12 @@ static void clk_core_disable(struct clk_core *core)
if (--core->enable_count > 0)
return;
- trace_clk_disable(core);
+ trace_clk_disable_rcuidle(core);
if (core->ops->disable)
core->ops->disable(core->hw);
- trace_clk_disable_complete(core);
+ trace_clk_disable_complete_rcuidle(core);
clk_core_disable(core->parent);
}
--
2.5.2
[PATCH v2 omap 3/6] arm: Add _rcuidle tracepoints to allow clk_core_disable() use from idle
This commit adds an _rcuidle suffix to a pair of trace events to
prevent the following splat:
> ===
> [ INFO: suspicious RCU usage. ]
> 4.6.0-rc5-next-20160426+ #1114 Not tainted
> ---
> include/trace/events/clk.h:59 suspicious rcu_dereference_check() usage!
>
> other info that might help us debug this:
>
>
> RCU used illegally from idle CPU!
> rcu_scheduler_active = 1, debug_locks = 0
> RCU used illegally from extended quiescent state!
> 2 locks held by swapper/0/0:
> #0: (>hwmod_key#30){..}, at: [] omap_hwmod_idle+0x18/0x44
> #1: (enable_lock){..}, at: [] clk_enable_lock+0x18/0x124
>
> stack backtrace:
> CPU: 0 PID: 0 Comm: swapper/0 Not tainted 4.6.0-rc5-next-20160426+ #1114
> Hardware name: Generic OMAP36xx (Flattened Device Tree)
> [] (unwind_backtrace) from [] (show_stack+0x10/0x14)
> [] (show_stack) from [] (dump_stack+0xb0/0xe4)
> [] (dump_stack) from [] (clk_core_disable+0x17c/0x348)
> [] (clk_core_disable) from [] (clk_disable+0x24/0x30)
> [] (clk_disable) from [] (_disable_clocks+0x18/0x7c)
> [] (_disable_clocks) from [] (_idle+0x12c/0x230)
> [] (_idle) from [] (omap_hwmod_idle+0x24/0x44)
> [] (omap_hwmod_idle) from [] (omap_device_idle+0x3c/0x90)
> [] (omap_device_idle) from [] (__rpm_callback+0x2c/0x60)
> [] (__rpm_callback) from [] (rpm_callback+0x20/0x80)
> [] (rpm_callback) from [] (rpm_suspend+0x100/0x768)
> [] (rpm_suspend) from [] (__pm_runtime_suspend+0x64/0x84)
> [] (__pm_runtime_suspend) from []
> (omap2_gpio_prepare_for_idle+0x5
> c/0x70)
> [] (omap2_gpio_prepare_for_idle) from []
> (omap_sram_idle+0x140/0x2
> 44)
> [] (omap_sram_idle) from []
> (omap3_enter_idle_bm+0xfc/0x1ec)
> [] (omap3_enter_idle_bm) from []
> (cpuidle_enter_state+0x80/0x3d4)
> [] (cpuidle_enter_state) from []
> (cpu_startup_entry+0x198/0x3a0)
> [] (cpu_startup_entry) from [] (start_kernel+0x354/0x3c8)
> [] (start_kernel) from [<8000807c>] (0x8000807c)
Reported-by: Tony Lindgren
Signed-off-by: Paul E. McKenney
Tested-by: Tony Lindgren
Cc: Russell King
Cc: Steven Rostedt
Cc: Michael Turquette
Cc: Stephen Boyd
Cc:
Cc:
Cc:
---
drivers/clk/clk.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
index fb74dc1f7520..4fa43c02d682 100644
--- a/drivers/clk/clk.c
+++ b/drivers/clk/clk.c
@@ -682,12 +682,12 @@ static void clk_core_disable(struct clk_core *core)
if (--core->enable_count > 0)
return;
- trace_clk_disable(core);
+ trace_clk_disable_rcuidle(core);
if (core->ops->disable)
core->ops->disable(core->hw);
- trace_clk_disable_complete(core);
+ trace_clk_disable_complete_rcuidle(core);
clk_core_disable(core->parent);
}
--
2.5.2
