Re: [PATCH v3] device property: don't bother the drivers with struct property_set

[Rafael J. Wysocki]

On Tuesday, March 29, 2016 02:52:23 PM Heikki Krogerus wrote:
> Since device_add_property_set() now always takes a copy of
> the property_set, and also since the fwnode type is always
> hard coded to be FWNODE_PDATA, there is no need for the
> drivers to deliver the entire struct property_set. The
> function can just create the instance of it on its own and
> bind the properties from the drivers to it on the spot.
> 
> This renames device_add_property_set() to
> device_add_properties(). The function now takes struct
> property_entry as its parameter instead of struct
> property_set.
> 
> Reviewed-by: Andy Shevchenko 
> Reviewed-by: Mika Westerberg 
> Acked-by: Thierry Reding 
> Acked-by: Lee Jones 
> Signed-off-by: Heikki Krogerus 

This patch has been applied to linux-pm.git and is available from its
device-properties branch

 git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git \
 device-properties

as commit f4d05266032346531b9f889e26aa31a0cf2a9822

  device property: don't bother the drivers with struct property_set

on top of 9735a22799b9214d17d3c231fe377fc852f042e9

  Linux 4.6-rc2

Thanks,
Rafael

Re: [PATCH v3] device property: don't bother the drivers with struct property_set

[Rafael J. Wysocki]

On Tuesday, March 29, 2016 02:52:23 PM Heikki Krogerus wrote:
> Since device_add_property_set() now always takes a copy of
> the property_set, and also since the fwnode type is always
> hard coded to be FWNODE_PDATA, there is no need for the
> drivers to deliver the entire struct property_set. The
> function can just create the instance of it on its own and
> bind the properties from the drivers to it on the spot.
> 
> This renames device_add_property_set() to
> device_add_properties(). The function now takes struct
> property_entry as its parameter instead of struct
> property_set.
> 
> Reviewed-by: Andy Shevchenko 
> Reviewed-by: Mika Westerberg 
> Acked-by: Thierry Reding 
> Acked-by: Lee Jones 
> Signed-off-by: Heikki Krogerus 

This patch has been applied to linux-pm.git and is available from its
device-properties branch

 git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git \
 device-properties

as commit f4d05266032346531b9f889e26aa31a0cf2a9822

  device property: don't bother the drivers with struct property_set

on top of 9735a22799b9214d17d3c231fe377fc852f042e9

  Linux 4.6-rc2

Thanks,
Rafael

Re: [PATCH v3] device property: don't bother the drivers with struct property_set

[Rafael J. Wysocki]

On Tue, Apr 12, 2016 at 9:24 AM, Lee Jones  wrote:
> On Mon, 11 Apr 2016, Rafael J. Wysocki wrote:
>
>> On Mon, Apr 11, 2016 at 6:20 PM, Lee Jones  wrote:
>> > On Mon, 11 Apr 2016, Rafael J. Wysocki wrote:
>> >
>> >> On Mon, Apr 11, 2016 at 4:05 PM, Lee Jones  wrote:
>> >> > On Mon, 11 Apr 2016, Rafael J. Wysocki wrote:
>> >> >
>> >> >> On Mon, Apr 11, 2016 at 11:52 AM, Heikki Krogerus
>> >> >>  wrote:
>> >> >> > On Mon, Apr 11, 2016 at 09:20:27AM +0100, Lee Jones wrote:
>> >> >> >> On Tue, 29 Mar 2016, Heikki Krogerus wrote:
>> >> >> >>
>> >> >> >> > Since device_add_property_set() now always takes a copy of
>> >> >> >> > the property_set, and also since the fwnode type is always
>> >> >> >> > hard coded to be FWNODE_PDATA, there is no need for the
>> >> >> >> > drivers to deliver the entire struct property_set. The
>> >> >> >> > function can just create the instance of it on its own and
>> >> >> >> > bind the properties from the drivers to it on the spot.
>> >> >> >> >
>> >> >> >> > This renames device_add_property_set() to
>> >> >> >> > device_add_properties(). The function now takes struct
>> >> >> >> > property_entry as its parameter instead of struct
>> >> >> >> > property_set.
>> >> >> >> >
>> >> >> >> > Reviewed-by: Andy Shevchenko 
>> >> >> >> > Reviewed-by: Mika Westerberg 
>> >> >> >> > Acked-by: Thierry Reding 
>> >> >> >> > Acked-by: Lee Jones 
>> >> >> >> > Signed-off-by: Heikki Krogerus 
>> >> >> >> > ---
>> >> >> >> >  arch/arm/mach-pxa/raumfeld.c  | 12 
>> >> >> >
>> >> >> > Daniel, I think we just need your ACK for this one.
>> >> >> >
>> >> >> > Otherwise I think we are covered.
>> >> >> >
>> >> >> >> >  arch/arm/mach-tegra/board-paz00.c |  6 +-
>> >> >> >> >  drivers/base/platform.c   | 19 ++-
>> >> >> >> >  drivers/base/property.c   | 34 
>> >> >> >> > +-
>> >> >> >> >  drivers/mfd/intel-lpss-acpi.c | 12 ++--
>> >> >> >> >  drivers/mfd/intel-lpss-pci.c  | 20 
>> >> >> >> >  drivers/mfd/intel-lpss.c  |  2 +-
>> >> >> >> >  drivers/mfd/intel-lpss.h  |  4 ++--
>> >> >> >> >  drivers/mfd/mfd-core.c|  4 ++--
>> >> >> >> >  include/linux/mfd/core.h  |  4 ++--
>> >> >> >> >  include/linux/platform_device.h   |  6 +++---
>> >> >> >> >  include/linux/property.h  | 15 +++
>> >> >> >> >  12 files changed, 55 insertions(+), 83 deletions(-)
>> >> >> >>
>> >> >> >> What's happening with this patch?  I believe we're still missing
>> >> >> >> Acks.  Once they are collected someone needs to create an immutable
>> >> >> >> branch and send out a pull-request.
>> >> >> >
>> >> >> > Rafael, have you had time to take a look at this?
>> >> >>
>> >> >> Yes, it's in my bleeding-edge branch now.  I'm planning to move it to
>> >> >> linux-next this week
>> >> >
>> >> > Please ensure you send out the relevant pull-requests.  Linus doesn't
>> >> > look his best when he's angry.
>> >>
>> >> I guess you mean I should expose by device-properties branch and
>> >> notify the relevant people about that, right?
>> >
>> > Exactly.  And the easiest way to do that is by sending out a
>> > pull-request.
>>
>> I hoping that sending a message with the relevant information in a
>> reply to this one will be sufficient.
>
> Because of the nature of MFD, I end up doing this kind of thing a lot.
>
> Here's what I normally do.  Normally in reply to the cover-letter (0/x):
>   https://lkml.org/lkml/2015/8/12/138

OK, makes sense.

Thanks,
Rafael

Re: [PATCH v3] device property: don't bother the drivers with struct property_set

[Rafael J. Wysocki]

On Tue, Apr 12, 2016 at 9:24 AM, Lee Jones  wrote:
> On Mon, 11 Apr 2016, Rafael J. Wysocki wrote:
>
>> On Mon, Apr 11, 2016 at 6:20 PM, Lee Jones  wrote:
>> > On Mon, 11 Apr 2016, Rafael J. Wysocki wrote:
>> >
>> >> On Mon, Apr 11, 2016 at 4:05 PM, Lee Jones  wrote:
>> >> > On Mon, 11 Apr 2016, Rafael J. Wysocki wrote:
>> >> >
>> >> >> On Mon, Apr 11, 2016 at 11:52 AM, Heikki Krogerus
>> >> >>  wrote:
>> >> >> > On Mon, Apr 11, 2016 at 09:20:27AM +0100, Lee Jones wrote:
>> >> >> >> On Tue, 29 Mar 2016, Heikki Krogerus wrote:
>> >> >> >>
>> >> >> >> > Since device_add_property_set() now always takes a copy of
>> >> >> >> > the property_set, and also since the fwnode type is always
>> >> >> >> > hard coded to be FWNODE_PDATA, there is no need for the
>> >> >> >> > drivers to deliver the entire struct property_set. The
>> >> >> >> > function can just create the instance of it on its own and
>> >> >> >> > bind the properties from the drivers to it on the spot.
>> >> >> >> >
>> >> >> >> > This renames device_add_property_set() to
>> >> >> >> > device_add_properties(). The function now takes struct
>> >> >> >> > property_entry as its parameter instead of struct
>> >> >> >> > property_set.
>> >> >> >> >
>> >> >> >> > Reviewed-by: Andy Shevchenko 
>> >> >> >> > Reviewed-by: Mika Westerberg 
>> >> >> >> > Acked-by: Thierry Reding 
>> >> >> >> > Acked-by: Lee Jones 
>> >> >> >> > Signed-off-by: Heikki Krogerus 
>> >> >> >> > ---
>> >> >> >> >  arch/arm/mach-pxa/raumfeld.c  | 12 
>> >> >> >
>> >> >> > Daniel, I think we just need your ACK for this one.
>> >> >> >
>> >> >> > Otherwise I think we are covered.
>> >> >> >
>> >> >> >> >  arch/arm/mach-tegra/board-paz00.c |  6 +-
>> >> >> >> >  drivers/base/platform.c   | 19 ++-
>> >> >> >> >  drivers/base/property.c   | 34 
>> >> >> >> > +-
>> >> >> >> >  drivers/mfd/intel-lpss-acpi.c | 12 ++--
>> >> >> >> >  drivers/mfd/intel-lpss-pci.c  | 20 
>> >> >> >> >  drivers/mfd/intel-lpss.c  |  2 +-
>> >> >> >> >  drivers/mfd/intel-lpss.h  |  4 ++--
>> >> >> >> >  drivers/mfd/mfd-core.c|  4 ++--
>> >> >> >> >  include/linux/mfd/core.h  |  4 ++--
>> >> >> >> >  include/linux/platform_device.h   |  6 +++---
>> >> >> >> >  include/linux/property.h  | 15 +++
>> >> >> >> >  12 files changed, 55 insertions(+), 83 deletions(-)
>> >> >> >>
>> >> >> >> What's happening with this patch?  I believe we're still missing
>> >> >> >> Acks.  Once they are collected someone needs to create an immutable
>> >> >> >> branch and send out a pull-request.
>> >> >> >
>> >> >> > Rafael, have you had time to take a look at this?
>> >> >>
>> >> >> Yes, it's in my bleeding-edge branch now.  I'm planning to move it to
>> >> >> linux-next this week
>> >> >
>> >> > Please ensure you send out the relevant pull-requests.  Linus doesn't
>> >> > look his best when he's angry.
>> >>
>> >> I guess you mean I should expose by device-properties branch and
>> >> notify the relevant people about that, right?
>> >
>> > Exactly.  And the easiest way to do that is by sending out a
>> > pull-request.
>>
>> I hoping that sending a message with the relevant information in a
>> reply to this one will be sufficient.
>
> Because of the nature of MFD, I end up doing this kind of thing a lot.
>
> Here's what I normally do.  Normally in reply to the cover-letter (0/x):
>   https://lkml.org/lkml/2015/8/12/138

OK, makes sense.

Thanks,
Rafael

Re: [PATCH v3] device property: don't bother the drivers with struct property_set

[Lee Jones]

On Mon, 11 Apr 2016, Rafael J. Wysocki wrote:

> On Mon, Apr 11, 2016 at 6:20 PM, Lee Jones  wrote:
> > On Mon, 11 Apr 2016, Rafael J. Wysocki wrote:
> >
> >> On Mon, Apr 11, 2016 at 4:05 PM, Lee Jones  wrote:
> >> > On Mon, 11 Apr 2016, Rafael J. Wysocki wrote:
> >> >
> >> >> On Mon, Apr 11, 2016 at 11:52 AM, Heikki Krogerus
> >> >>  wrote:
> >> >> > On Mon, Apr 11, 2016 at 09:20:27AM +0100, Lee Jones wrote:
> >> >> >> On Tue, 29 Mar 2016, Heikki Krogerus wrote:
> >> >> >>
> >> >> >> > Since device_add_property_set() now always takes a copy of
> >> >> >> > the property_set, and also since the fwnode type is always
> >> >> >> > hard coded to be FWNODE_PDATA, there is no need for the
> >> >> >> > drivers to deliver the entire struct property_set. The
> >> >> >> > function can just create the instance of it on its own and
> >> >> >> > bind the properties from the drivers to it on the spot.
> >> >> >> >
> >> >> >> > This renames device_add_property_set() to
> >> >> >> > device_add_properties(). The function now takes struct
> >> >> >> > property_entry as its parameter instead of struct
> >> >> >> > property_set.
> >> >> >> >
> >> >> >> > Reviewed-by: Andy Shevchenko 
> >> >> >> > Reviewed-by: Mika Westerberg 
> >> >> >> > Acked-by: Thierry Reding 
> >> >> >> > Acked-by: Lee Jones 
> >> >> >> > Signed-off-by: Heikki Krogerus 
> >> >> >> > ---
> >> >> >> >  arch/arm/mach-pxa/raumfeld.c  | 12 
> >> >> >
> >> >> > Daniel, I think we just need your ACK for this one.
> >> >> >
> >> >> > Otherwise I think we are covered.
> >> >> >
> >> >> >> >  arch/arm/mach-tegra/board-paz00.c |  6 +-
> >> >> >> >  drivers/base/platform.c   | 19 ++-
> >> >> >> >  drivers/base/property.c   | 34 
> >> >> >> > +-
> >> >> >> >  drivers/mfd/intel-lpss-acpi.c | 12 ++--
> >> >> >> >  drivers/mfd/intel-lpss-pci.c  | 20 
> >> >> >> >  drivers/mfd/intel-lpss.c  |  2 +-
> >> >> >> >  drivers/mfd/intel-lpss.h  |  4 ++--
> >> >> >> >  drivers/mfd/mfd-core.c|  4 ++--
> >> >> >> >  include/linux/mfd/core.h  |  4 ++--
> >> >> >> >  include/linux/platform_device.h   |  6 +++---
> >> >> >> >  include/linux/property.h  | 15 +++
> >> >> >> >  12 files changed, 55 insertions(+), 83 deletions(-)
> >> >> >>
> >> >> >> What's happening with this patch?  I believe we're still missing
> >> >> >> Acks.  Once they are collected someone needs to create an immutable
> >> >> >> branch and send out a pull-request.
> >> >> >
> >> >> > Rafael, have you had time to take a look at this?
> >> >>
> >> >> Yes, it's in my bleeding-edge branch now.  I'm planning to move it to
> >> >> linux-next this week
> >> >
> >> > Please ensure you send out the relevant pull-requests.  Linus doesn't
> >> > look his best when he's angry.
> >>
> >> I guess you mean I should expose by device-properties branch and
> >> notify the relevant people about that, right?
> >
> > Exactly.  And the easiest way to do that is by sending out a
> > pull-request.
> 
> I hoping that sending a message with the relevant information in a
> reply to this one will be sufficient.

Because of the nature of MFD, I end up doing this kind of thing a lot.

Here's what I normally do.  Normally in reply to the cover-letter (0/x):
  https://lkml.org/lkml/2015/8/12/138

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH v3] device property: don't bother the drivers with struct property_set

[Lee Jones]

On Mon, 11 Apr 2016, Rafael J. Wysocki wrote:

> On Mon, Apr 11, 2016 at 6:20 PM, Lee Jones  wrote:
> > On Mon, 11 Apr 2016, Rafael J. Wysocki wrote:
> >
> >> On Mon, Apr 11, 2016 at 4:05 PM, Lee Jones  wrote:
> >> > On Mon, 11 Apr 2016, Rafael J. Wysocki wrote:
> >> >
> >> >> On Mon, Apr 11, 2016 at 11:52 AM, Heikki Krogerus
> >> >>  wrote:
> >> >> > On Mon, Apr 11, 2016 at 09:20:27AM +0100, Lee Jones wrote:
> >> >> >> On Tue, 29 Mar 2016, Heikki Krogerus wrote:
> >> >> >>
> >> >> >> > Since device_add_property_set() now always takes a copy of
> >> >> >> > the property_set, and also since the fwnode type is always
> >> >> >> > hard coded to be FWNODE_PDATA, there is no need for the
> >> >> >> > drivers to deliver the entire struct property_set. The
> >> >> >> > function can just create the instance of it on its own and
> >> >> >> > bind the properties from the drivers to it on the spot.
> >> >> >> >
> >> >> >> > This renames device_add_property_set() to
> >> >> >> > device_add_properties(). The function now takes struct
> >> >> >> > property_entry as its parameter instead of struct
> >> >> >> > property_set.
> >> >> >> >
> >> >> >> > Reviewed-by: Andy Shevchenko 
> >> >> >> > Reviewed-by: Mika Westerberg 
> >> >> >> > Acked-by: Thierry Reding 
> >> >> >> > Acked-by: Lee Jones 
> >> >> >> > Signed-off-by: Heikki Krogerus 
> >> >> >> > ---
> >> >> >> >  arch/arm/mach-pxa/raumfeld.c  | 12 
> >> >> >
> >> >> > Daniel, I think we just need your ACK for this one.
> >> >> >
> >> >> > Otherwise I think we are covered.
> >> >> >
> >> >> >> >  arch/arm/mach-tegra/board-paz00.c |  6 +-
> >> >> >> >  drivers/base/platform.c   | 19 ++-
> >> >> >> >  drivers/base/property.c   | 34 
> >> >> >> > +-
> >> >> >> >  drivers/mfd/intel-lpss-acpi.c | 12 ++--
> >> >> >> >  drivers/mfd/intel-lpss-pci.c  | 20 
> >> >> >> >  drivers/mfd/intel-lpss.c  |  2 +-
> >> >> >> >  drivers/mfd/intel-lpss.h  |  4 ++--
> >> >> >> >  drivers/mfd/mfd-core.c|  4 ++--
> >> >> >> >  include/linux/mfd/core.h  |  4 ++--
> >> >> >> >  include/linux/platform_device.h   |  6 +++---
> >> >> >> >  include/linux/property.h  | 15 +++
> >> >> >> >  12 files changed, 55 insertions(+), 83 deletions(-)
> >> >> >>
> >> >> >> What's happening with this patch?  I believe we're still missing
> >> >> >> Acks.  Once they are collected someone needs to create an immutable
> >> >> >> branch and send out a pull-request.
> >> >> >
> >> >> > Rafael, have you had time to take a look at this?
> >> >>
> >> >> Yes, it's in my bleeding-edge branch now.  I'm planning to move it to
> >> >> linux-next this week
> >> >
> >> > Please ensure you send out the relevant pull-requests.  Linus doesn't
> >> > look his best when he's angry.
> >>
> >> I guess you mean I should expose by device-properties branch and
> >> notify the relevant people about that, right?
> >
> > Exactly.  And the easiest way to do that is by sending out a
> > pull-request.
> 
> I hoping that sending a message with the relevant information in a
> reply to this one will be sufficient.

Because of the nature of MFD, I end up doing this kind of thing a lot.

Here's what I normally do.  Normally in reply to the cover-letter (0/x):
  https://lkml.org/lkml/2015/8/12/138

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH v3] device property: don't bother the drivers with struct property_set

[Rafael J. Wysocki]

On Mon, Apr 11, 2016 at 6:20 PM, Lee Jones  wrote:
> On Mon, 11 Apr 2016, Rafael J. Wysocki wrote:
>
>> On Mon, Apr 11, 2016 at 4:05 PM, Lee Jones  wrote:
>> > On Mon, 11 Apr 2016, Rafael J. Wysocki wrote:
>> >
>> >> On Mon, Apr 11, 2016 at 11:52 AM, Heikki Krogerus
>> >>  wrote:
>> >> > On Mon, Apr 11, 2016 at 09:20:27AM +0100, Lee Jones wrote:
>> >> >> On Tue, 29 Mar 2016, Heikki Krogerus wrote:
>> >> >>
>> >> >> > Since device_add_property_set() now always takes a copy of
>> >> >> > the property_set, and also since the fwnode type is always
>> >> >> > hard coded to be FWNODE_PDATA, there is no need for the
>> >> >> > drivers to deliver the entire struct property_set. The
>> >> >> > function can just create the instance of it on its own and
>> >> >> > bind the properties from the drivers to it on the spot.
>> >> >> >
>> >> >> > This renames device_add_property_set() to
>> >> >> > device_add_properties(). The function now takes struct
>> >> >> > property_entry as its parameter instead of struct
>> >> >> > property_set.
>> >> >> >
>> >> >> > Reviewed-by: Andy Shevchenko 
>> >> >> > Reviewed-by: Mika Westerberg 
>> >> >> > Acked-by: Thierry Reding 
>> >> >> > Acked-by: Lee Jones 
>> >> >> > Signed-off-by: Heikki Krogerus 
>> >> >> > ---
>> >> >> >  arch/arm/mach-pxa/raumfeld.c  | 12 
>> >> >
>> >> > Daniel, I think we just need your ACK for this one.
>> >> >
>> >> > Otherwise I think we are covered.
>> >> >
>> >> >> >  arch/arm/mach-tegra/board-paz00.c |  6 +-
>> >> >> >  drivers/base/platform.c   | 19 ++-
>> >> >> >  drivers/base/property.c   | 34 
>> >> >> > +-
>> >> >> >  drivers/mfd/intel-lpss-acpi.c | 12 ++--
>> >> >> >  drivers/mfd/intel-lpss-pci.c  | 20 
>> >> >> >  drivers/mfd/intel-lpss.c  |  2 +-
>> >> >> >  drivers/mfd/intel-lpss.h  |  4 ++--
>> >> >> >  drivers/mfd/mfd-core.c|  4 ++--
>> >> >> >  include/linux/mfd/core.h  |  4 ++--
>> >> >> >  include/linux/platform_device.h   |  6 +++---
>> >> >> >  include/linux/property.h  | 15 +++
>> >> >> >  12 files changed, 55 insertions(+), 83 deletions(-)
>> >> >>
>> >> >> What's happening with this patch?  I believe we're still missing
>> >> >> Acks.  Once they are collected someone needs to create an immutable
>> >> >> branch and send out a pull-request.
>> >> >
>> >> > Rafael, have you had time to take a look at this?
>> >>
>> >> Yes, it's in my bleeding-edge branch now.  I'm planning to move it to
>> >> linux-next this week
>> >
>> > Please ensure you send out the relevant pull-requests.  Linus doesn't
>> > look his best when he's angry.
>>
>> I guess you mean I should expose by device-properties branch and
>> notify the relevant people about that, right?
>
> Exactly.  And the easiest way to do that is by sending out a
> pull-request.

I hoping that sending a message with the relevant information in a
reply to this one will be sufficient.

Thanks,
Rafael

Re: [PATCH v3] device property: don't bother the drivers with struct property_set

[Rafael J. Wysocki]

On Mon, Apr 11, 2016 at 6:20 PM, Lee Jones  wrote:
> On Mon, 11 Apr 2016, Rafael J. Wysocki wrote:
>
>> On Mon, Apr 11, 2016 at 4:05 PM, Lee Jones  wrote:
>> > On Mon, 11 Apr 2016, Rafael J. Wysocki wrote:
>> >
>> >> On Mon, Apr 11, 2016 at 11:52 AM, Heikki Krogerus
>> >>  wrote:
>> >> > On Mon, Apr 11, 2016 at 09:20:27AM +0100, Lee Jones wrote:
>> >> >> On Tue, 29 Mar 2016, Heikki Krogerus wrote:
>> >> >>
>> >> >> > Since device_add_property_set() now always takes a copy of
>> >> >> > the property_set, and also since the fwnode type is always
>> >> >> > hard coded to be FWNODE_PDATA, there is no need for the
>> >> >> > drivers to deliver the entire struct property_set. The
>> >> >> > function can just create the instance of it on its own and
>> >> >> > bind the properties from the drivers to it on the spot.
>> >> >> >
>> >> >> > This renames device_add_property_set() to
>> >> >> > device_add_properties(). The function now takes struct
>> >> >> > property_entry as its parameter instead of struct
>> >> >> > property_set.
>> >> >> >
>> >> >> > Reviewed-by: Andy Shevchenko 
>> >> >> > Reviewed-by: Mika Westerberg 
>> >> >> > Acked-by: Thierry Reding 
>> >> >> > Acked-by: Lee Jones 
>> >> >> > Signed-off-by: Heikki Krogerus 
>> >> >> > ---
>> >> >> >  arch/arm/mach-pxa/raumfeld.c  | 12 
>> >> >
>> >> > Daniel, I think we just need your ACK for this one.
>> >> >
>> >> > Otherwise I think we are covered.
>> >> >
>> >> >> >  arch/arm/mach-tegra/board-paz00.c |  6 +-
>> >> >> >  drivers/base/platform.c   | 19 ++-
>> >> >> >  drivers/base/property.c   | 34 
>> >> >> > +-
>> >> >> >  drivers/mfd/intel-lpss-acpi.c | 12 ++--
>> >> >> >  drivers/mfd/intel-lpss-pci.c  | 20 
>> >> >> >  drivers/mfd/intel-lpss.c  |  2 +-
>> >> >> >  drivers/mfd/intel-lpss.h  |  4 ++--
>> >> >> >  drivers/mfd/mfd-core.c|  4 ++--
>> >> >> >  include/linux/mfd/core.h  |  4 ++--
>> >> >> >  include/linux/platform_device.h   |  6 +++---
>> >> >> >  include/linux/property.h  | 15 +++
>> >> >> >  12 files changed, 55 insertions(+), 83 deletions(-)
>> >> >>
>> >> >> What's happening with this patch?  I believe we're still missing
>> >> >> Acks.  Once they are collected someone needs to create an immutable
>> >> >> branch and send out a pull-request.
>> >> >
>> >> > Rafael, have you had time to take a look at this?
>> >>
>> >> Yes, it's in my bleeding-edge branch now.  I'm planning to move it to
>> >> linux-next this week
>> >
>> > Please ensure you send out the relevant pull-requests.  Linus doesn't
>> > look his best when he's angry.
>>
>> I guess you mean I should expose by device-properties branch and
>> notify the relevant people about that, right?
>
> Exactly.  And the easiest way to do that is by sending out a
> pull-request.

I hoping that sending a message with the relevant information in a
reply to this one will be sufficient.

Thanks,
Rafael

Re: [PATCH v3] device property: don't bother the drivers with struct property_set

[Lee Jones]

On Mon, 11 Apr 2016, Rafael J. Wysocki wrote:

> On Mon, Apr 11, 2016 at 4:05 PM, Lee Jones  wrote:
> > On Mon, 11 Apr 2016, Rafael J. Wysocki wrote:
> >
> >> On Mon, Apr 11, 2016 at 11:52 AM, Heikki Krogerus
> >>  wrote:
> >> > On Mon, Apr 11, 2016 at 09:20:27AM +0100, Lee Jones wrote:
> >> >> On Tue, 29 Mar 2016, Heikki Krogerus wrote:
> >> >>
> >> >> > Since device_add_property_set() now always takes a copy of
> >> >> > the property_set, and also since the fwnode type is always
> >> >> > hard coded to be FWNODE_PDATA, there is no need for the
> >> >> > drivers to deliver the entire struct property_set. The
> >> >> > function can just create the instance of it on its own and
> >> >> > bind the properties from the drivers to it on the spot.
> >> >> >
> >> >> > This renames device_add_property_set() to
> >> >> > device_add_properties(). The function now takes struct
> >> >> > property_entry as its parameter instead of struct
> >> >> > property_set.
> >> >> >
> >> >> > Reviewed-by: Andy Shevchenko 
> >> >> > Reviewed-by: Mika Westerberg 
> >> >> > Acked-by: Thierry Reding 
> >> >> > Acked-by: Lee Jones 
> >> >> > Signed-off-by: Heikki Krogerus 
> >> >> > ---
> >> >> >  arch/arm/mach-pxa/raumfeld.c  | 12 
> >> >
> >> > Daniel, I think we just need your ACK for this one.
> >> >
> >> > Otherwise I think we are covered.
> >> >
> >> >> >  arch/arm/mach-tegra/board-paz00.c |  6 +-
> >> >> >  drivers/base/platform.c   | 19 ++-
> >> >> >  drivers/base/property.c   | 34 
> >> >> > +-
> >> >> >  drivers/mfd/intel-lpss-acpi.c | 12 ++--
> >> >> >  drivers/mfd/intel-lpss-pci.c  | 20 
> >> >> >  drivers/mfd/intel-lpss.c  |  2 +-
> >> >> >  drivers/mfd/intel-lpss.h  |  4 ++--
> >> >> >  drivers/mfd/mfd-core.c|  4 ++--
> >> >> >  include/linux/mfd/core.h  |  4 ++--
> >> >> >  include/linux/platform_device.h   |  6 +++---
> >> >> >  include/linux/property.h  | 15 +++
> >> >> >  12 files changed, 55 insertions(+), 83 deletions(-)
> >> >>
> >> >> What's happening with this patch?  I believe we're still missing
> >> >> Acks.  Once they are collected someone needs to create an immutable
> >> >> branch and send out a pull-request.
> >> >
> >> > Rafael, have you had time to take a look at this?
> >>
> >> Yes, it's in my bleeding-edge branch now.  I'm planning to move it to
> >> linux-next this week
> >
> > Please ensure you send out the relevant pull-requests.  Linus doesn't
> > look his best when he's angry.
> 
> I guess you mean I should expose by device-properties branch and
> notify the relevant people about that, right?

Exactly.  And the easiest way to do that is by sending out a
pull-request.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH v3] device property: don't bother the drivers with struct property_set

[Lee Jones]

On Mon, 11 Apr 2016, Rafael J. Wysocki wrote:

> On Mon, Apr 11, 2016 at 4:05 PM, Lee Jones  wrote:
> > On Mon, 11 Apr 2016, Rafael J. Wysocki wrote:
> >
> >> On Mon, Apr 11, 2016 at 11:52 AM, Heikki Krogerus
> >>  wrote:
> >> > On Mon, Apr 11, 2016 at 09:20:27AM +0100, Lee Jones wrote:
> >> >> On Tue, 29 Mar 2016, Heikki Krogerus wrote:
> >> >>
> >> >> > Since device_add_property_set() now always takes a copy of
> >> >> > the property_set, and also since the fwnode type is always
> >> >> > hard coded to be FWNODE_PDATA, there is no need for the
> >> >> > drivers to deliver the entire struct property_set. The
> >> >> > function can just create the instance of it on its own and
> >> >> > bind the properties from the drivers to it on the spot.
> >> >> >
> >> >> > This renames device_add_property_set() to
> >> >> > device_add_properties(). The function now takes struct
> >> >> > property_entry as its parameter instead of struct
> >> >> > property_set.
> >> >> >
> >> >> > Reviewed-by: Andy Shevchenko 
> >> >> > Reviewed-by: Mika Westerberg 
> >> >> > Acked-by: Thierry Reding 
> >> >> > Acked-by: Lee Jones 
> >> >> > Signed-off-by: Heikki Krogerus 
> >> >> > ---
> >> >> >  arch/arm/mach-pxa/raumfeld.c  | 12 
> >> >
> >> > Daniel, I think we just need your ACK for this one.
> >> >
> >> > Otherwise I think we are covered.
> >> >
> >> >> >  arch/arm/mach-tegra/board-paz00.c |  6 +-
> >> >> >  drivers/base/platform.c   | 19 ++-
> >> >> >  drivers/base/property.c   | 34 
> >> >> > +-
> >> >> >  drivers/mfd/intel-lpss-acpi.c | 12 ++--
> >> >> >  drivers/mfd/intel-lpss-pci.c  | 20 
> >> >> >  drivers/mfd/intel-lpss.c  |  2 +-
> >> >> >  drivers/mfd/intel-lpss.h  |  4 ++--
> >> >> >  drivers/mfd/mfd-core.c|  4 ++--
> >> >> >  include/linux/mfd/core.h  |  4 ++--
> >> >> >  include/linux/platform_device.h   |  6 +++---
> >> >> >  include/linux/property.h  | 15 +++
> >> >> >  12 files changed, 55 insertions(+), 83 deletions(-)
> >> >>
> >> >> What's happening with this patch?  I believe we're still missing
> >> >> Acks.  Once they are collected someone needs to create an immutable
> >> >> branch and send out a pull-request.
> >> >
> >> > Rafael, have you had time to take a look at this?
> >>
> >> Yes, it's in my bleeding-edge branch now.  I'm planning to move it to
> >> linux-next this week
> >
> > Please ensure you send out the relevant pull-requests.  Linus doesn't
> > look his best when he's angry.
> 
> I guess you mean I should expose by device-properties branch and
> notify the relevant people about that, right?

Exactly.  And the easiest way to do that is by sending out a
pull-request.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH v3] device property: don't bother the drivers with struct property_set

[Rafael J. Wysocki]

On Mon, Apr 11, 2016 at 4:05 PM, Lee Jones  wrote:
> On Mon, 11 Apr 2016, Rafael J. Wysocki wrote:
>
>> On Mon, Apr 11, 2016 at 11:52 AM, Heikki Krogerus
>>  wrote:
>> > On Mon, Apr 11, 2016 at 09:20:27AM +0100, Lee Jones wrote:
>> >> On Tue, 29 Mar 2016, Heikki Krogerus wrote:
>> >>
>> >> > Since device_add_property_set() now always takes a copy of
>> >> > the property_set, and also since the fwnode type is always
>> >> > hard coded to be FWNODE_PDATA, there is no need for the
>> >> > drivers to deliver the entire struct property_set. The
>> >> > function can just create the instance of it on its own and
>> >> > bind the properties from the drivers to it on the spot.
>> >> >
>> >> > This renames device_add_property_set() to
>> >> > device_add_properties(). The function now takes struct
>> >> > property_entry as its parameter instead of struct
>> >> > property_set.
>> >> >
>> >> > Reviewed-by: Andy Shevchenko 
>> >> > Reviewed-by: Mika Westerberg 
>> >> > Acked-by: Thierry Reding 
>> >> > Acked-by: Lee Jones 
>> >> > Signed-off-by: Heikki Krogerus 
>> >> > ---
>> >> >  arch/arm/mach-pxa/raumfeld.c  | 12 
>> >
>> > Daniel, I think we just need your ACK for this one.
>> >
>> > Otherwise I think we are covered.
>> >
>> >> >  arch/arm/mach-tegra/board-paz00.c |  6 +-
>> >> >  drivers/base/platform.c   | 19 ++-
>> >> >  drivers/base/property.c   | 34 
>> >> > +-
>> >> >  drivers/mfd/intel-lpss-acpi.c | 12 ++--
>> >> >  drivers/mfd/intel-lpss-pci.c  | 20 
>> >> >  drivers/mfd/intel-lpss.c  |  2 +-
>> >> >  drivers/mfd/intel-lpss.h  |  4 ++--
>> >> >  drivers/mfd/mfd-core.c|  4 ++--
>> >> >  include/linux/mfd/core.h  |  4 ++--
>> >> >  include/linux/platform_device.h   |  6 +++---
>> >> >  include/linux/property.h  | 15 +++
>> >> >  12 files changed, 55 insertions(+), 83 deletions(-)
>> >>
>> >> What's happening with this patch?  I believe we're still missing
>> >> Acks.  Once they are collected someone needs to create an immutable
>> >> branch and send out a pull-request.
>> >
>> > Rafael, have you had time to take a look at this?
>>
>> Yes, it's in my bleeding-edge branch now.  I'm planning to move it to
>> linux-next this week
>
> Please ensure you send out the relevant pull-requests.  Linus doesn't
> look his best when he's angry.

I guess you mean I should expose by device-properties branch and
notify the relevant people about that, right?

Thanks,
Rafael

Re: [PATCH v3] device property: don't bother the drivers with struct property_set

[Rafael J. Wysocki]

On Mon, Apr 11, 2016 at 4:05 PM, Lee Jones  wrote:
> On Mon, 11 Apr 2016, Rafael J. Wysocki wrote:
>
>> On Mon, Apr 11, 2016 at 11:52 AM, Heikki Krogerus
>>  wrote:
>> > On Mon, Apr 11, 2016 at 09:20:27AM +0100, Lee Jones wrote:
>> >> On Tue, 29 Mar 2016, Heikki Krogerus wrote:
>> >>
>> >> > Since device_add_property_set() now always takes a copy of
>> >> > the property_set, and also since the fwnode type is always
>> >> > hard coded to be FWNODE_PDATA, there is no need for the
>> >> > drivers to deliver the entire struct property_set. The
>> >> > function can just create the instance of it on its own and
>> >> > bind the properties from the drivers to it on the spot.
>> >> >
>> >> > This renames device_add_property_set() to
>> >> > device_add_properties(). The function now takes struct
>> >> > property_entry as its parameter instead of struct
>> >> > property_set.
>> >> >
>> >> > Reviewed-by: Andy Shevchenko 
>> >> > Reviewed-by: Mika Westerberg 
>> >> > Acked-by: Thierry Reding 
>> >> > Acked-by: Lee Jones 
>> >> > Signed-off-by: Heikki Krogerus 
>> >> > ---
>> >> >  arch/arm/mach-pxa/raumfeld.c  | 12 
>> >
>> > Daniel, I think we just need your ACK for this one.
>> >
>> > Otherwise I think we are covered.
>> >
>> >> >  arch/arm/mach-tegra/board-paz00.c |  6 +-
>> >> >  drivers/base/platform.c   | 19 ++-
>> >> >  drivers/base/property.c   | 34 
>> >> > +-
>> >> >  drivers/mfd/intel-lpss-acpi.c | 12 ++--
>> >> >  drivers/mfd/intel-lpss-pci.c  | 20 
>> >> >  drivers/mfd/intel-lpss.c  |  2 +-
>> >> >  drivers/mfd/intel-lpss.h  |  4 ++--
>> >> >  drivers/mfd/mfd-core.c|  4 ++--
>> >> >  include/linux/mfd/core.h  |  4 ++--
>> >> >  include/linux/platform_device.h   |  6 +++---
>> >> >  include/linux/property.h  | 15 +++
>> >> >  12 files changed, 55 insertions(+), 83 deletions(-)
>> >>
>> >> What's happening with this patch?  I believe we're still missing
>> >> Acks.  Once they are collected someone needs to create an immutable
>> >> branch and send out a pull-request.
>> >
>> > Rafael, have you had time to take a look at this?
>>
>> Yes, it's in my bleeding-edge branch now.  I'm planning to move it to
>> linux-next this week
>
> Please ensure you send out the relevant pull-requests.  Linus doesn't
> look his best when he's angry.

I guess you mean I should expose by device-properties branch and
notify the relevant people about that, right?

Thanks,
Rafael

Re: [PATCH v3] device property: don't bother the drivers with struct property_set

[Lee Jones]

On Mon, 11 Apr 2016, Rafael J. Wysocki wrote:

> On Mon, Apr 11, 2016 at 11:52 AM, Heikki Krogerus
>  wrote:
> > On Mon, Apr 11, 2016 at 09:20:27AM +0100, Lee Jones wrote:
> >> On Tue, 29 Mar 2016, Heikki Krogerus wrote:
> >>
> >> > Since device_add_property_set() now always takes a copy of
> >> > the property_set, and also since the fwnode type is always
> >> > hard coded to be FWNODE_PDATA, there is no need for the
> >> > drivers to deliver the entire struct property_set. The
> >> > function can just create the instance of it on its own and
> >> > bind the properties from the drivers to it on the spot.
> >> >
> >> > This renames device_add_property_set() to
> >> > device_add_properties(). The function now takes struct
> >> > property_entry as its parameter instead of struct
> >> > property_set.
> >> >
> >> > Reviewed-by: Andy Shevchenko 
> >> > Reviewed-by: Mika Westerberg 
> >> > Acked-by: Thierry Reding 
> >> > Acked-by: Lee Jones 
> >> > Signed-off-by: Heikki Krogerus 
> >> > ---
> >> >  arch/arm/mach-pxa/raumfeld.c  | 12 
> >
> > Daniel, I think we just need your ACK for this one.
> >
> > Otherwise I think we are covered.
> >
> >> >  arch/arm/mach-tegra/board-paz00.c |  6 +-
> >> >  drivers/base/platform.c   | 19 ++-
> >> >  drivers/base/property.c   | 34 
> >> > +-
> >> >  drivers/mfd/intel-lpss-acpi.c | 12 ++--
> >> >  drivers/mfd/intel-lpss-pci.c  | 20 
> >> >  drivers/mfd/intel-lpss.c  |  2 +-
> >> >  drivers/mfd/intel-lpss.h  |  4 ++--
> >> >  drivers/mfd/mfd-core.c|  4 ++--
> >> >  include/linux/mfd/core.h  |  4 ++--
> >> >  include/linux/platform_device.h   |  6 +++---
> >> >  include/linux/property.h  | 15 +++
> >> >  12 files changed, 55 insertions(+), 83 deletions(-)
> >>
> >> What's happening with this patch?  I believe we're still missing
> >> Acks.  Once they are collected someone needs to create an immutable
> >> branch and send out a pull-request.
> >
> > Rafael, have you had time to take a look at this?
> 
> Yes, it's in my bleeding-edge branch now.  I'm planning to move it to
> linux-next this week

Please ensure you send out the relevant pull-requests.  Linus doesn't
look his best when he's angry.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH v3] device property: don't bother the drivers with struct property_set

[Lee Jones]

On Mon, 11 Apr 2016, Rafael J. Wysocki wrote:

> On Mon, Apr 11, 2016 at 11:52 AM, Heikki Krogerus
>  wrote:
> > On Mon, Apr 11, 2016 at 09:20:27AM +0100, Lee Jones wrote:
> >> On Tue, 29 Mar 2016, Heikki Krogerus wrote:
> >>
> >> > Since device_add_property_set() now always takes a copy of
> >> > the property_set, and also since the fwnode type is always
> >> > hard coded to be FWNODE_PDATA, there is no need for the
> >> > drivers to deliver the entire struct property_set. The
> >> > function can just create the instance of it on its own and
> >> > bind the properties from the drivers to it on the spot.
> >> >
> >> > This renames device_add_property_set() to
> >> > device_add_properties(). The function now takes struct
> >> > property_entry as its parameter instead of struct
> >> > property_set.
> >> >
> >> > Reviewed-by: Andy Shevchenko 
> >> > Reviewed-by: Mika Westerberg 
> >> > Acked-by: Thierry Reding 
> >> > Acked-by: Lee Jones 
> >> > Signed-off-by: Heikki Krogerus 
> >> > ---
> >> >  arch/arm/mach-pxa/raumfeld.c  | 12 
> >
> > Daniel, I think we just need your ACK for this one.
> >
> > Otherwise I think we are covered.
> >
> >> >  arch/arm/mach-tegra/board-paz00.c |  6 +-
> >> >  drivers/base/platform.c   | 19 ++-
> >> >  drivers/base/property.c   | 34 
> >> > +-
> >> >  drivers/mfd/intel-lpss-acpi.c | 12 ++--
> >> >  drivers/mfd/intel-lpss-pci.c  | 20 
> >> >  drivers/mfd/intel-lpss.c  |  2 +-
> >> >  drivers/mfd/intel-lpss.h  |  4 ++--
> >> >  drivers/mfd/mfd-core.c|  4 ++--
> >> >  include/linux/mfd/core.h  |  4 ++--
> >> >  include/linux/platform_device.h   |  6 +++---
> >> >  include/linux/property.h  | 15 +++
> >> >  12 files changed, 55 insertions(+), 83 deletions(-)
> >>
> >> What's happening with this patch?  I believe we're still missing
> >> Acks.  Once they are collected someone needs to create an immutable
> >> branch and send out a pull-request.
> >
> > Rafael, have you had time to take a look at this?
> 
> Yes, it's in my bleeding-edge branch now.  I'm planning to move it to
> linux-next this week

Please ensure you send out the relevant pull-requests.  Linus doesn't
look his best when he's angry.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH v3] device property: don't bother the drivers with struct property_set

[Rafael J. Wysocki]

On Mon, Apr 11, 2016 at 11:52 AM, Heikki Krogerus
 wrote:
> On Mon, Apr 11, 2016 at 09:20:27AM +0100, Lee Jones wrote:
>> On Tue, 29 Mar 2016, Heikki Krogerus wrote:
>>
>> > Since device_add_property_set() now always takes a copy of
>> > the property_set, and also since the fwnode type is always
>> > hard coded to be FWNODE_PDATA, there is no need for the
>> > drivers to deliver the entire struct property_set. The
>> > function can just create the instance of it on its own and
>> > bind the properties from the drivers to it on the spot.
>> >
>> > This renames device_add_property_set() to
>> > device_add_properties(). The function now takes struct
>> > property_entry as its parameter instead of struct
>> > property_set.
>> >
>> > Reviewed-by: Andy Shevchenko 
>> > Reviewed-by: Mika Westerberg 
>> > Acked-by: Thierry Reding 
>> > Acked-by: Lee Jones 
>> > Signed-off-by: Heikki Krogerus 
>> > ---
>> >  arch/arm/mach-pxa/raumfeld.c  | 12 
>
> Daniel, I think we just need your ACK for this one.
>
> Otherwise I think we are covered.
>
>> >  arch/arm/mach-tegra/board-paz00.c |  6 +-
>> >  drivers/base/platform.c   | 19 ++-
>> >  drivers/base/property.c   | 34 +-
>> >  drivers/mfd/intel-lpss-acpi.c | 12 ++--
>> >  drivers/mfd/intel-lpss-pci.c  | 20 
>> >  drivers/mfd/intel-lpss.c  |  2 +-
>> >  drivers/mfd/intel-lpss.h  |  4 ++--
>> >  drivers/mfd/mfd-core.c|  4 ++--
>> >  include/linux/mfd/core.h  |  4 ++--
>> >  include/linux/platform_device.h   |  6 +++---
>> >  include/linux/property.h  | 15 +++
>> >  12 files changed, 55 insertions(+), 83 deletions(-)
>>
>> What's happening with this patch?  I believe we're still missing
>> Acks.  Once they are collected someone needs to create an immutable
>> branch and send out a pull-request.
>
> Rafael, have you had time to take a look at this?

Yes, it's in my bleeding-edge branch now.  I'm planning to move it to
linux-next this week

Thanks,
Rafael

Re: [PATCH v3] device property: don't bother the drivers with struct property_set

[Rafael J. Wysocki]

On Mon, Apr 11, 2016 at 11:52 AM, Heikki Krogerus
 wrote:
> On Mon, Apr 11, 2016 at 09:20:27AM +0100, Lee Jones wrote:
>> On Tue, 29 Mar 2016, Heikki Krogerus wrote:
>>
>> > Since device_add_property_set() now always takes a copy of
>> > the property_set, and also since the fwnode type is always
>> > hard coded to be FWNODE_PDATA, there is no need for the
>> > drivers to deliver the entire struct property_set. The
>> > function can just create the instance of it on its own and
>> > bind the properties from the drivers to it on the spot.
>> >
>> > This renames device_add_property_set() to
>> > device_add_properties(). The function now takes struct
>> > property_entry as its parameter instead of struct
>> > property_set.
>> >
>> > Reviewed-by: Andy Shevchenko 
>> > Reviewed-by: Mika Westerberg 
>> > Acked-by: Thierry Reding 
>> > Acked-by: Lee Jones 
>> > Signed-off-by: Heikki Krogerus 
>> > ---
>> >  arch/arm/mach-pxa/raumfeld.c  | 12 
>
> Daniel, I think we just need your ACK for this one.
>
> Otherwise I think we are covered.
>
>> >  arch/arm/mach-tegra/board-paz00.c |  6 +-
>> >  drivers/base/platform.c   | 19 ++-
>> >  drivers/base/property.c   | 34 +-
>> >  drivers/mfd/intel-lpss-acpi.c | 12 ++--
>> >  drivers/mfd/intel-lpss-pci.c  | 20 
>> >  drivers/mfd/intel-lpss.c  |  2 +-
>> >  drivers/mfd/intel-lpss.h  |  4 ++--
>> >  drivers/mfd/mfd-core.c|  4 ++--
>> >  include/linux/mfd/core.h  |  4 ++--
>> >  include/linux/platform_device.h   |  6 +++---
>> >  include/linux/property.h  | 15 +++
>> >  12 files changed, 55 insertions(+), 83 deletions(-)
>>
>> What's happening with this patch?  I believe we're still missing
>> Acks.  Once they are collected someone needs to create an immutable
>> branch and send out a pull-request.
>
> Rafael, have you had time to take a look at this?

Yes, it's in my bleeding-edge branch now.  I'm planning to move it to
linux-next this week

Thanks,
Rafael

Re: [PATCH v3] device property: don't bother the drivers with struct property_set

[Heikki Krogerus]

On Mon, Apr 11, 2016 at 09:20:27AM +0100, Lee Jones wrote:
> On Tue, 29 Mar 2016, Heikki Krogerus wrote:
> 
> > Since device_add_property_set() now always takes a copy of
> > the property_set, and also since the fwnode type is always
> > hard coded to be FWNODE_PDATA, there is no need for the
> > drivers to deliver the entire struct property_set. The
> > function can just create the instance of it on its own and
> > bind the properties from the drivers to it on the spot.
> > 
> > This renames device_add_property_set() to
> > device_add_properties(). The function now takes struct
> > property_entry as its parameter instead of struct
> > property_set.
> > 
> > Reviewed-by: Andy Shevchenko 
> > Reviewed-by: Mika Westerberg 
> > Acked-by: Thierry Reding 
> > Acked-by: Lee Jones 
> > Signed-off-by: Heikki Krogerus 
> > ---
> >  arch/arm/mach-pxa/raumfeld.c  | 12 

Daniel, I think we just need your ACK for this one.

Otherwise I think we are covered.

> >  arch/arm/mach-tegra/board-paz00.c |  6 +-
> >  drivers/base/platform.c   | 19 ++-
> >  drivers/base/property.c   | 34 +-
> >  drivers/mfd/intel-lpss-acpi.c | 12 ++--
> >  drivers/mfd/intel-lpss-pci.c  | 20 
> >  drivers/mfd/intel-lpss.c  |  2 +-
> >  drivers/mfd/intel-lpss.h  |  4 ++--
> >  drivers/mfd/mfd-core.c|  4 ++--
> >  include/linux/mfd/core.h  |  4 ++--
> >  include/linux/platform_device.h   |  6 +++---
> >  include/linux/property.h  | 15 +++
> >  12 files changed, 55 insertions(+), 83 deletions(-)
> 
> What's happening with this patch?  I believe we're still missing
> Acks.  Once they are collected someone needs to create an immutable
> branch and send out a pull-request.

Rafael, have you had time to take a look at this?


Thanks,

-- 
heikki

Re: [PATCH v3] device property: don't bother the drivers with struct property_set

[Heikki Krogerus]

On Mon, Apr 11, 2016 at 09:20:27AM +0100, Lee Jones wrote:
> On Tue, 29 Mar 2016, Heikki Krogerus wrote:
> 
> > Since device_add_property_set() now always takes a copy of
> > the property_set, and also since the fwnode type is always
> > hard coded to be FWNODE_PDATA, there is no need for the
> > drivers to deliver the entire struct property_set. The
> > function can just create the instance of it on its own and
> > bind the properties from the drivers to it on the spot.
> > 
> > This renames device_add_property_set() to
> > device_add_properties(). The function now takes struct
> > property_entry as its parameter instead of struct
> > property_set.
> > 
> > Reviewed-by: Andy Shevchenko 
> > Reviewed-by: Mika Westerberg 
> > Acked-by: Thierry Reding 
> > Acked-by: Lee Jones 
> > Signed-off-by: Heikki Krogerus 
> > ---
> >  arch/arm/mach-pxa/raumfeld.c  | 12 

Daniel, I think we just need your ACK for this one.

Otherwise I think we are covered.

> >  arch/arm/mach-tegra/board-paz00.c |  6 +-
> >  drivers/base/platform.c   | 19 ++-
> >  drivers/base/property.c   | 34 +-
> >  drivers/mfd/intel-lpss-acpi.c | 12 ++--
> >  drivers/mfd/intel-lpss-pci.c  | 20 
> >  drivers/mfd/intel-lpss.c  |  2 +-
> >  drivers/mfd/intel-lpss.h  |  4 ++--
> >  drivers/mfd/mfd-core.c|  4 ++--
> >  include/linux/mfd/core.h  |  4 ++--
> >  include/linux/platform_device.h   |  6 +++---
> >  include/linux/property.h  | 15 +++
> >  12 files changed, 55 insertions(+), 83 deletions(-)
> 
> What's happening with this patch?  I believe we're still missing
> Acks.  Once they are collected someone needs to create an immutable
> branch and send out a pull-request.

Rafael, have you had time to take a look at this?


Thanks,

-- 
heikki

Re: [PATCH v3] device property: don't bother the drivers with struct property_set

[Lee Jones]

On Tue, 29 Mar 2016, Heikki Krogerus wrote:

> Since device_add_property_set() now always takes a copy of
> the property_set, and also since the fwnode type is always
> hard coded to be FWNODE_PDATA, there is no need for the
> drivers to deliver the entire struct property_set. The
> function can just create the instance of it on its own and
> bind the properties from the drivers to it on the spot.
> 
> This renames device_add_property_set() to
> device_add_properties(). The function now takes struct
> property_entry as its parameter instead of struct
> property_set.
> 
> Reviewed-by: Andy Shevchenko 
> Reviewed-by: Mika Westerberg 
> Acked-by: Thierry Reding 
> Acked-by: Lee Jones 
> Signed-off-by: Heikki Krogerus 
> ---
>  arch/arm/mach-pxa/raumfeld.c  | 12 
>  arch/arm/mach-tegra/board-paz00.c |  6 +-
>  drivers/base/platform.c   | 19 ++-
>  drivers/base/property.c   | 34 +-
>  drivers/mfd/intel-lpss-acpi.c | 12 ++--
>  drivers/mfd/intel-lpss-pci.c  | 20 
>  drivers/mfd/intel-lpss.c  |  2 +-
>  drivers/mfd/intel-lpss.h  |  4 ++--
>  drivers/mfd/mfd-core.c|  4 ++--
>  include/linux/mfd/core.h  |  4 ++--
>  include/linux/platform_device.h   |  6 +++---
>  include/linux/property.h  | 15 +++
>  12 files changed, 55 insertions(+), 83 deletions(-)

What's happening with this patch?  I believe we're still missing
Acks.  Once they are collected someone needs to create an immutable
branch and send out a pull-request.

> Changes since v2:
> - Changed the function name also in raumfeld.c. Thanks 0-Day test for 
> capturing
>   that one.
> 
> Changes since v1:
> - Added the new users of the property framework
> 
> 
> diff --git a/arch/arm/mach-pxa/raumfeld.c b/arch/arm/mach-pxa/raumfeld.c
> index 5a941bd..e216433 100644
> --- a/arch/arm/mach-pxa/raumfeld.c
> +++ b/arch/arm/mach-pxa/raumfeld.c
> @@ -385,10 +385,6 @@ static struct property_entry 
> raumfeld_rotary_properties[] = {
>   { },
>  };
>  
> -static struct property_set raumfeld_rotary_property_set = {
> - .properties = raumfeld_rotary_properties,
> -};
> -
>  static struct platform_device rotary_encoder_device = {
>   .name   = "rotary-encoder",
>   .id = 0,
> @@ -1063,8 +1059,8 @@ static void __init __maybe_unused 
> raumfeld_controller_init(void)
>   pxa3xx_mfp_config(ARRAY_AND_SIZE(raumfeld_controller_pin_config));
>  
>   gpiod_add_lookup_table(_rotary_gpios_table);
> - device_add_property_set(_encoder_device.dev,
> - _rotary_property_set);
> + device_add_properties(_encoder_device.dev,
> +   raumfeld_rotary_properties);
>   platform_device_register(_encoder_device);
>  
>   spi_register_board_info(ARRAY_AND_SIZE(controller_spi_devices));
> @@ -1103,8 +1099,8 @@ static void __init __maybe_unused 
> raumfeld_speaker_init(void)
>   platform_device_register(_device);
>  
>   gpiod_add_lookup_table(_rotary_gpios_table);
> - device_add_property_set(_encoder_device.dev,
> - _rotary_property_set);
> + device_add_properties(_encoder_device.dev,
> +   raumfeld_rotary_properties);
>   platform_device_register(_encoder_device);
>  
>   raumfeld_audio_init();
> diff --git a/arch/arm/mach-tegra/board-paz00.c 
> b/arch/arm/mach-tegra/board-paz00.c
> index 52db8bf..7478f6f 100644
> --- a/arch/arm/mach-tegra/board-paz00.c
> +++ b/arch/arm/mach-tegra/board-paz00.c
> @@ -29,10 +29,6 @@ static struct property_entry __initdata wifi_rfkill_prop[] 
> = {
>   { },
>  };
>  
> -static struct property_set __initdata wifi_rfkill_pset = {
> - .properties = wifi_rfkill_prop,
> -};
> -
>  static struct platform_device wifi_rfkill_device = {
>   .name   = "rfkill_gpio",
>   .id = -1,
> @@ -49,7 +45,7 @@ static struct gpiod_lookup_table wifi_gpio_lookup = {
>  
>  void __init tegra_paz00_wifikill_init(void)
>  {
> - platform_device_add_properties(_rfkill_device, _rfkill_pset);
> + platform_device_add_properties(_rfkill_device, wifi_rfkill_prop);
>   gpiod_add_lookup_table(_gpio_lookup);
>   platform_device_register(_rfkill_device);
>  }
> diff --git a/drivers/base/platform.c b/drivers/base/platform.c
> index f437afa..6482d47 100644
> --- a/drivers/base/platform.c
> +++ b/drivers/base/platform.c
> @@ -322,16 +322,16 @@ EXPORT_SYMBOL_GPL(platform_device_add_data);
>  /**
>   * platform_device_add_properties - add built-in properties to a platform 
> device
>   * @pdev: platform device to add properties to
> - * @pset: properties to add
> + * @properties: null terminated array of properties to add
>   *
> - * The function will take deep copy of the 

Re: [PATCH v3] device property: don't bother the drivers with struct property_set

[Lee Jones]

On Tue, 29 Mar 2016, Heikki Krogerus wrote:

> Since device_add_property_set() now always takes a copy of
> the property_set, and also since the fwnode type is always
> hard coded to be FWNODE_PDATA, there is no need for the
> drivers to deliver the entire struct property_set. The
> function can just create the instance of it on its own and
> bind the properties from the drivers to it on the spot.
> 
> This renames device_add_property_set() to
> device_add_properties(). The function now takes struct
> property_entry as its parameter instead of struct
> property_set.
> 
> Reviewed-by: Andy Shevchenko 
> Reviewed-by: Mika Westerberg 
> Acked-by: Thierry Reding 
> Acked-by: Lee Jones 
> Signed-off-by: Heikki Krogerus 
> ---
>  arch/arm/mach-pxa/raumfeld.c  | 12 
>  arch/arm/mach-tegra/board-paz00.c |  6 +-
>  drivers/base/platform.c   | 19 ++-
>  drivers/base/property.c   | 34 +-
>  drivers/mfd/intel-lpss-acpi.c | 12 ++--
>  drivers/mfd/intel-lpss-pci.c  | 20 
>  drivers/mfd/intel-lpss.c  |  2 +-
>  drivers/mfd/intel-lpss.h  |  4 ++--
>  drivers/mfd/mfd-core.c|  4 ++--
>  include/linux/mfd/core.h  |  4 ++--
>  include/linux/platform_device.h   |  6 +++---
>  include/linux/property.h  | 15 +++
>  12 files changed, 55 insertions(+), 83 deletions(-)

What's happening with this patch?  I believe we're still missing
Acks.  Once they are collected someone needs to create an immutable
branch and send out a pull-request.

> Changes since v2:
> - Changed the function name also in raumfeld.c. Thanks 0-Day test for 
> capturing
>   that one.
> 
> Changes since v1:
> - Added the new users of the property framework
> 
> 
> diff --git a/arch/arm/mach-pxa/raumfeld.c b/arch/arm/mach-pxa/raumfeld.c
> index 5a941bd..e216433 100644
> --- a/arch/arm/mach-pxa/raumfeld.c
> +++ b/arch/arm/mach-pxa/raumfeld.c
> @@ -385,10 +385,6 @@ static struct property_entry 
> raumfeld_rotary_properties[] = {
>   { },
>  };
>  
> -static struct property_set raumfeld_rotary_property_set = {
> - .properties = raumfeld_rotary_properties,
> -};
> -
>  static struct platform_device rotary_encoder_device = {
>   .name   = "rotary-encoder",
>   .id = 0,
> @@ -1063,8 +1059,8 @@ static void __init __maybe_unused 
> raumfeld_controller_init(void)
>   pxa3xx_mfp_config(ARRAY_AND_SIZE(raumfeld_controller_pin_config));
>  
>   gpiod_add_lookup_table(_rotary_gpios_table);
> - device_add_property_set(_encoder_device.dev,
> - _rotary_property_set);
> + device_add_properties(_encoder_device.dev,
> +   raumfeld_rotary_properties);
>   platform_device_register(_encoder_device);
>  
>   spi_register_board_info(ARRAY_AND_SIZE(controller_spi_devices));
> @@ -1103,8 +1099,8 @@ static void __init __maybe_unused 
> raumfeld_speaker_init(void)
>   platform_device_register(_device);
>  
>   gpiod_add_lookup_table(_rotary_gpios_table);
> - device_add_property_set(_encoder_device.dev,
> - _rotary_property_set);
> + device_add_properties(_encoder_device.dev,
> +   raumfeld_rotary_properties);
>   platform_device_register(_encoder_device);
>  
>   raumfeld_audio_init();
> diff --git a/arch/arm/mach-tegra/board-paz00.c 
> b/arch/arm/mach-tegra/board-paz00.c
> index 52db8bf..7478f6f 100644
> --- a/arch/arm/mach-tegra/board-paz00.c
> +++ b/arch/arm/mach-tegra/board-paz00.c
> @@ -29,10 +29,6 @@ static struct property_entry __initdata wifi_rfkill_prop[] 
> = {
>   { },
>  };
>  
> -static struct property_set __initdata wifi_rfkill_pset = {
> - .properties = wifi_rfkill_prop,
> -};
> -
>  static struct platform_device wifi_rfkill_device = {
>   .name   = "rfkill_gpio",
>   .id = -1,
> @@ -49,7 +45,7 @@ static struct gpiod_lookup_table wifi_gpio_lookup = {
>  
>  void __init tegra_paz00_wifikill_init(void)
>  {
> - platform_device_add_properties(_rfkill_device, _rfkill_pset);
> + platform_device_add_properties(_rfkill_device, wifi_rfkill_prop);
>   gpiod_add_lookup_table(_gpio_lookup);
>   platform_device_register(_rfkill_device);
>  }
> diff --git a/drivers/base/platform.c b/drivers/base/platform.c
> index f437afa..6482d47 100644
> --- a/drivers/base/platform.c
> +++ b/drivers/base/platform.c
> @@ -322,16 +322,16 @@ EXPORT_SYMBOL_GPL(platform_device_add_data);
>  /**
>   * platform_device_add_properties - add built-in properties to a platform 
> device
>   * @pdev: platform device to add properties to
> - * @pset: properties to add
> + * @properties: null terminated array of properties to add
>   *
> - * The function will take deep copy of the properties in @pset and attach
> - * the copy to the platform device. The memory associated with properties
> - * will be freed when the platform 

[PATCH v3] device property: don't bother the drivers with struct property_set

[Heikki Krogerus]

Since device_add_property_set() now always takes a copy of
the property_set, and also since the fwnode type is always
hard coded to be FWNODE_PDATA, there is no need for the
drivers to deliver the entire struct property_set. The
function can just create the instance of it on its own and
bind the properties from the drivers to it on the spot.

This renames device_add_property_set() to
device_add_properties(). The function now takes struct
property_entry as its parameter instead of struct
property_set.

Reviewed-by: Andy Shevchenko 
Reviewed-by: Mika Westerberg 
Acked-by: Thierry Reding 
Acked-by: Lee Jones 
Signed-off-by: Heikki Krogerus 
---
 arch/arm/mach-pxa/raumfeld.c  | 12 
 arch/arm/mach-tegra/board-paz00.c |  6 +-
 drivers/base/platform.c   | 19 ++-
 drivers/base/property.c   | 34 +-
 drivers/mfd/intel-lpss-acpi.c | 12 ++--
 drivers/mfd/intel-lpss-pci.c  | 20 
 drivers/mfd/intel-lpss.c  |  2 +-
 drivers/mfd/intel-lpss.h  |  4 ++--
 drivers/mfd/mfd-core.c|  4 ++--
 include/linux/mfd/core.h  |  4 ++--
 include/linux/platform_device.h   |  6 +++---
 include/linux/property.h  | 15 +++
 12 files changed, 55 insertions(+), 83 deletions(-)

Hi,

Changes since v2:
- Changed the function name also in raumfeld.c. Thanks 0-Day test for capturing
  that one.

Changes since v1:
- Added the new users of the property framework


diff --git a/arch/arm/mach-pxa/raumfeld.c b/arch/arm/mach-pxa/raumfeld.c
index 5a941bd..e216433 100644
--- a/arch/arm/mach-pxa/raumfeld.c
+++ b/arch/arm/mach-pxa/raumfeld.c
@@ -385,10 +385,6 @@ static struct property_entry raumfeld_rotary_properties[] 
= {
{ },
 };
 
-static struct property_set raumfeld_rotary_property_set = {
-   .properties = raumfeld_rotary_properties,
-};
-
 static struct platform_device rotary_encoder_device = {
.name   = "rotary-encoder",
.id = 0,
@@ -1063,8 +1059,8 @@ static void __init __maybe_unused 
raumfeld_controller_init(void)
pxa3xx_mfp_config(ARRAY_AND_SIZE(raumfeld_controller_pin_config));
 
gpiod_add_lookup_table(_rotary_gpios_table);
-   device_add_property_set(_encoder_device.dev,
-   _rotary_property_set);
+   device_add_properties(_encoder_device.dev,
+ raumfeld_rotary_properties);
platform_device_register(_encoder_device);
 
spi_register_board_info(ARRAY_AND_SIZE(controller_spi_devices));
@@ -1103,8 +1099,8 @@ static void __init __maybe_unused 
raumfeld_speaker_init(void)
platform_device_register(_device);
 
gpiod_add_lookup_table(_rotary_gpios_table);
-   device_add_property_set(_encoder_device.dev,
-   _rotary_property_set);
+   device_add_properties(_encoder_device.dev,
+ raumfeld_rotary_properties);
platform_device_register(_encoder_device);
 
raumfeld_audio_init();
diff --git a/arch/arm/mach-tegra/board-paz00.c 
b/arch/arm/mach-tegra/board-paz00.c
index 52db8bf..7478f6f 100644
--- a/arch/arm/mach-tegra/board-paz00.c
+++ b/arch/arm/mach-tegra/board-paz00.c
@@ -29,10 +29,6 @@ static struct property_entry __initdata wifi_rfkill_prop[] = 
{
{ },
 };
 
-static struct property_set __initdata wifi_rfkill_pset = {
-   .properties = wifi_rfkill_prop,
-};
-
 static struct platform_device wifi_rfkill_device = {
.name   = "rfkill_gpio",
.id = -1,
@@ -49,7 +45,7 @@ static struct gpiod_lookup_table wifi_gpio_lookup = {
 
 void __init tegra_paz00_wifikill_init(void)
 {
-   platform_device_add_properties(_rfkill_device, _rfkill_pset);
+   platform_device_add_properties(_rfkill_device, wifi_rfkill_prop);
gpiod_add_lookup_table(_gpio_lookup);
platform_device_register(_rfkill_device);
 }
diff --git a/drivers/base/platform.c b/drivers/base/platform.c
index f437afa..6482d47 100644
--- a/drivers/base/platform.c
+++ b/drivers/base/platform.c
@@ -322,16 +322,16 @@ EXPORT_SYMBOL_GPL(platform_device_add_data);
 /**
  * platform_device_add_properties - add built-in properties to a platform 
device
  * @pdev: platform device to add properties to
- * @pset: properties to add
+ * @properties: null terminated array of properties to add
  *
- * The function will take deep copy of the properties in @pset and attach
- * the copy to the platform device. The memory associated with properties
- * will be freed when the platform device is released.
+ * The function will take deep copy of @properties and attach the copy to the
+ * platform device. The memory associated with properties will be freed when 
the
+ * platform device is released.
  */
 int 

[PATCH v3] device property: don't bother the drivers with struct property_set

[Heikki Krogerus]

Since device_add_property_set() now always takes a copy of
the property_set, and also since the fwnode type is always
hard coded to be FWNODE_PDATA, there is no need for the
drivers to deliver the entire struct property_set. The
function can just create the instance of it on its own and
bind the properties from the drivers to it on the spot.

This renames device_add_property_set() to
device_add_properties(). The function now takes struct
property_entry as its parameter instead of struct
property_set.

Reviewed-by: Andy Shevchenko 
Reviewed-by: Mika Westerberg 
Acked-by: Thierry Reding 
Acked-by: Lee Jones 
Signed-off-by: Heikki Krogerus 
---
 arch/arm/mach-pxa/raumfeld.c  | 12 
 arch/arm/mach-tegra/board-paz00.c |  6 +-
 drivers/base/platform.c   | 19 ++-
 drivers/base/property.c   | 34 +-
 drivers/mfd/intel-lpss-acpi.c | 12 ++--
 drivers/mfd/intel-lpss-pci.c  | 20 
 drivers/mfd/intel-lpss.c  |  2 +-
 drivers/mfd/intel-lpss.h  |  4 ++--
 drivers/mfd/mfd-core.c|  4 ++--
 include/linux/mfd/core.h  |  4 ++--
 include/linux/platform_device.h   |  6 +++---
 include/linux/property.h  | 15 +++
 12 files changed, 55 insertions(+), 83 deletions(-)

Hi,

Changes since v2:
- Changed the function name also in raumfeld.c. Thanks 0-Day test for capturing
  that one.

Changes since v1:
- Added the new users of the property framework


diff --git a/arch/arm/mach-pxa/raumfeld.c b/arch/arm/mach-pxa/raumfeld.c
index 5a941bd..e216433 100644
--- a/arch/arm/mach-pxa/raumfeld.c
+++ b/arch/arm/mach-pxa/raumfeld.c
@@ -385,10 +385,6 @@ static struct property_entry raumfeld_rotary_properties[] 
= {
{ },
 };
 
-static struct property_set raumfeld_rotary_property_set = {
-   .properties = raumfeld_rotary_properties,
-};
-
 static struct platform_device rotary_encoder_device = {
.name   = "rotary-encoder",
.id = 0,
@@ -1063,8 +1059,8 @@ static void __init __maybe_unused 
raumfeld_controller_init(void)
pxa3xx_mfp_config(ARRAY_AND_SIZE(raumfeld_controller_pin_config));
 
gpiod_add_lookup_table(_rotary_gpios_table);
-   device_add_property_set(_encoder_device.dev,
-   _rotary_property_set);
+   device_add_properties(_encoder_device.dev,
+ raumfeld_rotary_properties);
platform_device_register(_encoder_device);
 
spi_register_board_info(ARRAY_AND_SIZE(controller_spi_devices));
@@ -1103,8 +1099,8 @@ static void __init __maybe_unused 
raumfeld_speaker_init(void)
platform_device_register(_device);
 
gpiod_add_lookup_table(_rotary_gpios_table);
-   device_add_property_set(_encoder_device.dev,
-   _rotary_property_set);
+   device_add_properties(_encoder_device.dev,
+ raumfeld_rotary_properties);
platform_device_register(_encoder_device);
 
raumfeld_audio_init();
diff --git a/arch/arm/mach-tegra/board-paz00.c 
b/arch/arm/mach-tegra/board-paz00.c
index 52db8bf..7478f6f 100644
--- a/arch/arm/mach-tegra/board-paz00.c
+++ b/arch/arm/mach-tegra/board-paz00.c
@@ -29,10 +29,6 @@ static struct property_entry __initdata wifi_rfkill_prop[] = 
{
{ },
 };
 
-static struct property_set __initdata wifi_rfkill_pset = {
-   .properties = wifi_rfkill_prop,
-};
-
 static struct platform_device wifi_rfkill_device = {
.name   = "rfkill_gpio",
.id = -1,
@@ -49,7 +45,7 @@ static struct gpiod_lookup_table wifi_gpio_lookup = {
 
 void __init tegra_paz00_wifikill_init(void)
 {
-   platform_device_add_properties(_rfkill_device, _rfkill_pset);
+   platform_device_add_properties(_rfkill_device, wifi_rfkill_prop);
gpiod_add_lookup_table(_gpio_lookup);
platform_device_register(_rfkill_device);
 }
diff --git a/drivers/base/platform.c b/drivers/base/platform.c
index f437afa..6482d47 100644
--- a/drivers/base/platform.c
+++ b/drivers/base/platform.c
@@ -322,16 +322,16 @@ EXPORT_SYMBOL_GPL(platform_device_add_data);
 /**
  * platform_device_add_properties - add built-in properties to a platform 
device
  * @pdev: platform device to add properties to
- * @pset: properties to add
+ * @properties: null terminated array of properties to add
  *
- * The function will take deep copy of the properties in @pset and attach
- * the copy to the platform device. The memory associated with properties
- * will be freed when the platform device is released.
+ * The function will take deep copy of @properties and attach the copy to the
+ * platform device. The memory associated with properties will be freed when 
the
+ * platform device is released.
  */
 int platform_device_add_properties(struct platform_device *pdev,
-  const struct property_set *pset)
+  struct