Re: [PATCH v3] staging: fsl-mc: move bus driver out of staging
Hi Andrew, On 11/28/2017 06:04 PM, Andrew Lunn wrote: > On Tue, Nov 28, 2017 at 05:27:57PM +0200, laurentiu.tu...@nxp.com wrote: >> diff --git a/drivers/staging/fsl-mc/bus/dpmcp.h b/drivers/bus/fsl-mc/dpmcp.h >> similarity index 100% >> rename from drivers/staging/fsl-mc/bus/dpmcp.h >> rename to drivers/bus/fsl-mc/dpmcp.h >> diff --git a/drivers/staging/fsl-mc/bus/dpmng-cmd.h >> b/drivers/bus/fsl-mc/dpmng-cmd.h >> similarity index 100% >> rename from drivers/staging/fsl-mc/bus/dpmng-cmd.h >> rename to drivers/bus/fsl-mc/dpmng-cmd.h >> diff --git a/drivers/staging/fsl-mc/bus/dprc-cmd.h >> b/drivers/bus/fsl-mc/dprc-cmd.h >> similarity index 100% >> rename from drivers/staging/fsl-mc/bus/dprc-cmd.h >> rename to drivers/bus/fsl-mc/dprc-cmd.h >> diff --git a/drivers/staging/fsl-mc/bus/dprc-driver.c >> b/drivers/bus/fsl-mc/dprc-driver.c >> similarity index 99% >> rename from drivers/staging/fsl-mc/bus/dprc-driver.c >> rename to drivers/bus/fsl-mc/dprc-driver.c > > Hi Laurentiu > > It is hard to review code when we don't see it. I'll reformat the patch with rename detection disabled, but please note that it will be pretty big (~370KiB). --- Best Regards, Laurentiu
Re: [PATCH v3] staging: fsl-mc: move bus driver out of staging
Hi Andrew, On 11/28/2017 06:04 PM, Andrew Lunn wrote: > On Tue, Nov 28, 2017 at 05:27:57PM +0200, laurentiu.tu...@nxp.com wrote: >> diff --git a/drivers/staging/fsl-mc/bus/dpmcp.h b/drivers/bus/fsl-mc/dpmcp.h >> similarity index 100% >> rename from drivers/staging/fsl-mc/bus/dpmcp.h >> rename to drivers/bus/fsl-mc/dpmcp.h >> diff --git a/drivers/staging/fsl-mc/bus/dpmng-cmd.h >> b/drivers/bus/fsl-mc/dpmng-cmd.h >> similarity index 100% >> rename from drivers/staging/fsl-mc/bus/dpmng-cmd.h >> rename to drivers/bus/fsl-mc/dpmng-cmd.h >> diff --git a/drivers/staging/fsl-mc/bus/dprc-cmd.h >> b/drivers/bus/fsl-mc/dprc-cmd.h >> similarity index 100% >> rename from drivers/staging/fsl-mc/bus/dprc-cmd.h >> rename to drivers/bus/fsl-mc/dprc-cmd.h >> diff --git a/drivers/staging/fsl-mc/bus/dprc-driver.c >> b/drivers/bus/fsl-mc/dprc-driver.c >> similarity index 99% >> rename from drivers/staging/fsl-mc/bus/dprc-driver.c >> rename to drivers/bus/fsl-mc/dprc-driver.c > > Hi Laurentiu > > It is hard to review code when we don't see it. I'll reformat the patch with rename detection disabled, but please note that it will be pretty big (~370KiB). --- Best Regards, Laurentiu
Re: [PATCH v3] staging: fsl-mc: move bus driver out of staging
On Tue, Nov 28, 2017 at 05:27:57PM +0200, laurentiu.tu...@nxp.com wrote: > diff --git a/drivers/staging/fsl-mc/bus/dpmcp.h b/drivers/bus/fsl-mc/dpmcp.h > similarity index 100% > rename from drivers/staging/fsl-mc/bus/dpmcp.h > rename to drivers/bus/fsl-mc/dpmcp.h > diff --git a/drivers/staging/fsl-mc/bus/dpmng-cmd.h > b/drivers/bus/fsl-mc/dpmng-cmd.h > similarity index 100% > rename from drivers/staging/fsl-mc/bus/dpmng-cmd.h > rename to drivers/bus/fsl-mc/dpmng-cmd.h > diff --git a/drivers/staging/fsl-mc/bus/dprc-cmd.h > b/drivers/bus/fsl-mc/dprc-cmd.h > similarity index 100% > rename from drivers/staging/fsl-mc/bus/dprc-cmd.h > rename to drivers/bus/fsl-mc/dprc-cmd.h > diff --git a/drivers/staging/fsl-mc/bus/dprc-driver.c > b/drivers/bus/fsl-mc/dprc-driver.c > similarity index 99% > rename from drivers/staging/fsl-mc/bus/dprc-driver.c > rename to drivers/bus/fsl-mc/dprc-driver.c Hi Laurentiu It is hard to review code when we don't see it. Andrew
Re: [PATCH v3] staging: fsl-mc: move bus driver out of staging
On Tue, Nov 28, 2017 at 05:27:57PM +0200, laurentiu.tu...@nxp.com wrote: > diff --git a/drivers/staging/fsl-mc/bus/dpmcp.h b/drivers/bus/fsl-mc/dpmcp.h > similarity index 100% > rename from drivers/staging/fsl-mc/bus/dpmcp.h > rename to drivers/bus/fsl-mc/dpmcp.h > diff --git a/drivers/staging/fsl-mc/bus/dpmng-cmd.h > b/drivers/bus/fsl-mc/dpmng-cmd.h > similarity index 100% > rename from drivers/staging/fsl-mc/bus/dpmng-cmd.h > rename to drivers/bus/fsl-mc/dpmng-cmd.h > diff --git a/drivers/staging/fsl-mc/bus/dprc-cmd.h > b/drivers/bus/fsl-mc/dprc-cmd.h > similarity index 100% > rename from drivers/staging/fsl-mc/bus/dprc-cmd.h > rename to drivers/bus/fsl-mc/dprc-cmd.h > diff --git a/drivers/staging/fsl-mc/bus/dprc-driver.c > b/drivers/bus/fsl-mc/dprc-driver.c > similarity index 99% > rename from drivers/staging/fsl-mc/bus/dprc-driver.c > rename to drivers/bus/fsl-mc/dprc-driver.c Hi Laurentiu It is hard to review code when we don't see it. Andrew
[PATCH v3] staging: fsl-mc: move bus driver out of staging
From: Stuart YoderMove the source files out of staging into their final locations: -include files in drivers/staging/fsl-mc/include go to include/linux/fsl -irq-gic-v3-its-fsl-mc-msi.c goes to drivers/irqchip -source in drivers/staging/fsl-mc/bus goes to drivers/bus/fsl-mc -README.txt, providing and overview of DPAA goes to Documentation/dpaa2/overview.txt Update or delete other remaining staging files-- Makefile, Kconfig, TODO. Update dpaa2_eth and dpio staging drivers. Signed-off-by: Stuart Yoder Signed-off-by: Laurentiu Tudor [Laurentiu: rebased, add dpaa2_eth and dpio #include updates] Cc: Thomas Gleixner Cc: Jason Cooper Cc: Marc Zyngier --- Notes: -v3: - rebased -v2: - group irqchip gic its glue code together with the rest (Marc Zyngier) .../README.txt => Documentation/dpaa2/overview.txt | 0 MAINTAINERS| 2 +- drivers/bus/Kconfig| 2 ++ drivers/bus/Makefile | 3 +++ drivers/bus/fsl-mc/Kconfig | 17 + drivers/bus/fsl-mc/Makefile| 17 + drivers/{staging/fsl-mc/bus => bus/fsl-mc}/dpmcp-cmd.h | 0 drivers/{staging/fsl-mc/bus => bus/fsl-mc}/dpmcp.c | 2 +- drivers/{staging/fsl-mc/bus => bus/fsl-mc}/dpmcp.h | 0 drivers/{staging/fsl-mc/bus => bus/fsl-mc}/dpmng-cmd.h | 0 drivers/{staging/fsl-mc/bus => bus/fsl-mc}/dprc-cmd.h | 0 .../{staging/fsl-mc/bus => bus/fsl-mc}/dprc-driver.c | 1 - drivers/{staging/fsl-mc/bus => bus/fsl-mc}/dprc.c | 2 +- drivers/{staging/fsl-mc/bus => bus/fsl-mc}/dprc.h | 0 .../fsl-mc/bus => bus/fsl-mc}/fsl-mc-allocator.c | 1 - .../{staging/fsl-mc/bus => bus/fsl-mc}/fsl-mc-bus.c| 0 .../{staging/fsl-mc/bus => bus/fsl-mc}/fsl-mc-msi.c| 0 .../fsl-mc/bus => bus/fsl-mc}/fsl-mc-private.h | 2 +- drivers/{staging/fsl-mc/bus => bus/fsl-mc}/mc-io.c | 1 - drivers/{staging/fsl-mc/bus => bus/fsl-mc}/mc-sys.c| 2 +- drivers/irqchip/Makefile | 1 + .../fsl-mc/bus => irqchip}/irq-gic-v3-its-fsl-mc-msi.c | 2 +- drivers/staging/fsl-dpaa2/ethernet/README | 2 +- drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 2 +- drivers/staging/fsl-dpaa2/ethernet/dpni.c | 2 +- drivers/staging/fsl-mc/TODO| 18 -- drivers/staging/fsl-mc/bus/Kconfig | 10 -- drivers/staging/fsl-mc/bus/Makefile| 15 ++- drivers/staging/fsl-mc/bus/dpbp.c | 2 +- drivers/staging/fsl-mc/bus/dpcon.c | 2 +- drivers/staging/fsl-mc/bus/dpio/dpio-driver.c | 2 +- drivers/staging/fsl-mc/bus/dpio/dpio-service.c | 2 +- drivers/staging/fsl-mc/bus/dpio/dpio.c | 2 +- .../staging/fsl-mc/include => include/linux/fsl}/mc.h | 0 34 files changed, 56 insertions(+), 58 deletions(-) rename drivers/staging/fsl-mc/README.txt => Documentation/dpaa2/overview.txt (100%) create mode 100644 drivers/bus/fsl-mc/Kconfig create mode 100644 drivers/bus/fsl-mc/Makefile rename drivers/{staging/fsl-mc/bus => bus/fsl-mc}/dpmcp-cmd.h (100%) rename drivers/{staging/fsl-mc/bus => bus/fsl-mc}/dpmcp.c (99%) rename drivers/{staging/fsl-mc/bus => bus/fsl-mc}/dpmcp.h (100%) rename drivers/{staging/fsl-mc/bus => bus/fsl-mc}/dpmng-cmd.h (100%) rename drivers/{staging/fsl-mc/bus => bus/fsl-mc}/dprc-cmd.h (100%) rename drivers/{staging/fsl-mc/bus => bus/fsl-mc}/dprc-driver.c (99%) rename drivers/{staging/fsl-mc/bus => bus/fsl-mc}/dprc.c (99%) rename drivers/{staging/fsl-mc/bus => bus/fsl-mc}/dprc.h (100%) rename drivers/{staging/fsl-mc/bus => bus/fsl-mc}/fsl-mc-allocator.c (99%) rename drivers/{staging/fsl-mc/bus => bus/fsl-mc}/fsl-mc-bus.c (100%) rename drivers/{staging/fsl-mc/bus => bus/fsl-mc}/fsl-mc-msi.c (100%) rename drivers/{staging/fsl-mc/bus => bus/fsl-mc}/fsl-mc-private.h (99%) rename drivers/{staging/fsl-mc/bus => bus/fsl-mc}/mc-io.c (99%) rename drivers/{staging/fsl-mc/bus => bus/fsl-mc}/mc-sys.c (99%) rename drivers/{staging/fsl-mc/bus => irqchip}/irq-gic-v3-its-fsl-mc-msi.c (99%) delete mode 100644 drivers/staging/fsl-mc/TODO rename {drivers/staging/fsl-mc/include => include/linux/fsl}/mc.h (100%) diff --git a/drivers/staging/fsl-mc/README.txt b/Documentation/dpaa2/overview.txt similarity index 100% rename from drivers/staging/fsl-mc/README.txt rename to Documentation/dpaa2/overview.txt diff --git a/MAINTAINERS b/MAINTAINERS index aa71ab52f..f2d9fe7 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -11276,7 +11276,7 @@ M: Stuart Yoder M: Laurentiu Tudor L: linux-kernel@vger.kernel.org
[PATCH v3] staging: fsl-mc: move bus driver out of staging
From: Stuart Yoder Move the source files out of staging into their final locations: -include files in drivers/staging/fsl-mc/include go to include/linux/fsl -irq-gic-v3-its-fsl-mc-msi.c goes to drivers/irqchip -source in drivers/staging/fsl-mc/bus goes to drivers/bus/fsl-mc -README.txt, providing and overview of DPAA goes to Documentation/dpaa2/overview.txt Update or delete other remaining staging files-- Makefile, Kconfig, TODO. Update dpaa2_eth and dpio staging drivers. Signed-off-by: Stuart Yoder Signed-off-by: Laurentiu Tudor [Laurentiu: rebased, add dpaa2_eth and dpio #include updates] Cc: Thomas Gleixner Cc: Jason Cooper Cc: Marc Zyngier --- Notes: -v3: - rebased -v2: - group irqchip gic its glue code together with the rest (Marc Zyngier) .../README.txt => Documentation/dpaa2/overview.txt | 0 MAINTAINERS| 2 +- drivers/bus/Kconfig| 2 ++ drivers/bus/Makefile | 3 +++ drivers/bus/fsl-mc/Kconfig | 17 + drivers/bus/fsl-mc/Makefile| 17 + drivers/{staging/fsl-mc/bus => bus/fsl-mc}/dpmcp-cmd.h | 0 drivers/{staging/fsl-mc/bus => bus/fsl-mc}/dpmcp.c | 2 +- drivers/{staging/fsl-mc/bus => bus/fsl-mc}/dpmcp.h | 0 drivers/{staging/fsl-mc/bus => bus/fsl-mc}/dpmng-cmd.h | 0 drivers/{staging/fsl-mc/bus => bus/fsl-mc}/dprc-cmd.h | 0 .../{staging/fsl-mc/bus => bus/fsl-mc}/dprc-driver.c | 1 - drivers/{staging/fsl-mc/bus => bus/fsl-mc}/dprc.c | 2 +- drivers/{staging/fsl-mc/bus => bus/fsl-mc}/dprc.h | 0 .../fsl-mc/bus => bus/fsl-mc}/fsl-mc-allocator.c | 1 - .../{staging/fsl-mc/bus => bus/fsl-mc}/fsl-mc-bus.c| 0 .../{staging/fsl-mc/bus => bus/fsl-mc}/fsl-mc-msi.c| 0 .../fsl-mc/bus => bus/fsl-mc}/fsl-mc-private.h | 2 +- drivers/{staging/fsl-mc/bus => bus/fsl-mc}/mc-io.c | 1 - drivers/{staging/fsl-mc/bus => bus/fsl-mc}/mc-sys.c| 2 +- drivers/irqchip/Makefile | 1 + .../fsl-mc/bus => irqchip}/irq-gic-v3-its-fsl-mc-msi.c | 2 +- drivers/staging/fsl-dpaa2/ethernet/README | 2 +- drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 2 +- drivers/staging/fsl-dpaa2/ethernet/dpni.c | 2 +- drivers/staging/fsl-mc/TODO| 18 -- drivers/staging/fsl-mc/bus/Kconfig | 10 -- drivers/staging/fsl-mc/bus/Makefile| 15 ++- drivers/staging/fsl-mc/bus/dpbp.c | 2 +- drivers/staging/fsl-mc/bus/dpcon.c | 2 +- drivers/staging/fsl-mc/bus/dpio/dpio-driver.c | 2 +- drivers/staging/fsl-mc/bus/dpio/dpio-service.c | 2 +- drivers/staging/fsl-mc/bus/dpio/dpio.c | 2 +- .../staging/fsl-mc/include => include/linux/fsl}/mc.h | 0 34 files changed, 56 insertions(+), 58 deletions(-) rename drivers/staging/fsl-mc/README.txt => Documentation/dpaa2/overview.txt (100%) create mode 100644 drivers/bus/fsl-mc/Kconfig create mode 100644 drivers/bus/fsl-mc/Makefile rename drivers/{staging/fsl-mc/bus => bus/fsl-mc}/dpmcp-cmd.h (100%) rename drivers/{staging/fsl-mc/bus => bus/fsl-mc}/dpmcp.c (99%) rename drivers/{staging/fsl-mc/bus => bus/fsl-mc}/dpmcp.h (100%) rename drivers/{staging/fsl-mc/bus => bus/fsl-mc}/dpmng-cmd.h (100%) rename drivers/{staging/fsl-mc/bus => bus/fsl-mc}/dprc-cmd.h (100%) rename drivers/{staging/fsl-mc/bus => bus/fsl-mc}/dprc-driver.c (99%) rename drivers/{staging/fsl-mc/bus => bus/fsl-mc}/dprc.c (99%) rename drivers/{staging/fsl-mc/bus => bus/fsl-mc}/dprc.h (100%) rename drivers/{staging/fsl-mc/bus => bus/fsl-mc}/fsl-mc-allocator.c (99%) rename drivers/{staging/fsl-mc/bus => bus/fsl-mc}/fsl-mc-bus.c (100%) rename drivers/{staging/fsl-mc/bus => bus/fsl-mc}/fsl-mc-msi.c (100%) rename drivers/{staging/fsl-mc/bus => bus/fsl-mc}/fsl-mc-private.h (99%) rename drivers/{staging/fsl-mc/bus => bus/fsl-mc}/mc-io.c (99%) rename drivers/{staging/fsl-mc/bus => bus/fsl-mc}/mc-sys.c (99%) rename drivers/{staging/fsl-mc/bus => irqchip}/irq-gic-v3-its-fsl-mc-msi.c (99%) delete mode 100644 drivers/staging/fsl-mc/TODO rename {drivers/staging/fsl-mc/include => include/linux/fsl}/mc.h (100%) diff --git a/drivers/staging/fsl-mc/README.txt b/Documentation/dpaa2/overview.txt similarity index 100% rename from drivers/staging/fsl-mc/README.txt rename to Documentation/dpaa2/overview.txt diff --git a/MAINTAINERS b/MAINTAINERS index aa71ab52f..f2d9fe7 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -11276,7 +11276,7 @@ M: Stuart Yoder M: Laurentiu Tudor L: linux-kernel@vger.kernel.org S: Maintained -F: drivers/staging/fsl-mc/ +F: drivers/bus/fsl-mc/ F: Documentation/devicetree/bindings/misc/fsl,qoriq-mc.txt QT1010 MEDIA DRIVER diff --git