Re: [RESEND PATCH v3 0/2] ata: ahci_brcm: Fix use of BCM7216 reset controller
On Thu, Jan 21, 2021 at 12:48:07PM -0800, Florian Fainelli wrote: > On 1/14/2021 12:46 PM, Florian Fainelli wrote: > > On 1/5/21 1:22 PM, Florian Fainelli wrote: > >> On 12/23/20 4:05 PM, Florian Fainelli wrote: > >>> > >>> > >>> On 12/16/2020 1:41 PM, Jim Quinlan wrote: > v3 -- discard commit from v2; instead rely on the new function > reset_control_rearm provided in a recent commit [1] applied > to reset/next. > -- New commit to correct pcie-brcmstb.c usage of a reset controller > to use reset/rearm verses deassert/assert. > > v2 -- refactor rescal-reset driver to implement assert/deassert rather > than > reset because the reset call only fires once per lifetime and we > need > to reset after every resume from S2 or S3. > -- Split the use of "ahci" and "rescal" controllers in separate fields > to keep things simple. > > v1 -- original > > > [1] Applied commit "reset: make shared pulsed reset controls > re-triggerable" > found at git://git.pengutronix.de/git/pza/linux.git > branch reset/shared-retrigger > >>> > >>> The changes in that branch above have now landed in Linus' tree with: > >>> > >>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=557acb3d2cd9c82de19f944f6cc967a347735385 > >>> > >>> It would be good if we could get both patches applied via the same tree > >>> or within the same cycle to avoid having either PCIe or SATA broken on > >>> these platforms. > >> > >> Ping? Can someone apply those patches if you are happy with them? Thank > >> you. > > > > Ping? Can we review and ideally also apply these patches? Thanks > > Is there something going on preventing these patches from being reviewed > and/or applied? It mentions a dependency, which makes it harder to apply. I see that dependency seems to have been applied, so maybe post an updated version of the series, including both patches. The series touches both ATA and PCI, so not immediately obvious where it should go. It looks like the ATA part is bigger, but only 2/2 went to linux-pci, so it's harder to figure this out than it should be. I poked around a bit on lore, but I can't find 1/2 at all: https://lore.kernel.org/linux-arm-kernel/20201216214106.32851-1-james.quin...@broadcom.com/ Maybe also include Nicolas Saenz Julienne directly in "To:". I know I look at stuff addressed directly to me first; the "CC:" flood gets overwhelming fast. I assume Lorenzo will look for at least an ack from Nicolas before doing anything. If you repost, it's nice if you match existing style, e.g., - PCI: brcmstb: use reset/rearm instead of deassert/assert + PCI: brcmstb: Use reset/rearm instead of deassert/assert Bjorn
Re: [RESEND PATCH v3 0/2] ata: ahci_brcm: Fix use of BCM7216 reset controller
On 1/14/2021 12:46 PM, Florian Fainelli wrote: > On 1/5/21 1:22 PM, Florian Fainelli wrote: >> On 12/23/20 4:05 PM, Florian Fainelli wrote: >>> >>> >>> On 12/16/2020 1:41 PM, Jim Quinlan wrote: v3 -- discard commit from v2; instead rely on the new function reset_control_rearm provided in a recent commit [1] applied to reset/next. -- New commit to correct pcie-brcmstb.c usage of a reset controller to use reset/rearm verses deassert/assert. v2 -- refactor rescal-reset driver to implement assert/deassert rather than reset because the reset call only fires once per lifetime and we need to reset after every resume from S2 or S3. -- Split the use of "ahci" and "rescal" controllers in separate fields to keep things simple. v1 -- original [1] Applied commit "reset: make shared pulsed reset controls re-triggerable" found at git://git.pengutronix.de/git/pza/linux.git branch reset/shared-retrigger >>> >>> The changes in that branch above have now landed in Linus' tree with: >>> >>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=557acb3d2cd9c82de19f944f6cc967a347735385 >>> >>> It would be good if we could get both patches applied via the same tree >>> or within the same cycle to avoid having either PCIe or SATA broken on >>> these platforms. >> >> Ping? Can someone apply those patches if you are happy with them? Thank you. > > Ping? Can we review and ideally also apply these patches? Thanks Is there something going on preventing these patches from being reviewed and/or applied? -- Florian
Re: [RESEND PATCH v3 0/2] ata: ahci_brcm: Fix use of BCM7216 reset controller
On 1/5/21 1:22 PM, Florian Fainelli wrote: > On 12/23/20 4:05 PM, Florian Fainelli wrote: >> >> >> On 12/16/2020 1:41 PM, Jim Quinlan wrote: >>> v3 -- discard commit from v2; instead rely on the new function >>> reset_control_rearm provided in a recent commit [1] applied >>> to reset/next. >>>-- New commit to correct pcie-brcmstb.c usage of a reset controller >>> to use reset/rearm verses deassert/assert. >>> >>> v2 -- refactor rescal-reset driver to implement assert/deassert rather than >>> reset because the reset call only fires once per lifetime and we need >>> to reset after every resume from S2 or S3. >>>-- Split the use of "ahci" and "rescal" controllers in separate fields >>> to keep things simple. >>> >>> v1 -- original >>> >>> >>> [1] Applied commit "reset: make shared pulsed reset controls re-triggerable" >>> found at git://git.pengutronix.de/git/pza/linux.git >>> branch reset/shared-retrigger >> >> The changes in that branch above have now landed in Linus' tree with: >> >> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=557acb3d2cd9c82de19f944f6cc967a347735385 >> >> It would be good if we could get both patches applied via the same tree >> or within the same cycle to avoid having either PCIe or SATA broken on >> these platforms. > > Ping? Can someone apply those patches if you are happy with them? Thank you. Ping? Can we review and ideally also apply these patches? Thanks -- Florian
Re: [RESEND PATCH v3 0/2] ata: ahci_brcm: Fix use of BCM7216 reset controller
On 12/23/20 4:05 PM, Florian Fainelli wrote: > > > On 12/16/2020 1:41 PM, Jim Quinlan wrote: >> v3 -- discard commit from v2; instead rely on the new function >> reset_control_rearm provided in a recent commit [1] applied >> to reset/next. >>-- New commit to correct pcie-brcmstb.c usage of a reset controller >> to use reset/rearm verses deassert/assert. >> >> v2 -- refactor rescal-reset driver to implement assert/deassert rather than >> reset because the reset call only fires once per lifetime and we need >> to reset after every resume from S2 or S3. >>-- Split the use of "ahci" and "rescal" controllers in separate fields >> to keep things simple. >> >> v1 -- original >> >> >> [1] Applied commit "reset: make shared pulsed reset controls re-triggerable" >> found at git://git.pengutronix.de/git/pza/linux.git >> branch reset/shared-retrigger > > The changes in that branch above have now landed in Linus' tree with: > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=557acb3d2cd9c82de19f944f6cc967a347735385 > > It would be good if we could get both patches applied via the same tree > or within the same cycle to avoid having either PCIe or SATA broken on > these platforms. Ping? Can someone apply those patches if you are happy with them? Thank you. -- Florian
Re: [RESEND PATCH v3 0/2] ata: ahci_brcm: Fix use of BCM7216 reset controller
On 12/16/2020 1:41 PM, Jim Quinlan wrote: > v3 -- discard commit from v2; instead rely on the new function > reset_control_rearm provided in a recent commit [1] applied > to reset/next. >-- New commit to correct pcie-brcmstb.c usage of a reset controller > to use reset/rearm verses deassert/assert. > > v2 -- refactor rescal-reset driver to implement assert/deassert rather than > reset because the reset call only fires once per lifetime and we need > to reset after every resume from S2 or S3. >-- Split the use of "ahci" and "rescal" controllers in separate fields > to keep things simple. > > v1 -- original > > > [1] Applied commit "reset: make shared pulsed reset controls re-triggerable" > found at git://git.pengutronix.de/git/pza/linux.git > branch reset/shared-retrigger The changes in that branch above have now landed in Linus' tree with: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=557acb3d2cd9c82de19f944f6cc967a347735385 It would be good if we could get both patches applied via the same tree or within the same cycle to avoid having either PCIe or SATA broken on these platforms. Thanks! -- Florian
[RESEND PATCH v3 0/2] ata: ahci_brcm: Fix use of BCM7216 reset controller
v3 -- discard commit from v2; instead rely on the new function reset_control_rearm provided in a recent commit [1] applied to reset/next. -- New commit to correct pcie-brcmstb.c usage of a reset controller to use reset/rearm verses deassert/assert. v2 -- refactor rescal-reset driver to implement assert/deassert rather than reset because the reset call only fires once per lifetime and we need to reset after every resume from S2 or S3. -- Split the use of "ahci" and "rescal" controllers in separate fields to keep things simple. v1 -- original [1] Applied commit "reset: make shared pulsed reset controls re-triggerable" found at git://git.pengutronix.de/git/pza/linux.git branch reset/shared-retrigger Jim Quinlan (2): ata: ahci_brcm: Fix use of BCM7216 reset controller PCI: brcmstb: use reset/rearm instead of deassert/assert drivers/ata/ahci_brcm.c | 46 +-- drivers/pci/controller/pcie-brcmstb.c | 19 +++ 2 files changed, 36 insertions(+), 29 deletions(-) -- 2.17.1
[PATCH v3 0/2] ata: ahci_brcm: Fix use of BCM7216 reset controller
v3 -- discard commit from v2; instead relay on the new function reset_control_rearm provided in a recent commit [1] applied to reset/next. -- New commit to correct pcie-brcmstb.c usage of a reset controller to use reset/rearm verses deassert/assert. v2 -- refactor rescal-reset driver to implement assert/deassert rather than reset because the reset call only fires once per lifetime and we need to reset after every resume from S2 or S3. -- Split the use of "ahci" and "rescal" controllers in separate fields to keep things simple. v1 -- original [1] Applied commit "reset: make shared pulsed reset controls re-triggerable" found at git://git.pengutronix.de/git/pza/linux.git branch reset/shared-retrigger Jim Quinlan (2): ata: ahci_brcm: Fix use of BCM7216 reset controller PCI: brcmstb: use reset/rearm instead of deassert/assert drivers/ata/ahci_brcm.c | 46 +-- drivers/pci/controller/pcie-brcmstb.c | 19 +++ 2 files changed, 36 insertions(+), 29 deletions(-) -- 2.17.1 smime.p7s Description: S/MIME Cryptographic Signature
