Re: [PATCH v3 0/2] net/macb: merge at91_ether driver into macb driver
Hello Dave, On Fri, 06 Mar 2015 15:18:30 -0500 (EST) David Miller wrote: > From: Boris Brezillon > Date: Fri, 6 Mar 2015 11:48:39 +0100 > > > Changes since v2: > > - rebase after changed brought by [1] > > Ugh, actually I'm tossing all of your changes. Please do not make > complex dependencies like this. Okay, I'll remember that next time I submit patches to netdev. I've sent a new series integrating the patch this series depends on. Let me know if there's something wrong in this one. > > And furthermore, don't reference other sets of changes via lkml > postings. Reference them by where they are in patchwork which is > the definitive location for networking patch submissions. Noted. Best Regards, Boris -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v3 0/2] net/macb: merge at91_ether driver into macb driver
From: Boris Brezillon Date: Fri, 6 Mar 2015 11:48:39 +0100 > Changes since v2: > - rebase after changed brought by [1] Ugh, actually I'm tossing all of your changes. Please do not make complex dependencies like this. And furthermore, don't reference other sets of changes via lkml postings. Reference them by where they are in patchwork which is the definitive location for networking patch submissions. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH v3 0/2] net/macb: merge at91_ether driver into macb driver
Hello, The rm9200 boards use the dedicated at91_ether driver instead of the regular macb driver. Both the macb and at91_ether drivers can be compiled as separated modules. Since the at91_ether driver uses code from the macb driver, at91_ether.ko depends on macb.ko. However the macb.ko module always fails to load on rm9200 boards: the macb_probe() function expects a hclk clock which doesn't exist on rm9200. Then the at91_ether.ko can't be loaded in turn due to unresolved dependencies. This series of patches fix this issue by merging at91_ether into macb. This series depends on this one [1]. Best Regards, Boris Changes since v2: - rebase after changed brought by [1] Changes since v1: - rework probe functions to share common probing logic [1]https://lkml.org/lkml/2015/3/6/234 Cyrille Pitchen (2): net/macb: unify clock management net/macb: merge at91_ether driver into macb driver drivers/net/ethernet/cadence/Kconfig | 8 - drivers/net/ethernet/cadence/Makefile | 1 - drivers/net/ethernet/cadence/at91_ether.c | 481 -- drivers/net/ethernet/cadence/macb.c | 660 ++ drivers/net/ethernet/cadence/macb.h | 10 +- 5 files changed, 493 insertions(+), 667 deletions(-) delete mode 100644 drivers/net/ethernet/cadence/at91_ether.c -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH v3 0/2] net/macb: merge at91_ether driver into macb driver
Hello, The rm9200 boards use the dedicated at91_ether driver instead of the regular macb driver. Both the macb and at91_ether drivers can be compiled as separated modules. Since the at91_ether driver uses code from the macb driver, at91_ether.ko depends on macb.ko. However the macb.ko module always fails to load on rm9200 boards: the macb_probe() function expects a hclk clock which doesn't exist on rm9200. Then the at91_ether.ko can't be loaded in turn due to unresolved dependencies. This series of patches fix this issue by merging at91_ether into macb. This series depends on this one [1]. Best Regards, Boris Changes since v2: - rebase after changed brought by [1] Changes since v1: - rework probe functions to share common probing logic [1]https://lkml.org/lkml/2015/3/6/234 Cyrille Pitchen (2): net/macb: unify clock management net/macb: merge at91_ether driver into macb driver drivers/net/ethernet/cadence/Kconfig | 8 - drivers/net/ethernet/cadence/Makefile | 1 - drivers/net/ethernet/cadence/at91_ether.c | 481 -- drivers/net/ethernet/cadence/macb.c | 660 ++ drivers/net/ethernet/cadence/macb.h | 10 +- 5 files changed, 493 insertions(+), 667 deletions(-) delete mode 100644 drivers/net/ethernet/cadence/at91_ether.c -- 1.9.1 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v3 0/2] net/macb: merge at91_ether driver into macb driver
From: Boris Brezillon boris.brezil...@free-electrons.com Date: Fri, 6 Mar 2015 11:48:39 +0100 Changes since v2: - rebase after changed brought by [1] Ugh, actually I'm tossing all of your changes. Please do not make complex dependencies like this. And furthermore, don't reference other sets of changes via lkml postings. Reference them by where they are in patchwork which is the definitive location for networking patch submissions. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v3 0/2] net/macb: merge at91_ether driver into macb driver
Hello Dave, On Fri, 06 Mar 2015 15:18:30 -0500 (EST) David Miller da...@davemloft.net wrote: From: Boris Brezillon boris.brezil...@free-electrons.com Date: Fri, 6 Mar 2015 11:48:39 +0100 Changes since v2: - rebase after changed brought by [1] Ugh, actually I'm tossing all of your changes. Please do not make complex dependencies like this. Okay, I'll remember that next time I submit patches to netdev. I've sent a new series integrating the patch this series depends on. Let me know if there's something wrong in this one. And furthermore, don't reference other sets of changes via lkml postings. Reference them by where they are in patchwork which is the definitive location for networking patch submissions. Noted. Best Regards, Boris -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
