Re: [PATCH v3 01/17] pinctrl: dt-bindings: samsung: Add header with values used for configuration

2016-09-16 Thread Krzysztof Kozlowski 
On 09/07/2016 11:18 PM, Linus Walleij wrote:
> On Sun, Sep 4, 2016 at 1:04 PM, Krzysztof Kozlowski  wrote:
> 
>> From: Krzysztof Kozlowski 
>>
>> Hard-coded pinctrl configuration values are scattered through DTS files.
>> The numbers are difficult to decode by human, especially without the
>> datasheet.  Additionally the drive strength differs between S3C64xx,
>> S5PV210 and Exynos SoC families increasing the confusion.
>>
>> The header will help making this more readable and maintainable.
>>
>> Signed-off-by: Krzysztof Kozlowski 
>> Reviewed-by: Javier Martinez Canillas 
> 
> Acked-by: Linus Walleij 
> 
> Take this with the rest of the changes into ARM SoC.

Thanks!

Applied entire patchset.

Best regards,
Krzysztof

Re: [PATCH v3 01/17] pinctrl: dt-bindings: samsung: Add header with values used for configuration

2016-09-16 Thread Krzysztof Kozlowski 
On 09/07/2016 11:18 PM, Linus Walleij wrote:
> On Sun, Sep 4, 2016 at 1:04 PM, Krzysztof Kozlowski  wrote:
> 
>> From: Krzysztof Kozlowski 
>>
>> Hard-coded pinctrl configuration values are scattered through DTS files.
>> The numbers are difficult to decode by human, especially without the
>> datasheet.  Additionally the drive strength differs between S3C64xx,
>> S5PV210 and Exynos SoC families increasing the confusion.
>>
>> The header will help making this more readable and maintainable.
>>
>> Signed-off-by: Krzysztof Kozlowski 
>> Reviewed-by: Javier Martinez Canillas 
> 
> Acked-by: Linus Walleij 
> 
> Take this with the rest of the changes into ARM SoC.

Thanks!

Applied entire patchset.

Best regards,
Krzysztof

Re: [PATCH v3 01/17] pinctrl: dt-bindings: samsung: Add header with values used for configuration

2016-09-07 Thread Linus Walleij 
On Sun, Sep 4, 2016 at 1:04 PM, Krzysztof Kozlowski  wrote:

> From: Krzysztof Kozlowski 
>
> Hard-coded pinctrl configuration values are scattered through DTS files.
> The numbers are difficult to decode by human, especially without the
> datasheet.  Additionally the drive strength differs between S3C64xx,
> S5PV210 and Exynos SoC families increasing the confusion.
>
> The header will help making this more readable and maintainable.
>
> Signed-off-by: Krzysztof Kozlowski 
> Reviewed-by: Javier Martinez Canillas 

Acked-by: Linus Walleij 

Take this with the rest of the changes into ARM SoC.

Yours,
Linus Walleij

Re: [PATCH v3 01/17] pinctrl: dt-bindings: samsung: Add header with values used for configuration

2016-09-07 Thread Linus Walleij 
On Sun, Sep 4, 2016 at 1:04 PM, Krzysztof Kozlowski  wrote:

> From: Krzysztof Kozlowski 
>
> Hard-coded pinctrl configuration values are scattered through DTS files.
> The numbers are difficult to decode by human, especially without the
> datasheet.  Additionally the drive strength differs between S3C64xx,
> S5PV210 and Exynos SoC families increasing the confusion.
>
> The header will help making this more readable and maintainable.
>
> Signed-off-by: Krzysztof Kozlowski 
> Reviewed-by: Javier Martinez Canillas 

Acked-by: Linus Walleij 

Take this with the rest of the changes into ARM SoC.

Yours,
Linus Walleij

[PATCH v3 01/17] pinctrl: dt-bindings: samsung: Add header with values used for configuration

2016-09-04 Thread Krzysztof Kozlowski 
From: Krzysztof Kozlowski 

Hard-coded pinctrl configuration values are scattered through DTS files.
The numbers are difficult to decode by human, especially without the
datasheet.  Additionally the drive strength differs between S3C64xx,
S5PV210 and Exynos SoC families increasing the confusion.

The header will help making this more readable and maintainable.

Signed-off-by: Krzysztof Kozlowski 
Reviewed-by: Javier Martinez Canillas 

---

Changes since v2:
1. Rename double-include protection (suggested by Bartlomiej).
2. Squash here:
   pinctrl: dt-bindings: samsung: Add macros for S3C64xx pin configuration
   http://www.spinics.net/lists/arm-kernel/msg528016.html
3. Add Javier's reviewed-by.
4. Extend MAINTAINERS entry with bindings documentation
---
 MAINTAINERS   |  2 ++
 include/dt-bindings/pinctrl/samsung.h | 57 +++
 2 files changed, 59 insertions(+)
 create mode 100644 include/dt-bindings/pinctrl/samsung.h

diff --git a/MAINTAINERS b/MAINTAINERS
index d8e81b1dde30..be3dcca8439a 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -9318,6 +9318,8 @@ L:linux-arm-ker...@lists.infradead.org (moderated 
for non-subscribers)
 L: linux-samsung-...@vger.kernel.org (moderated for non-subscribers)
 S: Maintained
 F: drivers/pinctrl/samsung/
+F: include/dt-bindings/pinctrl/samsung.h
+F: Documentation/devicetree/bindings/pinctrl/samsung-pinctrl.txt
 
 PIN CONTROLLER - SINGLE
 M: Tony Lindgren 
diff --git a/include/dt-bindings/pinctrl/samsung.h 
b/include/dt-bindings/pinctrl/samsung.h
new file mode 100644
index ..6276eb785e2b
--- /dev/null
+++ b/include/dt-bindings/pinctrl/samsung.h
@@ -0,0 +1,57 @@
+/*
+ * Samsung's Exynos pinctrl bindings
+ *
+ * Copyright (c) 2016 Samsung Electronics Co., Ltd.
+ * http://www.samsung.com
+ * Author: Krzysztof Kozlowski 
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+*/
+
+#ifndef __DT_BINDINGS_PINCTRL_SAMSUNG_H__
+#define __DT_BINDINGS_PINCTRL_SAMSUNG_H__
+
+#define EXYNOS_PIN_PULL_NONE   0
+#define EXYNOS_PIN_PULL_DOWN   1
+#define EXYNOS_PIN_PULL_UP 3
+
+#define S3C64XX_PIN_PULL_NONE  0
+#define S3C64XX_PIN_PULL_DOWN  1
+#define S3C64XX_PIN_PULL_UP2
+
+/* Pin function in power down mode */
+#define EXYNOS_PIN_PDN_OUT00
+#define EXYNOS_PIN_PDN_OUT11
+#define EXYNOS_PIN_PDN_INPUT   2
+#define EXYNOS_PIN_PDN_PREV3
+
+/* Drive strengths for Exynos3250, Exynos4 (all) and Exynos5250 */
+#define EXYNOS4_PIN_DRV_LV10
+#define EXYNOS4_PIN_DRV_LV22
+#define EXYNOS4_PIN_DRV_LV31
+#define EXYNOS4_PIN_DRV_LV43
+
+/* Drive strengths for Exynos5260 */
+#define EXYNOS5260_PIN_DRV_LV1 0
+#define EXYNOS5260_PIN_DRV_LV2 1
+#define EXYNOS5260_PIN_DRV_LV4 2
+#define EXYNOS5260_PIN_DRV_LV6 3
+
+/* Drive strengths for Exynos5410, Exynos542x and Exynos5800 */
+#define EXYNOS5420_PIN_DRV_LV1 0
+#define EXYNOS5420_PIN_DRV_LV2 1
+#define EXYNOS5420_PIN_DRV_LV3 2
+#define EXYNOS5420_PIN_DRV_LV4 3
+
+#define EXYNOS_PIN_FUNC_INPUT  0
+#define EXYNOS_PIN_FUNC_OUTPUT 1
+#define EXYNOS_PIN_FUNC_2  2
+#define EXYNOS_PIN_FUNC_3  3
+#define EXYNOS_PIN_FUNC_4  4
+#define EXYNOS_PIN_FUNC_5  5
+#define EXYNOS_PIN_FUNC_6  6
+#define EXYNOS_PIN_FUNC_F  0xf
+
+#endif /* __DT_BINDINGS_PINCTRL_SAMSUNG_H__ */
-- 
2.7.4

[PATCH v3 01/17] pinctrl: dt-bindings: samsung: Add header with values used for configuration

2016-09-04 Thread Krzysztof Kozlowski 
From: Krzysztof Kozlowski 

Hard-coded pinctrl configuration values are scattered through DTS files.
The numbers are difficult to decode by human, especially without the
datasheet.  Additionally the drive strength differs between S3C64xx,
S5PV210 and Exynos SoC families increasing the confusion.

The header will help making this more readable and maintainable.

Signed-off-by: Krzysztof Kozlowski 
Reviewed-by: Javier Martinez Canillas 

---

Changes since v2:
1. Rename double-include protection (suggested by Bartlomiej).
2. Squash here:
   pinctrl: dt-bindings: samsung: Add macros for S3C64xx pin configuration
   http://www.spinics.net/lists/arm-kernel/msg528016.html
3. Add Javier's reviewed-by.
4. Extend MAINTAINERS entry with bindings documentation
---
 MAINTAINERS   |  2 ++
 include/dt-bindings/pinctrl/samsung.h | 57 +++
 2 files changed, 59 insertions(+)
 create mode 100644 include/dt-bindings/pinctrl/samsung.h

diff --git a/MAINTAINERS b/MAINTAINERS
index d8e81b1dde30..be3dcca8439a 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -9318,6 +9318,8 @@ L:linux-arm-ker...@lists.infradead.org (moderated 
for non-subscribers)
 L: linux-samsung-...@vger.kernel.org (moderated for non-subscribers)
 S: Maintained
 F: drivers/pinctrl/samsung/
+F: include/dt-bindings/pinctrl/samsung.h
+F: Documentation/devicetree/bindings/pinctrl/samsung-pinctrl.txt
 
 PIN CONTROLLER - SINGLE
 M: Tony Lindgren 
diff --git a/include/dt-bindings/pinctrl/samsung.h 
b/include/dt-bindings/pinctrl/samsung.h
new file mode 100644
index ..6276eb785e2b
--- /dev/null
+++ b/include/dt-bindings/pinctrl/samsung.h
@@ -0,0 +1,57 @@
+/*
+ * Samsung's Exynos pinctrl bindings
+ *
+ * Copyright (c) 2016 Samsung Electronics Co., Ltd.
+ * http://www.samsung.com
+ * Author: Krzysztof Kozlowski 
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+*/
+
+#ifndef __DT_BINDINGS_PINCTRL_SAMSUNG_H__
+#define __DT_BINDINGS_PINCTRL_SAMSUNG_H__
+
+#define EXYNOS_PIN_PULL_NONE   0
+#define EXYNOS_PIN_PULL_DOWN   1
+#define EXYNOS_PIN_PULL_UP 3
+
+#define S3C64XX_PIN_PULL_NONE  0
+#define S3C64XX_PIN_PULL_DOWN  1
+#define S3C64XX_PIN_PULL_UP2
+
+/* Pin function in power down mode */
+#define EXYNOS_PIN_PDN_OUT00
+#define EXYNOS_PIN_PDN_OUT11
+#define EXYNOS_PIN_PDN_INPUT   2
+#define EXYNOS_PIN_PDN_PREV3
+
+/* Drive strengths for Exynos3250, Exynos4 (all) and Exynos5250 */
+#define EXYNOS4_PIN_DRV_LV10
+#define EXYNOS4_PIN_DRV_LV22
+#define EXYNOS4_PIN_DRV_LV31
+#define EXYNOS4_PIN_DRV_LV43
+
+/* Drive strengths for Exynos5260 */
+#define EXYNOS5260_PIN_DRV_LV1 0
+#define EXYNOS5260_PIN_DRV_LV2 1
+#define EXYNOS5260_PIN_DRV_LV4 2
+#define EXYNOS5260_PIN_DRV_LV6 3
+
+/* Drive strengths for Exynos5410, Exynos542x and Exynos5800 */
+#define EXYNOS5420_PIN_DRV_LV1 0
+#define EXYNOS5420_PIN_DRV_LV2 1
+#define EXYNOS5420_PIN_DRV_LV3 2
+#define EXYNOS5420_PIN_DRV_LV4 3
+
+#define EXYNOS_PIN_FUNC_INPUT  0
+#define EXYNOS_PIN_FUNC_OUTPUT 1
+#define EXYNOS_PIN_FUNC_2  2
+#define EXYNOS_PIN_FUNC_3  3
+#define EXYNOS_PIN_FUNC_4  4
+#define EXYNOS_PIN_FUNC_5  5
+#define EXYNOS_PIN_FUNC_6  6
+#define EXYNOS_PIN_FUNC_F  0xf
+
+#endif /* __DT_BINDINGS_PINCTRL_SAMSUNG_H__ */
-- 
2.7.4