Re: [PATCH v3 070/105] drm/vc4: hdmi: rework connectors and encoders
Hi Maxime, Am 16.06.20 um 14:30 schrieb Maxime Ripard: > On Sun, Jun 14, 2020 at 06:16:56PM +0200, Stefan Wahren wrote: >> Am 11.06.20 um 15:34 schrieb Maxime Ripard: >>> Hi Stefan, >>> >>> On Sat, Jun 06, 2020 at 10:06:12AM +0200, Stefan Wahren wrote: Hi Maxime, Am 05.06.20 um 16:35 schrieb Maxime Ripard: > Hi Stefan, > > On Wed, Jun 03, 2020 at 07:32:30PM +0200, Stefan Wahren wrote: >> Am 02.06.20 um 17:54 schrieb Maxime Ripard: >> FWIW this is the first patch which breaks X on my Raspberry Pi 3 B. >> >> Here are the bisect results: >> >> 587d6e4a529a8d807a5c0bae583dd432d77064d6 bad (black screen, no heartbeat) >> >> b0523c7b1c9d0edcd6c0fe6d2cb558a9ad5c60a8 good >> >> 2c6a651cac6359cb0244a40d3b7a14e72918f169 good >> >> 1705c3cb40906863ec0d24ee5ea5092f5ee2e994 bad (black screen, but >> heartbeat) >> >> 601527fea6bb226abd088a864e74b25368218e87 good >> >> 2165607ede34d229d0cbce916c70c7fb6c0337be good >> >> f094f388fc2df848227e2ae648df2c97872df42b good >> >> 020de18840a1075b2671736c6cc2e451030fad74 bad (black screen, but >> heartbeat) >> >> 4c4da3823e4d1a8189e96a59a79451fff372f70b good >> >> 020de18840a1075b2671736c6cc2e451030fad74 is the first bad commit >> commit 020de18840a1075b2671736c6cc2e451030fad74 >> Author: Maxime Ripard >> Date: Mon Jan 6 17:17:29 2020 +0100 >> >> drm/vc4: hdmi: rework connectors and encoders >> >> the vc4_hdmi driver has some custom structures to hold the data it >> needs to >> associate with the drm_encoder and drm_connector structures. >> >> However, it allocates them separately from the vc4_hdmi structure >> which >> makes it more complicated than it needs to be. >> >> Move those structures to be contained by vc4_hdmi and update the code >> accordingly. >> >> Signed-off-by: Maxime Ripard > So it looks like there was two issues on the Pi3. The first one was > causing the timeouts (and therefore likely the black screen but > heartbeat case you had) and I've fixed it. > > However, I can indeed reproduce the case with the black screen / no > heartbeat you mentionned. My bisection however returns that it's the > patch "drm/vc4: hdmi: Implement finer-grained hooks" that is at fault. > I've pushed my updated branch, if you have some spare time, it would be > great if you could confirm it on your Pi. yesterday i checked out your latest rpi4-kms branch, but i was still facing similiar issues with my Raspberry Pi 3 and multi_v7_defconfig (heartbeat stops, splashscreen freeze, heartbeat is abnormal fast). So i tried to bisect but the offending commit didn't cause an issue the second time. By accident i noticed that a simple reboot seems to hang for at least 8 minutes (using b0523c7b1c9d0edcd the base of your branch). This usually take a few seconds. So i consider this base on linux-next as too unstable for reliable testing. Is it possible to rebase this on something more stable like linux-5.7 or at least drm-misc-next? This should avoid chasing unrelated issues. >>> I've rebased it on 5.7 here: >>> https://git.kernel.org/pub/scm/linux/kernel/git/mripard/linux.git/log/?h=rpi4-kms-5.7 >>> >>> And it looks to be indeed an issue coming from next. That branch can >>> start the desktop just fine on an RPi3 here. It would be great if you >>> could confirm on your end. >>> >>> Thanks! >>> Maxime >> thank you very much. The good news are that the "black screen, but >> heartbeat" issue and reboot hang are gone. Unfortunately the "no >> heartbeat" issue is still there. >> >> Here are more details about the issue. It doesn't occur everytime. I >> would guess the probability is about 40 percent, which made bisecting >> much harder. > Are you sure about that 40% reliability? it's more a gut feeling than a statistical analyze. It's definitely not 100% in my setup. > I found out that the culprit > was that the commit we mentionned was actually running atomic_disable > before our own custom callbacks, meaning that we would run the custom > callbacks with the clocks and the power domain shut down, resulting in a > stall. > > I was seeing it all the time when X was shutting down the display, but > maybe you were changing the resolution between the framebuffer console > or something, and since the power domain is shut down asynchronously, it > wasn't running fast enough for the next enable to come up and re-enable > it again? > >> It is reproducible on my 2 Raspberry Pi 3 B Rev 1.2. It is >> also seems independent from the display because the problem occured on >> my Computer display and my TV. > But only on HDMI, right? I only tested it with HDMI displays. All tests without any display were always successful. > > I've pushed a new branch with that fix.
Re: [PATCH v3 070/105] drm/vc4: hdmi: rework connectors and encoders
On Sun, Jun 14, 2020 at 06:16:56PM +0200, Stefan Wahren wrote: > Am 11.06.20 um 15:34 schrieb Maxime Ripard: > > Hi Stefan, > > > > On Sat, Jun 06, 2020 at 10:06:12AM +0200, Stefan Wahren wrote: > >> Hi Maxime, > >> > >> Am 05.06.20 um 16:35 schrieb Maxime Ripard: > >>> Hi Stefan, > >>> > >>> On Wed, Jun 03, 2020 at 07:32:30PM +0200, Stefan Wahren wrote: > Am 02.06.20 um 17:54 schrieb Maxime Ripard: > FWIW this is the first patch which breaks X on my Raspberry Pi 3 B. > > Here are the bisect results: > > 587d6e4a529a8d807a5c0bae583dd432d77064d6 bad (black screen, no heartbeat) > > b0523c7b1c9d0edcd6c0fe6d2cb558a9ad5c60a8 good > > 2c6a651cac6359cb0244a40d3b7a14e72918f169 good > > 1705c3cb40906863ec0d24ee5ea5092f5ee2e994 bad (black screen, but > heartbeat) > > 601527fea6bb226abd088a864e74b25368218e87 good > > 2165607ede34d229d0cbce916c70c7fb6c0337be good > > f094f388fc2df848227e2ae648df2c97872df42b good > > 020de18840a1075b2671736c6cc2e451030fad74 bad (black screen, but > heartbeat) > > 4c4da3823e4d1a8189e96a59a79451fff372f70b good > > 020de18840a1075b2671736c6cc2e451030fad74 is the first bad commit > commit 020de18840a1075b2671736c6cc2e451030fad74 > Author: Maxime Ripard > Date: Mon Jan 6 17:17:29 2020 +0100 > > drm/vc4: hdmi: rework connectors and encoders > > the vc4_hdmi driver has some custom structures to hold the data it > needs to > associate with the drm_encoder and drm_connector structures. > > However, it allocates them separately from the vc4_hdmi structure > which > makes it more complicated than it needs to be. > > Move those structures to be contained by vc4_hdmi and update the code > accordingly. > > Signed-off-by: Maxime Ripard > >>> So it looks like there was two issues on the Pi3. The first one was > >>> causing the timeouts (and therefore likely the black screen but > >>> heartbeat case you had) and I've fixed it. > >>> > >>> However, I can indeed reproduce the case with the black screen / no > >>> heartbeat you mentionned. My bisection however returns that it's the > >>> patch "drm/vc4: hdmi: Implement finer-grained hooks" that is at fault. > >>> I've pushed my updated branch, if you have some spare time, it would be > >>> great if you could confirm it on your Pi. > >> yesterday i checked out your latest rpi4-kms branch, but i was still > >> facing similiar issues with my Raspberry Pi 3 and multi_v7_defconfig > >> (heartbeat stops, splashscreen freeze, heartbeat is abnormal fast). So i > >> tried to bisect but the offending commit didn't cause an issue the > >> second time. > >> > >> By accident i noticed that a simple reboot seems to hang for at least 8 > >> minutes (using b0523c7b1c9d0edcd the base of your branch). This usually > >> take a few seconds. So i consider this base on linux-next as too > >> unstable for reliable testing. > >> > >> Is it possible to rebase this on something more stable like linux-5.7 or > >> at least drm-misc-next? This should avoid chasing unrelated issues. > > I've rebased it on 5.7 here: > > https://git.kernel.org/pub/scm/linux/kernel/git/mripard/linux.git/log/?h=rpi4-kms-5.7 > > > > And it looks to be indeed an issue coming from next. That branch can > > start the desktop just fine on an RPi3 here. It would be great if you > > could confirm on your end. > > > > Thanks! > > Maxime > > thank you very much. The good news are that the "black screen, but > heartbeat" issue and reboot hang are gone. Unfortunately the "no > heartbeat" issue is still there. > > Here are more details about the issue. It doesn't occur everytime. I > would guess the probability is about 40 percent, which made bisecting > much harder. Are you sure about that 40% reliability? I found out that the culprit was that the commit we mentionned was actually running atomic_disable before our own custom callbacks, meaning that we would run the custom callbacks with the clocks and the power domain shut down, resulting in a stall. I was seeing it all the time when X was shutting down the display, but maybe you were changing the resolution between the framebuffer console or something, and since the power domain is shut down asynchronously, it wasn't running fast enough for the next enable to come up and re-enable it again? > It is reproducible on my 2 Raspberry Pi 3 B Rev 1.2. It is > also seems independent from the display because the problem occured on > my Computer display and my TV. But only on HDMI, right? I've pushed a new branch with that fix. Maxime signature.asc Description: PGP signature
Re: [PATCH v3 070/105] drm/vc4: hdmi: rework connectors and encoders
Hi Maxime, Am 11.06.20 um 15:34 schrieb Maxime Ripard: > Hi Stefan, > > On Sat, Jun 06, 2020 at 10:06:12AM +0200, Stefan Wahren wrote: >> Hi Maxime, >> >> Am 05.06.20 um 16:35 schrieb Maxime Ripard: >>> Hi Stefan, >>> >>> On Wed, Jun 03, 2020 at 07:32:30PM +0200, Stefan Wahren wrote: Am 02.06.20 um 17:54 schrieb Maxime Ripard: FWIW this is the first patch which breaks X on my Raspberry Pi 3 B. Here are the bisect results: 587d6e4a529a8d807a5c0bae583dd432d77064d6 bad (black screen, no heartbeat) b0523c7b1c9d0edcd6c0fe6d2cb558a9ad5c60a8 good 2c6a651cac6359cb0244a40d3b7a14e72918f169 good 1705c3cb40906863ec0d24ee5ea5092f5ee2e994 bad (black screen, but heartbeat) 601527fea6bb226abd088a864e74b25368218e87 good 2165607ede34d229d0cbce916c70c7fb6c0337be good f094f388fc2df848227e2ae648df2c97872df42b good 020de18840a1075b2671736c6cc2e451030fad74 bad (black screen, but heartbeat) 4c4da3823e4d1a8189e96a59a79451fff372f70b good 020de18840a1075b2671736c6cc2e451030fad74 is the first bad commit commit 020de18840a1075b2671736c6cc2e451030fad74 Author: Maxime Ripard Date: Mon Jan 6 17:17:29 2020 +0100 drm/vc4: hdmi: rework connectors and encoders the vc4_hdmi driver has some custom structures to hold the data it needs to associate with the drm_encoder and drm_connector structures. However, it allocates them separately from the vc4_hdmi structure which makes it more complicated than it needs to be. Move those structures to be contained by vc4_hdmi and update the code accordingly. Signed-off-by: Maxime Ripard >>> So it looks like there was two issues on the Pi3. The first one was >>> causing the timeouts (and therefore likely the black screen but >>> heartbeat case you had) and I've fixed it. >>> >>> However, I can indeed reproduce the case with the black screen / no >>> heartbeat you mentionned. My bisection however returns that it's the >>> patch "drm/vc4: hdmi: Implement finer-grained hooks" that is at fault. >>> I've pushed my updated branch, if you have some spare time, it would be >>> great if you could confirm it on your Pi. >> yesterday i checked out your latest rpi4-kms branch, but i was still >> facing similiar issues with my Raspberry Pi 3 and multi_v7_defconfig >> (heartbeat stops, splashscreen freeze, heartbeat is abnormal fast). So i >> tried to bisect but the offending commit didn't cause an issue the >> second time. >> >> By accident i noticed that a simple reboot seems to hang for at least 8 >> minutes (using b0523c7b1c9d0edcd the base of your branch). This usually >> take a few seconds. So i consider this base on linux-next as too >> unstable for reliable testing. >> >> Is it possible to rebase this on something more stable like linux-5.7 or >> at least drm-misc-next? This should avoid chasing unrelated issues. > I've rebased it on 5.7 here: > https://git.kernel.org/pub/scm/linux/kernel/git/mripard/linux.git/log/?h=rpi4-kms-5.7 > > And it looks to be indeed an issue coming from next. That branch can > start the desktop just fine on an RPi3 here. It would be great if you > could confirm on your end. > > Thanks! > Maxime thank you very much. The good news are that the "black screen, but heartbeat" issue and reboot hang are gone. Unfortunately the "no heartbeat" issue is still there. Here are more details about the issue. It doesn't occur everytime. I would guess the probability is about 40 percent, which made bisecting much harder. It is reproducible on my 2 Raspberry Pi 3 B Rev 1.2. It is also seems independent from the display because the problem occured on my Computer display and my TV. Yes, i can confirm that i was able to bisect the issue to this commit: commit 7b7e335f98c6f3199dcc7db83469dccac66dca1e Author: Maxime Ripard Date: Tue May 12 11:36:13 2020 +0200 drm/vc4: hdmi: Implement finer-grained hooks In order to prevent some pixels getting stuck in an unflushable FIFO on bcm2711, we need to enable the HVS, the pixelvalve (the CRTC) and the HDMI controller (the encoder) in an intertwined way, and with tight delays. However, the atomic callbacks don't really provide a way to work with either constraints, so we need to roll our own callbacks so that we can provide those guarantees. Since those callbacks have been implemented and called in the CRTC code, we can just implement them in the HDMI driver now. Signed-off-by: Maxime Ripard
Re: [PATCH v3 070/105] drm/vc4: hdmi: rework connectors and encoders
Hi Stefan, On Sat, Jun 06, 2020 at 10:06:12AM +0200, Stefan Wahren wrote: > Hi Maxime, > > Am 05.06.20 um 16:35 schrieb Maxime Ripard: > > Hi Stefan, > > > > On Wed, Jun 03, 2020 at 07:32:30PM +0200, Stefan Wahren wrote: > >> Am 02.06.20 um 17:54 schrieb Maxime Ripard: > >>> On Wed, May 27, 2020 at 11:41:24AM -0700, Eric Anholt wrote: > On Wed, May 27, 2020 at 8:51 AM Maxime Ripard wrote: > > the vc4_hdmi driver has some custom structures to hold the data it > > needs to > > associate with the drm_encoder and drm_connector structures. > > > > However, it allocates them separately from the vc4_hdmi structure which > > makes it more complicated than it needs to be. > > > > Move those structures to be contained by vc4_hdmi and update the code > > accordingly. > > @@ -1220,7 +1219,7 @@ static int vc4_hdmi_bind(struct device *dev, > > struct device *master, void *data) > > struct drm_device *drm = dev_get_drvdata(master); > > struct vc4_dev *vc4 = drm->dev_private; > > struct vc4_hdmi *hdmi; > > - struct vc4_hdmi_encoder *vc4_hdmi_encoder; > > + struct drm_encoder *encoder; > > struct device_node *ddc_node; > > u32 value; > > int ret; > > @@ -1229,14 +1228,10 @@ static int vc4_hdmi_bind(struct device *dev, > > struct device *master, void *data) > > if (!hdmi) > > return -ENOMEM; > > > > - vc4_hdmi_encoder = devm_kzalloc(dev, sizeof(*vc4_hdmi_encoder), > > - GFP_KERNEL); > > - if (!vc4_hdmi_encoder) > > - return -ENOMEM; > > - vc4_hdmi_encoder->base.type = VC4_ENCODER_TYPE_HDMI0; > > - hdmi->encoder = _hdmi_encoder->base.base; > > - > > hdmi->pdev = pdev; > > + encoder = >encoder.base.base; > > + encoder->base.type = VC4_ENCODER_TYPE_HDMI0; > Wait, does this patch build? > >>> All those patches were build tested, so yep > >>> > setting struct drm_encoder->base.type = VC4_* seems very wrong, when > previously we were setting struct vc4_hdmi_encoder->base.type (struct > vc4_encoder->type). > >>> So the structure layout now is that vc4_hdmi embeds vc4_hdmi_encoder as > >>> encoder. So >encoder is a pointer to vc4_hdmi_encoder. > >>> vc4_hdmi_encoder's base is since that patch a struct vc4_encoder. and > >>> vc4_encoder's base is a drm_encoder. > >>> > >>> so encoder being a drm_encoder is correct there. > >>> > >>> However, drm_encoder's base is drm_mode_object that does have a type > >>> field, which is an uint32_t, which will accept a VC4_ENCODER_TYPE_* just > >>> fine... > >>> > >>> Now, drm_encoder_init will then kick in and call drm_mode_object_add > >>> which will override it to a proper value and since the clock select bit > >>> in the PV is the same for both HDMI0 and HDMI1, everything works just > >>> fine... > >>> > >>> Good catch, I'll fix it. And I guess it's a good indication we don't > >>> need a separate HDMI0 and HDMI1 encoder type. > >>> > >> FWIW this is the first patch which breaks X on my Raspberry Pi 3 B. > >> > >> Here are the bisect results: > >> > >> 587d6e4a529a8d807a5c0bae583dd432d77064d6 bad (black screen, no heartbeat) > >> > >> b0523c7b1c9d0edcd6c0fe6d2cb558a9ad5c60a8 good > >> > >> 2c6a651cac6359cb0244a40d3b7a14e72918f169 good > >> > >> 1705c3cb40906863ec0d24ee5ea5092f5ee2e994 bad (black screen, but heartbeat) > >> > >> 601527fea6bb226abd088a864e74b25368218e87 good > >> > >> 2165607ede34d229d0cbce916c70c7fb6c0337be good > >> > >> f094f388fc2df848227e2ae648df2c97872df42b good > >> > >> 020de18840a1075b2671736c6cc2e451030fad74 bad (black screen, but heartbeat) > >> > >> 4c4da3823e4d1a8189e96a59a79451fff372f70b good > >> > >> 020de18840a1075b2671736c6cc2e451030fad74 is the first bad commit > >> commit 020de18840a1075b2671736c6cc2e451030fad74 > >> Author: Maxime Ripard > >> Date: Mon Jan 6 17:17:29 2020 +0100 > >> > >> drm/vc4: hdmi: rework connectors and encoders > >> > >> the vc4_hdmi driver has some custom structures to hold the data it > >> needs to > >> associate with the drm_encoder and drm_connector structures. > >> > >> However, it allocates them separately from the vc4_hdmi structure which > >> makes it more complicated than it needs to be. > >> > >> Move those structures to be contained by vc4_hdmi and update the code > >> accordingly. > >> > >> Signed-off-by: Maxime Ripard > > So it looks like there was two issues on the Pi3. The first one was > > causing the timeouts (and therefore likely the black screen but > > heartbeat case you had) and I've fixed it. > > > > However, I can indeed reproduce the case with the black screen / no > > heartbeat you mentionned. My bisection however returns that it's the > > patch "drm/vc4: hdmi: Implement finer-grained hooks" that is at fault. > > I've
Re: [PATCH v3 070/105] drm/vc4: hdmi: rework connectors and encoders
Hi Maxime, Am 05.06.20 um 16:35 schrieb Maxime Ripard: > Hi Stefan, > > On Wed, Jun 03, 2020 at 07:32:30PM +0200, Stefan Wahren wrote: >> Am 02.06.20 um 17:54 schrieb Maxime Ripard: >>> On Wed, May 27, 2020 at 11:41:24AM -0700, Eric Anholt wrote: On Wed, May 27, 2020 at 8:51 AM Maxime Ripard wrote: > the vc4_hdmi driver has some custom structures to hold the data it needs > to > associate with the drm_encoder and drm_connector structures. > > However, it allocates them separately from the vc4_hdmi structure which > makes it more complicated than it needs to be. > > Move those structures to be contained by vc4_hdmi and update the code > accordingly. > @@ -1220,7 +1219,7 @@ static int vc4_hdmi_bind(struct device *dev, struct > device *master, void *data) > struct drm_device *drm = dev_get_drvdata(master); > struct vc4_dev *vc4 = drm->dev_private; > struct vc4_hdmi *hdmi; > - struct vc4_hdmi_encoder *vc4_hdmi_encoder; > + struct drm_encoder *encoder; > struct device_node *ddc_node; > u32 value; > int ret; > @@ -1229,14 +1228,10 @@ static int vc4_hdmi_bind(struct device *dev, > struct device *master, void *data) > if (!hdmi) > return -ENOMEM; > > - vc4_hdmi_encoder = devm_kzalloc(dev, sizeof(*vc4_hdmi_encoder), > - GFP_KERNEL); > - if (!vc4_hdmi_encoder) > - return -ENOMEM; > - vc4_hdmi_encoder->base.type = VC4_ENCODER_TYPE_HDMI0; > - hdmi->encoder = _hdmi_encoder->base.base; > - > hdmi->pdev = pdev; > + encoder = >encoder.base.base; > + encoder->base.type = VC4_ENCODER_TYPE_HDMI0; Wait, does this patch build? >>> All those patches were build tested, so yep >>> setting struct drm_encoder->base.type = VC4_* seems very wrong, when previously we were setting struct vc4_hdmi_encoder->base.type (struct vc4_encoder->type). >>> So the structure layout now is that vc4_hdmi embeds vc4_hdmi_encoder as >>> encoder. So >encoder is a pointer to vc4_hdmi_encoder. >>> vc4_hdmi_encoder's base is since that patch a struct vc4_encoder. and >>> vc4_encoder's base is a drm_encoder. >>> >>> so encoder being a drm_encoder is correct there. >>> >>> However, drm_encoder's base is drm_mode_object that does have a type >>> field, which is an uint32_t, which will accept a VC4_ENCODER_TYPE_* just >>> fine... >>> >>> Now, drm_encoder_init will then kick in and call drm_mode_object_add >>> which will override it to a proper value and since the clock select bit >>> in the PV is the same for both HDMI0 and HDMI1, everything works just >>> fine... >>> >>> Good catch, I'll fix it. And I guess it's a good indication we don't >>> need a separate HDMI0 and HDMI1 encoder type. >>> >> FWIW this is the first patch which breaks X on my Raspberry Pi 3 B. >> >> Here are the bisect results: >> >> 587d6e4a529a8d807a5c0bae583dd432d77064d6 bad (black screen, no heartbeat) >> >> b0523c7b1c9d0edcd6c0fe6d2cb558a9ad5c60a8 good >> >> 2c6a651cac6359cb0244a40d3b7a14e72918f169 good >> >> 1705c3cb40906863ec0d24ee5ea5092f5ee2e994 bad (black screen, but heartbeat) >> >> 601527fea6bb226abd088a864e74b25368218e87 good >> >> 2165607ede34d229d0cbce916c70c7fb6c0337be good >> >> f094f388fc2df848227e2ae648df2c97872df42b good >> >> 020de18840a1075b2671736c6cc2e451030fad74 bad (black screen, but heartbeat) >> >> 4c4da3823e4d1a8189e96a59a79451fff372f70b good >> >> 020de18840a1075b2671736c6cc2e451030fad74 is the first bad commit >> commit 020de18840a1075b2671736c6cc2e451030fad74 >> Author: Maxime Ripard >> Date: Mon Jan 6 17:17:29 2020 +0100 >> >> drm/vc4: hdmi: rework connectors and encoders >> >> the vc4_hdmi driver has some custom structures to hold the data it >> needs to >> associate with the drm_encoder and drm_connector structures. >> >> However, it allocates them separately from the vc4_hdmi structure which >> makes it more complicated than it needs to be. >> >> Move those structures to be contained by vc4_hdmi and update the code >> accordingly. >> >> Signed-off-by: Maxime Ripard > So it looks like there was two issues on the Pi3. The first one was > causing the timeouts (and therefore likely the black screen but > heartbeat case you had) and I've fixed it. > > However, I can indeed reproduce the case with the black screen / no > heartbeat you mentionned. My bisection however returns that it's the > patch "drm/vc4: hdmi: Implement finer-grained hooks" that is at fault. > I've pushed my updated branch, if you have some spare time, it would be > great if you could confirm it on your Pi. yesterday i checked out your latest rpi4-kms branch, but i was still facing similiar issues with my Raspberry Pi 3 and multi_v7_defconfig (heartbeat stops, splashscreen freeze, heartbeat is
Re: [PATCH v3 070/105] drm/vc4: hdmi: rework connectors and encoders
Hi Stefan, On Wed, Jun 03, 2020 at 07:32:30PM +0200, Stefan Wahren wrote: > Am 02.06.20 um 17:54 schrieb Maxime Ripard: > > On Wed, May 27, 2020 at 11:41:24AM -0700, Eric Anholt wrote: > >> On Wed, May 27, 2020 at 8:51 AM Maxime Ripard wrote: > >>> the vc4_hdmi driver has some custom structures to hold the data it needs > >>> to > >>> associate with the drm_encoder and drm_connector structures. > >>> > >>> However, it allocates them separately from the vc4_hdmi structure which > >>> makes it more complicated than it needs to be. > >>> > >>> Move those structures to be contained by vc4_hdmi and update the code > >>> accordingly. > >> > >>> @@ -1220,7 +1219,7 @@ static int vc4_hdmi_bind(struct device *dev, struct > >>> device *master, void *data) > >>> struct drm_device *drm = dev_get_drvdata(master); > >>> struct vc4_dev *vc4 = drm->dev_private; > >>> struct vc4_hdmi *hdmi; > >>> - struct vc4_hdmi_encoder *vc4_hdmi_encoder; > >>> + struct drm_encoder *encoder; > >>> struct device_node *ddc_node; > >>> u32 value; > >>> int ret; > >>> @@ -1229,14 +1228,10 @@ static int vc4_hdmi_bind(struct device *dev, > >>> struct device *master, void *data) > >>> if (!hdmi) > >>> return -ENOMEM; > >>> > >>> - vc4_hdmi_encoder = devm_kzalloc(dev, sizeof(*vc4_hdmi_encoder), > >>> - GFP_KERNEL); > >>> - if (!vc4_hdmi_encoder) > >>> - return -ENOMEM; > >>> - vc4_hdmi_encoder->base.type = VC4_ENCODER_TYPE_HDMI0; > >>> - hdmi->encoder = _hdmi_encoder->base.base; > >>> - > >>> hdmi->pdev = pdev; > >>> + encoder = >encoder.base.base; > >>> + encoder->base.type = VC4_ENCODER_TYPE_HDMI0; > >> Wait, does this patch build? > > All those patches were build tested, so yep > > > >> setting struct drm_encoder->base.type = VC4_* seems very wrong, when > >> previously we were setting struct vc4_hdmi_encoder->base.type (struct > >> vc4_encoder->type). > > So the structure layout now is that vc4_hdmi embeds vc4_hdmi_encoder as > > encoder. So >encoder is a pointer to vc4_hdmi_encoder. > > vc4_hdmi_encoder's base is since that patch a struct vc4_encoder. and > > vc4_encoder's base is a drm_encoder. > > > > so encoder being a drm_encoder is correct there. > > > > However, drm_encoder's base is drm_mode_object that does have a type > > field, which is an uint32_t, which will accept a VC4_ENCODER_TYPE_* just > > fine... > > > > Now, drm_encoder_init will then kick in and call drm_mode_object_add > > which will override it to a proper value and since the clock select bit > > in the PV is the same for both HDMI0 and HDMI1, everything works just > > fine... > > > > Good catch, I'll fix it. And I guess it's a good indication we don't > > need a separate HDMI0 and HDMI1 encoder type. > > > FWIW this is the first patch which breaks X on my Raspberry Pi 3 B. > > Here are the bisect results: > > 587d6e4a529a8d807a5c0bae583dd432d77064d6 bad (black screen, no heartbeat) > > b0523c7b1c9d0edcd6c0fe6d2cb558a9ad5c60a8 good > > 2c6a651cac6359cb0244a40d3b7a14e72918f169 good > > 1705c3cb40906863ec0d24ee5ea5092f5ee2e994 bad (black screen, but heartbeat) > > 601527fea6bb226abd088a864e74b25368218e87 good > > 2165607ede34d229d0cbce916c70c7fb6c0337be good > > f094f388fc2df848227e2ae648df2c97872df42b good > > 020de18840a1075b2671736c6cc2e451030fad74 bad (black screen, but heartbeat) > > 4c4da3823e4d1a8189e96a59a79451fff372f70b good > > 020de18840a1075b2671736c6cc2e451030fad74 is the first bad commit > commit 020de18840a1075b2671736c6cc2e451030fad74 > Author: Maxime Ripard > Date: Mon Jan 6 17:17:29 2020 +0100 > > drm/vc4: hdmi: rework connectors and encoders > > the vc4_hdmi driver has some custom structures to hold the data it > needs to > associate with the drm_encoder and drm_connector structures. > > However, it allocates them separately from the vc4_hdmi structure which > makes it more complicated than it needs to be. > > Move those structures to be contained by vc4_hdmi and update the code > accordingly. > > Signed-off-by: Maxime Ripard So it looks like there was two issues on the Pi3. The first one was causing the timeouts (and therefore likely the black screen but heartbeat case you had) and I've fixed it. However, I can indeed reproduce the case with the black screen / no heartbeat you mentionned. My bisection however returns that it's the patch "drm/vc4: hdmi: Implement finer-grained hooks" that is at fault. I've pushed my updated branch, if you have some spare time, it would be great if you could confirm it on your Pi. Thanks! Maxime signature.asc Description: PGP signature
Re: [PATCH v3 070/105] drm/vc4: hdmi: rework connectors and encoders
Am 02.06.20 um 17:54 schrieb Maxime Ripard: > On Wed, May 27, 2020 at 11:41:24AM -0700, Eric Anholt wrote: >> On Wed, May 27, 2020 at 8:51 AM Maxime Ripard wrote: >>> the vc4_hdmi driver has some custom structures to hold the data it needs to >>> associate with the drm_encoder and drm_connector structures. >>> >>> However, it allocates them separately from the vc4_hdmi structure which >>> makes it more complicated than it needs to be. >>> >>> Move those structures to be contained by vc4_hdmi and update the code >>> accordingly. >> >>> @@ -1220,7 +1219,7 @@ static int vc4_hdmi_bind(struct device *dev, struct >>> device *master, void *data) >>> struct drm_device *drm = dev_get_drvdata(master); >>> struct vc4_dev *vc4 = drm->dev_private; >>> struct vc4_hdmi *hdmi; >>> - struct vc4_hdmi_encoder *vc4_hdmi_encoder; >>> + struct drm_encoder *encoder; >>> struct device_node *ddc_node; >>> u32 value; >>> int ret; >>> @@ -1229,14 +1228,10 @@ static int vc4_hdmi_bind(struct device *dev, struct >>> device *master, void *data) >>> if (!hdmi) >>> return -ENOMEM; >>> >>> - vc4_hdmi_encoder = devm_kzalloc(dev, sizeof(*vc4_hdmi_encoder), >>> - GFP_KERNEL); >>> - if (!vc4_hdmi_encoder) >>> - return -ENOMEM; >>> - vc4_hdmi_encoder->base.type = VC4_ENCODER_TYPE_HDMI0; >>> - hdmi->encoder = _hdmi_encoder->base.base; >>> - >>> hdmi->pdev = pdev; >>> + encoder = >encoder.base.base; >>> + encoder->base.type = VC4_ENCODER_TYPE_HDMI0; >> Wait, does this patch build? > All those patches were build tested, so yep > >> setting struct drm_encoder->base.type = VC4_* seems very wrong, when >> previously we were setting struct vc4_hdmi_encoder->base.type (struct >> vc4_encoder->type). > So the structure layout now is that vc4_hdmi embeds vc4_hdmi_encoder as > encoder. So >encoder is a pointer to vc4_hdmi_encoder. > vc4_hdmi_encoder's base is since that patch a struct vc4_encoder. and > vc4_encoder's base is a drm_encoder. > > so encoder being a drm_encoder is correct there. > > However, drm_encoder's base is drm_mode_object that does have a type > field, which is an uint32_t, which will accept a VC4_ENCODER_TYPE_* just > fine... > > Now, drm_encoder_init will then kick in and call drm_mode_object_add > which will override it to a proper value and since the clock select bit > in the PV is the same for both HDMI0 and HDMI1, everything works just > fine... > > Good catch, I'll fix it. And I guess it's a good indication we don't > need a separate HDMI0 and HDMI1 encoder type. > FWIW this is the first patch which breaks X on my Raspberry Pi 3 B. Here are the bisect results: 587d6e4a529a8d807a5c0bae583dd432d77064d6 bad (black screen, no heartbeat) b0523c7b1c9d0edcd6c0fe6d2cb558a9ad5c60a8 good 2c6a651cac6359cb0244a40d3b7a14e72918f169 good 1705c3cb40906863ec0d24ee5ea5092f5ee2e994 bad (black screen, but heartbeat) 601527fea6bb226abd088a864e74b25368218e87 good 2165607ede34d229d0cbce916c70c7fb6c0337be good f094f388fc2df848227e2ae648df2c97872df42b good 020de18840a1075b2671736c6cc2e451030fad74 bad (black screen, but heartbeat) 4c4da3823e4d1a8189e96a59a79451fff372f70b good 020de18840a1075b2671736c6cc2e451030fad74 is the first bad commit commit 020de18840a1075b2671736c6cc2e451030fad74 Author: Maxime Ripard Date: Mon Jan 6 17:17:29 2020 +0100 drm/vc4: hdmi: rework connectors and encoders the vc4_hdmi driver has some custom structures to hold the data it needs to associate with the drm_encoder and drm_connector structures. However, it allocates them separately from the vc4_hdmi structure which makes it more complicated than it needs to be. Move those structures to be contained by vc4_hdmi and update the code accordingly. Signed-off-by: Maxime Ripard
Re: [PATCH v3 070/105] drm/vc4: hdmi: rework connectors and encoders
On Wed, May 27, 2020 at 11:41:24AM -0700, Eric Anholt wrote: > On Wed, May 27, 2020 at 8:51 AM Maxime Ripard wrote: > > > > the vc4_hdmi driver has some custom structures to hold the data it needs to > > associate with the drm_encoder and drm_connector structures. > > > > However, it allocates them separately from the vc4_hdmi structure which > > makes it more complicated than it needs to be. > > > > Move those structures to be contained by vc4_hdmi and update the code > > accordingly. > > > > @@ -1220,7 +1219,7 @@ static int vc4_hdmi_bind(struct device *dev, struct > > device *master, void *data) > > struct drm_device *drm = dev_get_drvdata(master); > > struct vc4_dev *vc4 = drm->dev_private; > > struct vc4_hdmi *hdmi; > > - struct vc4_hdmi_encoder *vc4_hdmi_encoder; > > + struct drm_encoder *encoder; > > struct device_node *ddc_node; > > u32 value; > > int ret; > > @@ -1229,14 +1228,10 @@ static int vc4_hdmi_bind(struct device *dev, struct > > device *master, void *data) > > if (!hdmi) > > return -ENOMEM; > > > > - vc4_hdmi_encoder = devm_kzalloc(dev, sizeof(*vc4_hdmi_encoder), > > - GFP_KERNEL); > > - if (!vc4_hdmi_encoder) > > - return -ENOMEM; > > - vc4_hdmi_encoder->base.type = VC4_ENCODER_TYPE_HDMI0; > > - hdmi->encoder = _hdmi_encoder->base.base; > > - > > hdmi->pdev = pdev; > > + encoder = >encoder.base.base; > > + encoder->base.type = VC4_ENCODER_TYPE_HDMI0; > > Wait, does this patch build? All those patches were build tested, so yep > setting struct drm_encoder->base.type = VC4_* seems very wrong, when > previously we were setting struct vc4_hdmi_encoder->base.type (struct > vc4_encoder->type). So the structure layout now is that vc4_hdmi embeds vc4_hdmi_encoder as encoder. So >encoder is a pointer to vc4_hdmi_encoder. vc4_hdmi_encoder's base is since that patch a struct vc4_encoder. and vc4_encoder's base is a drm_encoder. so encoder being a drm_encoder is correct there. However, drm_encoder's base is drm_mode_object that does have a type field, which is an uint32_t, which will accept a VC4_ENCODER_TYPE_* just fine... Now, drm_encoder_init will then kick in and call drm_mode_object_add which will override it to a proper value and since the clock select bit in the PV is the same for both HDMI0 and HDMI1, everything works just fine... Good catch, I'll fix it. And I guess it's a good indication we don't need a separate HDMI0 and HDMI1 encoder type. > Other than this, patch 68-78 r-b. Thanks for your review! Maxime signature.asc Description: PGP signature
Re: [PATCH v3 070/105] drm/vc4: hdmi: rework connectors and encoders
On Wed, May 27, 2020 at 8:51 AM Maxime Ripard wrote: > > the vc4_hdmi driver has some custom structures to hold the data it needs to > associate with the drm_encoder and drm_connector structures. > > However, it allocates them separately from the vc4_hdmi structure which > makes it more complicated than it needs to be. > > Move those structures to be contained by vc4_hdmi and update the code > accordingly. > @@ -1220,7 +1219,7 @@ static int vc4_hdmi_bind(struct device *dev, struct > device *master, void *data) > struct drm_device *drm = dev_get_drvdata(master); > struct vc4_dev *vc4 = drm->dev_private; > struct vc4_hdmi *hdmi; > - struct vc4_hdmi_encoder *vc4_hdmi_encoder; > + struct drm_encoder *encoder; > struct device_node *ddc_node; > u32 value; > int ret; > @@ -1229,14 +1228,10 @@ static int vc4_hdmi_bind(struct device *dev, struct > device *master, void *data) > if (!hdmi) > return -ENOMEM; > > - vc4_hdmi_encoder = devm_kzalloc(dev, sizeof(*vc4_hdmi_encoder), > - GFP_KERNEL); > - if (!vc4_hdmi_encoder) > - return -ENOMEM; > - vc4_hdmi_encoder->base.type = VC4_ENCODER_TYPE_HDMI0; > - hdmi->encoder = _hdmi_encoder->base.base; > - > hdmi->pdev = pdev; > + encoder = >encoder.base.base; > + encoder->base.type = VC4_ENCODER_TYPE_HDMI0; Wait, does this patch build? setting struct drm_encoder->base.type = VC4_* seems very wrong, when previously we were setting struct vc4_hdmi_encoder->base.type (struct vc4_encoder->type). Other than this, patch 68-78 r-b.
[PATCH v3 070/105] drm/vc4: hdmi: rework connectors and encoders
the vc4_hdmi driver has some custom structures to hold the data it needs to
associate with the drm_encoder and drm_connector structures.
However, it allocates them separately from the vc4_hdmi structure which
makes it more complicated than it needs to be.
Move those structures to be contained by vc4_hdmi and update the code
accordingly.
Signed-off-by: Maxime Ripard
---
drivers/gpu/drm/vc4/vc4_hdmi.c | 87 ---
drivers/gpu/drm/vc4/vc4_hdmi.h | 64 +-
2 files changed, 72 insertions(+), 79 deletions(-)
diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c
index 41573fca5a40..c1cb8790b552 100644
--- a/drivers/gpu/drm/vc4/vc4_hdmi.c
+++ b/drivers/gpu/drm/vc4/vc4_hdmi.c
@@ -191,20 +191,15 @@ static const struct drm_connector_helper_funcs
vc4_hdmi_connector_helper_funcs =
.get_modes = vc4_hdmi_connector_get_modes,
};
-static struct drm_connector *vc4_hdmi_connector_init(struct drm_device *dev,
-struct drm_encoder
*encoder,
-struct i2c_adapter *ddc)
+static int vc4_hdmi_connector_init(struct drm_device *dev,
+ struct vc4_hdmi *vc4_hdmi,
+ struct i2c_adapter *ddc)
{
- struct drm_connector *connector;
- struct vc4_hdmi_connector *hdmi_connector;
+ struct vc4_hdmi_connector *hdmi_connector = _hdmi->connector;
+ struct drm_connector *connector = _connector->base;
+ struct drm_encoder *encoder = _hdmi->encoder.base.base;
int ret;
- hdmi_connector = devm_kzalloc(dev->dev, sizeof(*hdmi_connector),
- GFP_KERNEL);
- if (!hdmi_connector)
- return ERR_PTR(-ENOMEM);
- connector = _connector->base;
-
hdmi_connector->encoder = encoder;
drm_connector_init_with_ddc(dev, connector,
@@ -216,7 +211,7 @@ static struct drm_connector *vc4_hdmi_connector_init(struct
drm_device *dev,
/* Create and attach TV margin props to this connector. */
ret = drm_mode_create_tv_margin_properties(dev);
if (ret)
- return ERR_PTR(ret);
+ return ret;
drm_connector_attach_tv_margin_properties(connector);
@@ -228,7 +223,7 @@ static struct drm_connector *vc4_hdmi_connector_init(struct
drm_device *dev,
drm_connector_attach_encoder(connector, encoder);
- return connector;
+ return 0;
}
static int vc4_hdmi_stop_packet(struct drm_encoder *encoder,
@@ -298,21 +293,22 @@ static void vc4_hdmi_set_avi_infoframe(struct drm_encoder
*encoder)
struct vc4_hdmi_encoder *vc4_encoder = to_vc4_hdmi_encoder(encoder);
struct vc4_dev *vc4 = encoder->dev->dev_private;
struct vc4_hdmi *hdmi = vc4->hdmi;
- struct drm_connector_state *cstate = hdmi->connector->state;
+ struct drm_connector *connector = >connector.base;
+ struct drm_connector_state *cstate = connector->state;
struct drm_crtc *crtc = encoder->crtc;
const struct drm_display_mode *mode = >state->adjusted_mode;
union hdmi_infoframe frame;
int ret;
ret = drm_hdmi_avi_infoframe_from_display_mode(,
- hdmi->connector, mode);
+ connector, mode);
if (ret < 0) {
DRM_ERROR("couldn't fill AVI infoframe\n");
return;
}
drm_hdmi_avi_infoframe_quant_range(,
- hdmi->connector, mode,
+ connector, mode,
vc4_encoder->limited_rgb_range ?
HDMI_QUANTIZATION_RANGE_LIMITED :
HDMI_QUANTIZATION_RANGE_FULL);
@@ -628,7 +624,8 @@ static const struct drm_encoder_helper_funcs
vc4_hdmi_encoder_helper_funcs = {
/* HDMI audio codec callbacks */
static void vc4_hdmi_audio_set_mai_clock(struct vc4_hdmi *hdmi)
{
- struct drm_device *drm = hdmi->encoder->dev;
+ struct drm_encoder *encoder = >encoder.base.base;
+ struct drm_device *drm = encoder->dev;
struct vc4_dev *vc4 = to_vc4_dev(drm);
u32 hsm_clock = clk_get_rate(hdmi->hsm_clock);
unsigned long n, m;
@@ -647,7 +644,7 @@ static void vc4_hdmi_audio_set_mai_clock(struct vc4_hdmi
*hdmi)
static void vc4_hdmi_set_n_cts(struct vc4_hdmi *hdmi)
{
- struct drm_encoder *encoder = hdmi->encoder;
+ struct drm_encoder *encoder = >encoder.base.base;
struct drm_crtc *crtc = encoder->crtc;
struct drm_device *drm = encoder->dev;
struct vc4_dev *vc4 = to_vc4_dev(drm);
@@ -685,7 +682,8 @@ static int vc4_hdmi_audio_startup(struct snd_pcm_substream
*substream,
struct
