Re: [PATCH v3 1/2] dt-bindings: display: bridge: Add bindings for Chipone ICN6211
On Sun, 14 Feb 2021 23:22:10 +0530, Jagan Teki wrote: > ICN6211 is MIPI-DSI to RGB Convertor bridge from Chipone. > > It has a flexible configuration of MIPI DSI signal input and > produce RGB565, RGB666, RGB888 output format. > > Add dt-bingings for it. > > Signed-off-by: Jagan Teki > --- > Changes for v3: > - updated to new dt-bindings style > > .../display/bridge/chipone,icn6211.yaml | 90 +++ > 1 file changed, 90 insertions(+) > create mode 100644 > Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml > Reviewed-by: Rob Herring
Re: [PATCH v3 1/2] dt-bindings: display: bridge: Add bindings for Chipone ICN6211
On Mon, Feb 15, 2021 at 05:38:16PM +0530, Jagan Teki wrote: > On Mon, Feb 15, 2021 at 5:28 PM Robert Foss wrote: > > > > Hey Jagan, > > > > Thanks for submitting this. > > > > checkpatch.pl threw some typ-o warnings, and I listed them below. I > > think either spelling is correct, but 'spelling.txt' does list this as > > a typ-o explicitly, so I would suggest conforming to that just to > > silence the checkpatch warning. > > > > This patch also passes 'dt_binding_check' and 'dtbs_check', but I > > think I'd like to defer to Rob Herring for an actual r-b. > > > > On Sun, 14 Feb 2021 at 18:55, Jagan Teki wrote: > > > > > > ICN6211 is MIPI-DSI to RGB Convertor bridge from Chipone. > > > > > > It has a flexible configuration of MIPI DSI signal input and > > > produce RGB565, RGB666, RGB888 output format. > > > > > > Add dt-bingings for it. > > > > > > Signed-off-by: Jagan Teki > > > --- > > > Changes for v3: > > > - updated to new dt-bindings style > > > > > > .../display/bridge/chipone,icn6211.yaml | 90 +++ > > > 1 file changed, 90 insertions(+) > > > create mode 100644 > > > Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml > > > > > > diff --git > > > a/Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml > > > b/Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml > > > new file mode 100644 > > > index ..13764f13fe46 > > > --- /dev/null > > > +++ > > > b/Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml > > > @@ -0,0 +1,90 @@ > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > > +%YAML 1.2 > > > +--- > > > +$id: http://devicetree.org/schemas/display/bridge/chipone,icn6211.yaml# > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > + > > > +title: Chipone ICN6211 MIPI-DSI to RGB Converter bridge > > > > $ scripts/checkpatch.pl --git HEAD~0 > > WARNING: 'Convertor' may be misspelled - perhaps 'Converter'? > > Thanks for pointing it. > > I was aware of it before sending it and need to understand whether we > need to use vendor naming conversion or not. Chipone call these > devices are Convertor [1], So I have used the vendor notation for > better understanding. > > Any comments are this would be welcome? Fix their spelling. If you need to propagate spelling/grammar errors, there's a defined way to do so. Rob > > [1] http://en.chiponeic.com/content/details45_123.html > > Jagan.
Re: [PATCH v3 1/2] dt-bindings: display: bridge: Add bindings for Chipone ICN6211
Hi Laurent, On Thu, Mar 4, 2021 at 4:29 AM Laurent Pinchart wrote: > > Hi Jagan, > > On Wed, Mar 03, 2021 at 08:08:35PM +0530, Jagan Teki wrote: > > On Wed, Feb 24, 2021 at 6:44 PM Laurent Pinchart wrote: > > > On Wed, Feb 24, 2021 at 06:07:43PM +0530, Jagan Teki wrote: > > > > On Mon, Feb 15, 2021 at 5:48 PM Laurent Pinchart wrote: > > > > > On Sun, Feb 14, 2021 at 11:22:10PM +0530, Jagan Teki wrote: > > > > > > ICN6211 is MIPI-DSI to RGB Convertor bridge from Chipone. > > > > > > > > > > > > It has a flexible configuration of MIPI DSI signal input and > > > > > > produce RGB565, RGB666, RGB888 output format. > > > > > > > > > > > > Add dt-bingings for it. > > > > > > > > > > > > Signed-off-by: Jagan Teki > > > > > > --- > > > > > > Changes for v3: > > > > > > - updated to new dt-bindings style > > > > > > > > > > > > .../display/bridge/chipone,icn6211.yaml | 90 > > > > > > +++ > > > > > > 1 file changed, 90 insertions(+) > > > > > > create mode 100644 > > > > > > Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml > > > > > > > > > > > > diff --git > > > > > > a/Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml > > > > > > > > > > > > b/Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml > > > > > > new file mode 100644 > > > > > > index ..13764f13fe46 > > > > > > --- /dev/null > > > > > > +++ > > > > > > b/Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml > > > > > > @@ -0,0 +1,90 @@ > > > > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > > > > > +%YAML 1.2 > > > > > > +--- > > > > > > +$id: > > > > > > http://devicetree.org/schemas/display/bridge/chipone,icn6211.yaml# > > > > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > > > > + > > > > > > +title: Chipone ICN6211 MIPI-DSI to RGB Converter bridge > > > > > > + > > > > > > +maintainers: > > > > > > + - Jagan Teki > > > > > > + > > > > > > +description: | > > > > > > + ICN6211 is MIPI-DSI to RGB Convertor bridge from chipone. > > > > > > + > > > > > > + It has a flexible configuration of MIPI DSI signal input and > > > > > > + produce RGB565, RGB666, RGB888 output format. > > > > > > > > > > How does one select between the output formats ? Should the output > > > > > connection option be described in the device tree ? > > > > > > > > I think that is a good option to select output formats via dts. what > > > > if it makes it a generic property like data-lanes? since it is common > > > > across many other bridges. > > > > > > Describing the output connection in the device tree sounds like a good > > > idea indeed. The bus-width property could be used for this, maybe along > > > the lines of > > > https://lore.kernel.org/dri-devel/20201013020619.gg3...@pendragon.ideasonboard.com/. > > > > I have seen an issue by passing bus-width where the same bus-with 24 > > can use by RGB888 and RGB666 according to > > mipi_dsi_pixel_format_to_bpp. Having a default RGB888 format now and > > update it when it supports properly, can be a good Idea I thought of. > > Let me know if you have any comments? > > I'm fine with hardcoding a default for now. If a given bus wiring (which > is described in DT by bus-width) can transport different formats, that's > something that should be configured dynamically, either by querying what > format a sink (such as a panel) requires, or if both the source and the > sink can support different formats, possibly by involving userspace in > the selection. Not sure how we can get userspace involvement in DRM here, but if source and sink can have different formats then having precedence to the source would be a good option as it handles low-level configuration for formats. Look like it is worth trying-feature. Maybe we can come up with some RFC and have a discussion. Jagan.
Re: [PATCH v3 1/2] dt-bindings: display: bridge: Add bindings for Chipone ICN6211
Hi Jagan, On Wed, Mar 03, 2021 at 08:08:35PM +0530, Jagan Teki wrote: > On Wed, Feb 24, 2021 at 6:44 PM Laurent Pinchart wrote: > > On Wed, Feb 24, 2021 at 06:07:43PM +0530, Jagan Teki wrote: > > > On Mon, Feb 15, 2021 at 5:48 PM Laurent Pinchart wrote: > > > > On Sun, Feb 14, 2021 at 11:22:10PM +0530, Jagan Teki wrote: > > > > > ICN6211 is MIPI-DSI to RGB Convertor bridge from Chipone. > > > > > > > > > > It has a flexible configuration of MIPI DSI signal input and > > > > > produce RGB565, RGB666, RGB888 output format. > > > > > > > > > > Add dt-bingings for it. > > > > > > > > > > Signed-off-by: Jagan Teki > > > > > --- > > > > > Changes for v3: > > > > > - updated to new dt-bindings style > > > > > > > > > > .../display/bridge/chipone,icn6211.yaml | 90 > > > > > +++ > > > > > 1 file changed, 90 insertions(+) > > > > > create mode 100644 > > > > > Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml > > > > > > > > > > diff --git > > > > > a/Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml > > > > > > > > > > b/Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml > > > > > new file mode 100644 > > > > > index ..13764f13fe46 > > > > > --- /dev/null > > > > > +++ > > > > > b/Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml > > > > > @@ -0,0 +1,90 @@ > > > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > > > > +%YAML 1.2 > > > > > +--- > > > > > +$id: > > > > > http://devicetree.org/schemas/display/bridge/chipone,icn6211.yaml# > > > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > > > + > > > > > +title: Chipone ICN6211 MIPI-DSI to RGB Converter bridge > > > > > + > > > > > +maintainers: > > > > > + - Jagan Teki > > > > > + > > > > > +description: | > > > > > + ICN6211 is MIPI-DSI to RGB Convertor bridge from chipone. > > > > > + > > > > > + It has a flexible configuration of MIPI DSI signal input and > > > > > + produce RGB565, RGB666, RGB888 output format. > > > > > > > > How does one select between the output formats ? Should the output > > > > connection option be described in the device tree ? > > > > > > I think that is a good option to select output formats via dts. what > > > if it makes it a generic property like data-lanes? since it is common > > > across many other bridges. > > > > Describing the output connection in the device tree sounds like a good > > idea indeed. The bus-width property could be used for this, maybe along > > the lines of > > https://lore.kernel.org/dri-devel/20201013020619.gg3...@pendragon.ideasonboard.com/. > > I have seen an issue by passing bus-width where the same bus-with 24 > can use by RGB888 and RGB666 according to > mipi_dsi_pixel_format_to_bpp. Having a default RGB888 format now and > update it when it supports properly, can be a good Idea I thought of. > Let me know if you have any comments? I'm fine with hardcoding a default for now. If a given bus wiring (which is described in DT by bus-width) can transport different formats, that's something that should be configured dynamically, either by querying what format a sink (such as a panel) requires, or if both the source and the sink can support different formats, possibly by involving userspace in the selection. -- Regards, Laurent Pinchart
Re: [PATCH v3 1/2] dt-bindings: display: bridge: Add bindings for Chipone ICN6211
On Wed, Feb 24, 2021 at 6:44 PM Laurent Pinchart wrote: > > Hi Jagan, > > On Wed, Feb 24, 2021 at 06:07:43PM +0530, Jagan Teki wrote: > > On Mon, Feb 15, 2021 at 5:48 PM Laurent Pinchart wrote: > > > On Sun, Feb 14, 2021 at 11:22:10PM +0530, Jagan Teki wrote: > > > > ICN6211 is MIPI-DSI to RGB Convertor bridge from Chipone. > > > > > > > > It has a flexible configuration of MIPI DSI signal input and > > > > produce RGB565, RGB666, RGB888 output format. > > > > > > > > Add dt-bingings for it. > > > > > > > > Signed-off-by: Jagan Teki > > > > --- > > > > Changes for v3: > > > > - updated to new dt-bindings style > > > > > > > > .../display/bridge/chipone,icn6211.yaml | 90 +++ > > > > 1 file changed, 90 insertions(+) > > > > create mode 100644 > > > > Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml > > > > > > > > diff --git > > > > a/Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml > > > > b/Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml > > > > new file mode 100644 > > > > index ..13764f13fe46 > > > > --- /dev/null > > > > +++ > > > > b/Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml > > > > @@ -0,0 +1,90 @@ > > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > > > +%YAML 1.2 > > > > +--- > > > > +$id: http://devicetree.org/schemas/display/bridge/chipone,icn6211.yaml# > > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > > + > > > > +title: Chipone ICN6211 MIPI-DSI to RGB Converter bridge > > > > + > > > > +maintainers: > > > > + - Jagan Teki > > > > + > > > > +description: | > > > > + ICN6211 is MIPI-DSI to RGB Convertor bridge from chipone. > > > > + > > > > + It has a flexible configuration of MIPI DSI signal input and > > > > + produce RGB565, RGB666, RGB888 output format. > > > > > > How does one select between the output formats ? Should the output > > > connection option be described in the device tree ? > > > > I think that is a good option to select output formats via dts. what > > if it makes it a generic property like data-lanes? since it is common > > across many other bridges. > > Describing the output connection in the device tree sounds like a good > idea indeed. The bus-width property could be used for this, maybe along > the lines of > https://lore.kernel.org/dri-devel/20201013020619.gg3...@pendragon.ideasonboard.com/. I have seen an issue by passing bus-width where the same bus-with 24 can use by RGB888 and RGB666 according to mipi_dsi_pixel_format_to_bpp. Having a default RGB888 format now and update it when it supports properly, can be a good Idea I thought of. Let me know if you have any comments? Jagan.
Re: [PATCH v3 1/2] dt-bindings: display: bridge: Add bindings for Chipone ICN6211
Hi Laurent, On Wed, Feb 24, 2021 at 6:44 PM Laurent Pinchart wrote: > > Hi Jagan, > > On Wed, Feb 24, 2021 at 06:07:43PM +0530, Jagan Teki wrote: > > On Mon, Feb 15, 2021 at 5:48 PM Laurent Pinchart wrote: > > > On Sun, Feb 14, 2021 at 11:22:10PM +0530, Jagan Teki wrote: > > > > ICN6211 is MIPI-DSI to RGB Convertor bridge from Chipone. > > > > > > > > It has a flexible configuration of MIPI DSI signal input and > > > > produce RGB565, RGB666, RGB888 output format. > > > > > > > > Add dt-bingings for it. > > > > > > > > Signed-off-by: Jagan Teki > > > > --- > > > > Changes for v3: > > > > - updated to new dt-bindings style > > > > > > > > .../display/bridge/chipone,icn6211.yaml | 90 +++ > > > > 1 file changed, 90 insertions(+) > > > > create mode 100644 > > > > Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml > > > > > > > > diff --git > > > > a/Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml > > > > b/Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml > > > > new file mode 100644 > > > > index ..13764f13fe46 > > > > --- /dev/null > > > > +++ > > > > b/Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml > > > > @@ -0,0 +1,90 @@ > > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > > > +%YAML 1.2 > > > > +--- > > > > +$id: http://devicetree.org/schemas/display/bridge/chipone,icn6211.yaml# > > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > > + > > > > +title: Chipone ICN6211 MIPI-DSI to RGB Converter bridge > > > > + > > > > +maintainers: > > > > + - Jagan Teki > > > > + > > > > +description: | > > > > + ICN6211 is MIPI-DSI to RGB Convertor bridge from chipone. > > > > + > > > > + It has a flexible configuration of MIPI DSI signal input and > > > > + produce RGB565, RGB666, RGB888 output format. > > > > > > How does one select between the output formats ? Should the output > > > connection option be described in the device tree ? > > > > I think that is a good option to select output formats via dts. what > > if it makes it a generic property like data-lanes? since it is common > > across many other bridges. > > Describing the output connection in the device tree sounds like a good > idea indeed. The bus-width property could be used for this, maybe along > the lines of > https://lore.kernel.org/dri-devel/20201013020619.gg3...@pendragon.ideasonboard.com/. I think this bridge is doing, what we discussed? am I correct? Documentation/devicetree/bindings/display/bridge/ti,tfp410.yaml > > If, for a given wiring of the output, different formats could be used, > then we would need to select them at runtime. That means the opposite of what mipi_dsi_pixel_format_to_bpp is doing right? like given bpp we need to select format. Jagan.
Re: [PATCH v3 1/2] dt-bindings: display: bridge: Add bindings for Chipone ICN6211
Hi Jagan, On Wed, Feb 24, 2021 at 06:07:43PM +0530, Jagan Teki wrote: > On Mon, Feb 15, 2021 at 5:48 PM Laurent Pinchart wrote: > > On Sun, Feb 14, 2021 at 11:22:10PM +0530, Jagan Teki wrote: > > > ICN6211 is MIPI-DSI to RGB Convertor bridge from Chipone. > > > > > > It has a flexible configuration of MIPI DSI signal input and > > > produce RGB565, RGB666, RGB888 output format. > > > > > > Add dt-bingings for it. > > > > > > Signed-off-by: Jagan Teki > > > --- > > > Changes for v3: > > > - updated to new dt-bindings style > > > > > > .../display/bridge/chipone,icn6211.yaml | 90 +++ > > > 1 file changed, 90 insertions(+) > > > create mode 100644 > > > Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml > > > > > > diff --git > > > a/Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml > > > b/Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml > > > new file mode 100644 > > > index ..13764f13fe46 > > > --- /dev/null > > > +++ > > > b/Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml > > > @@ -0,0 +1,90 @@ > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > > +%YAML 1.2 > > > +--- > > > +$id: http://devicetree.org/schemas/display/bridge/chipone,icn6211.yaml# > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > + > > > +title: Chipone ICN6211 MIPI-DSI to RGB Converter bridge > > > + > > > +maintainers: > > > + - Jagan Teki > > > + > > > +description: | > > > + ICN6211 is MIPI-DSI to RGB Convertor bridge from chipone. > > > + > > > + It has a flexible configuration of MIPI DSI signal input and > > > + produce RGB565, RGB666, RGB888 output format. > > > > How does one select between the output formats ? Should the output > > connection option be described in the device tree ? > > I think that is a good option to select output formats via dts. what > if it makes it a generic property like data-lanes? since it is common > across many other bridges. Describing the output connection in the device tree sounds like a good idea indeed. The bus-width property could be used for this, maybe along the lines of https://lore.kernel.org/dri-devel/20201013020619.gg3...@pendragon.ideasonboard.com/. If, for a given wiring of the output, different formats could be used, then we would need to select them at runtime. > > > + > > > +properties: > > > + compatible: > > > +enum: > > > + - chipone,icn6211 > > > + > > > + reg: > > > +maxItems: 1 > > > +description: virtual channel number of a DSI peripheral > > > + > > > + reset-gpios: > > > +description: GPIO connected for the reset pin > > > + > > > + ports: > > > +$ref: /schemas/graph.yaml#/properties/ports > > > + > > > +properties: > > > + port@0: > > > +$ref: /schemas/graph.yaml#/properties/port > > > +description: > > > + Video port for MIPI DSI input > > > + > > > + port@1: > > > +$ref: /schemas/graph.yaml#/properties/port > > > +description: > > > + Video port for MIPI DPI output (panel or connector). > > > + > > > +required: > > > + - port@0 > > > + - port@1 > > > + > > > +required: > > > + - compatible > > > + - reg > > > + - reset-gpios > > > + - ports > > > > How about regulators ? > > Will add it in the next version. -- Regards, Laurent Pinchart
Re: [PATCH v3 1/2] dt-bindings: display: bridge: Add bindings for Chipone ICN6211
Hi Laurent, On Mon, Feb 15, 2021 at 5:48 PM Laurent Pinchart wrote: > > Hi Jagan, > > Thank you for the patch. > > On Sun, Feb 14, 2021 at 11:22:10PM +0530, Jagan Teki wrote: > > ICN6211 is MIPI-DSI to RGB Convertor bridge from Chipone. > > > > It has a flexible configuration of MIPI DSI signal input and > > produce RGB565, RGB666, RGB888 output format. > > > > Add dt-bingings for it. > > > > Signed-off-by: Jagan Teki > > --- > > Changes for v3: > > - updated to new dt-bindings style > > > > .../display/bridge/chipone,icn6211.yaml | 90 +++ > > 1 file changed, 90 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml > > > > diff --git > > a/Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml > > b/Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml > > new file mode 100644 > > index ..13764f13fe46 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml > > @@ -0,0 +1,90 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/display/bridge/chipone,icn6211.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Chipone ICN6211 MIPI-DSI to RGB Converter bridge > > + > > +maintainers: > > + - Jagan Teki > > + > > +description: | > > + ICN6211 is MIPI-DSI to RGB Convertor bridge from chipone. > > + > > + It has a flexible configuration of MIPI DSI signal input and > > + produce RGB565, RGB666, RGB888 output format. > > How does one select between the output formats ? Should the output > connection option be described in the device tree ? I think that is a good option to select output formats via dts. what if it makes it a generic property like data-lanes? since it is common across many other bridges. > > > + > > +properties: > > + compatible: > > +enum: > > + - chipone,icn6211 > > + > > + reg: > > +maxItems: 1 > > +description: virtual channel number of a DSI peripheral > > + > > + reset-gpios: > > +description: GPIO connected for the reset pin > > + > > + ports: > > +$ref: /schemas/graph.yaml#/properties/ports > > + > > +properties: > > + port@0: > > +$ref: /schemas/graph.yaml#/properties/port > > +description: > > + Video port for MIPI DSI input > > + > > + port@1: > > +$ref: /schemas/graph.yaml#/properties/port > > +description: > > + Video port for MIPI DPI output (panel or connector). > > + > > +required: > > + - port@0 > > + - port@1 > > + > > +required: > > + - compatible > > + - reg > > + - reset-gpios > > + - ports > > How about regulators ? Will add it in the next version. Jagan.
Re: [PATCH v3 1/2] dt-bindings: display: bridge: Add bindings for Chipone ICN6211
Hi Jagan,
Thank you for the patch.
On Sun, Feb 14, 2021 at 11:22:10PM +0530, Jagan Teki wrote:
> ICN6211 is MIPI-DSI to RGB Convertor bridge from Chipone.
>
> It has a flexible configuration of MIPI DSI signal input and
> produce RGB565, RGB666, RGB888 output format.
>
> Add dt-bingings for it.
>
> Signed-off-by: Jagan Teki
> ---
> Changes for v3:
> - updated to new dt-bindings style
>
> .../display/bridge/chipone,icn6211.yaml | 90 +++
> 1 file changed, 90 insertions(+)
> create mode 100644
> Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml
>
> diff --git
> a/Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml
> b/Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml
> new file mode 100644
> index ..13764f13fe46
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml
> @@ -0,0 +1,90 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/bridge/chipone,icn6211.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Chipone ICN6211 MIPI-DSI to RGB Converter bridge
> +
> +maintainers:
> + - Jagan Teki
> +
> +description: |
> + ICN6211 is MIPI-DSI to RGB Convertor bridge from chipone.
> +
> + It has a flexible configuration of MIPI DSI signal input and
> + produce RGB565, RGB666, RGB888 output format.
How does one select between the output formats ? Should the output
connection option be described in the device tree ?
> +
> +properties:
> + compatible:
> +enum:
> + - chipone,icn6211
> +
> + reg:
> +maxItems: 1
> +description: virtual channel number of a DSI peripheral
> +
> + reset-gpios:
> +description: GPIO connected for the reset pin
> +
> + ports:
> +$ref: /schemas/graph.yaml#/properties/ports
> +
> +properties:
> + port@0:
> +$ref: /schemas/graph.yaml#/properties/port
> +description:
> + Video port for MIPI DSI input
> +
> + port@1:
> +$ref: /schemas/graph.yaml#/properties/port
> +description:
> + Video port for MIPI DPI output (panel or connector).
> +
> +required:
> + - port@0
> + - port@1
> +
> +required:
> + - compatible
> + - reg
> + - reset-gpios
> + - ports
How about regulators ?
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> +#include
> +
> +dsi {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + bridge@0 {
> +compatible = "chipone,icn6211";
> +reg = <0>;
> +reset-gpios = <&r_pio 0 5 GPIO_ACTIVE_HIGH>; /* LCD-RST: PL5 */
> +
> +ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + bridge_in: port@0 {
You can drop this label.
> +reg = <0>;
> +
> +bridge_out_dsi: endpoint {
This label should be bridge_in_dsi.
> + remote-endpoint = <&dsi_out_bridge>;
> +};
> + };
> +
> + bridge_out: port@1 {
You can drop this label too.
> +reg = <1>;
> +
> +bridge_out_panel: endpoint {
> + remote-endpoint = <&panel_out_bridge>;
> +};
> + };
> +};
> + };
> +};
--
Regards,
Laurent Pinchart
Re: [PATCH v3 1/2] dt-bindings: display: bridge: Add bindings for Chipone ICN6211
On Mon, Feb 15, 2021 at 5:28 PM Robert Foss wrote: > > Hey Jagan, > > Thanks for submitting this. > > checkpatch.pl threw some typ-o warnings, and I listed them below. I > think either spelling is correct, but 'spelling.txt' does list this as > a typ-o explicitly, so I would suggest conforming to that just to > silence the checkpatch warning. > > This patch also passes 'dt_binding_check' and 'dtbs_check', but I > think I'd like to defer to Rob Herring for an actual r-b. > > On Sun, 14 Feb 2021 at 18:55, Jagan Teki wrote: > > > > ICN6211 is MIPI-DSI to RGB Convertor bridge from Chipone. > > > > It has a flexible configuration of MIPI DSI signal input and > > produce RGB565, RGB666, RGB888 output format. > > > > Add dt-bingings for it. > > > > Signed-off-by: Jagan Teki > > --- > > Changes for v3: > > - updated to new dt-bindings style > > > > .../display/bridge/chipone,icn6211.yaml | 90 +++ > > 1 file changed, 90 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml > > > > diff --git > > a/Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml > > b/Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml > > new file mode 100644 > > index ..13764f13fe46 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml > > @@ -0,0 +1,90 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/display/bridge/chipone,icn6211.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Chipone ICN6211 MIPI-DSI to RGB Converter bridge > > $ scripts/checkpatch.pl --git HEAD~0 > WARNING: 'Convertor' may be misspelled - perhaps 'Converter'? Thanks for pointing it. I was aware of it before sending it and need to understand whether we need to use vendor naming conversion or not. Chipone call these devices are Convertor [1], So I have used the vendor notation for better understanding. Any comments are this would be welcome? [1] http://en.chiponeic.com/content/details45_123.html Jagan.
Re: [PATCH v3 1/2] dt-bindings: display: bridge: Add bindings for Chipone ICN6211
Hey Jagan,
Thanks for submitting this.
checkpatch.pl threw some typ-o warnings, and I listed them below. I
think either spelling is correct, but 'spelling.txt' does list this as
a typ-o explicitly, so I would suggest conforming to that just to
silence the checkpatch warning.
This patch also passes 'dt_binding_check' and 'dtbs_check', but I
think I'd like to defer to Rob Herring for an actual r-b.
On Sun, 14 Feb 2021 at 18:55, Jagan Teki wrote:
>
> ICN6211 is MIPI-DSI to RGB Convertor bridge from Chipone.
>
> It has a flexible configuration of MIPI DSI signal input and
> produce RGB565, RGB666, RGB888 output format.
>
> Add dt-bingings for it.
>
> Signed-off-by: Jagan Teki
> ---
> Changes for v3:
> - updated to new dt-bindings style
>
> .../display/bridge/chipone,icn6211.yaml | 90 +++
> 1 file changed, 90 insertions(+)
> create mode 100644
> Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml
>
> diff --git
> a/Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml
> b/Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml
> new file mode 100644
> index ..13764f13fe46
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml
> @@ -0,0 +1,90 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/bridge/chipone,icn6211.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Chipone ICN6211 MIPI-DSI to RGB Converter bridge
$ scripts/checkpatch.pl --git HEAD~0
WARNING: 'Convertor' may be misspelled - perhaps 'Converter'?
#7:
ICN6211 is MIPI-DSI to RGB Convertor bridge from Chipone.
^
> +
> +maintainers:
> + - Jagan Teki
> +
> +description: |
> + ICN6211 is MIPI-DSI to RGB Convertor bridge from chipone.
WARNING: 'Convertor' may be misspelled - perhaps 'Converter'?
#38: FILE:
Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml:13:
+ ICN6211 is MIPI-DSI to RGB Convertor bridge from chipone.
^
> +
> + It has a flexible configuration of MIPI DSI signal input and
> + produce RGB565, RGB666, RGB888 output format.
> +
> +properties:
> + compatible:
> +enum:
> + - chipone,icn6211
> +
> + reg:
> +maxItems: 1
> +description: virtual channel number of a DSI peripheral
> +
> + reset-gpios:
> +description: GPIO connected for the reset pin
> +
> + ports:
> +$ref: /schemas/graph.yaml#/properties/ports
> +
> +properties:
> + port@0:
> +$ref: /schemas/graph.yaml#/properties/port
> +description:
> + Video port for MIPI DSI input
> +
> + port@1:
> +$ref: /schemas/graph.yaml#/properties/port
> +description:
> + Video port for MIPI DPI output (panel or connector).
> +
> +required:
> + - port@0
> + - port@1
> +
> +required:
> + - compatible
> + - reg
> + - reset-gpios
> + - ports
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> +#include
> +
> +dsi {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + bridge@0 {
> +compatible = "chipone,icn6211";
> +reg = <0>;
> +reset-gpios = <&r_pio 0 5 GPIO_ACTIVE_HIGH>; /* LCD-RST: PL5 */
> +
> +ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + bridge_in: port@0 {
> +reg = <0>;
> +
> +bridge_out_dsi: endpoint {
> + remote-endpoint = <&dsi_out_bridge>;
> +};
> + };
> +
> + bridge_out: port@1 {
> +reg = <1>;
> +
> +bridge_out_panel: endpoint {
> + remote-endpoint = <&panel_out_bridge>;
> +};
> + };
> +};
> + };
> +};
> --
> 2.25.1
>
[PATCH v3 1/2] dt-bindings: display: bridge: Add bindings for Chipone ICN6211
ICN6211 is MIPI-DSI to RGB Convertor bridge from Chipone.
It has a flexible configuration of MIPI DSI signal input and
produce RGB565, RGB666, RGB888 output format.
Add dt-bingings for it.
Signed-off-by: Jagan Teki
---
Changes for v3:
- updated to new dt-bindings style
.../display/bridge/chipone,icn6211.yaml | 90 +++
1 file changed, 90 insertions(+)
create mode 100644
Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml
diff --git
a/Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml
b/Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml
new file mode 100644
index ..13764f13fe46
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml
@@ -0,0 +1,90 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/bridge/chipone,icn6211.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Chipone ICN6211 MIPI-DSI to RGB Converter bridge
+
+maintainers:
+ - Jagan Teki
+
+description: |
+ ICN6211 is MIPI-DSI to RGB Convertor bridge from chipone.
+
+ It has a flexible configuration of MIPI DSI signal input and
+ produce RGB565, RGB666, RGB888 output format.
+
+properties:
+ compatible:
+enum:
+ - chipone,icn6211
+
+ reg:
+maxItems: 1
+description: virtual channel number of a DSI peripheral
+
+ reset-gpios:
+description: GPIO connected for the reset pin
+
+ ports:
+$ref: /schemas/graph.yaml#/properties/ports
+
+properties:
+ port@0:
+$ref: /schemas/graph.yaml#/properties/port
+description:
+ Video port for MIPI DSI input
+
+ port@1:
+$ref: /schemas/graph.yaml#/properties/port
+description:
+ Video port for MIPI DPI output (panel or connector).
+
+required:
+ - port@0
+ - port@1
+
+required:
+ - compatible
+ - reg
+ - reset-gpios
+ - ports
+
+additionalProperties: false
+
+examples:
+ - |
+#include
+
+dsi {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ bridge@0 {
+compatible = "chipone,icn6211";
+reg = <0>;
+reset-gpios = <&r_pio 0 5 GPIO_ACTIVE_HIGH>; /* LCD-RST: PL5 */
+
+ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ bridge_in: port@0 {
+reg = <0>;
+
+bridge_out_dsi: endpoint {
+ remote-endpoint = <&dsi_out_bridge>;
+};
+ };
+
+ bridge_out: port@1 {
+reg = <1>;
+
+bridge_out_panel: endpoint {
+ remote-endpoint = <&panel_out_bridge>;
+};
+ };
+};
+ };
+};
--
2.25.1
