Re: [PATCH v3 1/2] dt-bindings: sound: add DT bindings for Microchip S/PDIF TX Controller

2020-08-12 Thread Rob Herring
On Mon, 03 Aug 2020 11:18:50 +0300, Codrin Ciubotariu wrote:
> This patch adds DT bindings for the new Microchip S/PDIF TX Controller
> embedded inside sama7g5 SoCs.
> 
> Signed-off-by: Codrin Ciubotariu 
> ---
> 
> Changes in v3:
>  - removed 'oneOf' from 'compatible' property;
>  - added 'maxItems: 1' to 'dmas' property;
>  - removed pinctrl related properties;
> 
> Changes in v2:
>  - replaced https with http;
>  - reworked example, included bindings;
> 
>  .../bindings/sound/mchp,spdiftx.yaml  | 75 +++
>  1 file changed, 75 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/sound/mchp,spdiftx.yaml
> 

Reviewed-by: Rob Herring 


[PATCH v3 1/2] dt-bindings: sound: add DT bindings for Microchip S/PDIF TX Controller

2020-08-03 Thread Codrin Ciubotariu
This patch adds DT bindings for the new Microchip S/PDIF TX Controller
embedded inside sama7g5 SoCs.

Signed-off-by: Codrin Ciubotariu 
---

Changes in v3:
 - removed 'oneOf' from 'compatible' property;
 - added 'maxItems: 1' to 'dmas' property;
 - removed pinctrl related properties;

Changes in v2:
 - replaced https with http;
 - reworked example, included bindings;

 .../bindings/sound/mchp,spdiftx.yaml  | 75 +++
 1 file changed, 75 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/sound/mchp,spdiftx.yaml

diff --git a/Documentation/devicetree/bindings/sound/mchp,spdiftx.yaml 
b/Documentation/devicetree/bindings/sound/mchp,spdiftx.yaml
new file mode 100644
index ..a03b0b871fc9
--- /dev/null
+++ b/Documentation/devicetree/bindings/sound/mchp,spdiftx.yaml
@@ -0,0 +1,75 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/sound/mchp,spdiftx.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Microchip S/PDIF Tx Controller Device Tree Bindings
+
+maintainers:
+  - Codrin Ciubotariu 
+
+description:
+The Microchip Sony/Philips Digital Interface Transmitter is a
+serial port compliant with the IEC-60958 standard.
+
+properties:
+  "#sound-dai-cells":
+const: 0
+
+  compatible:
+const: microchip,sama7g5-spdiftx
+
+  reg:
+maxItems: 1
+
+  interrupts:
+maxItems: 1
+
+  clocks:
+items:
+  - description: Peripheral Bus Clock
+  - description: Generic Clock
+
+  clock-names:
+items:
+  - const: pclk
+  - const: gclk
+
+  dmas:
+description: TX DMA Channel
+maxItems: 1
+
+  dma-names:
+const: tx
+
+required:
+  - "#sound-dai-cells"
+  - compatible
+  - reg
+  - interrupts
+  - clocks
+  - clock-names
+  - dmas
+  - dma-names
+
+additionalProperties: false
+
+examples:
+  - |
+#include 
+#include 
+#include 
+
+spdiftx@e1618000 {
+#sound-dai-cells = <0>;
+compatible = "microchip,sama7g5-spdiftx";
+reg = <0xe1618000 0x4000>;
+interrupts = ;
+dmas = < AT91_XDMAC_DT_PERID(50)>;
+dma-names = "tx";
+clocks = < PMC_TYPE_PERIPHERAL 85>, < PMC_TYPE_GCK 85>;
+clock-names = "pclk", "gclk";
+pinctrl-names = "default";
+pinctrl-0 = <_spdiftx_default>;
+};
-- 
2.25.1