Re: [PATCH v3 1/3] acpi : cpu hot-remove returns error when cpu_down() fails

2012-07-13 Thread Yasuaki Ishimatsu 
Hi Srivatsa,

2012/07/12 21:32, Srivatsa S. Bhat wrote:
> On 07/12/2012 04:52 PM, Yasuaki Ishimatsu wrote:
>> Even if cpu_down() fails, acpi_processor_remove() continues to remove the 
>> cpu.
>> But in this case, it should return error number since some process may run on
>> the cpu. If the cpu has a running process and the cpu is turned the power 
>> off,
>> the system may not work well.
>>
>> Signed-off-by: Yasuaki Ishimatsu 
>>
> 
> Reviewed-by: Srivatsa S. Bhat 

Thank you for reviewing.

Thanks,
Yasuaki Ishimatsu

> Regards,
> Srivatsa S. Bhat
> 
>> ---
>>   drivers/acpi/processor_driver.c |   18 --
>>   1 file changed, 12 insertions(+), 6 deletions(-)
>>
>> Index: linux-3.5-rc4/drivers/acpi/processor_driver.c
>> ===
>> --- linux-3.5-rc4.orig/drivers/acpi/processor_driver.c   2012-06-25 
>> 04:53:04.0 +0900
>> +++ linux-3.5-rc4/drivers/acpi/processor_driver.c2012-07-05 
>> 21:02:58.711285382 +0900
>> @@ -610,7 +610,7 @@ err_free_pr:
>>   static int acpi_processor_remove(struct acpi_device *device, int type)
>>   {
>>  struct acpi_processor *pr = NULL;
>> -
>> +int ret;
>>
>>  if (!device || !acpi_driver_data(device))
>>  return -EINVAL;
>> @@ -621,8 +621,9 @@ static int acpi_processor_remove(struct
>>  goto free;
>>
>>  if (type == ACPI_BUS_REMOVAL_EJECT) {
>> -if (acpi_processor_handle_eject(pr))
>> -return -EINVAL;
>> +ret = acpi_processor_handle_eject(pr);
>> +if (ret)
>> +return ret;
>>  }
>>
>>  acpi_processor_power_exit(pr, device);
>> @@ -841,12 +842,17 @@ static acpi_status acpi_processor_hotadd
>>
>>   static int acpi_processor_handle_eject(struct acpi_processor *pr)
>>   {
>> -if (cpu_online(pr->id))
>> -cpu_down(pr->id);
>> +int ret;
>> +
>> +if (cpu_online(pr->id)) {
>> +ret = cpu_down(pr->id);
>> +if (ret)
>> +return ret;
>> +}
>>
>>  arch_unregister_cpu(pr->id);
>>  acpi_unmap_lsapic(pr->id);
>> -return (0);
>> +return ret;
>>   }
>>   #else
>>   static acpi_status acpi_processor_hotadd_init(struct acpi_processor *pr)
>>
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH v3 1/3] acpi : cpu hot-remove returns error when cpu_down() fails

2012-07-13 Thread Yasuaki Ishimatsu 

Hi Toshi,

2012/07/13 1:48, Toshi Kani wrote:

On Thu, 2012-07-12 at 20:22 +0900, Yasuaki Ishimatsu wrote:

Even if cpu_down() fails, acpi_processor_remove() continues to remove the cpu.
But in this case, it should return error number since some process may run on
the cpu. If the cpu has a running process and the cpu is turned the power off,
the system may not work well.

Signed-off-by: Yasuaki Ishimatsu 

---
  drivers/acpi/processor_driver.c |   18 --
  1 file changed, 12 insertions(+), 6 deletions(-)

Index: linux-3.5-rc4/drivers/acpi/processor_driver.c
===
--- linux-3.5-rc4.orig/drivers/acpi/processor_driver.c  2012-06-25 
04:53:04.0 +0900
+++ linux-3.5-rc4/drivers/acpi/processor_driver.c   2012-07-05 
21:02:58.711285382 +0900
@@ -610,7 +610,7 @@ err_free_pr:
  static int acpi_processor_remove(struct acpi_device *device, int type)
  {
struct acpi_processor *pr = NULL;
-
+   int ret;

if (!device || !acpi_driver_data(device))
return -EINVAL;
@@ -621,8 +621,9 @@ static int acpi_processor_remove(struct
goto free;

if (type == ACPI_BUS_REMOVAL_EJECT) {
-   if (acpi_processor_handle_eject(pr))
-   return -EINVAL;
+   ret = acpi_processor_handle_eject(pr);
+   if (ret)
+   return ret;
}

acpi_processor_power_exit(pr, device);
@@ -841,12 +842,17 @@ static acpi_status acpi_processor_hotadd

  static int acpi_processor_handle_eject(struct acpi_processor *pr)
  {
-   if (cpu_online(pr->id))
-   cpu_down(pr->id);
+   int ret;
+
+   if (cpu_online(pr->id)) {
+   ret = cpu_down(pr->id);
+   if (ret)
+   return ret;
+   }

arch_unregister_cpu(pr->id);
acpi_unmap_lsapic(pr->id);
-   return (0);
+   return ret;


ret is uninitialized when !cpu_online().


Oops! I'll update it.

Thanks,
Yasuaki Ishimatsu


Thanks,
-Toshi


  }
  #else
  static acpi_status acpi_processor_hotadd_init(struct acpi_processor *pr)

--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html



--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html





--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH v3 1/3] acpi : cpu hot-remove returns error when cpu_down() fails

2012-07-13 Thread Yasuaki Ishimatsu 

Hi Toshi,

2012/07/13 1:48, Toshi Kani wrote:

On Thu, 2012-07-12 at 20:22 +0900, Yasuaki Ishimatsu wrote:

Even if cpu_down() fails, acpi_processor_remove() continues to remove the cpu.
But in this case, it should return error number since some process may run on
the cpu. If the cpu has a running process and the cpu is turned the power off,
the system may not work well.

Signed-off-by: Yasuaki Ishimatsu isimatu.yasu...@jp.fujitsu.com

---
  drivers/acpi/processor_driver.c |   18 --
  1 file changed, 12 insertions(+), 6 deletions(-)

Index: linux-3.5-rc4/drivers/acpi/processor_driver.c
===
--- linux-3.5-rc4.orig/drivers/acpi/processor_driver.c  2012-06-25 
04:53:04.0 +0900
+++ linux-3.5-rc4/drivers/acpi/processor_driver.c   2012-07-05 
21:02:58.711285382 +0900
@@ -610,7 +610,7 @@ err_free_pr:
  static int acpi_processor_remove(struct acpi_device *device, int type)
  {
struct acpi_processor *pr = NULL;
-
+   int ret;

if (!device || !acpi_driver_data(device))
return -EINVAL;
@@ -621,8 +621,9 @@ static int acpi_processor_remove(struct
goto free;

if (type == ACPI_BUS_REMOVAL_EJECT) {
-   if (acpi_processor_handle_eject(pr))
-   return -EINVAL;
+   ret = acpi_processor_handle_eject(pr);
+   if (ret)
+   return ret;
}

acpi_processor_power_exit(pr, device);
@@ -841,12 +842,17 @@ static acpi_status acpi_processor_hotadd

  static int acpi_processor_handle_eject(struct acpi_processor *pr)
  {
-   if (cpu_online(pr-id))
-   cpu_down(pr-id);
+   int ret;
+
+   if (cpu_online(pr-id)) {
+   ret = cpu_down(pr-id);
+   if (ret)
+   return ret;
+   }

arch_unregister_cpu(pr-id);
acpi_unmap_lsapic(pr-id);
-   return (0);
+   return ret;


ret is uninitialized when !cpu_online().


Oops! I'll update it.

Thanks,
Yasuaki Ishimatsu


Thanks,
-Toshi


  }
  #else
  static acpi_status acpi_processor_hotadd_init(struct acpi_processor *pr)

--
To unsubscribe from this list: send the line unsubscribe linux-acpi in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html



--
To unsubscribe from this list: send the line unsubscribe linux-acpi in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html





--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH v3 1/3] acpi : cpu hot-remove returns error when cpu_down() fails

2012-07-13 Thread Yasuaki Ishimatsu 
Hi Srivatsa,

2012/07/12 21:32, Srivatsa S. Bhat wrote:
 On 07/12/2012 04:52 PM, Yasuaki Ishimatsu wrote:
 Even if cpu_down() fails, acpi_processor_remove() continues to remove the 
 cpu.
 But in this case, it should return error number since some process may run on
 the cpu. If the cpu has a running process and the cpu is turned the power 
 off,
 the system may not work well.

 Signed-off-by: Yasuaki Ishimatsu isimatu.yasu...@jp.fujitsu.com

 
 Reviewed-by: Srivatsa S. Bhat srivatsa.b...@linux.vnet.ibm.com

Thank you for reviewing.

Thanks,
Yasuaki Ishimatsu

 Regards,
 Srivatsa S. Bhat
 
 ---
   drivers/acpi/processor_driver.c |   18 --
   1 file changed, 12 insertions(+), 6 deletions(-)

 Index: linux-3.5-rc4/drivers/acpi/processor_driver.c
 ===
 --- linux-3.5-rc4.orig/drivers/acpi/processor_driver.c   2012-06-25 
 04:53:04.0 +0900
 +++ linux-3.5-rc4/drivers/acpi/processor_driver.c2012-07-05 
 21:02:58.711285382 +0900
 @@ -610,7 +610,7 @@ err_free_pr:
   static int acpi_processor_remove(struct acpi_device *device, int type)
   {
  struct acpi_processor *pr = NULL;
 -
 +int ret;

  if (!device || !acpi_driver_data(device))
  return -EINVAL;
 @@ -621,8 +621,9 @@ static int acpi_processor_remove(struct
  goto free;

  if (type == ACPI_BUS_REMOVAL_EJECT) {
 -if (acpi_processor_handle_eject(pr))
 -return -EINVAL;
 +ret = acpi_processor_handle_eject(pr);
 +if (ret)
 +return ret;
  }

  acpi_processor_power_exit(pr, device);
 @@ -841,12 +842,17 @@ static acpi_status acpi_processor_hotadd

   static int acpi_processor_handle_eject(struct acpi_processor *pr)
   {
 -if (cpu_online(pr-id))
 -cpu_down(pr-id);
 +int ret;
 +
 +if (cpu_online(pr-id)) {
 +ret = cpu_down(pr-id);
 +if (ret)
 +return ret;
 +}

  arch_unregister_cpu(pr-id);
  acpi_unmap_lsapic(pr-id);
 -return (0);
 +return ret;
   }
   #else
   static acpi_status acpi_processor_hotadd_init(struct acpi_processor *pr)

 
 --
 To unsubscribe from this list: send the line unsubscribe linux-acpi in
 the body of a message to majord...@vger.kernel.org
 More majordomo info at  http://vger.kernel.org/majordomo-info.html
 



--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH v3 1/3] acpi : cpu hot-remove returns error when cpu_down() fails

2012-07-12 Thread Toshi Kani 
On Thu, 2012-07-12 at 20:22 +0900, Yasuaki Ishimatsu wrote:
> Even if cpu_down() fails, acpi_processor_remove() continues to remove the cpu.
> But in this case, it should return error number since some process may run on
> the cpu. If the cpu has a running process and the cpu is turned the power off,
> the system may not work well.
> 
> Signed-off-by: Yasuaki Ishimatsu 
> 
> ---
>  drivers/acpi/processor_driver.c |   18 --
>  1 file changed, 12 insertions(+), 6 deletions(-)
> 
> Index: linux-3.5-rc4/drivers/acpi/processor_driver.c
> ===
> --- linux-3.5-rc4.orig/drivers/acpi/processor_driver.c2012-06-25 
> 04:53:04.0 +0900
> +++ linux-3.5-rc4/drivers/acpi/processor_driver.c 2012-07-05 
> 21:02:58.711285382 +0900
> @@ -610,7 +610,7 @@ err_free_pr:
>  static int acpi_processor_remove(struct acpi_device *device, int type)
>  {
>   struct acpi_processor *pr = NULL;
> -
> + int ret;
> 
>   if (!device || !acpi_driver_data(device))
>   return -EINVAL;
> @@ -621,8 +621,9 @@ static int acpi_processor_remove(struct
>   goto free;
> 
>   if (type == ACPI_BUS_REMOVAL_EJECT) {
> - if (acpi_processor_handle_eject(pr))
> - return -EINVAL;
> + ret = acpi_processor_handle_eject(pr);
> + if (ret)
> + return ret;
>   }
> 
>   acpi_processor_power_exit(pr, device);
> @@ -841,12 +842,17 @@ static acpi_status acpi_processor_hotadd
> 
>  static int acpi_processor_handle_eject(struct acpi_processor *pr)
>  {
> - if (cpu_online(pr->id))
> - cpu_down(pr->id);
> + int ret;
> +
> + if (cpu_online(pr->id)) {
> + ret = cpu_down(pr->id);
> + if (ret)
> + return ret;
> + }
> 
>   arch_unregister_cpu(pr->id);
>   acpi_unmap_lsapic(pr->id);
> - return (0);
> + return ret;

ret is uninitialized when !cpu_online().

Thanks,
-Toshi

>  }
>  #else
>  static acpi_status acpi_processor_hotadd_init(struct acpi_processor *pr)
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH v3 1/3] acpi : cpu hot-remove returns error when cpu_down() fails

2012-07-12 Thread Srivatsa S. Bhat 
On 07/12/2012 04:52 PM, Yasuaki Ishimatsu wrote:
> Even if cpu_down() fails, acpi_processor_remove() continues to remove the cpu.
> But in this case, it should return error number since some process may run on
> the cpu. If the cpu has a running process and the cpu is turned the power off,
> the system may not work well.
> 
> Signed-off-by: Yasuaki Ishimatsu 
> 

Reviewed-by: Srivatsa S. Bhat 

Regards,
Srivatsa S. Bhat

> ---
>  drivers/acpi/processor_driver.c |   18 --
>  1 file changed, 12 insertions(+), 6 deletions(-)
> 
> Index: linux-3.5-rc4/drivers/acpi/processor_driver.c
> ===
> --- linux-3.5-rc4.orig/drivers/acpi/processor_driver.c2012-06-25 
> 04:53:04.0 +0900
> +++ linux-3.5-rc4/drivers/acpi/processor_driver.c 2012-07-05 
> 21:02:58.711285382 +0900
> @@ -610,7 +610,7 @@ err_free_pr:
>  static int acpi_processor_remove(struct acpi_device *device, int type)
>  {
>   struct acpi_processor *pr = NULL;
> -
> + int ret;
> 
>   if (!device || !acpi_driver_data(device))
>   return -EINVAL;
> @@ -621,8 +621,9 @@ static int acpi_processor_remove(struct
>   goto free;
> 
>   if (type == ACPI_BUS_REMOVAL_EJECT) {
> - if (acpi_processor_handle_eject(pr))
> - return -EINVAL;
> + ret = acpi_processor_handle_eject(pr);
> + if (ret)
> + return ret;
>   }
> 
>   acpi_processor_power_exit(pr, device);
> @@ -841,12 +842,17 @@ static acpi_status acpi_processor_hotadd
> 
>  static int acpi_processor_handle_eject(struct acpi_processor *pr)
>  {
> - if (cpu_online(pr->id))
> - cpu_down(pr->id);
> + int ret;
> +
> + if (cpu_online(pr->id)) {
> + ret = cpu_down(pr->id);
> + if (ret)
> + return ret;
> + }
> 
>   arch_unregister_cpu(pr->id);
>   acpi_unmap_lsapic(pr->id);
> - return (0);
> + return ret;
>  }
>  #else
>  static acpi_status acpi_processor_hotadd_init(struct acpi_processor *pr)
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH v3 1/3] acpi : cpu hot-remove returns error when cpu_down() fails

2012-07-12 Thread Yasuaki Ishimatsu 
Even if cpu_down() fails, acpi_processor_remove() continues to remove the cpu.
But in this case, it should return error number since some process may run on
the cpu. If the cpu has a running process and the cpu is turned the power off,
the system may not work well.

Signed-off-by: Yasuaki Ishimatsu 

---
 drivers/acpi/processor_driver.c |   18 --
 1 file changed, 12 insertions(+), 6 deletions(-)

Index: linux-3.5-rc4/drivers/acpi/processor_driver.c
===
--- linux-3.5-rc4.orig/drivers/acpi/processor_driver.c  2012-06-25 
04:53:04.0 +0900
+++ linux-3.5-rc4/drivers/acpi/processor_driver.c   2012-07-05 
21:02:58.711285382 +0900
@@ -610,7 +610,7 @@ err_free_pr:
 static int acpi_processor_remove(struct acpi_device *device, int type)
 {
struct acpi_processor *pr = NULL;
-
+   int ret;

if (!device || !acpi_driver_data(device))
return -EINVAL;
@@ -621,8 +621,9 @@ static int acpi_processor_remove(struct
goto free;

if (type == ACPI_BUS_REMOVAL_EJECT) {
-   if (acpi_processor_handle_eject(pr))
-   return -EINVAL;
+   ret = acpi_processor_handle_eject(pr);
+   if (ret)
+   return ret;
}

acpi_processor_power_exit(pr, device);
@@ -841,12 +842,17 @@ static acpi_status acpi_processor_hotadd

 static int acpi_processor_handle_eject(struct acpi_processor *pr)
 {
-   if (cpu_online(pr->id))
-   cpu_down(pr->id);
+   int ret;
+
+   if (cpu_online(pr->id)) {
+   ret = cpu_down(pr->id);
+   if (ret)
+   return ret;
+   }

arch_unregister_cpu(pr->id);
acpi_unmap_lsapic(pr->id);
-   return (0);
+   return ret;
 }
 #else
 static acpi_status acpi_processor_hotadd_init(struct acpi_processor *pr)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH v3 1/3] acpi : cpu hot-remove returns error when cpu_down() fails

2012-07-12 Thread Yasuaki Ishimatsu 
Even if cpu_down() fails, acpi_processor_remove() continues to remove the cpu.
But in this case, it should return error number since some process may run on
the cpu. If the cpu has a running process and the cpu is turned the power off,
the system may not work well.

Signed-off-by: Yasuaki Ishimatsu isimatu.yasu...@jp.fujitsu.com

---
 drivers/acpi/processor_driver.c |   18 --
 1 file changed, 12 insertions(+), 6 deletions(-)

Index: linux-3.5-rc4/drivers/acpi/processor_driver.c
===
--- linux-3.5-rc4.orig/drivers/acpi/processor_driver.c  2012-06-25 
04:53:04.0 +0900
+++ linux-3.5-rc4/drivers/acpi/processor_driver.c   2012-07-05 
21:02:58.711285382 +0900
@@ -610,7 +610,7 @@ err_free_pr:
 static int acpi_processor_remove(struct acpi_device *device, int type)
 {
struct acpi_processor *pr = NULL;
-
+   int ret;

if (!device || !acpi_driver_data(device))
return -EINVAL;
@@ -621,8 +621,9 @@ static int acpi_processor_remove(struct
goto free;

if (type == ACPI_BUS_REMOVAL_EJECT) {
-   if (acpi_processor_handle_eject(pr))
-   return -EINVAL;
+   ret = acpi_processor_handle_eject(pr);
+   if (ret)
+   return ret;
}

acpi_processor_power_exit(pr, device);
@@ -841,12 +842,17 @@ static acpi_status acpi_processor_hotadd

 static int acpi_processor_handle_eject(struct acpi_processor *pr)
 {
-   if (cpu_online(pr-id))
-   cpu_down(pr-id);
+   int ret;
+
+   if (cpu_online(pr-id)) {
+   ret = cpu_down(pr-id);
+   if (ret)
+   return ret;
+   }

arch_unregister_cpu(pr-id);
acpi_unmap_lsapic(pr-id);
-   return (0);
+   return ret;
 }
 #else
 static acpi_status acpi_processor_hotadd_init(struct acpi_processor *pr)

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH v3 1/3] acpi : cpu hot-remove returns error when cpu_down() fails

2012-07-12 Thread Srivatsa S. Bhat 
On 07/12/2012 04:52 PM, Yasuaki Ishimatsu wrote:
 Even if cpu_down() fails, acpi_processor_remove() continues to remove the cpu.
 But in this case, it should return error number since some process may run on
 the cpu. If the cpu has a running process and the cpu is turned the power off,
 the system may not work well.
 
 Signed-off-by: Yasuaki Ishimatsu isimatu.yasu...@jp.fujitsu.com
 

Reviewed-by: Srivatsa S. Bhat srivatsa.b...@linux.vnet.ibm.com

Regards,
Srivatsa S. Bhat

 ---
  drivers/acpi/processor_driver.c |   18 --
  1 file changed, 12 insertions(+), 6 deletions(-)
 
 Index: linux-3.5-rc4/drivers/acpi/processor_driver.c
 ===
 --- linux-3.5-rc4.orig/drivers/acpi/processor_driver.c2012-06-25 
 04:53:04.0 +0900
 +++ linux-3.5-rc4/drivers/acpi/processor_driver.c 2012-07-05 
 21:02:58.711285382 +0900
 @@ -610,7 +610,7 @@ err_free_pr:
  static int acpi_processor_remove(struct acpi_device *device, int type)
  {
   struct acpi_processor *pr = NULL;
 -
 + int ret;
 
   if (!device || !acpi_driver_data(device))
   return -EINVAL;
 @@ -621,8 +621,9 @@ static int acpi_processor_remove(struct
   goto free;
 
   if (type == ACPI_BUS_REMOVAL_EJECT) {
 - if (acpi_processor_handle_eject(pr))
 - return -EINVAL;
 + ret = acpi_processor_handle_eject(pr);
 + if (ret)
 + return ret;
   }
 
   acpi_processor_power_exit(pr, device);
 @@ -841,12 +842,17 @@ static acpi_status acpi_processor_hotadd
 
  static int acpi_processor_handle_eject(struct acpi_processor *pr)
  {
 - if (cpu_online(pr-id))
 - cpu_down(pr-id);
 + int ret;
 +
 + if (cpu_online(pr-id)) {
 + ret = cpu_down(pr-id);
 + if (ret)
 + return ret;
 + }
 
   arch_unregister_cpu(pr-id);
   acpi_unmap_lsapic(pr-id);
 - return (0);
 + return ret;
  }
  #else
  static acpi_status acpi_processor_hotadd_init(struct acpi_processor *pr)
 

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH v3 1/3] acpi : cpu hot-remove returns error when cpu_down() fails

2012-07-12 Thread Toshi Kani 
On Thu, 2012-07-12 at 20:22 +0900, Yasuaki Ishimatsu wrote:
 Even if cpu_down() fails, acpi_processor_remove() continues to remove the cpu.
 But in this case, it should return error number since some process may run on
 the cpu. If the cpu has a running process and the cpu is turned the power off,
 the system may not work well.
 
 Signed-off-by: Yasuaki Ishimatsu isimatu.yasu...@jp.fujitsu.com
 
 ---
  drivers/acpi/processor_driver.c |   18 --
  1 file changed, 12 insertions(+), 6 deletions(-)
 
 Index: linux-3.5-rc4/drivers/acpi/processor_driver.c
 ===
 --- linux-3.5-rc4.orig/drivers/acpi/processor_driver.c2012-06-25 
 04:53:04.0 +0900
 +++ linux-3.5-rc4/drivers/acpi/processor_driver.c 2012-07-05 
 21:02:58.711285382 +0900
 @@ -610,7 +610,7 @@ err_free_pr:
  static int acpi_processor_remove(struct acpi_device *device, int type)
  {
   struct acpi_processor *pr = NULL;
 -
 + int ret;
 
   if (!device || !acpi_driver_data(device))
   return -EINVAL;
 @@ -621,8 +621,9 @@ static int acpi_processor_remove(struct
   goto free;
 
   if (type == ACPI_BUS_REMOVAL_EJECT) {
 - if (acpi_processor_handle_eject(pr))
 - return -EINVAL;
 + ret = acpi_processor_handle_eject(pr);
 + if (ret)
 + return ret;
   }
 
   acpi_processor_power_exit(pr, device);
 @@ -841,12 +842,17 @@ static acpi_status acpi_processor_hotadd
 
  static int acpi_processor_handle_eject(struct acpi_processor *pr)
  {
 - if (cpu_online(pr-id))
 - cpu_down(pr-id);
 + int ret;
 +
 + if (cpu_online(pr-id)) {
 + ret = cpu_down(pr-id);
 + if (ret)
 + return ret;
 + }
 
   arch_unregister_cpu(pr-id);
   acpi_unmap_lsapic(pr-id);
 - return (0);
 + return ret;

ret is uninitialized when !cpu_online().

Thanks,
-Toshi

  }
  #else
  static acpi_status acpi_processor_hotadd_init(struct acpi_processor *pr)
 
 --
 To unsubscribe from this list: send the line unsubscribe linux-acpi in
 the body of a message to majord...@vger.kernel.org
 More majordomo info at  http://vger.kernel.org/majordomo-info.html


--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/