Re: [PATCH v3 1/4] dt-bindings: gpio: Add bindings for Toshiba Visconti GPIO Controller
Nobuhiro Iwamatsu writes:
> Add bindings for the Toshiba Visconti GPIO Controller.
>
> Signed-off-by: Nobuhiro Iwamatsu
> ---
> .../bindings/gpio/toshiba,gpio-visconti.yaml | 85 +++
> 1 file changed, 85 insertions(+)
> create mode 100644
> Documentation/devicetree/bindings/gpio/toshiba,gpio-visconti.yaml
>
> diff --git
> a/Documentation/devicetree/bindings/gpio/toshiba,gpio-visconti.yaml
> b/Documentation/devicetree/bindings/gpio/toshiba,gpio-visconti.yaml
> new file mode 100644
> index ..5168a15b90e1
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/gpio/toshiba,gpio-visconti.yaml
> @@ -0,0 +1,85 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/gpio/toshiba,gpio-visconti.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Toshiba Visconti ARM SoCs GPIO controller
> +
> +maintainers:
> + - Nobuhiro Iwamatsu
> +
> +properties:
> + compatible:
> +items:
> + - const: toshiba,gpio-tmpv7708
> +
> + reg:
> +maxItems: 1
> +
> + "#gpio-cells":
> +const: 2
> +
> + gpio-ranges: true
> +
> + gpio-controller: true
> +
> + interrupt-controller: true
> +
> + "#interrupt-cells":
> +const: 2
> +
> + interrupts:
> +description:
> + interrupt mapping one per GPIO.
> +minItems: 16
> +maxItems: 16
> +
> +required:
> + - compatible
> + - reg
> + - "#gpio-cells"
> + - gpio-ranges
> + - gpio-controller
> + - interrupt-controller
> + - "#interrupt-cells"
> + - interrupts
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include
> + #include
> +
> + soc {
> +#address-cells = <2>;
> +#size-cells = <2>;
> +
> +gpio: gpio@2802 {
> + compatible = "toshiba,gpio-tmpv7708";
> + reg = <0 0x2802 0 0x1000>;
> + #gpio-cells = <0x2>;
> + gpio-ranges = < 0 0 32>;
> + gpio-controller;
> + interrupt-controller;
> + #interrupt-cells = <2>;
> + interrupts = ,
> + ,
> + ,
> + ,
> + ,
> + ,
> + ,
> + ,
> + ,
> + ,
> + ,
> + ,
> + ,
> + ,
> + ,
> + ;
> +};
> + };
> +...
FWIW,
Reviewed-by: Punit Agrawal
Thanks,
Punit
Re: [PATCH v3 1/4] dt-bindings: gpio: Add bindings for Toshiba Visconti GPIO Controller
Rob Herring writes: [...] >> > + gpio-ranges: true >> >> I am not sure I have a good handle on the yaml schema definitions but >> "gpio-ranges" feels like it should be a list of ranges not a boolean. >> >> Something like - >> >> gpio-ranges: >> maxItems: 1 >> >> feels more appropriate. >> >> I see both the usages in gpio bindings and for other range properties so >> maybe it's OK. I hope Rob or somebody more knowledgeable on this can >> clarify the usage. > > If you know how many (or a range) entries there are for gpio-ranges, > then maxItems is good. If you don't, then 'gpio-ranges: true' is fine. > That doesn't make the property a boolean, but just says the property can > be present. Makes sense. Thanks for the explanation. [...]
Re: [PATCH v3 1/4] dt-bindings: gpio: Add bindings for Toshiba Visconti GPIO Controller
On Wed, 02 Dec 2020 03:14:03 +0900, Nobuhiro Iwamatsu wrote: > Add bindings for the Toshiba Visconti GPIO Controller. > > Signed-off-by: Nobuhiro Iwamatsu > --- > .../bindings/gpio/toshiba,gpio-visconti.yaml | 85 +++ > 1 file changed, 85 insertions(+) > create mode 100644 > Documentation/devicetree/bindings/gpio/toshiba,gpio-visconti.yaml > Reviewed-by: Rob Herring
Re: [PATCH v3 1/4] dt-bindings: gpio: Add bindings for Toshiba Visconti GPIO Controller
On Thu, Dec 03, 2020 at 05:16:51PM +0900, Punit Agrawal wrote: > Iwamatsu-san, > > Nobuhiro Iwamatsu writes: > > > Add bindings for the Toshiba Visconti GPIO Controller. > > > > Signed-off-by: Nobuhiro Iwamatsu > > --- > > .../bindings/gpio/toshiba,gpio-visconti.yaml | 85 +++ > > 1 file changed, 85 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/gpio/toshiba,gpio-visconti.yaml > > > > diff --git > > a/Documentation/devicetree/bindings/gpio/toshiba,gpio-visconti.yaml > > b/Documentation/devicetree/bindings/gpio/toshiba,gpio-visconti.yaml > > new file mode 100644 > > index ..5168a15b90e1 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/gpio/toshiba,gpio-visconti.yaml > > @@ -0,0 +1,85 @@ > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/gpio/toshiba,gpio-visconti.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Toshiba Visconti ARM SoCs GPIO controller > > + > > +maintainers: > > + - Nobuhiro Iwamatsu > > + > > +properties: > > + compatible: > > +items: > > + - const: toshiba,gpio-tmpv7708 > > + > > + reg: > > +maxItems: 1 > > + > > + "#gpio-cells": > > +const: 2 > > + > > + gpio-ranges: true > > I am not sure I have a good handle on the yaml schema definitions but > "gpio-ranges" feels like it should be a list of ranges not a boolean. > > Something like - > > gpio-ranges: > maxItems: 1 > > feels more appropriate. > > I see both the usages in gpio bindings and for other range properties so > maybe it's OK. I hope Rob or somebody more knowledgeable on this can > clarify the usage. If you know how many (or a range) entries there are for gpio-ranges, then maxItems is good. If you don't, then 'gpio-ranges: true' is fine. That doesn't make the property a boolean, but just says the property can be present. Rob
Re: [PATCH v3 1/4] dt-bindings: gpio: Add bindings for Toshiba Visconti GPIO Controller
Iwamatsu-san,
Nobuhiro Iwamatsu writes:
> Add bindings for the Toshiba Visconti GPIO Controller.
>
> Signed-off-by: Nobuhiro Iwamatsu
> ---
> .../bindings/gpio/toshiba,gpio-visconti.yaml | 85 +++
> 1 file changed, 85 insertions(+)
> create mode 100644
> Documentation/devicetree/bindings/gpio/toshiba,gpio-visconti.yaml
>
> diff --git
> a/Documentation/devicetree/bindings/gpio/toshiba,gpio-visconti.yaml
> b/Documentation/devicetree/bindings/gpio/toshiba,gpio-visconti.yaml
> new file mode 100644
> index ..5168a15b90e1
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/gpio/toshiba,gpio-visconti.yaml
> @@ -0,0 +1,85 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/gpio/toshiba,gpio-visconti.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Toshiba Visconti ARM SoCs GPIO controller
> +
> +maintainers:
> + - Nobuhiro Iwamatsu
> +
> +properties:
> + compatible:
> +items:
> + - const: toshiba,gpio-tmpv7708
> +
> + reg:
> +maxItems: 1
> +
> + "#gpio-cells":
> +const: 2
> +
> + gpio-ranges: true
I am not sure I have a good handle on the yaml schema definitions but
"gpio-ranges" feels like it should be a list of ranges not a boolean.
Something like -
gpio-ranges:
maxItems: 1
feels more appropriate.
I see both the usages in gpio bindings and for other range properties so
maybe it's OK. I hope Rob or somebody more knowledgeable on this can
clarify the usage.
Otherwise, the patch looks good.
Thanks,
Punit
> +
> + gpio-controller: true
> +
> + interrupt-controller: true
> +
> + "#interrupt-cells":
> +const: 2
> +
> + interrupts:
> +description:
> + interrupt mapping one per GPIO.
> +minItems: 16
> +maxItems: 16
> +
> +required:
> + - compatible
> + - reg
> + - "#gpio-cells"
> + - gpio-ranges
> + - gpio-controller
> + - interrupt-controller
> + - "#interrupt-cells"
> + - interrupts
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include
> + #include
> +
> + soc {
> +#address-cells = <2>;
> +#size-cells = <2>;
> +
> +gpio: gpio@2802 {
> + compatible = "toshiba,gpio-tmpv7708";
> + reg = <0 0x2802 0 0x1000>;
> + #gpio-cells = <0x2>;
> + gpio-ranges = < 0 0 32>;
> + gpio-controller;
> + interrupt-controller;
> + #interrupt-cells = <2>;
> + interrupts = ,
> + ,
> + ,
> + ,
> + ,
> + ,
> + ,
> + ,
> + ,
> + ,
> + ,
> + ,
> + ,
> + ,
> + ,
> + ;
> +};
> + };
> +...
[PATCH v3 1/4] dt-bindings: gpio: Add bindings for Toshiba Visconti GPIO Controller
Add bindings for the Toshiba Visconti GPIO Controller.
Signed-off-by: Nobuhiro Iwamatsu
---
.../bindings/gpio/toshiba,gpio-visconti.yaml | 85 +++
1 file changed, 85 insertions(+)
create mode 100644
Documentation/devicetree/bindings/gpio/toshiba,gpio-visconti.yaml
diff --git a/Documentation/devicetree/bindings/gpio/toshiba,gpio-visconti.yaml
b/Documentation/devicetree/bindings/gpio/toshiba,gpio-visconti.yaml
new file mode 100644
index ..5168a15b90e1
--- /dev/null
+++ b/Documentation/devicetree/bindings/gpio/toshiba,gpio-visconti.yaml
@@ -0,0 +1,85 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/gpio/toshiba,gpio-visconti.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Toshiba Visconti ARM SoCs GPIO controller
+
+maintainers:
+ - Nobuhiro Iwamatsu
+
+properties:
+ compatible:
+items:
+ - const: toshiba,gpio-tmpv7708
+
+ reg:
+maxItems: 1
+
+ "#gpio-cells":
+const: 2
+
+ gpio-ranges: true
+
+ gpio-controller: true
+
+ interrupt-controller: true
+
+ "#interrupt-cells":
+const: 2
+
+ interrupts:
+description:
+ interrupt mapping one per GPIO.
+minItems: 16
+maxItems: 16
+
+required:
+ - compatible
+ - reg
+ - "#gpio-cells"
+ - gpio-ranges
+ - gpio-controller
+ - interrupt-controller
+ - "#interrupt-cells"
+ - interrupts
+
+additionalProperties: false
+
+examples:
+ - |
+ #include
+ #include
+
+ soc {
+#address-cells = <2>;
+#size-cells = <2>;
+
+gpio: gpio@2802 {
+ compatible = "toshiba,gpio-tmpv7708";
+ reg = <0 0x2802 0 0x1000>;
+ #gpio-cells = <0x2>;
+ gpio-ranges = < 0 0 32>;
+ gpio-controller;
+ interrupt-controller;
+ #interrupt-cells = <2>;
+ interrupts = ,
+ ,
+ ,
+ ,
+ ,
+ ,
+ ,
+ ,
+ ,
+ ,
+ ,
+ ,
+ ,
+ ,
+ ,
+ ;
+};
+ };
+...
--
2.29.2
