Re: [PATCH v3 2/2] arm64: dts: ti: k3-j7200: Add support for higher speed modes in MMCSD subsystems
On 20:50-20210127, Aswath Govindraju wrote: > Hi Nishanth, > > On 27/01/21 8:44 pm, Nishanth Menon wrote: > > On 20:38-20210127, Aswath Govindraju wrote: > >> The following speed modes are now supported in J7200 SoC, > >> - HS200 and HS400 modes at 1.8 V card voltage, in MMCSD0 subsystem [1]. > >> - UHS-I speed modes in MMCSD1 subsystem [1]. > >> > >> Add support for UHS-I modes by adding voltage regulator device tree nodes > >> and corresponding pinmux details, to power cycle and voltage switch cards. > >> Also set respective tags in sdhci0 and remove no-1-8-v tag from sdhci1 > >> device tree nodes. > >> > >> [1] - section 12.3.6.1.1 MMCSD Features, in > >> https://www.ti.com/lit/ug/spruiu1a/spruiu1a.pdf > >> > >> Signed-off-by: Aswath Govindraju > >> --- > >> > >> performance test logs using EXT4 filesystem for eMMC HS400 speed mode, > >> https://pastebin.ubuntu.com/p/KFphDYXj93/ > >> > > > > 5.11.0-rc3-next-20210118-4 : > > > > a) could you make sure to post patches when you test with latest next? > > b) I see 2 patches in this series, but delta seems to be 4 patches, is > > there a dependency I am not aware of? > > > > There are no dependencies. The other two commits are completely > unrelated. From next time I will make sure that I use the latest next > and the delta matches. Thanks. -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
Re: [PATCH v3 2/2] arm64: dts: ti: k3-j7200: Add support for higher speed modes in MMCSD subsystems
Hi Nishanth, On 27/01/21 8:44 pm, Nishanth Menon wrote: > On 20:38-20210127, Aswath Govindraju wrote: >> The following speed modes are now supported in J7200 SoC, >> - HS200 and HS400 modes at 1.8 V card voltage, in MMCSD0 subsystem [1]. >> - UHS-I speed modes in MMCSD1 subsystem [1]. >> >> Add support for UHS-I modes by adding voltage regulator device tree nodes >> and corresponding pinmux details, to power cycle and voltage switch cards. >> Also set respective tags in sdhci0 and remove no-1-8-v tag from sdhci1 >> device tree nodes. >> >> [1] - section 12.3.6.1.1 MMCSD Features, in >> https://www.ti.com/lit/ug/spruiu1a/spruiu1a.pdf >> >> Signed-off-by: Aswath Govindraju >> --- >> >> performance test logs using EXT4 filesystem for eMMC HS400 speed mode, >> https://pastebin.ubuntu.com/p/KFphDYXj93/ >> > > 5.11.0-rc3-next-20210118-4 : > > a) could you make sure to post patches when you test with latest next? > b) I see 2 patches in this series, but delta seems to be 4 patches, is > there a dependency I am not aware of? > There are no dependencies. The other two commits are completely unrelated. From next time I will make sure that I use the latest next and the delta matches. Thanks, Aswath
Re: [PATCH v3 2/2] arm64: dts: ti: k3-j7200: Add support for higher speed modes in MMCSD subsystems
On 20:38-20210127, Aswath Govindraju wrote: > The following speed modes are now supported in J7200 SoC, > - HS200 and HS400 modes at 1.8 V card voltage, in MMCSD0 subsystem [1]. > - UHS-I speed modes in MMCSD1 subsystem [1]. > > Add support for UHS-I modes by adding voltage regulator device tree nodes > and corresponding pinmux details, to power cycle and voltage switch cards. > Also set respective tags in sdhci0 and remove no-1-8-v tag from sdhci1 > device tree nodes. > > [1] - section 12.3.6.1.1 MMCSD Features, in > https://www.ti.com/lit/ug/spruiu1a/spruiu1a.pdf > > Signed-off-by: Aswath Govindraju > --- > > performance test logs using EXT4 filesystem for eMMC HS400 speed mode, > https://pastebin.ubuntu.com/p/KFphDYXj93/ > 5.11.0-rc3-next-20210118-4 : a) could you make sure to post patches when you test with latest next? b) I see 2 patches in this series, but delta seems to be 4 patches, is there a dependency I am not aware of? -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
[PATCH v3 2/2] arm64: dts: ti: k3-j7200: Add support for higher speed modes in MMCSD subsystems
The following speed modes are now supported in J7200 SoC,
- HS200 and HS400 modes at 1.8 V card voltage, in MMCSD0 subsystem [1].
- UHS-I speed modes in MMCSD1 subsystem [1].
Add support for UHS-I modes by adding voltage regulator device tree nodes
and corresponding pinmux details, to power cycle and voltage switch cards.
Also set respective tags in sdhci0 and remove no-1-8-v tag from sdhci1
device tree nodes.
[1] - section 12.3.6.1.1 MMCSD Features, in
https://www.ti.com/lit/ug/spruiu1a/spruiu1a.pdf
Signed-off-by: Aswath Govindraju
---
performance test logs using EXT4 filesystem for eMMC HS400 speed mode,
https://pastebin.ubuntu.com/p/KFphDYXj93/
performance test logs using EXT4 filesystem for SD SDR104 speed mode,
https://pastebin.ubuntu.com/p/GQKtwGT8Qg/
.../dts/ti/k3-j7200-common-proc-board.dts | 31 +++
arch/arm64/boot/dts/ti/k3-j7200-main.dtsi | 3 +-
2 files changed, 33 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
index 4a7182abccf5..1e1a0022822d 100644
--- a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
+++ b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
@@ -16,6 +16,29 @@
stdout-path = "serial2:115200n8";
bootargs = "console=ttyS2,115200n8
earlycon=ns16550a,mmio32,0x0280";
};
+
+ vdd_mmc1: fixedregulator-sd {
+ compatible = "regulator-fixed";
+ regulator-name = "vdd_mmc1";
+ regulator-min-microvolt = <330>;
+ regulator-max-microvolt = <330>;
+ regulator-boot-on;
+ enable-active-high;
+ gpios = < 2 GPIO_ACTIVE_HIGH>;
+ };
+
+ vdd_sd_dv: gpio-regulator-vdd-sd-dv {
+ compatible = "regulator-gpio";
+ regulator-name = "vdd_sd_dv";
+ pinctrl-names = "default";
+ pinctrl-0 = <_sd_dv_pins_default>;
+ regulator-min-microvolt = <180>;
+ regulator-max-microvolt = <330>;
+ regulator-boot-on;
+ gpios = <_gpio0 55 GPIO_ACTIVE_HIGH>;
+ states = <180 0x0
+ 330 0x1>;
+ };
};
_pmx0 {
@@ -70,6 +93,12 @@
J721E_IOPAD(0x120, PIN_OUTPUT, 0) /* (T4) USB0_DRVVBUS
*/
>;
};
+
+ vdd_sd_dv_pins_default: vdd_sd_dv_pins_default {
+ pinctrl-single,pins = <
+ J721E_IOPAD(0xd0, PIN_INPUT, 7) /* (T5)
SPI0_D1.GPIO0_55 */
+ >;
+ };
};
_uart0 {
@@ -190,6 +219,8 @@
/* SD card */
pinctrl-0 = <_mmc1_pins_default>;
pinctrl-names = "default";
+ vmmc-supply = <_mmc1>;
+ vqmmc-supply = <_sd_dv>;
ti,driver-strength-ohm = <50>;
disable-wp;
};
diff --git a/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi
b/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi
index 75dffbb26d52..8392d771ef13 100644
--- a/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi
@@ -534,6 +534,8 @@
ti,trm-icp = <0x8>;
bus-width = <8>;
mmc-ddr-1_8v;
+ mmc-hs200-1_8v;
+ mmc-hs400-1_8v;
dma-coherent;
};
@@ -551,7 +553,6 @@
ti,otap-del-sel-sdr50 = <0xc>;
ti,otap-del-sel-sdr104 = <0x5>;
ti,otap-del-sel-ddr50 = <0xc>;
- no-1-8-v;
dma-coherent;
};
--
2.17.1
