Re: [PATCH v3 2/4] pinctrl: amd: use higher precision for 512 RtcClk

[Linus Walleij]

On Fri, Nov 6, 2020 at 12:19 AM Coiby Xu  wrote:

> RTC is 32.768kHz thus 512 RtcClk equals 15625 usec. The documentation
> likely has dropped precision and that's why the driver mistakenly took
> the slightly deviated value.
>
> Reported-by: Andy Shevchenko 
> Suggested-by: Andy Shevchenko 
> Suggested-by: Hans de Goede 
> Reviewed-by: Andy Shevchenko 
> Link: 
> https://lore.kernel.org/linux-gpio/2f4706a1-502f-75f0-9596-cc25b4933...@redhat.com/
> Signed-off-by: Coiby Xu 

This patch applied for fixes and tagged for stable.

Yours,
Linus Walleij

Re: [PATCH v3 2/4] pinctrl: amd: use higher precision for 512 RtcClk

[Hans de Goede]

Hi,

On 11/6/20 12:19 AM, Coiby Xu wrote:
> RTC is 32.768kHz thus 512 RtcClk equals 15625 usec. The documentation
> likely has dropped precision and that's why the driver mistakenly took
> the slightly deviated value.
> 
> Reported-by: Andy Shevchenko 
> Suggested-by: Andy Shevchenko 
> Suggested-by: Hans de Goede 
> Reviewed-by: Andy Shevchenko 
> Link: 
> https://lore.kernel.org/linux-gpio/2f4706a1-502f-75f0-9596-cc25b4933...@redhat.com/
> Signed-off-by: Coiby Xu 

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede 

Regards,

Hans


> ---
>  drivers/pinctrl/pinctrl-amd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pinctrl/pinctrl-amd.c b/drivers/pinctrl/pinctrl-amd.c
> index d6b2b4bd337c..4aea3e05e8c6 100644
> --- a/drivers/pinctrl/pinctrl-amd.c
> +++ b/drivers/pinctrl/pinctrl-amd.c
> @@ -156,7 +156,7 @@ static int amd_gpio_set_debounce(struct gpio_chip *gc, 
> unsigned offset,
>   pin_reg |= BIT(DB_TMR_OUT_UNIT_OFF);
>   pin_reg &= ~BIT(DB_TMR_LARGE_OFF);
>   } else if (debounce < 25) {
> - time = debounce / 15600;
> + time = debounce / 15625;
>   pin_reg |= time & DB_TMR_OUT_MASK;
>   pin_reg &= ~BIT(DB_TMR_OUT_UNIT_OFF);
>   pin_reg |= BIT(DB_TMR_LARGE_OFF);
> 

[PATCH v3 2/4] pinctrl: amd: use higher precision for 512 RtcClk

[Coiby Xu]

RTC is 32.768kHz thus 512 RtcClk equals 15625 usec. The documentation
likely has dropped precision and that's why the driver mistakenly took
the slightly deviated value.

Reported-by: Andy Shevchenko 
Suggested-by: Andy Shevchenko 
Suggested-by: Hans de Goede 
Reviewed-by: Andy Shevchenko 
Link: 
https://lore.kernel.org/linux-gpio/2f4706a1-502f-75f0-9596-cc25b4933...@redhat.com/
Signed-off-by: Coiby Xu 
---
 drivers/pinctrl/pinctrl-amd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/pinctrl-amd.c b/drivers/pinctrl/pinctrl-amd.c
index d6b2b4bd337c..4aea3e05e8c6 100644
--- a/drivers/pinctrl/pinctrl-amd.c
+++ b/drivers/pinctrl/pinctrl-amd.c
@@ -156,7 +156,7 @@ static int amd_gpio_set_debounce(struct gpio_chip *gc, 
unsigned offset,
pin_reg |= BIT(DB_TMR_OUT_UNIT_OFF);
pin_reg &= ~BIT(DB_TMR_LARGE_OFF);
} else if (debounce < 25) {
-   time = debounce / 15600;
+   time = debounce / 15625;
pin_reg |= time & DB_TMR_OUT_MASK;
pin_reg &= ~BIT(DB_TMR_OUT_UNIT_OFF);
pin_reg |= BIT(DB_TMR_LARGE_OFF);
-- 
2.28.0