Re: [PATCH v3 47/77] ncr5380: Fix and cleanup scsi_host_template initializers

2015-12-21 Thread Hannes Reinecke 

On 12/22/2015 02:18 AM, Finn Thain wrote:

Add missing .module initializer. Use distinct .proc_name values for the
g_NCR5380 and g_NCR5380_mmio modules. Remove pointless CAN_QUEUE and
CMD_PER_LUN override macros. Cleanup whitespace and code style.

Signed-off-by: Finn Thain 

---
  drivers/scsi/atari_scsi.c |2 +-
  drivers/scsi/dmx3191d.c   |1 +
  drivers/scsi/dtc.c|   32 
  drivers/scsi/dtc.h|8 
  drivers/scsi/g_NCR5380.c  |   26 +-
  drivers/scsi/g_NCR5380.h  |   10 ++
  drivers/scsi/mac_scsi.c   |   28 ++--
  drivers/scsi/pas16.c  |   32 
  drivers/scsi/pas16.h  |8 
  drivers/scsi/sun3_scsi.c  |6 +++---
  drivers/scsi/t128.c   |   32 
  drivers/scsi/t128.h   |8 
  12 files changed, 82 insertions(+), 111 deletions(-)


Reviewed-by: Hannes Reinecke 

Cheers,

Hannes
--
Dr. Hannes Reinecke   zSeries & Storage
h...@suse.de  +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH v3 47/77] ncr5380: Fix and cleanup scsi_host_template initializers

2015-12-21 Thread Finn Thain 
Add missing .module initializer. Use distinct .proc_name values for the
g_NCR5380 and g_NCR5380_mmio modules. Remove pointless CAN_QUEUE and
CMD_PER_LUN override macros. Cleanup whitespace and code style.

Signed-off-by: Finn Thain 

---
 drivers/scsi/atari_scsi.c |2 +-
 drivers/scsi/dmx3191d.c   |1 +
 drivers/scsi/dtc.c|   32 
 drivers/scsi/dtc.h|8 
 drivers/scsi/g_NCR5380.c  |   26 +-
 drivers/scsi/g_NCR5380.h  |   10 ++
 drivers/scsi/mac_scsi.c   |   28 ++--
 drivers/scsi/pas16.c  |   32 
 drivers/scsi/pas16.h  |8 
 drivers/scsi/sun3_scsi.c  |6 +++---
 drivers/scsi/t128.c   |   32 
 drivers/scsi/t128.h   |8 
 12 files changed, 82 insertions(+), 111 deletions(-)

Index: linux/drivers/scsi/dmx3191d.c
===
--- linux.orig/drivers/scsi/dmx3191d.c  2015-12-22 12:16:37.0 +1100
+++ linux/drivers/scsi/dmx3191d.c   2015-12-22 12:16:41.0 +1100
@@ -49,6 +49,7 @@
 
 
 static struct scsi_host_template dmx3191d_driver_template = {
+   .module = THIS_MODULE,
.proc_name  = DMX3191D_DRIVER_NAME,
.name   = "Domex DMX3191D",
.info   = NCR5380_info,
Index: linux/drivers/scsi/dtc.c
===
--- linux.orig/drivers/scsi/dtc.c   2015-12-22 12:16:37.0 +1100
+++ linux/drivers/scsi/dtc.c2015-12-22 12:16:41.0 +1100
@@ -436,21 +436,21 @@ static int dtc_release(struct Scsi_Host
 }
 
 static struct scsi_host_template driver_template = {
-   .name   = "DTC 3180/3280 ",
-   .detect = dtc_detect,
-   .release= dtc_release,
-   .proc_name  = "dtc3x80",
-   .show_info  = dtc_show_info,
-   .write_info = dtc_write_info,
-   .info   = dtc_info,
-   .queuecommand   = dtc_queue_command,
-   .eh_abort_handler   = dtc_abort,
-   .eh_bus_reset_handler   = dtc_bus_reset,
-   .bios_param = dtc_biosparam,
-   .can_queue  = CAN_QUEUE,
-   .this_id= 7,
-   .sg_tablesize   = SG_ALL,
-   .cmd_per_lun= CMD_PER_LUN,
-   .use_clustering = DISABLE_CLUSTERING,
+   .name   = "DTC 3180/3280",
+   .detect = dtc_detect,
+   .release= dtc_release,
+   .proc_name  = "dtc3x80",
+   .show_info  = dtc_show_info,
+   .write_info = dtc_write_info,
+   .info   = dtc_info,
+   .queuecommand   = dtc_queue_command,
+   .eh_abort_handler   = dtc_abort,
+   .eh_bus_reset_handler   = dtc_bus_reset,
+   .bios_param = dtc_biosparam,
+   .can_queue  = 32,
+   .this_id= 7,
+   .sg_tablesize   = SG_ALL,
+   .cmd_per_lun= 2,
+   .use_clustering = DISABLE_CLUSTERING,
 };
 #include "scsi_module.c"
Index: linux/drivers/scsi/dtc.h
===
--- linux.orig/drivers/scsi/dtc.h   2015-12-22 12:16:07.0 +1100
+++ linux/drivers/scsi/dtc.h2015-12-22 12:16:41.0 +1100
@@ -10,14 +10,6 @@
 #ifndef DTC3280_H
 #define DTC3280_H
 
-#ifndef CMD_PER_LUN
-#define CMD_PER_LUN 2
-#endif
-
-#ifndef CAN_QUEUE
-#define CAN_QUEUE 32 
-#endif
-
 #define NCR5380_implementation_fields \
 void __iomem *base
 
Index: linux/drivers/scsi/g_NCR5380.c
===
--- linux.orig/drivers/scsi/g_NCR5380.c 2015-12-22 12:16:37.0 +1100
+++ linux/drivers/scsi/g_NCR5380.c  2015-12-22 12:16:41.0 +1100
@@ -305,7 +305,6 @@ static int __init generic_NCR5380_detect
}
}
 #endif
-   tpnt->proc_name = "g_NCR5380";
 
for (count = 0; current_override < NO_OVERRIDES; ++current_override) {
if (!(overrides[current_override].NCR5380_map_name))
@@ -715,20 +714,21 @@ static int generic_NCR5380_dma_xfer_len(
 #include "NCR5380.c"
 
 static struct scsi_host_template driver_template = {
-   .show_info  = generic_NCR5380_show_info,
-   .name   = "Generic NCR5380/NCR53C400 SCSI",
-   .detect = generic_NCR5380_detect,
-   .release= generic_NCR5380_release_resources,
-   .info   = generic_NCR5380_info,
-   .queuecommand   =

[PATCH v3 47/77] ncr5380: Fix and cleanup scsi_host_template initializers

2015-12-21 Thread Finn Thain 
Add missing .module initializer. Use distinct .proc_name values for the
g_NCR5380 and g_NCR5380_mmio modules. Remove pointless CAN_QUEUE and
CMD_PER_LUN override macros. Cleanup whitespace and code style.

Signed-off-by: Finn Thain 

---
 drivers/scsi/atari_scsi.c |2 +-
 drivers/scsi/dmx3191d.c   |1 +
 drivers/scsi/dtc.c|   32 
 drivers/scsi/dtc.h|8 
 drivers/scsi/g_NCR5380.c  |   26 +-
 drivers/scsi/g_NCR5380.h  |   10 ++
 drivers/scsi/mac_scsi.c   |   28 ++--
 drivers/scsi/pas16.c  |   32 
 drivers/scsi/pas16.h  |8 
 drivers/scsi/sun3_scsi.c  |6 +++---
 drivers/scsi/t128.c   |   32 
 drivers/scsi/t128.h   |8 
 12 files changed, 82 insertions(+), 111 deletions(-)

Index: linux/drivers/scsi/dmx3191d.c
===
--- linux.orig/drivers/scsi/dmx3191d.c  2015-12-22 12:16:37.0 +1100
+++ linux/drivers/scsi/dmx3191d.c   2015-12-22 12:16:41.0 +1100
@@ -49,6 +49,7 @@
 
 
 static struct scsi_host_template dmx3191d_driver_template = {
+   .module = THIS_MODULE,
.proc_name  = DMX3191D_DRIVER_NAME,
.name   = "Domex DMX3191D",
.info   = NCR5380_info,
Index: linux/drivers/scsi/dtc.c
===
--- linux.orig/drivers/scsi/dtc.c   2015-12-22 12:16:37.0 +1100
+++ linux/drivers/scsi/dtc.c2015-12-22 12:16:41.0 +1100
@@ -436,21 +436,21 @@ static int dtc_release(struct Scsi_Host
 }
 
 static struct scsi_host_template driver_template = {
-   .name   = "DTC 3180/3280 ",
-   .detect = dtc_detect,
-   .release= dtc_release,
-   .proc_name  = "dtc3x80",
-   .show_info  = dtc_show_info,
-   .write_info = dtc_write_info,
-   .info   = dtc_info,
-   .queuecommand   = dtc_queue_command,
-   .eh_abort_handler   = dtc_abort,
-   .eh_bus_reset_handler   = dtc_bus_reset,
-   .bios_param = dtc_biosparam,
-   .can_queue  = CAN_QUEUE,
-   .this_id= 7,
-   .sg_tablesize   = SG_ALL,
-   .cmd_per_lun= CMD_PER_LUN,
-   .use_clustering = DISABLE_CLUSTERING,
+   .name   = "DTC 3180/3280",
+   .detect = dtc_detect,
+   .release= dtc_release,
+   .proc_name  = "dtc3x80",
+   .show_info  = dtc_show_info,
+   .write_info = dtc_write_info,
+   .info   = dtc_info,
+   .queuecommand   = dtc_queue_command,
+   .eh_abort_handler   = dtc_abort,
+   .eh_bus_reset_handler   = dtc_bus_reset,
+   .bios_param = dtc_biosparam,
+   .can_queue  = 32,
+   .this_id= 7,
+   .sg_tablesize   = SG_ALL,
+   .cmd_per_lun= 2,
+   .use_clustering = DISABLE_CLUSTERING,
 };
 #include "scsi_module.c"
Index: linux/drivers/scsi/dtc.h
===
--- linux.orig/drivers/scsi/dtc.h   2015-12-22 12:16:07.0 +1100
+++ linux/drivers/scsi/dtc.h2015-12-22 12:16:41.0 +1100
@@ -10,14 +10,6 @@
 #ifndef DTC3280_H
 #define DTC3280_H
 
-#ifndef CMD_PER_LUN
-#define CMD_PER_LUN 2
-#endif
-
-#ifndef CAN_QUEUE
-#define CAN_QUEUE 32 
-#endif
-
 #define NCR5380_implementation_fields \
 void __iomem *base
 
Index: linux/drivers/scsi/g_NCR5380.c
===
--- linux.orig/drivers/scsi/g_NCR5380.c 2015-12-22 12:16:37.0 +1100
+++ linux/drivers/scsi/g_NCR5380.c  2015-12-22 12:16:41.0 +1100
@@ -305,7 +305,6 @@ static int __init generic_NCR5380_detect
}
}
 #endif
-   tpnt->proc_name = "g_NCR5380";
 
for (count = 0; current_override < NO_OVERRIDES; ++current_override) {
if (!(overrides[current_override].NCR5380_map_name))
@@ -715,20 +714,21 @@ static int generic_NCR5380_dma_xfer_len(
 #include "NCR5380.c"
 
 static struct scsi_host_template driver_template = {
-   .show_info  = generic_NCR5380_show_info,
-   .name   = "Generic NCR5380/NCR53C400 SCSI",
-   .detect = generic_NCR5380_detect,
-   .release= generic_NCR5380_release_resources,
-   .info   = generic_NCR5380_info,
-   .queuecommand   =

Re: [PATCH v3 47/77] ncr5380: Fix and cleanup scsi_host_template initializers

2015-12-21 Thread Hannes Reinecke 

On 12/22/2015 02:18 AM, Finn Thain wrote:

Add missing .module initializer. Use distinct .proc_name values for the
g_NCR5380 and g_NCR5380_mmio modules. Remove pointless CAN_QUEUE and
CMD_PER_LUN override macros. Cleanup whitespace and code style.

Signed-off-by: Finn Thain 

---
  drivers/scsi/atari_scsi.c |2 +-
  drivers/scsi/dmx3191d.c   |1 +
  drivers/scsi/dtc.c|   32 
  drivers/scsi/dtc.h|8 
  drivers/scsi/g_NCR5380.c  |   26 +-
  drivers/scsi/g_NCR5380.h  |   10 ++
  drivers/scsi/mac_scsi.c   |   28 ++--
  drivers/scsi/pas16.c  |   32 
  drivers/scsi/pas16.h  |8 
  drivers/scsi/sun3_scsi.c  |6 +++---
  drivers/scsi/t128.c   |   32 
  drivers/scsi/t128.h   |8 
  12 files changed, 82 insertions(+), 111 deletions(-)


Reviewed-by: Hannes Reinecke 

Cheers,

Hannes
--
Dr. Hannes Reinecke   zSeries & Storage
h...@suse.de  +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/